Patch for memo query

[Alvaro Soliverez]

Hello all,
this is a patch to fix the way the transaction reports filter the splits by
text.
With this patch, if the text matches the memo of the "main" split (eg. what is
shown as the transaction memo), it will show all splits. If it matches the
memo of another split, it will show only that split.

Thomas,
could you check it for correctness? It passes all tests, but I would like you
to take a look at it before commiting. It's only a few lines.

Thanks!

Regards,
Alvaro



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer

[Thomas Baumgart]

On Wednesday 16 July 2008 02:34:45 Alvaro Soliverez wrote:

> Hello all,
> this is a patch to fix the way the transaction reports filter the splits by
> text.
> With this patch, if the text matches the memo of the "main" split (eg. what
> is shown as the transaction memo), it will show all splits. If it matches
> the memo of another split, it will show only that split.
>
> Thomas,
> could you check it for correctness? It passes all tests, but I would like
> you to take a look at it before commiting. It's only a few lines.

Looks good to me. I could not see any problem with my reports. One thing I
would change is to write

        transaction_text = m_config.match(&(*is));

instead of

        const MyMoneySplit* split = &(*is);
        transaction_text = m_config.match(split);

If you prefer your way for better readability, it's ok with me.


--

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Real Programmers don't write in PL/I. PL/I is for programmers who
can't decide whether to write in COBOL or FORTRAN.
-------------------------------------------------------------


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
KMyMoney2-developer mailing list
KMyMoney2-developer@...
https://lists.sourceforge.net/lists/listinfo/kmymoney2-developer