Nabble - OpenJDK

Support BSD and Caciocavallo

2008-08-29T18:39:12Z

This patch adds support for downloading the BSD and Caciocavallo trees
to IcedTea.
You can choose a project using --with-project and a value of jdk7 (the
default), closures,
cvmi, caciocavallo and bsd to select a tree. It currently only makes
a difference if you also add --enable-hg; the two are separated so
additional project-specific rules can be added. I tried building the
caciocavallo and closures trees but the IcedTea patches need some work
to apply cleanly (presumably because these trees are based on older
build drops).

2008-08-30 Andrew John Hughes <gnu_andrew@...>

* Makefile.am: Add BSD and Caciocavallo URLs.
* acinclude.m4:
(WITH_PROJECT): Added.
(ENABLE_OTHER_PROJECTS): Converted to WITH_PROJECT.
* configure.ac: Support building with BSD
and Caciocavallo projects via --with-project.

Note that jdk7 is now finally at b33, just as b34 comes out...

Bedtime,
--
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8

diff -r 40ffba722e7d ChangeLog
--- a/ChangeLog Sat Aug 30 00:14:16 2008 +0100
+++ b/ChangeLog Sat Aug 30 02:31:21 2008 +0100
@@ -1,4 +1,4 @@
-2008-08-25 Andrew John Hughes <gnu_andrew@...>
+2008-08-30 Andrew John Hughes <gnu_andrew@...>

* patches/icedtea-ecj.patch: Fix OGLContext.h to
use correct headers when generated by gjavah.
diff -r 40ffba722e7d Makefile.am
--- a/Makefile.am Sat Aug 30 00:14:16 2008 +0100
+++ b/Makefile.am Sat Aug 30 02:31:21 2008 +0100
@@ -256,9 +256,10 @@
OPENJDK_HG_URL = http://hg.openjdk.java.net/jdk7/jdk7
CVMI_HG_URL = http://hg.openjdk.java.net/cvmi/cvmi/
CLOSURES_HG_URL = http://hg.openjdk.java.net/closures/closures/
+CACIOCAVALLO_HG_URL = http://hg.openjdk.java.net/caciocavallo/jdk7/
+BSD_HG_URL = http://hg.openjdk.java.net/bsd-port/bsd-port

OPENJDK_URL = http://www.java.net/download/openjdk/jdk7/promoted/$(OPENJDK_VERSION)/
-
if USE_ALT_OPENJDK_SRC_ZIP
OPENJDK_SRC_ZIP = $(ALT_OPENJDK_SRC_ZIP)
else
@@ -296,7 +297,15 @@
if USE_CVMI
hg fclone $(CVMI_HG_URL) openjdk;
else
+if USE_CACIOCAVALLO
+ hg fclone $(CACIOCAVALLO_HG_URL) openjdk;
+else
+if USE_BSD
+ hg fclone $(BSD_HG_URL) openjdk;
+else
hg fclone -r jdk7-$(OPENJDK_VERSION) $(OPENJDK_HG_URL) openjdk;
+endif
+endif
endif
endif
else
diff -r 40ffba722e7d acinclude.m4
--- a/acinclude.m4 Sat Aug 30 00:14:16 2008 +0100
+++ b/acinclude.m4 Sat Aug 30 02:31:21 2008 +0100
@@ -802,42 +802,30 @@
AM_CONDITIONAL([USE_HG], test x"${enable_hg}" = "xyes")
])

-AC_DEFUN([ENABLE_EXTRA_PROJECTS],
+AC_DEFUN([WITH_PROJECT],
[
- AC_MSG_CHECKING(whether to use code from the Closures project)
- AC_ARG_ENABLE([closures],
- [AS_HELP_STRING(--enable-closures,use Closures source code [[default=no]])],
+ AC_MSG_CHECKING(which OpenJDK project is being used)
+ AC_ARG_WITH([project],
+ [AS_HELP_STRING(--with-project,choose the OpenJDK project to use: jdk7 closures cvmi cacioavallo bsd [[default=jdk7]])],
[
- case "${enableval}" in
+ case "${withval}" in
+ yes)
+ project=jdk7
+ ;;
no)
- enable_closures=no
- ;;
+ project=jdk7
+ ;;
*)
- enable_closures=yes
+ project=${withval}
;;
esac
],
[
- enable_closures=no
+ project=jdk7
])
- AC_MSG_RESULT([${enable_closures}])
- AM_CONDITIONAL([USE_CLOSURES], test x"${enable_closures}" = "xyes")
- AC_MSG_CHECKING(whether to use code from the CVMI project)
- AC_ARG_ENABLE([cvmi],
- [AS_HELP_STRING(--enable-cvmi,use CVMI source code [[default=no]])],
- [
- case "${enableval}" in
- no)
- enable_cvmi=no
- ;;
- *)
- enable_cvmi=yes
- ;;
- esac
- ],
- [
- enable_cvmi=no
- ])
- AC_MSG_RESULT([${enable_cvmi}])
- AM_CONDITIONAL([USE_CVMI], test x"${enable_cvmi}" = "xyes")
+ AC_MSG_RESULT([${project}])
+ AM_CONDITIONAL([USE_CLOSURES], test x"${project}" = "xclosures")
+ AM_CONDITIONAL([USE_CVMI], test x"${project}" = "xcvmi")
+ AM_CONDITIONAL([USE_CACIOCAVALLO], test x"${project}" = "xcaciocavallo")
+ AM_CONDITIONAL([USE_BSD], test x"${project}" = "xbsd")
])
diff -r 40ffba722e7d configure.ac
--- a/configure.ac Sat Aug 30 00:14:16 2008 +0100
+++ b/configure.ac Sat Aug 30 02:31:21 2008 +0100
@@ -215,7 +215,7 @@
ENABLE_ZERO_BUILD
SET_CORE_OR_SHARK_BUILD
ENABLE_HG
-ENABLE_EXTRA_PROJECTS
+WITH_PROJECT

if test "x${enable_hg}" = "xyes"; then
FIND_TOOL([MERCURIAL],[hg])

From forum: OpenJDK Distribution-specific Packaging

Re: RMI RemoteException

2008-08-29T17:55:00Z

HI Trenton,

This might not be the right place for it but ... RemoteException is
checked because you have to understand that it can happen (and
occasionally will) and you have to think about what can be done to
recover (even if you ultimately decide to just to "fail" by throwing
some other exception). The "distributed computing can be transparent"
myth was debunked years ago (I used to work with a system that tried it
and nicely demonstrated why it didn't work!).

Jim Waldo has a famous paper on this topic "Notes on Distributed Computing":

http://research.sun.com/techrep/1994/abstract-29.html

Cheers,
David Holmes
Senior Java Technologist
Java SE VM Real-time and Embedded Group
---------------------------------------

Trenton D. Adams said the following on 08/30/08 06:21:

> Hi Guys,
>
> Is this the right list to be discussing RMI topics? I saw some RMI related stuff when I did a site search on google.
>
> I'm curious what the reasoning is behind leaving RemoteException as a checked exception. It seems to me that it would be more relevant to have it as a RuntimeException, as there is not a whole lot one can do about it.
>
> Any ideas why it might be that way? If there is agreement that it should be an unchecked exception, any hope of moving toward it being unchecked?
>
> Thanks.
>
> Trenton D. Adams
> Systems Analyst/Web Software Engineer
> Navy Penguins at your service!
> Athabasca University
> (780) 675-6195
> :wq!
>
> __
> This communication is intended for the use of the recipient to whom it
> is addressed, and may contain confidential, personal, and or privileged
> information. Please contact us immediately if you are not the intended
> recipient of this communication, and do not copy, distribute, or take
> action relying on it. Any communications received in error, or
> subsequent reply, should be deleted or destroyed.
> ---

From forum: OpenJDK Core Libraries

hg: jdk7/tl/jdk: 6614052: jhat fails to read heap dump > 2GB.

2008-08-29T14:36:19Z

Changeset: dc604a6da888
Author: swamyv
Date: 2008-08-29 14:33 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc604a6da888

6614052: jhat fails to read heap dump > 2GB.
Summary: Modified the jhat code to use long for unsigned int. This is a forward port of changes from Kevin Walls.
Reviewed-by: jjh

! src/share/classes/com/sun/tools/hat/internal/parser/HprofReader.java

From forum: OpenJDK Compiler Development

hg: jdk7/tl/jdk: 6614052: jhat fails to read heap dump > 2GB.

2008-08-29T14:36:19Z

From forum: OpenJDK Serviceability Development

hg: jdk7/tl/jdk: 6614052: jhat fails to read heap dump > 2GB.

2008-08-29T14:36:19Z

From forum: OpenJDK Core Libraries

Re: hg: jdk7/jsn/jdk: 6717876: Make java.net.NetworkInterface.getIndex() public

2008-08-29T14:17:33Z

* Mark Wielaard:

> Aha. OK. I might be dense, but I don't think I am the only person not
> immediately making the link between these methods and the RFC 2133
> "Interface Identification" and how they are used as described in RFC
> 2292 for selecting the outgoing interface.

For the record, RFC 2133 has been obsoleted by RFC 3493, and RFC 2292 by
RFC 3542.

> So I assume the Index returned can be used as an Scope identifier when
> creating a Inet6Address.

Scoped addresses are described in RFC 4007. Site-local addresses have
been deprecated (in RFC 3879). The documentation in the Inet6Address
class should be updated accordingly.

I don't know how relevant these docs are for real-world IPv6 operation.

From forum: OpenJDK Networking Development

changeset in /hg/pulseaudio: 2008-08-29 Omair Majid
2008-08-29T13:26:28Z
changeset e99d53a7bcfa in /hg/pulseaudio
details: http://icedtea.classpath.org/hg/pulseaudio?cmd=changeset;node=e99d53a7bcfa
description:
2008-08-29 Omair Majid <omajid@...>

* build.xml: Removed header generation for classes with no native methods.

* src/java/org/classpath/icedtea/pulseaudio/EventLoop.java
Parameterized {target,source}PortNameList. Gets rid of a few warnings.

* src/java/org/classpath/icedtea/pulseaudio/PulseAudioClip.java
(writeFrames): Commented out debug output.

* src/java/org/claspath/icedtea/pulseaudio/PulseAudioSourcePort.java
(addLineListener): Implemented method.
(close): Commented out unimplemented stuff.
(nativeClose): Changed return type to long (since it can return a 64 bit
pointer).
(getControl): Implemented function.
(getControls): Likewise.
(getName): New function.
(isOpen): Implemented function.
(open): Commented out unimplemented stuff.
(nativeOpen): Changed return type to long.
(removeLineListener): Implemented function.

* src/native/org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.c
(Java_org_classpath_icedtea_pulseaudio_PulseAudioSourcePort_nativeClose):
Added stub for future implementeation.
(Java_org_classpath_icedtea_pulseaudio_PulseAudioSourcePort_nativeOpen):
Likewise.

* unittests/org/classpath/icedtea/pulseaudio/PulseAudioClipTest.java
(testPlayTwoClips): New function. Tests
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=173 .

* unittests/org/classpath/icedtea/pulseaudio/PulseAudioMixerTest.java
(testSourceLinesExist): Fixed function to work with SourcePorts as well as
SourceDataLines.
(testTargetLinesExist): Fixed function to work with
Target{Ports,DataLines}.
(testSourceLinesOpenAndClose): Fixed to work with ports and
sourcedatalines.
(testTargetLinesOpenAndClose): Fixed to work with ports and target data
lines.

diffstat:

8 files changed, 148 insertions(+), 67 deletions(-)
build.xml | 4
src/java/org/classpath/icedtea/pulseaudio/EventLoop.java | 4
src/java/org/classpath/icedtea/pulseaudio/PulseAudioClip.java | 15 +
src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourcePort.java | 77 ++++++----
src/native/Makefile.am | 4
src/native/org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.c | 25 +++
unittests/org/classpath/icedtea/pulseaudio/PulseAudioClipTest.java | 31 ++++
unittests/org/classpath/icedtea/pulseaudio/PulseAudioMixerTest.java | 55 ++++---

diffs (417 lines):

diff -r cf375df7c7b7 -r e99d53a7bcfa build.xml
--- a/build.xml Thu Aug 28 16:16:38 2008 -0400
+++ b/build.xml Fri Aug 29 16:26:10 2008 -0400
@@ -38,12 +38,8 @@
<class name="org.classpath.icedtea.pulseaudio.EventLoop"/>
<class name="org.classpath.icedtea.pulseaudio.Operation"/>
<class name="org.classpath.icedtea.pulseaudio.Stream"/>
- <class name="org.classpath.icedtea.pulseaudio.PulseAudioTargetDataLine"/>
- <class name="org.classpath.icedtea.pulseaudio.PulseAudioStreamVolumeControl"/>
- <class name="org.classpath.icedtea.pulseaudio.PulseAudioDataLine"/>
<class name="org.classpath.icedtea.pulseaudio.PulseAudioSourcePort"/>
<class name="org.classpath.icedtea.pulseaudio.PulseAudioTargetPort"/>
- <class name="org.classpath.icedtea.pulseaudio.PulseAudioTargetPortVolumeControl"/>
</javah>
</target>

diff -r cf375df7c7b7 -r e99d53a7bcfa src/java/org/classpath/icedtea/pulseaudio/EventLoop.java
--- a/src/java/org/classpath/icedtea/pulseaudio/EventLoop.java Thu Aug 28 16:16:38 2008 -0400
+++ b/src/java/org/classpath/icedtea/pulseaudio/EventLoop.java Fri Aug 29 16:26:10 2008 -0400
@@ -72,8 +72,8 @@ public class EventLoop implements Runnab

public Semaphore finished = new Semaphore(0);

- private List<String> targetPortNameList = new ArrayList();
- private List<String> sourcePortNameList = new ArrayList();
+ private List<String> targetPortNameList = new ArrayList<String>();
+ private List<String> sourcePortNameList = new ArrayList<String>();

/*
* JNI stuff
diff -r cf375df7c7b7 -r e99d53a7bcfa src/java/org/classpath/icedtea/pulseaudio/PulseAudioClip.java
--- a/src/java/org/classpath/icedtea/pulseaudio/PulseAudioClip.java Thu Aug 28 16:16:38 2008 -0400
+++ b/src/java/org/classpath/icedtea/pulseaudio/PulseAudioClip.java Fri Aug 29 16:26:10 2008 -0400
@@ -54,7 +54,8 @@ import javax.sound.sampled.LineUnavailab
import javax.sound.sampled.LineUnavailableException;
import javax.sound.sampled.Control.Type;

-public class PulseAudioClip extends PulseAudioDataLine implements Clip, PulseAudioPlaybackLine {
+public class PulseAudioClip extends PulseAudioDataLine implements Clip,
+ PulseAudioPlaybackLine {

private byte[] data = null;

@@ -130,7 +131,7 @@ public class PulseAudioClip extends Puls
Thread.currentThread().interrupt();
break;
}
- System.out.println("remaining frames" + remainingFrames);
+ // System.out.println("remaining frames" + remainingFrames);
}
}
}
@@ -213,7 +214,7 @@ public class PulseAudioClip extends Puls
if (control.getClass() == BooleanControl.Type.MUTE.getClass()) {
return controls.get(1);
}
-
+
if (control.getClass() == FloatControl.Type.VOLUME.getClass()) {
return controls.get(0);
}
@@ -344,17 +345,17 @@ public class PulseAudioClip extends Puls

PulseAudioVolumeControl volumeControl = new PulseAudioVolumeControl(
this, eventLoop);
- PulseAudioMuteControl muteControl = new PulseAudioMuteControl(
- this, volumeControl);
+ PulseAudioMuteControl muteControl = new PulseAudioMuteControl(this,
+ volumeControl);
controls.add(volumeControl);
controls.add(muteControl);

}
-
+
public int native_setVolume(float value) {
return stream.native_setVolume(value);
}
-
+
public boolean isMuted() {
return muted;
}
diff -r cf375df7c7b7 -r e99d53a7bcfa src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourcePort.java
--- a/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourcePort.java Thu Aug 28 16:16:38 2008 -0400
+++ b/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourcePort.java Fri Aug 29 16:26:10 2008 -0400
@@ -1,4 +1,7 @@ package org.classpath.icedtea.pulseaudio
package org.classpath.icedtea.pulseaudio;
+
+import java.util.LinkedList;
+import java.util.List;

import javax.sound.sampled.Control;
import javax.sound.sampled.LineListener;
@@ -7,48 +10,58 @@ import javax.sound.sampled.Control.Type;
import javax.sound.sampled.Control.Type;

public class PulseAudioSourcePort implements Port {
-
+
private String name;
+
+ @SuppressWarnings("unused")
private long contextPointer;
+
private EventLoop eventLoop;
-
+
+ private boolean isOpen;
+
+ private List<LineListener> lineListeners = new LinkedList<LineListener>();
+
public PulseAudioSourcePort(String name, EventLoop eventLoop) {
+ System.out.println("new SourcePort constructed");
this.name = name;
this.contextPointer = eventLoop.getContextPointer();
this.eventLoop = eventLoop;
- System.out.println("Opened Source Port" + name);
+ System.out.println("Opened Source Port: " + name);
}

@Override
public void addLineListener(LineListener listener) {
- // TODO Auto-generated method stub
+ synchronized (lineListeners) {
+ lineListeners.add(listener);
+ }
}

@Override
public void close() {
Operation operation;

- synchronized (eventLoop.threadLock) {
- operation = new Operation(nativeClose());
- }
+// synchronized (eventLoop.threadLock) {
+// operation = new Operation(nativeClose());
+// }
+//
+// operation.waitForCompletion();
+// operation.releaseReference();

- operation.waitForCompletion();
- operation.releaseReference();
-
+ isOpen = false;
}
-
- private native int nativeClose();
+
+ private native long nativeClose();

@Override
public Control getControl(Type control) {
- // TODO Auto-generated method stub
- return null;
+ throw new IllegalArgumentException(control.toString()
+ + " not supported");
}

@Override
public Control[] getControls() {
- // TODO Auto-generated method stub
- return null;
+ return new Control[] {};
}

@Override
@@ -57,36 +70,44 @@ public class PulseAudioSourcePort implem
return null;
}

+ public String getName() {
+ return this.name;
+
+ }
+
@Override
public boolean isControlSupported(Type control) {
- // TODO Auto-generated method stub
return false;
}

@Override
public boolean isOpen() {
- // TODO Auto-generated method stub
- return false;
+ return isOpen;
}

@Override
public void open() throws LineUnavailableException {
+ System.out.println("SourcePort opened");
Operation operation;

- synchronized (eventLoop.threadLock) {
- operation = new Operation(nativeOpen());
- }
+// synchronized (eventLoop.threadLock) {
+// operation = new Operation(nativeOpen());
+// }
+//
+// operation.waitForCompletion();
+// operation.releaseReference();

- operation.waitForCompletion();
- operation.releaseReference();
+ isOpen = true;
}
-
- private native int nativeOpen();
+
+ private native long nativeOpen();

@Override
public void removeLineListener(LineListener listener) {
- // TODO Auto-generated method stub
-
+ synchronized (lineListeners) {
+ lineListeners.remove(listener);
+ }
+
}

}
diff -r cf375df7c7b7 -r e99d53a7bcfa src/native/Makefile.am
--- a/src/native/Makefile.am Thu Aug 28 16:16:38 2008 -0400
+++ b/src/native/Makefile.am Fri Aug 29 16:26:10 2008 -0400
@@ -9,10 +9,10 @@ libpulse_java_la_SOURCES = \
org_classpath_icedtea_pulseaudio_Operation.c \
org_classpath_icedtea_pulseaudio_Stream.c \
org_classpath_icedtea_pulseaudio_Stream.h \
+ org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.h \
org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.c \
- org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.h \
org_classpath_icedtea_pulseaudio_PulseAudioTargetPort.c \
- org_classpath_icedtea_pulseaudio_PulseAudioTargetPort.h
+ org_classpath_icedtea_pulseaudio_PulseAudioTargetPort.h

diff -r cf375df7c7b7 -r e99d53a7bcfa src/native/org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.c
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/src/native/org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.c Fri Aug 29 16:26:10 2008 -0400
@@ -0,0 +1,25 @@
+#include "org_classpath_icedtea_pulseaudio_PulseAudioSourcePort.h"
+
+#include "jni-common.h"
+
+/*
+ * Class: org_classpath_icedtea_pulseaudio_PulseAudioSourcePort
+ * Method: nativeClose
+ * Signature: ()J
+ /
+JNIEXPORT jlong JNICALL Java_org_classpath_icedtea_pulseaudio_PulseAudioSourcePort_nativeClose
+(JNIEnv env, jobject obj) {
+ return convertPointerToJavaLong(NULL);
+}
+
+/*
+ * Class: org_classpath_icedtea_pulseaudio_PulseAudioSourcePort
+ * Method: nativeOpen
+ * Signature: ()J
+ /
+JNIEXPORT jlong JNICALL Java_org_classpath_icedtea_pulseaudio_PulseAudioSourcePort_nativeOpen
+(JNIEnv env, jobject obj) {
+ return convertPointerToJavaLong(NULL);
+
+}
+
diff -r cf375df7c7b7 -r e99d53a7bcfa unittests/org/classpath/icedtea/pulseaudio/PulseAudioClipTest.java
--- a/unittests/org/classpath/icedtea/pulseaudio/PulseAudioClipTest.java Thu Aug 28 16:16:38 2008 -0400
+++ b/unittests/org/classpath/icedtea/pulseaudio/PulseAudioClipTest.java Fri Aug 29 16:26:10 2008 -0400
@@ -184,6 +184,37 @@ public class PulseAudioClipTest {

}

+ /*
+ *
+ * modified version of the sample code at
+ * http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=173
+ *
+ */
+
+ @Test
+ public void testPlayTwoClips() {
+ try {
+ Clip clip1 = (Clip) mixer.getLine(new Line.Info(Clip.class));
+ File soundFile1 = new File("testsounds/startup.wav");
+ AudioInputStream audioInputStream1 = AudioSystem
+ .getAudioInputStream(soundFile1);
+ clip1.open(audioInputStream1);
+
+ Clip clip2 = (Clip) mixer.getLine(new Line.Info(Clip.class));
+ File soundFile2 = new File("testsounds/logout.wav");
+ AudioInputStream audioInputStream2 = AudioSystem
+ .getAudioInputStream(soundFile2);
+ clip2.open(audioInputStream2);
+
+ clip1.start();
+ clip2.start();
+
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
+
+ }
+
@After
public void tearDown() {

diff -r cf375df7c7b7 -r e99d53a7bcfa unittests/org/classpath/icedtea/pulseaudio/PulseAudioMixerTest.java
--- a/unittests/org/classpath/icedtea/pulseaudio/PulseAudioMixerTest.java Thu Aug 28 16:16:38 2008 -0400
+++ b/unittests/org/classpath/icedtea/pulseaudio/PulseAudioMixerTest.java Fri Aug 29 16:26:10 2008 -0400
@@ -49,7 +49,6 @@ import javax.sound.sampled.LineUnavailab
import javax.sound.sampled.LineUnavailableException;
import javax.sound.sampled.Mixer;
import javax.sound.sampled.Port;
-import javax.sound.sampled.SourceDataLine;
import javax.sound.sampled.TargetDataLine;

import junit.framework.JUnit4TestAdapter;
@@ -62,6 +61,9 @@ public class PulseAudioMixerTest {
public class PulseAudioMixerTest {

PulseAudioMixer selectedMixer;
+
+ AudioFormat aSupportedFormat = new AudioFormat(
+ AudioFormat.Encoding.PCM_UNSIGNED, 44100f, 8, 1, 1, 10, true);

public static junit.framework.Test suite() {
return new JUnit4TestAdapter(PulseAudioMixerTest.class);
@@ -152,9 +154,8 @@ public class PulseAudioMixerTest {
for (Line.Info lineInfo : allLineInfo) {
System.out.println("Source Line " + j++ + ": "
+ lineInfo.getLineClass());
- SourceDataLine sourceDataLine = (SourceDataLine) selectedMixer
- .getLine(lineInfo);
- assertNotNull(sourceDataLine);
+ Line sourceLine = (Line) selectedMixer.getLine(lineInfo);
+ assertNotNull(sourceLine);

}

@@ -170,9 +171,8 @@ public class PulseAudioMixerTest {
for (Line.Info lineInfo : allLineInfo) {
System.out.println("Target Line " + j++ + ": "
+ lineInfo.getLineClass());
- TargetDataLine targetDataLine = (TargetDataLine) selectedMixer
- .getLine(lineInfo);
- assertNotNull(targetDataLine);
+ Line targetLine = (Line) selectedMixer.getLine(lineInfo);
+ assertNotNull(targetLine);

}

@@ -263,17 +263,17 @@ public class PulseAudioMixerTest {
System.out.println("This test checks if source lines open and close");
selectedMixer.open();

- AudioFormat wantedFormat = new AudioFormat(
- AudioFormat.Encoding.PCM_UNSIGNED, 44100f, 8, 1, 1, 10, true);
-
Line.Info allLineInfo[] = selectedMixer.getSourceLineInfo();
for (Line.Info lineInfo : allLineInfo) {
- SourceDataLine sourceDataLine = (SourceDataLine) selectedMixer
- .getLine(lineInfo);
+ Line sourceLine = (Line) selectedMixer.getLine(lineInfo);
System.out.println("opening line");
- sourceDataLine.open(wantedFormat);
- System.out.println("closing line");
- sourceDataLine.close();
+ try {
+ sourceLine.open();
+ System.out.println("closing line");
+ sourceLine.close();
+ } catch (IllegalArgumentException e) {
+ assert (sourceLine.getClass() == PulseAudioClip.class);
+ }
}
}

@@ -282,17 +282,24 @@ public class PulseAudioMixerTest {
System.out.println("This test checks if source lines open and close");
selectedMixer.open();

- AudioFormat wantedFormat = new AudioFormat(
- AudioFormat.Encoding.PCM_UNSIGNED, 44100f, 8, 1, 1, 10, true);
-
Line.Info allLineInfo[] = selectedMixer.getTargetLineInfo();
for (Line.Info lineInfo : allLineInfo) {
- TargetDataLine targetDataLine = (TargetDataLine) selectedMixer
- .getLine(lineInfo);
- System.out.println("opening line");
- targetDataLine.open(wantedFormat);
- System.out.println("closing line");
- targetDataLine.close();
+ try {
+ TargetDataLine targetLine = (TargetDataLine) selectedMixer
+ .getLine(lineInfo);
+ Assert.assertNotNull(targetLine);
+ System.out.println("opening line");
+ targetLine.open(aSupportedFormat);
+ System.out.println("closing line");
+ targetLine.close();
+ } catch (ClassCastException cce) {
+ Port targetLine = (Port) selectedMixer.getLine(lineInfo);
+ Assert.assertNotNull(targetLine);
+ targetLine.open();
+ System.out.println("closing line");
+ targetLine.close();
+ }
+
}
}

From forum: OpenJDK Distribution-specific Packaging

RMI RemoteException

2008-08-29T13:21:19Z

Hi Guys,

Is this the right list to be discussing RMI topics? I saw some RMI related stuff when I did a site search on google.

I'm curious what the reasoning is behind leaving RemoteException as a checked exception. It seems to me that it would be more relevant to have it as a RuntimeException, as there is not a whole lot one can do about it.

Any ideas why it might be that way? If there is agreement that it should be an unchecked exception, any hope of moving toward it being unchecked?

Thanks.

Trenton D. Adams
Systems Analyst/Web Software Engineer
Navy Penguins at your service!
Athabasca University
(780) 675-6195
:wq!

__
This communication is intended for the use of the recipient to whom it
is addressed, and may contain confidential, personal, and or privileged
information. Please contact us immediately if you are not the intended
recipient of this communication, and do not copy, distribute, or take
action relying on it. Any communications received in error, or
subsequent reply, should be deleted or destroyed.
---

From forum: OpenJDK Core Libraries

hg: jdk7/tl/langtools: 6597471: unused imports in javax.tools.JavaCompiler; ...

2008-08-29T11:10:47Z

Changeset: 5e89c4ca637c
Author: jjg
Date: 2008-08-29 11:10 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5e89c4ca637c

6597471: unused imports in javax.tools.JavaCompiler
6597531: unused imports and unused private const. in com.sun.tools.javac.Server.java
Reviewed-by: mcimadamore
Contributed-by: davide.angelocola@...

! src/share/classes/com/sun/tools/javac/Server.java
! src/share/classes/com/sun/tools/javac/api/JavacScope.java
! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java
! src/share/classes/com/sun/tools/javac/code/Attribute.java
! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Enter.java
! src/share/classes/com/sun/tools/javac/comp/Env.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! src/share/classes/com/sun/tools/javac/jvm/Items.java
! src/share/classes/com/sun/tools/javac/jvm/Pool.java
! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java
! src/share/classes/com/sun/tools/javac/model/FilteredMemberList.java
! src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java
! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java
! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java
! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java
! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java
! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java
! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java
! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java
! src/share/classes/com/sun/tools/javac/util/Context.java

From forum: OpenJDK Compiler Development

hg: jdk7/tl/langtools: 6597471: unused imports in javax.tools.JavaCompiler; ...

2008-08-29T11:10:47Z

From forum: OpenJDK Serviceability Development

hg: jdk7/tl/langtools: 6597471: unused imports in javax.tools.JavaCompiler; ...

2008-08-29T11:10:47Z

From forum: OpenJDK Core Libraries

Re: splashscreen.so is missing pnggccrd.c

2008-08-29T10:46:03Z

On Fri, Aug 29, 2008 at 3:37 AM, Anthony Petrov <Anthony.Petrov@...> wrote:

> On 08/28/2008 08:33 PM Martin Buchholz wrote:
>>
>> I'm thinking:
>> - the MMX support is in pnggccrd.c,
>> - but that file is never compiled in OpenJDK
>
> Why? There's the following line in the make/sun/splashscreen/Makefile:
>
> vpath %.c $(SHARE_SRC)/native/$(PKGDIR)/libpng
>
> that effectively includes all *.c files in the libpng sources directory
> (src/share/native/sun/awt/libpng/) in the compilation process.

Anthony,

I believe this is a small misunderstanding of how vpath works.
vpath changes the _search path_ for files, but does not affect which
files are actually compiled. That is defined in
make/sun/splashscreen/FILES_c.gmk
and pnggccrd.c is notably absent from that file.
If you actually try a clean build, on any platform,
you will see no references to pnggccrd (or pngvcrd)
in the logs (prove me wrong!).

Martin

From forum: OpenJDK Build Infrastructure

Re: splashscreen.so is missing pnggccrd.c

2008-08-29T10:46:03Z

On Fri, Aug 29, 2008 at 3:37 AM, Anthony Petrov <Anthony.Petrov@...> wrote:

From forum: OpenJDK AWT Development

Re: splashscreen.so is missing pnggccrd.c

2008-08-29T10:36:45Z

Hi Anthony,

On Fri, Aug 29, 2008 at 3:30 AM, Anthony Petrov <Anthony.Petrov@...> wrote:
> Hi Martin,
>
> The AWT folks think we need to guard this CPPFLAGS setting with the
> following condition:
>
> ifneq ($(PLATFORM), windows)
> ...
> endif

I am certain this would "work" for everyone, but ...
I am a perfectionist and I am also quite certain that it is wrong.
But if you insist, it's OK.

> We don't use gcc on Windows, and everything works just fine with MS VS.

"We" are now a community of folks with different platforms in mind.
People will want to use gcc on Windows.

> Please feel free to submit the patch with this change, and please add
> OpenJDK user 'art' to the reviewers list. Given this modification applied,
> I'm approving the fix. The push is going to be performed by Artem (CC'ed).
> Thanks in advance!

Again, sorry to be contrary, but I am an OpenJDK committer,
and I would prefer to do hg pushes myself,
for "community development" reasons.
I propose to push these changes to jdk7/awt-gate/jdk

It appears that currently every changeset needs a unique bugid,
so a new bug would have to be filed. Anthony, could you take care of this?

Thanks,

Martin

From forum: OpenJDK Build Infrastructure

Re: splashscreen.so is missing pnggccrd.c

2008-08-29T10:36:45Z

From forum: OpenJDK AWT Development

hg: jdk7/modules/langtools: 15 new changesets

2008-08-29T10:03:04Z

Changeset: 3437676858e3
Author: jjg
Date: 2008-08-01 15:23 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/3437676858e3

6627362: javac generates code that uses array.clone, which is not available on JavaCard
6627364: javac needs Float and Double on the bootclasspath even when not directly used
6627366: javac needs Cloneable and Serializable on the classpath even when not directly used
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! test/tools/javac/5045412/Bar.java
! test/tools/javac/5045412/Foo.java
- test/tools/javac/5045412/out
+ test/tools/javac/6627362/T6627362.java
+ test/tools/javac/6627362/x/E.java
+ test/tools/javac/6627362/x/Object.java
+ test/tools/javac/synthesize/Boolean.java
+ test/tools/javac/synthesize/Byte.java
+ test/tools/javac/synthesize/Character.java
+ test/tools/javac/synthesize/Cloneable.java
+ test/tools/javac/synthesize/Double.java
+ test/tools/javac/synthesize/Float.java
+ test/tools/javac/synthesize/Integer.java
+ test/tools/javac/synthesize/Long.java
+ test/tools/javac/synthesize/Main.java
+ test/tools/javac/synthesize/Number.java
+ test/tools/javac/synthesize/Object.java
+ test/tools/javac/synthesize/Serializable.java
+ test/tools/javac/synthesize/Short.java
+ test/tools/javac/synthesize/Test.java
+ test/tools/javac/synthesize/Void.java

Changeset: fd1d361ae294
Author: jjg
Date: 2008-08-04 15:09 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/fd1d361ae294

4111861: static final field contents are not displayed
Reviewed-by: ksrini

! src/share/classes/com/sun/tools/javap/ClassWriter.java
! src/share/classes/com/sun/tools/javap/JavapTask.java
! src/share/classes/com/sun/tools/javap/Options.java
! src/share/classes/com/sun/tools/javap/resources/javap.properties
+ test/tools/javap/4111861/A.java
+ test/tools/javap/4111861/T4111861.java

Changeset: 05684554f040
Author: jjg
Date: 2008-08-04 17:54 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/05684554f040

4884240: additional option required for javap
Reviewed-by: ksrini

! src/share/classes/com/sun/tools/javap/ClassWriter.java
! src/share/classes/com/sun/tools/javap/JavapTask.java
! src/share/classes/com/sun/tools/javap/Options.java
! src/share/classes/com/sun/tools/javap/resources/javap.properties
+ test/tools/javap/T4884240.java
! test/tools/javap/T6622260.java

Changeset: b6d5f53b3b29
Author: mcimadamore
Date: 2008-08-05 12:54 +0100
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/b6d5f53b3b29

6730423: Diagnostic formatter should be an instance field of JCDiagnostic
Summary: JCDiagnostic.fragment should be deprecated and the diagnostic factory should be used instead
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java

Changeset: 6be961ee2290
Author: jjg
Date: 2008-08-05 17:07 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/6be961ee2290

6733995: legal notice repair on langtools/src/share/classes/com/sun/tools/javap/JavapTask.java
Reviewed-by: ksrini

! src/share/classes/com/sun/tools/javap/JavapTask.java

Changeset: 7ec8d871eb8c
Author: tbell
Date: 2008-08-07 18:03 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/7ec8d871eb8c

Merge

- test/tools/javac/5045412/out

Changeset: d635feaf3747
Author: mcimadamore
Date: 2008-08-08 15:16 +0100
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/d635feaf3747

6695838: javac does not detect cyclic inheritance involving static inner classes after import clause
Summary: Javac fails to detect some errors due to the order in which a class' static imports are entered
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
+ test/tools/javac/staticImport/6695838/T6695838.java
+ test/tools/javac/staticImport/6695838/a/Foo.java
+ test/tools/javac/staticImport/6695838/a/FooInterface.java

Changeset: 30a415f8667f
Author: mcimadamore
Date: 2008-08-08 17:38 +0100
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/30a415f8667f

6718364: inference fails when a generic method is invoked with raw arguments
Summary: Bug in the implementation of Types.isSubtypeUnchecked
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Types.java
+ test/tools/javac/generics/inference/6718364/T6718364.java
+ test/tools/javac/generics/inference/6718364/T6718364.out

Changeset: 6542933af8f4
Author: mcimadamore
Date: 2008-08-08 17:43 +0100
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/6542933af8f4

6676362: Spurious forward reference error with final var + instance variable initializer
Summary: Some javac forward reference errors aren't compliant with the JLS
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/AttrContext.java
! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/ForwardReference/T6676362a.java
+ test/tools/javac/ForwardReference/T6676362b.java
! test/tools/javac/enum/forwardRef/T6425594.out

Changeset: fac6b1beaa5a
Author: mcimadamore
Date: 2008-08-08 17:48 +0100
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/fac6b1beaa5a

6734819: Javac performs flows analysis on already translated classes
Summary: Regression in JavaCompiler.desugar introduced in 6726015
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
+ test/tools/javac/6734819/T6734819a.java
+ test/tools/javac/6734819/T6734819a.out
+ test/tools/javac/6734819/T6734819b.java
+ test/tools/javac/6734819/T6734819b.out
+ test/tools/javac/6734819/T6734819c.java
+ test/tools/javac/6734819/T6734819c.out

Changeset: 938a80a47670
Author: mcimadamore
Date: 2008-08-08 17:52 +0100
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/938a80a47670

6732461: broken message file for annotation processing
Summary: Regression in sqe test introduced in 6720185
Reviewed-by: jjg

! src/share/classes/com/sun/tools/apt/util/Bark.java

Changeset: eefde0421566
Author: tbell
Date: 2008-08-10 18:36 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/eefde0421566

Merge

Changeset: 4026dece07e8
Author: tbell
Date: 2008-08-14 22:17 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/4026dece07e8

Merge

Changeset: 8889fb6c5af0
Author: xdono
Date: 2008-08-28 11:05 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/8889fb6c5af0

Added tag jdk7-b34 for changeset 4026dece07e8

! .hgtags

Changeset: 275025a3a878
Author: ksrini
Date: 2008-08-29 08:11 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/langtools/rev/275025a3a878

Merge

! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javap/Options.java
- test/tools/javac/5045412/out

_______________________________________________
modules-dev mailing list
modules-dev@...
http://mail.openjdk.java.net/mailman/listinfo/modules-dev

From forum: OpenJDK Modules Project

hg: jdk7/modules/jdk: 2 new changesets

2008-08-29T09:59:50Z

Changeset: bf580c41f68f
Author: xdono
Date: 2008-08-28 11:05 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/jdk/rev/bf580c41f68f

Added tag jdk7-b34 for changeset 434055a0716e

! .hgtags

Changeset: 08b34b8dc824
Author: ksrini
Date: 2008-08-29 04:40 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/jdk/rev/08b34b8dc824

Merge

_______________________________________________
modules-dev mailing list
modules-dev@...
http://mail.openjdk.java.net/mailman/listinfo/modules-dev

From forum: OpenJDK Modules Project

hg: jdk7/modules/jaxws: Added tag jdk7-b34 for changeset 7a9f629cd957

2008-08-29T09:59:09Z

Changeset: b0f01c2508b6
Author: xdono
Date: 2008-08-28 11:05 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/jaxws/rev/b0f01c2508b6

Added tag jdk7-b34 for changeset 7a9f629cd957

! .hgtags

_______________________________________________
modules-dev mailing list
modules-dev@...
http://mail.openjdk.java.net/mailman/listinfo/modules-dev

From forum: OpenJDK Modules Project

hg: jdk7/modules/jaxp: Added tag jdk7-b34 for changeset 01facdf8cabd

2008-08-29T09:58:31Z

Changeset: eac46d1eb7f0
Author: xdono
Date: 2008-08-28 11:05 -0700
URL: http://hg.openjdk.java.net/jdk7/modules/jaxp/rev/eac46d1eb7f0

Added tag jdk7-b34 for changeset 01facdf8cabd

! .hgtags

_______________________________________________
modules-dev mailing list
modules-dev@...
http://mail.openjdk.java.net/mailman/listinfo/modules-dev

From forum: OpenJDK Modules Project