Notes & Deleted projects (Bug#1976)

[Adam Tauno Williams-2]

<http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1976>

Currently OGo is pretty sloppy about deletes and leaves behind a fair
amount of detritus.

In relation to appointments, notes, and projects.

When an appointment is deleted, if there are any notes attached to it
they are unlinked.  The appointment is gone.

When a project is deleted, if there are any notes attached to it they
are not unlinked.

That would seem like a straight-forward bug, except...
If you see an appointment via-a-note in the project editor and you click
on the appointment - if the appointment has been deleted you get an
error.
If you see a project via-a-note in the appointment editor and the
project no longer exists the project link icon is x-ed out and not a
link.

The later seems weird to me.  If a project is deleted can we just unlink
the notes like we do when an appointment is deleted?  

This x-project icon that doesn't go anywhere doesn't make much sense to
me.

If both sides (project & appointment) unlink when they are deleted then
if project_id = NULL and date_id = NULL we can delete the note as well
(from db & filesystem).  Currently it appears that notes always remain
in the filesystem.

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

[Adam Tauno Williams-2]

On Fri, 2008-05-30 at 14:59 -0400, Adam Tauno Williams wrote:
> <http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1976>
>
> Currently OGo is pretty sloppy about deletes and leaves behind a fair
> amount of detritus.
> The later seems weird to me.  If a project is deleted can we just unlink
> the notes like we do when an appointment is deleted?  

On top of that, just discovered (and buzzdee confirmed) that attempting
to edit an appointment from the appointment side that links to a deleted
project (x-project icon displayed) fails with a "cannot fault to-one for
primary key" exception.
--
          Consonance: an Open Source .NET OpenGroupware client.
 Contact:awilliam@...   http://freshmeat.net/projects/consonance/

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

[Adam Tauno Williams]

> > <http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1976>
> > Currently OGo is pretty sloppy about deletes and leaves behind a fair
> > amount of detritus.
> > The later seems weird to me.  If a project is deleted can we just unlink
> > the notes like we do when an appointment is deleted?  
>
> On top of that, just discovered (and buzzdee confirmed) that attempting
> to edit an appointment from the appointment side that links to a deleted
> project (x-project icon displayed) fails with a "cannot fault to-one for
> primary key" exception.

Sebastian,  have do you have the "new" LSDeleteProjectCommand and
LSDeleteAppointmentCommand in your tree?  If so, any feedback?

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

[SebastianR]

Moin,

developer@... wrote:
>
> > > <http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1976>
> > > Currently OGo is pretty sloppy about deletes and leaves behind a fair
> > > amount of detritus.
> > > The later seems weird to me.  If a project is deleted can we just
unlink
> > > the notes like we do when an appointment is deleted?  
> >
> > On top of that, just discovered (and buzzdee confirmed) that attempting
> > to edit an appointment from the appointment side that links to a deleted
> > project (x-project icon displayed) fails with a "cannot fault to-one for
> > primary key" exception.
>
> Sebastian,  have do you have the "new" LSDeleteProjectCommand and
> LSDeleteAppointmentCommand in your tree?  If so, any feedback?

just came back from vacation last night, will checkout latest version from
svn and patches from the bugzilla this week. need a little bit to order
myself here ;)

cheers
Sebastian

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

[Adam Tauno Williams]

> > > > <http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1976>
> > > > Currently OGo is pretty sloppy about deletes and leaves behind a fair
> > > > amount of detritus.
> > > > The later seems weird to me.  If a project is deleted can we just
> unlink
> > > > the notes like we do when an appointment is deleted?  
> > > On top of that, just discovered (and buzzdee confirmed) that attempting
> > > to edit an appointment from the appointment side that links to a deleted
> > > project (x-project icon displayed) fails with a "cannot fault to-one for
> > > primary key" exception.
> > Sebastian,  have do you have the "new" LSDeleteProjectCommand and
> > LSDeleteAppointmentCommand in your tree?  If so, any feedback?
> just came back from vacation last night, will checkout latest version from
> svn and patches from the bugzilla this week. need a little bit to order
> myself here ;)

Excellent.  I just started vacation!

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer