Malformed URL in WSIG Console

[Cranfill, Robert E]

Hello,

I can't find this bug reported in Mantis or on the list, so perhaps it's
just me; if so, my apolgies.

When I access the WSIG Console's page for my service, at, say,
http://localhost:8080/wsig/detail.jsp?service=PFAFIDService, I get a
page that includes a link to WSIG that will emit the service's WSDL, but
it seems to be malformed: it has a backslash as the last path delimiter,
instead of a forward slash, like this:=

        WSDL url:
http://localhost:8080/wsig/wsdl\PFAFIDService.wsdl

This fails in my browser (Firefox 2.0.0.x). I'm guessing that some bit
of code is appending the OS's delimiter, and because I'm on Windows,
that's the wrong thing to do. (Well, it's just the wrong thing to do,
period.)

I'd be glad to delve into the code and see if I can fix it, but first I
thought I'd see if it's already been solved or otherwise addressed.

 - rob
 Seattle, WA, USA


PS - I'm really impressed with WSIG so far (as I am with JADE, of
course). I've struggled to create web services with Axis and a couple
other products, and WSIG was really quite easy, comparatively!


_______________________________________________
jade-develop mailing list
jade-develop@...
https://avalon.cselt.it/mailman/listinfo/jade-develop
UNSUBSCRIBE INSTRUCTIONS AT
http://jade.tilab.com/community-mailinglist.htm

[Scagliotti Enrico]

Hello Robert,
thank you for this message.
The problem signals, together with others, have already been resolved and
are currently available on the sources SVN repository of the project.

Bye,
Enrico


-----Messaggio originale-----
Da: jade-develop-bounces@...
[mailto:jade-develop-bounces@...] Per conto di Cranfill, Robert
E
Inviato: martedì 8 luglio 2008 17.29
A: jade-develop@...
Oggetto: [jade-develop] Malformed URL in WSIG Console

Hello,

I can't find this bug reported in Mantis or on the list, so perhaps it's
just me; if so, my apolgies.

When I access the WSIG Console's page for my service, at, say,
http://localhost:8080/wsig/detail.jsp?service=PFAFIDService, I get a
page that includes a link to WSIG that will emit the service's WSDL, but
it seems to be malformed: it has a backslash as the last path delimiter,
instead of a forward slash, like this:=

        WSDL url:
http://localhost:8080/wsig/wsdl\PFAFIDService.wsdl

This fails in my browser (Firefox 2.0.0.x). I'm guessing that some bit
of code is appending the OS's delimiter, and because I'm on Windows,
that's the wrong thing to do. (Well, it's just the wrong thing to do,
period.)

I'd be glad to delve into the code and see if I can fix it, but first I
thought I'd see if it's already been solved or otherwise addressed.

 - rob
 Seattle, WA, USA


PS - I'm really impressed with WSIG so far (as I am with JADE, of
course). I've struggled to create web services with Axis and a couple
other products, and WSIG was really quite easy, comparatively!


_______________________________________________
jade-develop mailing list
jade-develop@...
https://avalon.cselt.it/mailman/listinfo/jade-develop
UNSUBSCRIBE INSTRUCTIONS AT
http://jade.tilab.com/community-mailinglist.htm

_______________________________________________
jade-develop mailing list
jade-develop@...
https://avalon.cselt.it/mailman/listinfo/jade-develop
UNSUBSCRIBE INSTRUCTIONS AT
http://jade.tilab.com/community-mailinglist.htm

[Cranfill, Robert E]

 Enrico Scagliotti wrote

// The problem signals, together with others, have already been resolved
and
// are currently available on the sources SVN repository of the project.


As of version 1081, the code that created my original problem does
indeed appear to be corrected:

com/tilab/wsig/agent/WSIGAgent.java:370:    wsigService.setWsdl(new
URL(WSIGConfiguration.getInstance().getWsdlUri()+"/"+serviceName+".wsdl"
));


However, in looking into this issue, I find the following line

$grep -rn File.sep *
com/tilab/wsig/wsdl/WSDLGeneratorUtils.java:431:    return
WSIGConfiguration.getInstance().getWsdlDirectory() + File.separator +
serviceName + ".wsdl";


This is a similar mistake; I'm not sure just what code it impacts, but I
think it's clear that "File.separator" is never the right thing to use
to build URLs! :)

So I think there's one more change that needs to be made.

 - rob



_______________________________________________
jade-develop mailing list
jade-develop@...
https://avalon.cselt.it/mailman/listinfo/jade-develop
UNSUBSCRIBE INSTRUCTIONS AT
http://jade.tilab.com/community-mailinglist.htm

[Scagliotti Enrico]

Hi Robert,
you are right "File.separator" is dangerous, but WSIG use it exclusively in
getWSDLFilename method that is used to write wsdl files to file system.
So, is not used in URLs (where use "/") but only in file path.

Bye
Enrico


-----Messaggio originale-----
Da: Cranfill, Robert E [mailto:robert.e.cranfill@...]
Inviato: giovedì 10 luglio 2008 17.57
A: Scagliotti Enrico; jade-develop@...
Oggetto: RE: [jade-develop] Malformed URL in WSIG Console


 Enrico Scagliotti wrote

// The problem signals, together with others, have already been resolved
and
// are currently available on the sources SVN repository of the project.


As of version 1081, the code that created my original problem does
indeed appear to be corrected:

com/tilab/wsig/agent/WSIGAgent.java:370:    wsigService.setWsdl(new
URL(WSIGConfiguration.getInstance().getWsdlUri()+"/"+serviceName+".wsdl"
));


However, in looking into this issue, I find the following line

$grep -rn File.sep *
com/tilab/wsig/wsdl/WSDLGeneratorUtils.java:431:    return
WSIGConfiguration.getInstance().getWsdlDirectory() + File.separator +
serviceName + ".wsdl";


This is a similar mistake; I'm not sure just what code it impacts, but I
think it's clear that "File.separator" is never the right thing to use
to build URLs! :)

So I think there's one more change that needs to be made.

 - rob




_______________________________________________
jade-develop mailing list
jade-develop@...
https://avalon.cselt.it/mailman/listinfo/jade-develop
UNSUBSCRIBE INSTRUCTIONS AT
http://jade.tilab.com/community-mailinglist.htm