Make syslinux beep?

[Frans Pop-3]

On Tuesday 12 August 2008, Samuel Thibault wrote:
> Here is a patch.  I didn't know how I should detect the kind of build,
> I just made it look at the udebs source.

I don't think it's smart to use USE_UDEBS_FROM here. Better use a
dedicated variable. Also, please use '[ <test> ] && [ <test> ]' instead
of '[ <test> -a <test> ]'.

[Samuel Thibault]

Frans Pop, le Tue 12 Aug 2008 10:29:23 +0200, a écrit :
> On Tuesday 12 August 2008, Samuel Thibault wrote:
> > Here is a patch.  I didn't know how I should detect the kind of build,
> > I just made it look at the udebs source.
>
> I don't think it's smart to use USE_UDEBS_FROM here. Better use a
> dedicated variable.

So add a new one, just for the beeps or some RELEASE_BUILD=true/false?

> Also, please use '[ <test> ] && [ <test> ]' instead of '[ <test> -a
> <test> ]'.

I'm curious: why?

Samuel


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Otavio Salvador]

Samuel Thibault <samuel.thibault@...> writes:

> Otavio Salvador, le Mon 11 Aug 2008 22:06:50 -0300, a écrit :
>> Samuel Thibault <samuel.thibault@...> writes:
>>
>> > Samuel Thibault, le Tue 12 Aug 2008 00:10:26 +0100, a écrit :
>> >> Still no feedback on this?
>> >
>> > (I mean feedback from debian-boot, I got some from debian-accessibility,
>> > the feature was greatly appreciated).
>>
>> It would be acceptable for release images. Could to work on a patch to
>> only make it when we're doing a release? (no dailies or local builds)
>
> Here is a patch.  I didn't know how I should detect the kind of build, I
> just made it look at the udebs source.

I think this is a good way of detection since debian/rules set it in
case we're doing a daily build.

>From my POV it looks good. Let's wait few days to see if someone nack
it or something, otherwise I'll commit it in the end of week.

--
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@...      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Otavio Salvador]

Samuel Thibault <samuel.thibault@...> writes:

>> Also, please use '[ <test> ] && [ <test> ]' instead of '[ <test> -a
>> <test> ]'.
>
> I'm curious: why?

Coding Style.

--
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@...      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Otavio Salvador]

Otavio Salvador <otavio@...> writes:

> From my POV it looks good. Let's wait few days to see if someone nack
> it or something, otherwise I'll commit it in the end of week.

Samuel,

Please address both points spoted by Frans and resubmit it.

Thanks a lot.

--
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@...      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Frank J. Carmickle]

On Tue, Aug 12, Samuel Thibault wrote:
Snip.
> > Also, please use '[ <test> ] && [ <test> ]' instead of '[ <test> -a
> > <test> ]'.
>
> I'm curious: why?

To bash specific.  Have a look at the dash man page.

--Frank


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Frans Pop-3]

On Tuesday 12 August 2008, Samuel Thibault wrote:
> Frans Pop, le Tue 12 Aug 2008 10:29:23 +0200, a écrit :
> > On Tuesday 12 August 2008, Samuel Thibault wrote:
> > > Here is a patch.  I didn't know how I should detect the kind of
> > > build, I just made it look at the udebs source.
> >
> > I don't think it's smart to use USE_UDEBS_FROM here. Better use a
> > dedicated variable.
>
> So add a new one, just for the beeps or some RELEASE_BUILD=true/false?

Something just for the beeps. Someone should be able to turn this specific
feature on/off for a particular build. It also means that config/common
should only set a default if not already set. Of course the option also
needs to be documented in build/README.

> > Also, please use '[ <test> ] && [ <test> ]' instead of '[ <test> -a
> > <test> ]'.
>
> I'm curious: why?

Readability; general D-I coding style preference; bashism.
Take your pick :-)

[Samuel Thibault]

Hello,

Here is an corrected patch

Samuel

Index: build/config/x86.cfg
===================================================================
--- build/config/x86.cfg (révision 54981)
+++ build/config/x86.cfg (copie de travail)
@@ -60,6 +60,11 @@
  outfile="" ; \
  fi; \
  fi; \
+ if [ $$outfile = menu.cfg ] && $$MENU_BEEP ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  if [ "$$outfile" ]; then \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
@@ -70,6 +75,7 @@
  INITRD_GTK initrdg.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  | todos | mcopy -i$(TEMP_BOOT) - ::$$outfile; \
  fi; \
  )
@@ -157,6 +163,11 @@
  outfile=isolinux.cfg; \
  fi; \
  cat $(file) \
+ if [ $$outfile = menu.cfg ] && $$MENU_BEEP ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
  BUILD_DATE "$(BUILD_DATE)" \
@@ -165,6 +176,7 @@
  INITRD_GTK /install/gtk/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  > $(TEMP_CD_INFO_DIR)/$$outfile; \
  )
 
@@ -213,6 +225,11 @@
  if [ $$outfile = syslinux.cfg ]; then \
  outfile=isolinux.cfg; \
  fi; \
+ if [ $$outfile = menu.cfg ] && $$MENU_BEEP ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
@@ -222,6 +239,7 @@
  INITRD_GTK /install/gtk/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  | todos > $(TEMP_CD_TREE)/$$outfile; \
  )
 
@@ -266,6 +284,11 @@
  if [ `basename $(file)` = syslinux.cfg ]; then \
  outfile=$(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/pxelinux.cfg/default; \
  fi; \
+ if [ $$outfile = menu.cfg ] && $$MENU_BEEP ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
@@ -274,6 +297,7 @@
  KERNEL $(NETBOOT_PATH)/linux \
  INITRD $(NETBOOT_PATH)/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
+ | sed -e "$$addbeep" \
  > $$outfile; \
  )
 
Index: build/config/common
===================================================================
--- build/config/common (révision 54981)
+++ build/config/common (copie de travail)
@@ -55,6 +55,9 @@
 # The date the installer is built.
 BUILD_DATE ?= $(shell date -u '+%Y%m%d-%H:%M')
 
+# Produce a beep at boot menu
+MENU_BEEP ?= false
+
 # Filesystem type for the initrd, currently valid values are ext2, cramfs,
 # and initramfs.
 # NOTE: Your kernel must support this filesystem, not just a module.
Index: build/README
===================================================================
--- build/README (révision 54981)
+++ build/README (copie de travail)
@@ -348,6 +348,11 @@
 DOS_VOLUME_LABEL
   Volume ID and label for DOS filesystems.
 
+MENU_BEEP
+  Set to true to produce a beep when the boot menu is ready to accept commands
+  (e.g. extra kernel parameters)
+  This improves accessibility of the image for blind people.
+
 GZIPPED
   Create gzipped images. This works only for the BOOT, ROOT and EXTRA
   targets.
Index: debian/rules
===================================================================
--- debian/rules (révision 54981)
+++ debian/rules (copie de travail)
@@ -7,9 +7,11 @@
 ifeq (${SUITE},UNRELEASED)
 USE_UDEBS_FROM=unstable
 TRANSSTATUS=
+MENU_BEEP=false
 else
 USE_UDEBS_FROM=lenny
 TRANSSTATUS=translation-status
+MENU_BEEP=true
 endif
 
 ARCHIVEDIR=debian/tmp/installer-$(ARCH)
@@ -29,7 +31,7 @@
 build-images:
  $(MAKE) -C build all_build stats release \
  USE_UDEBS_FROM=$(USE_UDEBS_FROM) BUILD_DATE=$(DATE) \
- TRANSSTATUS=$(TRANSSTATUS)
+ TRANSSTATUS=$(TRANSSTATUS) MENU_BEEP=$(MENU_BEEP)
 
 build: build-stamp
 build-stamp:


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Frans Pop-3]

On Tuesday 12 August 2008, Samuel Thibault wrote:
> Here is an corrected patch

Looks fine to me.

Only wonder if it would not make more sense to rename the variable to
BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easily be confused
with the D-I main menu.

[Samuel Thibault]

Frans Pop, le Wed 13 Aug 2008 00:51:29 +0200, a écrit :
> On Tuesday 12 August 2008, Samuel Thibault wrote:
> > Here is an corrected patch
>
> Looks fine to me.
>
> Only wonder if it would not make more sense to rename the variable to
> BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easily be confused
> with the D-I main menu.

BOOTMENU_BEEP?

BOOT_BEEP alone would make me think that it's just beeping during boot,
not at the menu.

(SYSLINUX is probably not generic enough)

Samuel


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Per Andersson-3]

On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <elendil@...> wrote:
> On Tuesday 12 August 2008, Samuel Thibault wrote:
>> Here is an corrected patch
>
> Looks fine to me.

Shouldn't there be a left bracket after the &&?
(It's missing in several places.)

if [ $$outfile == menu.cfg ] && $$MENU_BEEP ]; then


-- Per


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit :

> On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <elendil@...> wrote:
> > On Tuesday 12 August 2008, Samuel Thibault wrote:
> >> Here is an corrected patch
> >
> > Looks fine to me.
>
> Shouldn't there be a left bracket after the &&?
> (It's missing in several places.)
>
> if [ $$outfile == menu.cfg ] && $$MENU_BEEP ]; then

EPARSE :)

MENU_BEEP holds true or false, which doesn't need a [ ].

Samuel


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Frans Pop-3]

On Wednesday 13 August 2008, Per Andersson wrote:

> On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <elendil@...> wrote:
> > On Tuesday 12 August 2008, Samuel Thibault wrote:
> >> Here is an corrected patch
> >
> > Looks fine to me.
>
> Shouldn't there be a left bracket after the &&?
> (It's missing in several places.)
>
> if [ $$outfile == menu.cfg ] && $$MENU_BEEP ]; then

Looks like a mix between wanting to execute $$MENU_BEEP (as true/false)
and testing for a value.

Please do NOT try to execute it. Better to just use 0/1 as values and only
test for '= 1' (or test for set/unset, not sure what is more common).

[Samuel Thibault]

Samuel Thibault, le Wed 13 Aug 2008 00:54:15 +0100, a écrit :

> Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit :
> > On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <elendil@...> wrote:
> > > On Tuesday 12 August 2008, Samuel Thibault wrote:
> > >> Here is an corrected patch
> > >
> > > Looks fine to me.
> >
> > Shouldn't there be a left bracket after the &&?
> > (It's missing in several places.)
> >
> > if [ $$outfile == menu.cfg ] && $$MENU_BEEP ]; then
>
> EPARSE :)

Oops, man read for me, sorry, that's a typo indeed.

Samuel


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit :
> Better to just use 0/1 as values and only test for '= 1' (or test for
> set/unset, not sure what is more common).

At least DEBUG uses y/n, so I have done the same in the attached fixed
patch.

Samuel

Index: build/config/x86.cfg
===================================================================
--- build/config/x86.cfg (révision 54981)
+++ build/config/x86.cfg (copie de travail)
@@ -60,6 +60,11 @@
  outfile="" ; \
  fi; \
  fi; \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  if [ "$$outfile" ]; then \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
@@ -70,6 +75,7 @@
  INITRD_GTK initrdg.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  | todos | mcopy -i$(TEMP_BOOT) - ::$$outfile; \
  fi; \
  )
@@ -157,6 +163,11 @@
  outfile=isolinux.cfg; \
  fi; \
  cat $(file) \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
  BUILD_DATE "$(BUILD_DATE)" \
@@ -165,6 +176,7 @@
  INITRD_GTK /install/gtk/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  > $(TEMP_CD_INFO_DIR)/$$outfile; \
  )
 
@@ -213,6 +225,11 @@
  if [ $$outfile = syslinux.cfg ]; then \
  outfile=isolinux.cfg; \
  fi; \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
@@ -222,6 +239,7 @@
  INITRD_GTK /install/gtk/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  | todos > $(TEMP_CD_TREE)/$$outfile; \
  )
 
@@ -266,6 +284,11 @@
  if [ `basename $(file)` = syslinux.cfg ]; then \
  outfile=$(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/pxelinux.cfg/default; \
  fi; \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
@@ -274,6 +297,7 @@
  KERNEL $(NETBOOT_PATH)/linux \
  INITRD $(NETBOOT_PATH)/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
+ | sed -e "$$addbeep" \
  > $$outfile; \
  )
 
Index: build/config/common
===================================================================
--- build/config/common (révision 54981)
+++ build/config/common (copie de travail)
@@ -55,6 +55,9 @@
 # The date the installer is built.
 BUILD_DATE ?= $(shell date -u '+%Y%m%d-%H:%M')
 
+# Produce a beep at boot menu
+BOOTMENU_BEEP ?= n
+
 # Filesystem type for the initrd, currently valid values are ext2, cramfs,
 # and initramfs.
 # NOTE: Your kernel must support this filesystem, not just a module.
Index: build/README
===================================================================
--- build/README (révision 54981)
+++ build/README (copie de travail)
@@ -348,6 +348,11 @@
 DOS_VOLUME_LABEL
   Volume ID and label for DOS filesystems.
 
+BOOTMENU_BEEP
+  Set to y to produce a beep when the boot menu is ready to accept commands
+  (e.g. extra kernel parameters, etc.)
+  This improves accessibility of the image for blind people.
+
 GZIPPED
   Create gzipped images. This works only for the BOOT, ROOT and EXTRA
   targets.
Index: debian/rules
===================================================================
--- debian/rules (révision 54981)
+++ debian/rules (copie de travail)
@@ -7,9 +7,11 @@
 ifeq (${SUITE},UNRELEASED)
 USE_UDEBS_FROM=unstable
 TRANSSTATUS=
+BOOTMENU_BEEP=n
 else
 USE_UDEBS_FROM=lenny
 TRANSSTATUS=translation-status
+BOOTMENU_BEEP=y
 endif
 
 ARCHIVEDIR=debian/tmp/installer-$(ARCH)
@@ -29,7 +31,7 @@
 build-images:
  $(MAKE) -C build all_build stats release \
  USE_UDEBS_FROM=$(USE_UDEBS_FROM) BUILD_DATE=$(DATE) \
- TRANSSTATUS=$(TRANSSTATUS)
+ TRANSSTATUS=$(TRANSSTATUS) BOOTMENU_BEEP=$(BOOTMENU_BEEP)
 
 build: build-stamp
 build-stamp:


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Samuel Thibault, le Wed 13 Aug 2008 01:39:31 +0100, a écrit :
> Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit :
> > Better to just use 0/1 as values and only test for '= 1' (or test for
> > set/unset, not sure what is more common).
>
> At least DEBUG uses y/n, so I have done the same in the attached fixed
> patch.

ping?

Samuel

Index: build/config/x86.cfg
===================================================================
--- build/config/x86.cfg (révision 54981)
+++ build/config/x86.cfg (copie de travail)
@@ -60,6 +60,11 @@
  outfile="" ; \
  fi; \
  fi; \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  if [ "$$outfile" ]; then \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
@@ -70,6 +75,7 @@
  INITRD_GTK initrdg.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  | todos | mcopy -i$(TEMP_BOOT) - ::$$outfile; \
  fi; \
  )
@@ -157,6 +163,11 @@
  outfile=isolinux.cfg; \
  fi; \
  cat $(file) \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
  BUILD_DATE "$(BUILD_DATE)" \
@@ -165,6 +176,7 @@
  INITRD_GTK /install/gtk/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  > $(TEMP_CD_INFO_DIR)/$$outfile; \
  )
 
@@ -213,6 +225,11 @@
  if [ $$outfile = syslinux.cfg ]; then \
  outfile=isolinux.cfg; \
  fi; \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
@@ -222,6 +239,7 @@
  INITRD_GTK /install/gtk/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
  VIDEO_MODE_GTK $(VIDEO_MODE_GTK) \
+ | sed -e "$$addbeep" \
  | todos > $(TEMP_CD_TREE)/$$outfile; \
  )
 
@@ -266,6 +284,11 @@
  if [ `basename $(file)` = syslinux.cfg ]; then \
  outfile=$(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/pxelinux.cfg/default; \
  fi; \
+ if [ $$outfile = menu.cfg ] && [ $$BOOTMENU_BEEP = y ] ; then \
+ addbeep="s/^menu title.*/&/"; \
+ else \
+ addbeep=""; \
+ fi; \
  cat $(file) \
  | bootvars-subst MEDIA_TYPE "$(MEDIA_TYPE)" \
  DEBIAN_VERSION "$(DEBIAN_VERSION)" \
@@ -274,6 +297,7 @@
  KERNEL $(NETBOOT_PATH)/linux \
  INITRD $(NETBOOT_PATH)/initrd.gz \
  VIDEO_MODE $(VIDEO_MODE) \
+ | sed -e "$$addbeep" \
  > $$outfile; \
  )
 
Index: build/config/common
===================================================================
--- build/config/common (révision 54981)
+++ build/config/common (copie de travail)
@@ -55,6 +55,9 @@
 # The date the installer is built.
 BUILD_DATE ?= $(shell date -u '+%Y%m%d-%H:%M')
 
+# Produce a beep at boot menu
+BOOTMENU_BEEP ?= n
+
 # Filesystem type for the initrd, currently valid values are ext2, cramfs,
 # and initramfs.
 # NOTE: Your kernel must support this filesystem, not just a module.
Index: build/README
===================================================================
--- build/README (révision 54981)
+++ build/README (copie de travail)
@@ -348,6 +348,11 @@
 DOS_VOLUME_LABEL
   Volume ID and label for DOS filesystems.
 
+BOOTMENU_BEEP
+  Set to y to produce a beep when the boot menu is ready to accept commands
+  (e.g. extra kernel parameters, etc.)
+  This improves accessibility of the image for blind people.
+
 GZIPPED
   Create gzipped images. This works only for the BOOT, ROOT and EXTRA
   targets.
Index: debian/rules
===================================================================
--- debian/rules (révision 54981)
+++ debian/rules (copie de travail)
@@ -7,9 +7,11 @@
 ifeq (${SUITE},UNRELEASED)
 USE_UDEBS_FROM=unstable
 TRANSSTATUS=
+BOOTMENU_BEEP=n
 else
 USE_UDEBS_FROM=lenny
 TRANSSTATUS=translation-status
+BOOTMENU_BEEP=y
 endif
 
 ARCHIVEDIR=debian/tmp/installer-$(ARCH)
@@ -29,7 +31,7 @@
 build-images:
  $(MAKE) -C build all_build stats release \
  USE_UDEBS_FROM=$(USE_UDEBS_FROM) BUILD_DATE=$(DATE) \
- TRANSSTATUS=$(TRANSSTATUS)
+ TRANSSTATUS=$(TRANSSTATUS) BOOTMENU_BEEP=$(BOOTMENU_BEEP)
 
 build: build-stamp
 build-stamp:

 


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Otavio Salvador]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Samuel Thibault <samuel.thibault@...> writes:

> Samuel Thibault, le Wed 13 Aug 2008 01:39:31 +0100, a écrit :
>> Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit :
>> > Better to just use 0/1 as values and only test for '= 1' (or test for
>> > set/unset, not sure what is more common).
>>
>> At least DEBUG uses y/n, so I have done the same in the attached fixed
>> patch.
>
> ping?

Hello Samuel,

It looks OK for me. What is you alioth login? I think it is
'sthibaul-guest' but wanted to be sure before adding you on the
project.

Obviously, you should still send the patches for review on the mailing
list before commiting them but it makes easier for you to be able to
commit your changes.

- --
        O T A V I O    S A L V A D O R
- ---------------------------------------------
 E-mail: otavio@...      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
- ---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ <http://mailcrypt.sourceforge.net/>

iEYEARECAAYFAkisY9AACgkQLqiZQEml+FUDigCgsDn/6jgg4ZjWzTQl/sKaaGyc
8dkAn0ytjPoUDX80sUjVDwhqDedvE9vc
=3sMB
-----END PGP SIGNATURE-----


--
To UNSUBSCRIBE, email to debian-accessibility-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...