Kerberos Ticket Forwarding Patch/Update

[Derrick Schommer-2]

Here is the patch for changes to samba 3.0.x for Kerberos ticket
forwarding. I'll send the 3.2 in a second.

 

I've tested this compiles under Fedora and OS X Leopard.

 

Derrick Schommer |  Corporate Systems Engineer

F5 Networks

  P 978.513.2900

 F 978.513.2990

www.f5.com <http://www.f5.com>  

  D 978.513.2960

 M 603.765.0012

 

 

[Jeremy Allison]

On Thu, Jul 24, 2008 at 04:54:47PM -0400, Derrick Schommer wrote:
> Here is the patch for changes to samba 3.0.x for Kerberos ticket
> forwarding. I'll send the 3.2 in a second.

Ok, couple of immediate comments. Looks like you've diff'ed
between new -> old, not old -> new as the patch is reversed.
That's not such a problem as I could reverse that.

Second issue is you're using C++ '//' style comments. We
don't allow this in the Samba code, so all the comments
will need to be re-written.

Can you fix these & resubmit please ?

Jeremy.

[Derrick Schommer-2]

Here is the update with C-style comments for 3.0.x

 

Derrick Schommer |  Corporate Systems Engineer

F5 Networks

  P 978.513.2900

 F 978.513.2990

www.f5.com <http://www.f5.com>  

  D 978.513.2960

 M 603.765.0012

 

 

[Andrew Bartlett]

On Thu, 2008-07-24 at 17:32 -0400, Derrick Schommer wrote:
> Here is the update with C-style comments for 3.0.x

Would it not be more sane to actually use GSSAPI?  

Andrew Bartlett

--
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.

[Derrick Schommer-2]

The actual code is roughly 3-years old, I'm finally able to commit it,
honestly, I remember looking at the GSSAPI stuff but found it didn't do
what I need. I'll go back and try to remember why :-)

Derrick

-----Original Message-----
From: Andrew Bartlett [mailto:abartlet@...]
Sent: Thursday, July 24, 2008 17:38
To: Derrick Schommer
Cc: samba-technical@...
Subject: Re: Kerberos Ticket Forwarding Patch/Update

On Thu, 2008-07-24 at 17:32 -0400, Derrick Schommer wrote:
> Here is the update with C-style comments for 3.0.x

Would it not be more sane to actually use GSSAPI?  

Andrew Bartlett

--
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.

[Love Hörnquist Åstrand]

Set GSS_C_DELEG_FLAG in init_sec_context() and the ticket will be  
delegated.

Love


24 jul 2008 kl. 22.40 skrev Derrick Schommer:

> The actual code is roughly 3-years old, I'm finally able to commit it,
> honestly, I remember looking at the GSSAPI stuff but found it didn't  
> do
> what I need. I'll go back and try to remember why :-)
>
> Derrick
>
> -----Original Message-----
> From: Andrew Bartlett [mailto:abartlet@...]
> Sent: Thursday, July 24, 2008 17:38
> To: Derrick Schommer
> Cc: samba-technical@...
> Subject: Re: Kerberos Ticket Forwarding Patch/Update
>
> On Thu, 2008-07-24 at 17:32 -0400, Derrick Schommer wrote:
>> Here is the update with C-style comments for 3.0.x
>
> Would it not be more sane to actually use GSSAPI?
>
> Andrew Bartlett
>
> --
> Andrew Bartlett
> http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Red Hat Inc.