JSP support for Findbugs

View: New views
2 Messages — Rating Filter:   Alert me  

JSP support for Findbugs

by Dmitry Kozlov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello everyone.
We have implemented support for JSP page view in Findbugs. It looks
like: http://lvk.cs.msu.su/~ddk/lj/findbugs_jsp.jpg
Can it be included into FindBugs mainstream?

And one more question: we are working on the same improvement to
Findbugs Eclipse plugin, but this requires JSP precompilation. As
proof-of-concept we do precompilation in FindBugsWorker (part of
Builder). But I have a question: is it better to leave JSP
precompilation as part of FindBugs or as separate plugin?

WBR
Dmitry

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

Re: JSP support for Findbugs

by Andrei Loskutov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Dmitry!

Please submit a patch based on the latest SVN code (please use Eclipse if
you can to create the patch).

See also http://findbugs.sourceforge.net/contributing.html

On Tue, 16 Sep 2008 17:17:23 +0200, Dmitry Kozlov <ddk@...> wrote:

> We have implemented support for JSP page view in Findbugs. It looks
> like: http://lvk.cs.msu.su/~ddk/lj/findbugs_jsp.jpg
> Can it be included into FindBugs mainstream?

If patch is useful & bug-free, why not? But first submit the patch ;-)

> And one more question: we are working on the same improvement to
> Findbugs Eclipse plugin, but this requires JSP precompilation. As
> proof-of-concept we do precompilation in FindBugsWorker (part of
> Builder). But I have a question: is it better to leave JSP
> precompilation as part of FindBugs or as separate plugin?

Please do not add this precompilation thing as a part of FindBugs plugin.
There are many ways how to deploy/compile/precompile JSP's or any kind of
code, but FindBugs should do only the one thing right - analyze the
bytecode. How this bytecode is generated, it's not a part of the FindBugs
job description ;-)

--
Kind regards,
Mit freundlichen Grüßen
Andrei Loskutov

@Home: http://andrei.gmxhome.de/
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss
LightInTheBox - Buy quality products at wholesale price!