Hit a bump...

[Stuart Sheldon]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey all,

After running our monthly recurring orders, I found that the systypes
entry for typeid 30 was out of sync with the salesorders table. I went
ahead and changed the value to the last orderno in the DB.

I'm not a programmer, I'm an admin type, so the code is a bit confusing
to me. I've tried to figure the problem out and this is what I came up
with... Please let me know if this is the right approach. If so I'll
post a diff.

~From what I see in the code, RecurringSalesOrdersProcess.php calls
DB_Last_Insert_ID() to get the orderno. This does not appear to even
look at the systypes DB let alone toggle it up.

DeliveryDetails.php calls GetNextTransNo() for the orderno. Would we
also want to do this in RecurringSalesOrdersProcess.php? Would that fix it?

Thanks,

Stu

- --
Harmlessly passing your time in the grassland away;
Only dimly aware of a certain unease in the air. You better watch out,
There may be dogs about I've looked over Jordan, and I have seen
Things are not what they seem.
~               -- Pink Floyd - "Sheep Lyrics"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiBD+QACgkQK69Y+xPZrWZ5sgCdGDIq+YAuMbw89OjYKt+ZHeg9
H0EAoIUcsxTxUCuNUrOqoPwli3HGpM97
=uxS8
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Web-erp-developers mailing list
Web-erp-developers@...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers

[Tim Schofield]

Stuart,

Thanks for this you are quite right. When we changed to using
GetNextTransNo() I updated all the scripts apart from these. I have
uploaded RecurringSalesOrders.php and RecurringSalesOrdersProcess.php
to cvs with your correction.

Thanks
Tim


2008/7/19 Stuart Sheldon <stu@...>:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hey all,
>
> After running our monthly recurring orders, I found that the systypes
> entry for typeid 30 was out of sync with the salesorders table. I went
> ahead and changed the value to the last orderno in the DB.
>
> I'm not a programmer, I'm an admin type, so the code is a bit confusing
> to me. I've tried to figure the problem out and this is what I came up
> with... Please let me know if this is the right approach. If so I'll
> post a diff.
>
> ~From what I see in the code, RecurringSalesOrdersProcess.php calls
> DB_Last_Insert_ID() to get the orderno. This does not appear to even
> look at the systypes DB let alone toggle it up.
>
> DeliveryDetails.php calls GetNextTransNo() for the orderno. Would we
> also want to do this in RecurringSalesOrdersProcess.php? Would that fix it?
>
> Thanks,
>
> Stu
>
> - --
> Harmlessly passing your time in the grassland away;
> Only dimly aware of a certain unease in the air. You better watch out,
> There may be dogs about I've looked over Jordan, and I have seen
> Things are not what they seem.
> ~               -- Pink Floyd - "Sheep Lyrics"
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkiBD+QACgkQK69Y+xPZrWZ5sgCdGDIq+YAuMbw89OjYKt+ZHeg9
> H0EAoIUcsxTxUCuNUrOqoPwli3HGpM97
> =uxS8
> -----END PGP SIGNATURE-----
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Web-erp-developers mailing list
> Web-erp-developers@...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Web-erp-developers mailing list
Web-erp-developers@...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers

[Stuart Sheldon]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Tim,

Thanks for the quick fix, I was looking at the code, and I think that
your change to RecuringSalesOrders.php might need to be reversed?

The recurrorderno in the recurringsalesorders DB is different from the
orderno in salesorders. I don't believe it is tracked via the systypes
table at all.

If I'm all wet about this, please tell me... I want to understand... <g>

Oh, if I'm wrong, and GetNextTransNo() should be used for the
recurringsalesorders DB, I think you need to add
includes/SQL_CommonFunctions.inc in the RecuringSalesOrders.php file...

Cheers,

Stu


Tim Schofield wrote:
| Stuart,
|
| Thanks for this you are quite right. When we changed to using
| GetNextTransNo() I updated all the scripts apart from these. I have
| uploaded RecurringSalesOrders.php and RecurringSalesOrdersProcess.php
| to cvs with your correction.
|
| Thanks
| Tim
|
|
| 2008/7/19 Stuart Sheldon <stu@...>:
| Hey all,
|
| After running our monthly recurring orders, I found that the systypes
| entry for typeid 30 was out of sync with the salesorders table. I went
| ahead and changed the value to the last orderno in the DB.
|
| I'm not a programmer, I'm an admin type, so the code is a bit confusing
| to me. I've tried to figure the problem out and this is what I came up
| with... Please let me know if this is the right approach. If so I'll
| post a diff.
|
| ~From what I see in the code, RecurringSalesOrdersProcess.php calls
| DB_Last_Insert_ID() to get the orderno. This does not appear to even
| look at the systypes DB let alone toggle it up.
|
| DeliveryDetails.php calls GetNextTransNo() for the orderno. Would we
| also want to do this in RecurringSalesOrdersProcess.php? Would that
fix it?
|
| Thanks,
|
| Stu
|
|>
- -------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great
prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Web-erp-developers mailing list
Web-erp-developers@...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
|>

| -------------------------------------------------------------------------
| This SF.Net email is sponsored by the Moblin Your Move Developer's
challenge
| Build the coolest Linux based applications with Moblin SDK & win great
prizes
| Grand prize is a trip for two to an Open Source event anywhere in the
world
| http://moblin-contest.org/redirect.php?banner_id=100&url=/
| _______________________________________________
| Web-erp-developers mailing list
| Web-erp-developers@...
| https://lists.sourceforge.net/lists/listinfo/web-erp-developers


- --
Well I've always had a deep respect, And I mean that most sincerely.
The band is just fantastic, that is really what I think.
Oh by the way, which one's Pink?
~               -- Pink Floyd - "Have a Cigar Lyrics"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiE9LgACgkQK69Y+xPZrWbQ2ACfVC0sEXHUoWvzUMBnurB8KWgr
KXMAnjO1eK4knW3jKxgRFyRnaOJ0BzDW
=AQcc
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Web-erp-developers mailing list
Web-erp-developers@...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers

[Tim Schofield]

Stuart,

That serves me right for doing updates without properly checking them
:-) Let me look again.

Tim


2008/7/21 Stuart Sheldon <stu@...>:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hey Tim,
>
> Thanks for the quick fix, I was looking at the code, and I think that
> your change to RecuringSalesOrders.php might need to be reversed?
>
> The recurrorderno in the recurringsalesorders DB is different from the
> orderno in salesorders. I don't believe it is tracked via the systypes
> table at all.
>
> If I'm all wet about this, please tell me... I want to understand... <g>
>
> Oh, if I'm wrong, and GetNextTransNo() should be used for the
> recurringsalesorders DB, I think you need to add
> includes/SQL_CommonFunctions.inc in the RecuringSalesOrders.php file...
>
> Cheers,
>
> Stu
>
>
> Tim Schofield wrote:
> | Stuart,
> |
> | Thanks for this you are quite right. When we changed to using
> | GetNextTransNo() I updated all the scripts apart from these. I have
> | uploaded RecurringSalesOrders.php and RecurringSalesOrdersProcess.php
> | to cvs with your correction.
> |
> | Thanks
> | Tim
> |
> |
> | 2008/7/19 Stuart Sheldon <stu@...>:
> | Hey all,
> |
> | After running our monthly recurring orders, I found that the systypes
> | entry for typeid 30 was out of sync with the salesorders table. I went
> | ahead and changed the value to the last orderno in the DB.
> |
> | I'm not a programmer, I'm an admin type, so the code is a bit confusing
> | to me. I've tried to figure the problem out and this is what I came up
> | with... Please let me know if this is the right approach. If so I'll
> | post a diff.
> |
> | ~From what I see in the code, RecurringSalesOrdersProcess.php calls
> | DB_Last_Insert_ID() to get the orderno. This does not appear to even
> | look at the systypes DB let alone toggle it up.
> |
> | DeliveryDetails.php calls GetNextTransNo() for the orderno. Would we
> | also want to do this in RecurringSalesOrdersProcess.php? Would that
> fix it?
> |
> | Thanks,
> |
> | Stu
> |
> |>
> - -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Web-erp-developers mailing list
> Web-erp-developers@...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
> |>
>
> | -------------------------------------------------------------------------
> | This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> | Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> | Grand prize is a trip for two to an Open Source event anywhere in the
> world
> | http://moblin-contest.org/redirect.php?banner_id=100&url=/
> | _______________________________________________
> | Web-erp-developers mailing list
> | Web-erp-developers@...
> | https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>
>
> - --
> Well I've always had a deep respect, And I mean that most sincerely.
> The band is just fantastic, that is really what I think.
> Oh by the way, which one's Pink?
> ~               -- Pink Floyd - "Have a Cigar Lyrics"
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkiE9LgACgkQK69Y+xPZrWbQ2ACfVC0sEXHUoWvzUMBnurB8KWgr
> KXMAnjO1eK4knW3jKxgRFyRnaOJ0BzDW
> =AQcc
> -----END PGP SIGNATURE-----
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Web-erp-developers mailing list
> Web-erp-developers@...
> https://lists.sourceforge.net/lists/listinfo/web-erp-developers
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Web-erp-developers mailing list
Web-erp-developers@...
https://lists.sourceforge.net/lists/listinfo/web-erp-developers