Nabble - Hippo CMS

[JIRA] Assigned: (HREPTWO-1553) Support 'classic' CMS next to new style 'deque' CMS

2008-10-12T07:53:59Z

[ http://issues.hippo.nl/browse/HREPTWO-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink reassigned HREPTWO-1553:
---------------------------------------

Assignee: Wander Grevink

> Support 'classic' CMS next to new style 'deque' CMS
> ---------------------------------------------------
>
> Key: HREPTWO-1553
> URL: http://issues.hippo.nl/browse/HREPTWO-1553
> Project: Hippo Repository 2
> Issue Type: Bug
> Affects Versions: 2.01.00m06.3
> Reporter: Wander Grevink
> Assignee: Wander Grevink
> Fix For: 2.01.00m08
>
>
> It should be able to support both CMS styles
> In the sprint to create the new 'deque' CMS some code duplication was done and some things broke in the 'classic' CMS
> This issue is intended as an umbrella for all these issues.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.hippo.nl/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

_______________________________________________
HippoRepos-dev mailing list
HippoRepos-dev@...
http://lists.hippo.nl/mailman/listinfo/hipporepos-dev

From forum: Hippo Repository development public mailinglist

[JIRA] Assigned: (HREPTWO-1556) 'Classic' CMS: Remove code duplication

2008-10-12T07:53:59Z

[ http://issues.hippo.nl/browse/HREPTWO-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink reassigned HREPTWO-1556:
---------------------------------------

Assignee: Wander Grevink

> 'Classic' CMS: Remove code duplication
> --------------------------------------
>
> Key: HREPTWO-1556
> URL: http://issues.hippo.nl/browse/HREPTWO-1556
> Project: Hippo Repository 2
> Issue Type: Sub-task
> Affects Versions: 2.01.00m06.3
> Reporter: Wander Grevink
> Assignee: Wander Grevink
> Priority: Low
> Fix For: 2.01.00m08
>
>
> In order to support the two CMS flavors the following classes have been duplicated:
> hippo-ecm$ find . -name New*.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewAbstractFolderWorkflowPlugin.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewRemodelWorkflowPlugin.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/remodel/NewRemodelDialog.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/dialogs/NewCreateTypeDialog.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/dialogs/NewNamespaceDialog.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/dialogs/NewCopyModelDialog.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewOrderableFolderWorkflowPlugin.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowPlugin.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowExtendedDialog.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java
> ./addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewNamespaceWorkflowPlugin.java
> ./addon/cms/browse/src/main/java/org/hippoecm/frontend/plugins/cms/browse/list/NewDocumentListingPlugin.java

From forum: Hippo Repository development public mailinglist

[JIRA] Resolved: (HREPTWO-1524) While it's possible to create a Gallery folder, it's not possible to create an Assets folder

2008-10-12T07:25:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink resolved HREPTWO-1524.
-------------------------------------

Resolution: Fixed

Resolved in HREPTWO-1662

> While it's possible to create a Gallery folder, it's not possible to create an Assets folder
> --------------------------------------------------------------------------------------------
>
> Key: HREPTWO-1524
> URL: http://issues.hippo.nl/browse/HREPTWO-1524
> Project: Hippo Repository 2
> Issue Type: Bug
> Affects Versions: 2.01.00m06.3
> Reporter: Wander Grevink
> Assignee: Wander Grevink
> Priority: Normal
> Fix For: 2.01.00m07
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Login, go to browse perspective, select 'content' folder
> Expand the workflow dropdown box above the document listing
> => Note that there is a 'new Gallery' item, but no 'new asset folder' item

From forum: Hippo Repository development public mailinglist

[JIRA] Assigned: (HREPTWO-1523) While it's possible to create a Gallery folder, it's not possible to delete one

2008-10-12T07:25:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink reassigned HREPTWO-1523:
---------------------------------------

Assignee: Wander Grevink (was: (Berry) A.W. van Halderen)

> While it's possible to create a Gallery folder, it's not possible to delete one
> -------------------------------------------------------------------------------
>
> Key: HREPTWO-1523
> URL: http://issues.hippo.nl/browse/HREPTWO-1523
> Project: Hippo Repository 2
> Issue Type: Bug
> Affects Versions: 2.01.00m06.3
> Reporter: Wander Grevink
> Assignee: Wander Grevink
> Fix For: 2.01.00m07
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1> Login, go to browse perspective, select 'content' folder
> 2> In dropdown box above document listing select 'New Gallery'
> 3> Give it a name, press OK
> 4> Select newly created Gallery folder
> ==> No active workflow, this means that it's impossible to delete a created Gallery folder

From forum: Hippo Repository development public mailinglist

[JIRA] Resolved: (HREPTWO-1523) While it's possible to create a Gallery folder, it's not possible to delete one

2008-10-12T07:25:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink resolved HREPTWO-1523.
-------------------------------------

Resolution: Fixed

Resolved for HREPTWO-1662

From forum: Hippo Repository development public mailinglist

[JIRA] Assigned: (HREPTWO-1524) While it's possible to create a Gallery folder, it's not possible to create an Assets folder

2008-10-12T07:23:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink reassigned HREPTWO-1524:
---------------------------------------

Assignee: Wander Grevink (was: (Berry) A.W. van Halderen)

From forum: Hippo Repository development public mailinglist

[JIRA] Resolved: (HREPTWO-1711) OK button disabled in new document dialog

2008-10-12T07:21:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink resolved HREPTWO-1711.
-------------------------------------

Resolution: Fixed

> OK button disabled in new document dialog
> -----------------------------------------
>
> Key: HREPTWO-1711
> URL: http://issues.hippo.nl/browse/HREPTWO-1711
> Project: Hippo Repository 2
> Issue Type: Bug
> Affects Versions: 2.01.00m07
> Environment: trunk r13879
> Reporter: Niels van Kampenhout
> Assignee: Wander Grevink
> Priority: Normal
> Fix For: 2.01.00m07
>
> Attachments: HREPTWO-1711.png
>
>
> When adding a new document, the OK button in the dialog is disabled / greyed out. Only after changing the selected document type a few times, does it become enabled.
> - log in to CMS
> - hit 'New document' in the top of the screen
> - choose a document type in the dropdown (do not yet type in a name!)
> - only then type in a name
> - the OK button is greyed out
> The OK button does get enabled if you switch to another application/window and back. Therefore taking a screenshot of this is impossible.......

From forum: Hippo Repository development public mailinglist

[JIRA] Resolved: (HREPTWO-1671) Creating orderable folder in non-orderable, or vice versa results in error.

2008-10-12T07:21:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink resolved HREPTWO-1671.
-------------------------------------

Resolution: Fixed

Cannot reproduce anymore, probably solved by other issues

> Creating orderable folder in non-orderable, or vice versa results in error.
> ---------------------------------------------------------------------------
>
> Key: HREPTWO-1671
> URL: http://issues.hippo.nl/browse/HREPTWO-1671
> Project: Hippo Repository 2
> Issue Type: Bug
> Reporter: (Berry) A.W. van Halderen
> Assignee: Wander Grevink
> Fix For: 2.01.00m07
>
> Original Estimate: 3 hours
> Remaining Estimate: 3 hours
>
> Note that before tagging, the functionality to create non-orderable function can/should be disabled by removing this from configuration ONLY.

From forum: Hippo Repository development public mailinglist

[13913] hippo-ecm: HREPTWO-1711: The 'name' textfield only fires ajax events when leaving or entering the field, not when entering characters.

2008-10-12T07:16:41Z

Revision: 13913
Author: wgrevink
Date: 2008-10-12 16:16:40 +0200 (Sun, 12 Oct 2008)
Log Message:
-----------
HREPTWO-1711: The 'name' textfield only fires ajax events when leaving or entering the field, not when entering characters. therefore move the 'name is not empty' check to the execute method.

Modified Paths:
--------------
hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java
hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java

Modified: hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java
===================================================================
--- hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java 2008-10-12 13:08:28 UTC (rev 13912)
+++ hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java 2008-10-12 14:16:40 UTC (rev 13913)
@@ -364,7 +364,7 @@
folderChoice.setVisible(false);
prototype = null;
}
- ok.setEnabled(prototype != null && name != null && !"".equals(name));
+ ok.setEnabled(prototype != null);
AjaxRequestTarget target = AjaxRequestTarget.get();
if (target != null) {
target.addComponent(ok);
@@ -386,6 +386,9 @@
}

protected void ok() throws Exception {
+ if (name == null || "".equals(name)) {
+ throw new IllegalArgumentException("You need to enter a name");
+ }
IModel model = getModel();
if (model != null && model instanceof WorkflowsModel) {
Session jcrSession = ((UserSession) org.apache.wicket.Session.get()).getJcrSession();

Modified: hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java
===================================================================
--- hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java 2008-10-12 13:08:28 UTC (rev 13912)
+++ hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java 2008-10-12 14:16:40 UTC (rev 13913)
@@ -116,15 +116,18 @@
private void enableButtons() {
NewAbstractFolderWorkflowPlugin folderWorkflowPlugin = (NewAbstractFolderWorkflowPlugin) getPlugin();
WorkflowsModel model = (WorkflowsModel) folderWorkflowPlugin.getModel();
- ok.setEnabled(model.getNodeModel().getNode() != null && prototype != null && name != null && !"".equals(name));
+ ok.setEnabled(model.getNodeModel().getNode() != null && prototype != null);
}

@Override
protected void execute() throws Exception {
FolderWorkflow workflow = (FolderWorkflow) getWorkflow();
if (prototype == null) {
- throw new WorkflowException("You need to select a type");
+ throw new IllegalArgumentException("You need to select a type");
}
+ if (name == null || "".equals(name)) {
+ throw new IllegalArgumentException("You need to enter a name");
+ }
if (workflow != null) {
NewAbstractFolderWorkflowPlugin folderWorkflowPlugin = (NewAbstractFolderWorkflowPlugin) getPlugin();
if (!folderWorkflowPlugin.templates.get(category).getPrototypes().contains(prototype)) {

_______________________________________________
HippoRepos-dev mailing list
HippoRepos-dev@...
http://lists.hippo.nl/mailman/listinfo/hipporepos-dev

From forum: Hippo Repository development public mailinglist

[HippoCMS-svn] [13913] hippo-ecm: HREPTWO-1711: The 'name' textfield only fires ajax events when leaving or entering the field, not when entering characters.

2008-10-12T07:16:41Z

Revision: 13913
Author: wgrevink
Date: 2008-10-12 16:16:40 +0200 (Sun, 12 Oct 2008)
Log Message:
-----------
HREPTWO-1711: The 'name' textfield only fires ajax events when leaving or entering the field, not when entering characters. therefore move the 'name is not empty' check to the execute method.

Modified Paths:
--------------
hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java
hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java

Modified: hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java
===================================================================
--- hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java 2008-10-12 13:08:28 UTC (rev 13912)
+++ hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/FolderShortcutPlugin.java 2008-10-12 14:16:40 UTC (rev 13913)
@@ -364,7 +364,7 @@
folderChoice.setVisible(false);
prototype = null;
}
- ok.setEnabled(prototype != null && name != null && !"".equals(name));
+ ok.setEnabled(prototype != null);
AjaxRequestTarget target = AjaxRequestTarget.get();
if (target != null) {
target.addComponent(ok);
@@ -386,6 +386,9 @@
}

protected void ok() throws Exception {
+ if (name == null || "".equals(name)) {
+ throw new IllegalArgumentException("You need to enter a name");
+ }
IModel model = getModel();
if (model != null && model instanceof WorkflowsModel) {
Session jcrSession = ((UserSession) org.apache.wicket.Session.get()).getJcrSession();

Modified: hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java
===================================================================
--- hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java 2008-10-12 13:08:28 UTC (rev 13912)
+++ hippo-ecm/trunk/addon/builtin/frontend/src/main/java/org/hippoecm/frontend/plugins/standardworkflow/NewFolderWorkflowDialog.java 2008-10-12 14:16:40 UTC (rev 13913)
@@ -116,15 +116,18 @@
private void enableButtons() {
NewAbstractFolderWorkflowPlugin folderWorkflowPlugin = (NewAbstractFolderWorkflowPlugin) getPlugin();
WorkflowsModel model = (WorkflowsModel) folderWorkflowPlugin.getModel();
- ok.setEnabled(model.getNodeModel().getNode() != null && prototype != null && name != null && !"".equals(name));
+ ok.setEnabled(model.getNodeModel().getNode() != null && prototype != null);
}

@Override
protected void execute() throws Exception {
FolderWorkflow workflow = (FolderWorkflow) getWorkflow();
if (prototype == null) {
- throw new WorkflowException("You need to select a type");
+ throw new IllegalArgumentException("You need to select a type");
}
+ if (name == null || "".equals(name)) {
+ throw new IllegalArgumentException("You need to enter a name");
+ }
if (workflow != null) {
NewAbstractFolderWorkflowPlugin folderWorkflowPlugin = (NewAbstractFolderWorkflowPlugin) getPlugin();
if (!folderWorkflowPlugin.templates.get(category).getPrototypes().contains(prototype)) {

_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@...
http://lists.hippo.nl/mailman/listinfo/hippocms-svn

From forum: Hippo CMS development public svn log

[JIRA] Assigned: (HREPTWO-1671) Creating orderable folder in non-orderable, or vice versa results in error.

2008-10-12T07:07:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink reassigned HREPTWO-1671:
---------------------------------------

Assignee: Wander Grevink (was: Frank van Lankvelt)

From forum: Hippo Repository development public mailinglist

[JIRA] Assigned: (HREPTWO-1711) OK button disabled in new document dialog

2008-10-12T07:07:58Z

[ http://issues.hippo.nl/browse/HREPTWO-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wander Grevink reassigned HREPTWO-1711:
---------------------------------------

Assignee: Wander Grevink

From forum: Hippo Repository development public mailinglist