|
View:
New views
2 Messages
—
Rating Filter:
Alert me
|
|
|
HTML output errorI've found, what I think is some kind of bug or error on the code
generated when compiling a form. I compiled some simple form using the sawfisch-crux theme and I found that the images where not displayed. Then I tried with the xp theme with the same results. When looking at the code, at the function output of the generated form class, there's something wrong with the images URIs. <img style=\"display: block\" src=\""."\n ".$this->images."\n "."lighttopleft.gif\" width=\"5\" height=\"5\" alt=\"\" /> Note that $this->images has the path to where all images are stored. Take special note on the new line character and the spaces following inmediately. HTMLTidy gives two warnings: "discarding new line in URI reference" and "escaping malformed URI reference" deleting the new line corrects the first warning but still the images are not displayed. Eliminating the spaces will do the trick. This makes me think about accessibility and how accessible is the code generated by the metastorage tool. I know by experience that all the javascript code used by the forms class is cross-browser compatible, but I think that the HTML accessibility has not been considered as much. I would need to make more tests, but my guess is that the HTML code generated by the metastorage themes could be improved to be more accessible and tidy. If you're willing to work a bit on the matter, I would gladly point you out whenever I find some of these inconveniences. BARBAZUL ------------------------ Yahoo! Groups Sponsor --------------------~--> Check out the new improvements in Yahoo! Groups email. http://us.click.yahoo.com/6pRQfA/fOaOAA/yQLSAA/saFolB/TM --------------------------------------------------------------------~-> Yahoo! Groups Links <*> To visit your group on the web, go to: http://groups.yahoo.com/group/metal-dev/ <*> To unsubscribe from this group, send an email to: metal-dev-unsubscribe@... <*> Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/ |
|
|
Re: HTML output errorHello,
on 06/30/2006 10:46 PM comfortablementeadormecido said the following: > I've found, what I think is some kind of bug or error on the code > generated when compiling a form. > I compiled some simple form using the sawfisch-crux theme and I found > that the images where not displayed. Then I tried with the xp theme > with the same results. > > When looking at the code, at the function output of the generated form > class, there's something wrong with the images URIs. > > <img style=\"display: block\" src=\""."\n ".$this->images."\n > "."lighttopleft.gif\" width=\"5\" height=\"5\" alt=\"\" /> > > Note that $this->images has the path to where all images are stored. > Take special note on the new line character and the spaces following > inmediately. > > HTMLTidy gives two warnings: "discarding new line in URI reference" > and "escaping malformed URI reference" > > deleting the new line corrects the first warning but still the images > are not displayed. > Eliminating the spaces will do the trick. I just tried it here and I could not reproduce the problem. I suspect that you have edited the templates with text editor that forces line breaks and adds automatic indentation spaces. If that is the case, try extracting the original files again from the archive downloaded from the site. Another possibility is that you are using a PHP version with bugs traversing arrays. Which PHP version are you using? > This makes me think about accessibility and how accessible is the code > generated by the metastorage tool. I know by experience that all the > javascript code used by the forms class is cross-browser compatible, > but I think that the HTML accessibility has not been considered as much. > > I would need to make more tests, but my guess is that the HTML code > generated by the metastorage themes could be improved to be more > accessible and tidy. > > If you're willing to work a bit on the matter, I would gladly point > you out whenever I find some of these inconveniences. You are free to improve the current themes or propose new themes besides the ones that are made available. -- Regards, Manuel Lemos Metastorage - Data object relational mapping layer generator http://www.metastorage.net/ PHP Classes - Free ready to use OOP components written in PHP http://www.phpclasses.org/ ------------------------ Yahoo! Groups Sponsor --------------------~--> Yahoo! Groups gets a make over. See the new email design. http://us.click.yahoo.com/XISQkA/lOaOAA/yQLSAA/saFolB/TM --------------------------------------------------------------------~-> Yahoo! Groups Links <*> To visit your group on the web, go to: http://groups.yahoo.com/group/metal-dev/ <*> To unsubscribe from this group, send an email to: metal-dev-unsubscribe@... <*> Your use of Yahoo! Groups is subject to: http://docs.yahoo.com/info/terms/ |
| Free Forum Powered by Nabble | Forum Help |