Group support in Item and Manager

[Shaun Murray]

Matt, how is the group support supposed to work (or was supposed to  
work) in Item/Manager ?

core/Item.php and core/Manager.php are used across a lot of modules  
in phpWebSite but the permission support in them is left half  
implemented it seems.

In Item.php the _groups member var is commented out.

We do however have addGroup() and removeGroup() funcs that add and  
remove groups to/from an Item.


In Manager.php we have getItems() and one of the parameters is  
$filterGroups which filters out Items if the user doesn't belong to  
one of the groups the Item belongs to. We also have the GROUPS column  
to show which groups an Item belongs to in a list/row display.

I'm wondering how much trouble it is to use these features or what  
extra needs adding to complete the support. eg. adding filter support  
to Manager's getList() function. That could pretty much add view  
permission support, easily, to Article, Announce, Documents, phpwsBB,  
PhotoAlbum and many more 3rd party mods. It'd stave off a bunch of  
hacks at each module level too.


Shaun
aegis design - http://www.aegisdesign.co.uk
aegis hosting - http://www.aegishosting.co.uk


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Phpwebsite-developers mailing list
Phpwebsite-developers@...
https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers

[Matthew McNaney]

Shaun,

Sorry but I have to cop out: I don't know. Item and Manager were Steven
and Adam's babies. I rarely used them unless I was updating their code.

It looks difficult to add item permissions to those classes. They were
planning on saving the groups in a serialize array. This means you would
have to pull each item from the table, unserialize the allowed groups,
then compare them to the current user's group array. If the item was
allowed, Manager could display it. If not, then it would keep it hidden.

This sounds like a bit of overhead. It also sounds like it would
throw-off the pagination in Manager. Imagine if you had a ten thousand
items but only one of those should be seen by the user. You may load and
process 9999 items before you can print the allowed one.

I suppose you could recode it to create a separate group item table to
cross-reference. Depends on how fancy you want your shoehorn :)

Matt

On Sat, 2006-09-02 at 03:15 +0100, Shaun Murray wrote:

> Matt, how is the group support supposed to work (or was supposed to  
> work) in Item/Manager ?
>
> core/Item.php and core/Manager.php are used across a lot of modules  
> in phpWebSite but the permission support in them is left half  
> implemented it seems.
>
> In Item.php the _groups member var is commented out.
>
> We do however have addGroup() and removeGroup() funcs that add and  
> remove groups to/from an Item.
>
>
> In Manager.php we have getItems() and one of the parameters is  
> $filterGroups which filters out Items if the user doesn't belong to  
> one of the groups the Item belongs to. We also have the GROUPS column  
> to show which groups an Item belongs to in a list/row display.
>
> I'm wondering how much trouble it is to use these features or what  
> extra needs adding to complete the support. eg. adding filter support  
> to Manager's getList() function. That could pretty much add view  
> permission support, easily, to Article, Announce, Documents, phpwsBB,  
> PhotoAlbum and many more 3rd party mods. It'd stave off a bunch of  
> hacks at each module level too.
>
>
> Shaun
> aegis design - http://www.aegisdesign.co.uk
> aegis hosting - http://www.aegishosting.co.uk
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Phpwebsite-developers mailing list
> Phpwebsite-developers@...
> https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers

--
Matthew McNaney
Electronic Student Services
Appalachian State University
http://phpwebsite.appstate.edu


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Phpwebsite-developers mailing list
Phpwebsite-developers@...
https://lists.sourceforge.net/lists/listinfo/phpwebsite-developers