For Review: Change 20080723-ptw-P Summary: Revert broken swf9-only version of LzMessage class

View: New views
2 Messages — Rating Filter:   Alert me  

For Review: Change 20080723-ptw-P Summary: Revert broken swf9-only version of LzMessage class

by P T Withington :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Change 20080723-ptw-P by ptw@... on 2008-07-23  
16:26:54 EDT
     in /Users/ptw/OpenLaszlo/dingdong-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Revert broken swf9-only version of LzMessage class

Bugs Fixed:
LPP-6170 'LzText.format does not work in swf9 (missing  
LzMessage.toString)'

Technical Reviewer: hminsky (pending)
QA Reviewer: jcrowley (pending)

Details:
     I couldn't convince Henry that the existing bootstrap LzMessage
     class was already swf9 compatible.  Maybe this will.

Tests:
     Test case from bug report.

Files:
M      WEB-INF/lps/lfc/debugger/swf9stubs.lzs
M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
M      WEB-INF/lps/lfc/compiler/Library.lzs


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080723-ptw-P.tar

Re: For Review: Change 20080723-ptw-P Summary: Revert broken swf9-only version of LzMessage class

by Henry Minsky-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

approved ...

hmm I forget why I thought it wouldn't work in swf9...


On Wed, Jul 23, 2008 at 4:34 PM, P T Withington <ptw@...> wrote:

> Change 20080723-ptw-P by ptw@... on 2008-07-23 16:26:54 EDT
>    in /Users/ptw/OpenLaszlo/dingdong-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Revert broken swf9-only version of LzMessage class
>
> Bugs Fixed:
> LPP-6170 'LzText.format does not work in swf9 (missing LzMessage.toString)'
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: jcrowley (pending)
>
> Details:
>    I couldn't convince Henry that the existing bootstrap LzMessage
>    class was already swf9 compatible.  Maybe this will.
>
> Tests:
>    Test case from bug report.
>
> Files:
> M      WEB-INF/lps/lfc/debugger/swf9stubs.lzs
> M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
> M      WEB-INF/lps/lfc/compiler/Library.lzs
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080723-ptw-P.tar
>



--
Henry Minsky
Software Architect
hminsky@...
LightInTheBox - Buy quality products at wholesale price