For Review: Change 20080723-hqm-a Summary: fix for swf9 resource loading

View: New views
2 Messages — Rating Filter:   Alert me  

For Review: Change 20080723-hqm-a Summary: fix for swf9 resource loading

by Henry Minsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Change 20080723-hqm-a by hqm@... on 2008-07-23 16:27:48 EDT
     in /Users/hqm/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix for swf9 resource loading

New Features:

Bugs Fixed:

Technical Reviewer: max
QA Reviewer: pbr
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

wrap a try-catch around an operation that sometimes throws an error

sometimes the progress tracking is asking for the loader info too  
early in the load, which causes
a runtime error from the URL loader object.

This is sporadic, and probably would have no user-visible consequence  
in the non-debug flash player,
but we should catch the error to avoid runtime errors in the debug  
player


Tests:

run lzpix, don't see the error happen (at least not yet, it's  
intermittent)

Files:
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080723-hqm-a.tar

Parent Message unknown Re: For Review: Change 20080723-hqm-a Summary: fix for swf9 resource loading

by Henry Minsky :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Yeah, the error seems to happen in the getter that runs for the access to

event.target.loader



On Wed, Jul 23, 2008 at 4:33 PM, Max Carlson <max@...> wrote:

> Approved!  Sorry, I thought this was covered by the existing try/catch...
>
> Henry Minsky wrote:
>>
>> Change 20080723-hqm-a by hqm@... on 2008-07-23 16:27:48 EDT
>>    in /Users/hqm/openlaszlo/trunk
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: fix for swf9 resource loading
>>
>> New Features:
>>
>> Bugs Fixed:
>>
>> Technical Reviewer: max
>> QA Reviewer: pbr
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>
>> wrap a try-catch around an operation that sometimes throws an error
>>
>> sometimes the progress tracking is asking for the loader info too early in
>> the load, which causes
>> a runtime error from the URL loader object.
>>
>> This is sporadic, and probably would have no user-visible consequence in
>> the non-debug flash player,
>> but we should catch the error to avoid runtime errors in the debug player
>>
>>
>> Tests:
>>
>> run lzpix, don't see the error happen (at least not yet, it's
>> intermittent)
>>
>> Files:
>> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080723-hqm-a.tar
>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>



--
Henry Minsky
Software Architect
hminsky@...
LightInTheBox - Buy quality products at wholesale price