For Review: Change 20080722-maxcarlson-6 Summary: Fix setSource() in swf9

[Max Carlson-2]

Change 20080722-maxcarlson-6 by maxcarlson@Roboto on 2008-07-22  
20:12:12 PDT
     in /Users/maxcarlson/openlaszlo/trunk-clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix setSource() in swf9

Bugs Fixed: LPP-6707 - swf9: setSource() calls show previous image

Technical Reviewer: hminsky
QA Reviewer: promanik

Details: LzSprite.as - Use resource property instead of resourceURL.  
Use default args in LaszloView.resourceevent(). Reuse loader and reset  
scale for setSource() calls. Expand loaderEventHandler() to handle  
load progress. Avoid potential division by zeron in  
applyStretchResource(). Rename updateResourceSize() to  
sendResourceLoad() and expose skiponload arg, defaulting to false.

LaszloView.lzs - Add default arg values for resourceevent() calls.

Tests: See LPP-6707.

Files:
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
M      WEB-INF/lps/lfc/views/LaszloView.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080722-maxcarlson-6.tar

[Henry Minsky-2]

Approved.

When running lzpix with this, just once I got this error message from the player

There must be some condition that happens when the load is in some intial state, maybe we should put

a try/catch around this call. 

rror: Error #2099: The loading object is not sufficiently loaded to provide this information.

at flash.display::LoaderInfo/get loader()

at LzSprite/loaderEventHandler()

at flash.display::Loader/_load()

at flash.display::Loader/load()

at LzSprite/setSource()

at LzView/setSource()

at $lzc$class_detailsview/setImage()

at $lzc$class_$m338/$m307()

at Function/http://adobe.com/AS3/2006/builtin::call()

at LzEvent/sendEvent()

at $lzc$class_photo/$m94()

at Function/http://adobe.com/AS3/2006/builtin::call()

at LzEvent/sendEvent()

at MethodInfo-2229()

at Function/http://adobe.com/AS3/2006/builtin::call()

at LzEvent/sendEvent()

at LzView/mouseevent()

at LzModeManagerService/handleMouseEvent()

at LzModeManagerService/rawMouseEvent()

at LzMouseKernel$/__sendEvent()

at LzSprite/__mouseEvent()

On Tue, Jul 22, 2008 at 11:25 PM, Max Carlson <max@...> wrote:

Change 20080722-maxcarlson-6 by maxcarlson@Roboto on 2008-07-22 20:12:12 PDT
   in /Users/maxcarlson/openlaszlo/trunk-clean
   for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix setSource() in swf9

Bugs Fixed: LPP-6707 - swf9: setSource() calls show previous image

Technical Reviewer: hminsky
QA Reviewer: promanik

Details: LzSprite.as - Use resource property instead of resourceURL. Use default args in LaszloView.resourceevent(). Reuse loader and reset scale for setSource() calls. Expand loaderEventHandler() to handle load progress. Avoid potential division by zeron in applyStretchResource(). Rename updateResourceSize() to sendResourceLoad() and expose skiponload arg, defaulting to false.

LaszloView.lzs - Add default arg values for resourceevent() calls.

Tests: See LPP-6707.

Files:
M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
M      WEB-INF/lps/lfc/views/LaszloView.lzs

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080722-maxcarlson-6.tar

--
Henry Minsky
Software Architect
hminsky@...