Feedback wanted: patch to eliminate need for findbugs/findbugs.bat scripts

View: New views
6 Messages — Rating Filter:   Alert me  

Feedback wanted: patch to eliminate need for findbugs/findbugs.bat scripts

by David Hovemeyer-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi everyone,

As you probably know, FindBugs is launched by a Bourne shell
script or a Windows batch file.  The only reason the script and batch
file exist is as a convenience - they can infer the directory in which
FindBugs is installed, and ensure that any detector
in the "plugin" directory plugins (including third-party or
user-implemented plugins) get loaded.

For a variety of reasons, it would be nice for FindBugs to be able to
launch directly from a jar file.  Some of the reasons include:

- "play nice" as a part of a pure-Java ecosystem

- modularity (see FindBugs feature request #1995284)

- double-click on a jar file, have FindBugs launch and do something
  useful out of the box

- ease of debugging FindBugs

- the script has some annoying bugs in it (and I assume the
  batch file does as well)

Here is a preliminary, proof-of-concept patch to make this happen:

  http://faculty.ycp.edu/~dhovemey/findbugs-noscript.patch

This patch is against the latest development code at

  http://code.google.com/p/findbugs/

The patch allows you to do things like

  java -jar $FINDBUGS_HOME/lib/findbugs.jar -project myProj.fbp
    [launch the command line interface]

  java -jar $FINDBUGS_HOME/lib/findbugsGUI.jar
    [launch the GUI]

and have things work (hopefully) as expected.  Note that if you have
plugins you want loaded, all you have to do is add

  -Dfindbugs.home="$FINDBUGS_HOME"

to the java command line.

Any feedback would be greatly appreciated.

-Dave
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

Re: Feedback wanted: patch to eliminate need for findbugs/findbugs.bat scripts

by Jeff Jensen-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> Any feedback would be greatly appreciated.

We run FindBugs via Maven or the Eclipse plugin, so your proposal should not
affect us.  However, I like your proposal :-).


-----Original Message-----
From: findbugs-discuss-bounces@...
[mailto:findbugs-discuss-bounces@...] On Behalf Of David Hovemeyer
Sent: Tuesday, July 01, 2008 2:00 PM
To: FindBugs discuss
Subject: [FB-Discuss] Feedback wanted: patch to eliminate need for
findbugs/findbugs.bat scripts

Hi everyone,

As you probably know, FindBugs is launched by a Bourne shell
script or a Windows batch file.  The only reason the script and batch
file exist is as a convenience - they can infer the directory in which
FindBugs is installed, and ensure that any detector
in the "plugin" directory plugins (including third-party or
user-implemented plugins) get loaded.

For a variety of reasons, it would be nice for FindBugs to be able to
launch directly from a jar file.  Some of the reasons include:

- "play nice" as a part of a pure-Java ecosystem

- modularity (see FindBugs feature request #1995284)

- double-click on a jar file, have FindBugs launch and do something
  useful out of the box

- ease of debugging FindBugs

- the script has some annoying bugs in it (and I assume the
  batch file does as well)

Here is a preliminary, proof-of-concept patch to make this happen:

  http://faculty.ycp.edu/~dhovemey/findbugs-noscript.patch

This patch is against the latest development code at

  http://code.google.com/p/findbugs/

The patch allows you to do things like

  java -jar $FINDBUGS_HOME/lib/findbugs.jar -project myProj.fbp
    [launch the command line interface]

  java -jar $FINDBUGS_HOME/lib/findbugsGUI.jar
    [launch the GUI]

and have things work (hopefully) as expected.  Note that if you have
plugins you want loaded, all you have to do is add

  -Dfindbugs.home="$FINDBUGS_HOME"

to the java command line.

Any feedback would be greatly appreciated.

-Dave
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

Java Version with 1.3.4

by David.Cate :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


The site says that JRE 1.4 is the minimum requirement but I'm getting errors indicating that JRE 1.5 is the requirement. I am currently trying to use the ANT task but noticed that the JVM argument is not accessible. Has anyone had success running 1.3.4 Ant task in Java 1.4?
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

Re: Feedback wanted: patch to eliminate need for findbugs/findbugs.bat scripts

by Garvin LeClaire-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I am in a similar situation as Jeff since I use and maintain the Maven 2 Findbugs plugin.

I do see the merit of this.  It may even help with the latest function I am adding to launch FindBugs GUI from Maven and have it configured for the Maven project within my POM.
Regards,



Garvin LeClaire
garvin.leclaire@...



Jeff Jensen wrote:
Any feedback would be greatly appreciated.
    

We run FindBugs via Maven or the Eclipse plugin, so your proposal should not
affect us.  However, I like your proposal :-).


-----Original Message-----
From: findbugs-discuss-bounces@...
[findbugs-discuss-bounces@...] On Behalf Of David Hovemeyer
Sent: Tuesday, July 01, 2008 2:00 PM
To: FindBugs discuss
Subject: [FB-Discuss] Feedback wanted: patch to eliminate need for
findbugs/findbugs.bat scripts

Hi everyone,

As you probably know, FindBugs is launched by a Bourne shell
script or a Windows batch file.  The only reason the script and batch
file exist is as a convenience - they can infer the directory in which
FindBugs is installed, and ensure that any detector
in the "plugin" directory plugins (including third-party or
user-implemented plugins) get loaded.

For a variety of reasons, it would be nice for FindBugs to be able to
launch directly from a jar file.  Some of the reasons include:

- "play nice" as a part of a pure-Java ecosystem

- modularity (see FindBugs feature request #1995284)

- double-click on a jar file, have FindBugs launch and do something
  useful out of the box

- ease of debugging FindBugs

- the script has some annoying bugs in it (and I assume the
  batch file does as well)

Here is a preliminary, proof-of-concept patch to make this happen:

  http://faculty.ycp.edu/~dhovemey/findbugs-noscript.patch

This patch is against the latest development code at

  http://code.google.com/p/findbugs/

The patch allows you to do things like

  java -jar $FINDBUGS_HOME/lib/findbugs.jar -project myProj.fbp
    [launch the command line interface]

  java -jar $FINDBUGS_HOME/lib/findbugsGUI.jar
    [launch the GUI]

and have things work (hopefully) as expected.  Note that if you have
plugins you want loaded, all you have to do is add

  -Dfindbugs.home="$FINDBUGS_HOME"

to the java command line.

Any feedback would be greatly appreciated.

-Dave
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

  

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

Re: Java Version with 1.3.4

by David Hovemeyer-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

1.3.4 requires JRE 1.5.

If you can let us know which parts of the website and documentation
still list 1.4 as the requirement, please let us know.  1.5 has been
required for a while, but we haven't quite gotten to updating all
of the references.

-Dave

On Thu, Jul 3, 2008 at 1:50 PM,  <david.cate@...> wrote:

>
> The site says that JRE 1.4 is the minimum requirement but I'm getting errors
> indicating that JRE 1.5 is the requirement. I am currently trying to use the
> ANT task but noticed that the JVM argument is not accessible. Has anyone had
> success running 1.3.4 Ant task in Java 1.4?
> _______________________________________________
> Findbugs-discuss mailing list
> Findbugs-discuss@...
> https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss
>
>
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

Re: Feedback wanted: patch to eliminate need for findbugs/findbugs.bat scripts

by David Hovemeyer-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Thu, Jul 3, 2008 at 2:05 PM, Garvin LeClaire
<garvin.leclaire@...> wrote:
> I am in a similar situation as Jeff since I use and maintain the Maven 2
> Findbugs plugin.
>
> I do see the merit of this.  It may even help with the latest function I am
> adding to launch FindBugs GUI from Maven and have it configured for the
> Maven project within my POM.

OK, great.

The latest development code at code.google.com builds a single
jar file (findbugs.jar) with the core engine, detectors, and GUI.
A system property. findbugs.launchUI, selects among the
different UIs.

So, to launch the textui:

  java -Dfindbugs.launchUI=textui -jar $FINDBUGS_HOME/lib/findbugs.jar

To launch the GUI:

  java -Dfindbugs.launchUI=gui2 -jar $FINDBUGS_HOME/lib/findbugs.jar
  java -jar $FINDBUGS_HOME/lib/findbugs.jar

[The second command works because running the GUI is
the default behavior.]

Anyway, feedback is appreciated.

-Dave
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss