Fatal bug in mod_python with 3.1.0rc1

[Frank McIngvale]

Hi all,

I tried creating a ticket for this, but it wouldn't let me for some
reason. There is a showstopping bug in 3.1.0rc1 with mod_python. Here
is a patch ... hopefully it won't become too mangled by the mailing
list. The issue is that _control_console_handler is left undefined on
non-win32 platforms.

diff -u -r CherryPy-3.1.0rc1/cherrypy/__init__.py fm-CherryPy-3.1.0rc1/
cherrypy/__init__.py
--- CherryPy-3.1.0rc1/cherrypy/__init__.py 2008-05-17
15:34:25.000000000 -0500
+++ fm-CherryPy-3.1.0rc1/cherrypy/__init__.py 2008-06-12
11:33:48.467036800 -0500
@@ -181,7 +181,8 @@
     del win32
 except ImportError:
     engine = process.bus
-
+    _console_control_handler = None
+

 # Timeout monitor
 class _TimeoutMonitor(process.plugins.Monitor):
diff -u -r CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py fm-CherryPy-3.1.0rc1/
cherrypy/_cpmodpy.py
--- CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py 2008-05-17
15:34:26.000000000 -0500
+++ fm-CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py 2008-06-12
11:34:11.149164400 -0500
@@ -97,7 +97,8 @@
                             "tools.ignore_headers.headers":
['Range'],
                             })

-    cherrypy._console_control_handler.unsubscribe()
+    if cherrypy._console_control_handler is not None:
+        cherrypy._console_control_handler.unsubscribe()
     cherrypy.engine.autoreload.unsubscribe()
     cherrypy.server.unsubscribe()




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "cherrypy-users" group.
To post to this group, send email to cherrypy-users@...
To unsubscribe from this group, send email to cherrypy-users-unsubscribe@...
For more options, visit this group at http://groups.google.com/group/cherrypy-users?hl=en
-~----------~----~----~----~------~----~------~--~---

[Robert Brewer-4]

Frank McIngvale wrote:
> I tried creating a ticket for this, but it wouldn't let me for some
> reason. There is a showstopping bug in 3.1.0rc1 with mod_python. Here
> is a patch ... hopefully it won't become too mangled by the mailing
> list. The issue is that _control_console_handler is left undefined on
> non-win32 platforms.
>
> diff -u -r CherryPy-3.1.0rc1/cherrypy/__init__.py
fm-CherryPy-3.1.0rc1/

> cherrypy/__init__.py
> --- CherryPy-3.1.0rc1/cherrypy/__init__.py 2008-05-17
> 15:34:25.000000000 -0500
> +++ fm-CherryPy-3.1.0rc1/cherrypy/__init__.py 2008-06-12
> 11:33:48.467036800 -0500
> @@ -181,7 +181,8 @@
>      del win32
>  except ImportError:
>      engine = process.bus
> -
> +    _console_control_handler = None
> +
>
>  # Timeout monitor
>  class _TimeoutMonitor(process.plugins.Monitor):
> diff -u -r CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py

fm-CherryPy-3.1.0rc1/

> cherrypy/_cpmodpy.py
> --- CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py 2008-05-17
> 15:34:26.000000000 -0500
> +++ fm-CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py 2008-06-12
> 11:34:11.149164400 -0500
> @@ -97,7 +97,8 @@
>                              "tools.ignore_headers.headers":
> ['Range'],
>                              })
>
> -    cherrypy._console_control_handler.unsubscribe()
> +    if cherrypy._console_control_handler is not None:
> +        cherrypy._console_control_handler.unsubscribe()
>      cherrypy.engine.autoreload.unsubscribe()
>      cherrypy.server.unsubscribe()

Thanks. I'll fix this ASAP as I'm trying to move the
console_control_handler subscribe call into quickstart anyway...


Robert Brewer
fumanchu@...


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "cherrypy-users" group.
To post to this group, send email to cherrypy-users@...
To unsubscribe from this group, send email to cherrypy-users-unsubscribe@...
For more options, visit this group at http://groups.google.com/group/cherrypy-users?hl=en
-~----------~----~----~----~------~----~------~--~---

[Robert Brewer-4]

Frank McIngvale wrote:
> I tried creating a ticket for this, but it wouldn't let me for some
> reason. There is a showstopping bug in 3.1.0rc1 with mod_python. Here
> is a patch ... hopefully it won't become too mangled by the mailing
> list. The issue is that _control_console_handler is left undefined on
> non-win32 platforms.

Lakin just fixed this in http://cherrypy.org/changeset/1982. But I'm
still going to audit all the Bus plugin madness again when I get a
chance.


Robert Brewer
fumanchu@...


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "cherrypy-users" group.
To post to this group, send email to cherrypy-users@...
To unsubscribe from this group, send email to cherrypy-users-unsubscribe@...
For more options, visit this group at http://groups.google.com/group/cherrypy-users?hl=en
-~----------~----~----~----~------~----~------~--~---

[Robert Brewer-4]

I wrote:
> Frank McIngvale wrote:
> > I tried creating a ticket for this, but it wouldn't let me for some
> > reason. There is a showstopping bug in 3.1.0rc1 with mod_python.
Here
> > is a patch ... hopefully it won't become too mangled by the mailing
> > list. The issue is that _control_console_handler is left undefined
on

> > non-win32 platforms.
> >
> > diff -u -r CherryPy-3.1.0rc1/cherrypy/__init__.py
> fm-CherryPy-3.1.0rc1/
> > cherrypy/__init__.py
> > --- CherryPy-3.1.0rc1/cherrypy/__init__.py 2008-05-17
> > 15:34:25.000000000 -0500
> > +++ fm-CherryPy-3.1.0rc1/cherrypy/__init__.py 2008-06-12
> > 11:33:48.467036800 -0500
> > @@ -181,7 +181,8 @@
> >      del win32
> >  except ImportError:
> >      engine = process.bus
> > -
> > +    _console_control_handler = None
> > +
> >
> >  # Timeout monitor
> >  class _TimeoutMonitor(process.plugins.Monitor):
> > diff -u -r CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py
> fm-CherryPy-3.1.0rc1/
> > cherrypy/_cpmodpy.py
> > --- CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py 2008-05-17
> > 15:34:26.000000000 -0500
> > +++ fm-CherryPy-3.1.0rc1/cherrypy/_cpmodpy.py 2008-06-12
> > 11:34:11.149164400 -0500
> > @@ -97,7 +97,8 @@
> >                              "tools.ignore_headers.headers":
> > ['Range'],
> >                              })
> >
> > -    cherrypy._console_control_handler.unsubscribe()
> > +    if cherrypy._console_control_handler is not None:
> > +        cherrypy._console_control_handler.unsubscribe()
> >      cherrypy.engine.autoreload.unsubscribe()
> >      cherrypy.server.unsubscribe()
>
> Thanks. I'll fix this ASAP as I'm trying to move the
> console_control_handler subscribe call into quickstart anyway...

Done in http://www.cherrypy.org/changeset/1989.


Robert Brewer
fumanchu@...


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "cherrypy-users" group.
To post to this group, send email to cherrypy-users@...
To unsubscribe from this group, send email to cherrypy-users-unsubscribe@...
For more options, visit this group at http://groups.google.com/group/cherrypy-users?hl=en
-~----------~----~----~----~------~----~------~--~---