False positive? [OBL] Method may fail to clean up stream or resource [OBL_UNSATISFIED_OBLIGATION]

[Tim Keith]

Findbugs is reporting [OBL] Method may fail to clean up stream or resource [OBL_UNSATISFIED_OBLIGATION] for this code:

        Reader reader = new InputStreamReader(new FileInputStream(file), UTF8);
        try {
            ...
        } finally {
            reader.close();
        }

Doesn't closing the Reader close the underlying InputStream?

-- Tim

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[Dave Brosius-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

Theoretically the InputStreamReader's constructor could throw an exception after the FileInputStream was created. Thus the finally block is never executed, leaving the FileInputStream open.

 

 

----- Original Message -----

From: tim.keith@...

To: findbugs-discuss@...

Sent: Tuesday, September 30, 2008 7:48 PM

Subject: [FB-Discuss] False positive? [OBL] Method may fail to clean upstream or resource [OBL_UNSATISFIED_OBLIGATION]

Findbugs is reporting [OBL] Method may fail to clean up stream or resource [OBL_UNSATISFIED_OBLIGATION] for this code:

        Reader reader = new InputStreamReader(new FileInputStream(file), UTF8);
        try {
            ...
        } finally {
            reader.close();
        }

Doesn't closing the Reader close the underlying InputStream?

-- Tim

---

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[Noel Grandin-2]

So what is the "findbugs approved" version?

Thanks, Noel.

On Wed, Oct 1, 2008 at 04:38, Dave Brosius <dbrosius@...> wrote:
> Theoretically the InputStreamReader's constructor could throw an exception
> after the FileInputStream was created. Thus the finally block is never
> executed, leaving the FileInputStream open.
>
>
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[Thomas Hawtin]

Noel Grandin wrote:
> So what is the "findbugs approved" version?

This should pass:

         InputStream fileIn = new FileInputStream(file);
         try {
             Reader reader = new InputStreamReader(fileIn, UTF8);
             ...
         } finally {
             fileIn.close();
         }

Of course, if you are writing it often you can write it once with the
"execute around" idiom.

Tom Hawtin
_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss

[Thomas Suckow]

FileInputStream fis = null;
try
{
    fis = new FileInputStream(file);
    Reader reader = null;
    try
    {
        reader = new InputStreamReader(fis, UTF8);
    } finally {
        if( reader != null ) reader.close();
    }
}
finally
{
    if( fis != null) fis.close();
}


Thomas Suckow



On Wed, Oct 1, 2008 at 8:26 AM, Noel Grandin <noelgrandin@...> wrote:

> So what is the "findbugs approved" version?
>
> Thanks, Noel.
>
> On Wed, Oct 1, 2008 at 04:38, Dave Brosius <dbrosius@...> wrote:
>> Theoretically the InputStreamReader's constructor could throw an exception
>> after the FileInputStream was created. Thus the finally block is never
>> executed, leaving the FileInputStream open.
>>
>>
> _______________________________________________
> Findbugs-discuss mailing list
> Findbugs-discuss@...
> https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss
>

_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss