FailureRecorder problems in Gump

[Stefan Bodewig]

Hi all,

we can finally see[1] why the tests fail in Gump (and this is the only
remaining failure on vmgump, BTW)

    [junit] nested build's System.err: /srv/gump/public/workspace/ant/src/etc/testcases/taskdefs/optional/out/FailedTests.java:9: cannot find symbol
    [junit] symbol  : constructor JUnit4TestCaseFacade(java.lang.String)
    [junit] location: class junit.framework.JUnit4TestCaseFacade
    [junit]         suite.addTest(new junit.framework.JUnit4TestCaseFacade("test02"));
    [junit]                       ^
    [junit] /srv/gump/public/workspace/ant/src/etc/testcases/taskdefs/optional/out/FailedTests.java:10: cannot find symbol
    [junit] symbol  : constructor JUnit4TestCaseFacade(java.lang.String)
    [junit] location: class junit.framework.JUnit4TestCaseFacade
    [junit]         suite.addTest(new junit.framework.JUnit4TestCaseFacade("test03"));
    [junit]                       ^
    [junit] /srv/gump/public/workspace/ant/src/etc/testcases/taskdefs/optional/out/FailedTests.java:11: cannot find symbol
    [junit] symbol  : constructor JUnit4TestCaseFacade(java.lang.String)
    [junit] location: class junit.framework.JUnit4TestCaseFacade
    [junit]         suite.addTest(new junit.framework.JUnit4TestCaseFacade("test04"));
    [junit]                       ^
    [junit] /srv/gump/public/workspace/ant/src/etc/testcases/taskdefs/optional/out/FailedTests.java:12: cannot find symbol
    [junit] symbol  : constructor JUnit4TestCaseFacade(java.lang.String)
    [junit] location: class junit.framework.JUnit4TestCaseFacade
    [junit]         suite.addTest(new junit.framework.JUnit4TestCaseFacade("test10"));
    [junit]                       ^
    [junit] 4 errors

Looking at the current CVS HEAD of JUnit[2], I don't see a String-arg
constructor there, so this explains the problem.  The strange thing is
that even the oldest version of JUnit4TestCaseFacade[3] I can find
contains such a constructor.

Any ideas?

Stefan

[1] http://vmgump.apache.org/gump/public/ant/test-ant/gump_work/build_ant_test-ant.html

[2] http://junit.cvs.sourceforge.net/junit/junit/src/main/java/junit/framework/JUnit4TestCaseFacade.java?revision=1.1&view=markup

[3] http://junit.cvs.sourceforge.net/junit/junit/src/junit/framework/JUnit4TestCaseFacade.java?hideattic=0&revision=1.1&view=markup

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Stefan Bodewig]

On Fri, 04 Apr 2008, Stefan Bodewig <bodewig@...> wrote:

> The strange thing is that even the oldest version of
> JUnit4TestCaseFacade[3] I can find contains such a constructor.

http://junit.cvs.sourceforge.net/junit/junit/junit/framework/JUnit4TestCaseFacade.java?hideattic=0&revision=1.2&view=markup
seems to be the version from JUnit 4.0 'till 4.2, doesn't have a
String-arg constructor either.

Since most of us are running Ant's tests against JUnit 3 (at least I
do when testing locally), we've probably not seen the task break on
JUnit4.

The root of the problem probably is that FailureRecorder expects the
Test instance passed into addFailure to be an instance of the class
under test - something that isn't true for JUnit4 wrapped tests in
Ant.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Stefan Bodewig]

On Fri, 04 Apr 2008, Stefan Bodewig <bodewig@...> wrote:

> The root of the problem probably is that FailureRecorder expects the
> Test instance passed into addFailure to be an instance of the class
> under test - something that isn't true for JUnit4 wrapped tests in
> Ant.

it also assumes the class under test has a String-arg constructor
which isn't necessarily true for JUnit3 type of tests either.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...