FFTW

12 Messages Forum Options Options
Alert me of new posts
Permalink
Martyn Shaw-2
FFTW
Reply Threaded More
Print post
Permalink
Hi there

Now that FFTW http://www.fftw.org/faq/section1.html#isfftwfree is GPL,
is anyone out there working on using it in Audacity?

I am thinking about writing something to (generally) convolve one
track with another and thought that FFTW might be useful.  Any input?

I have been reading
http://pcfarina.eng.unipr.it/Public/Papers/134-AES00.PDF
and the things to be convolved may be quite long (let's say up to 10^6
samples for the impulse response). Obviously that shouldn't be done
directly but do you have ideas about how this should be implemented?

TTFN
Martyn

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Brian Cameron
Re: FFTW
Reply Threaded More
Print post
Permalink
Martyn:

I know that the swh-plugins LADSPA plugins use the FFTW code already.

    http://plugin.org.uk/

Brian

> Now that FFTW http://www.fftw.org/faq/section1.html#isfftwfree is GPL,
> is anyone out there working on using it in Audacity?
>
> I am thinking about writing something to (generally) convolve one
> track with another and thought that FFTW might be useful.  Any input?
>
> I have been reading
> http://pcfarina.eng.unipr.it/Public/Papers/134-AES00.PDF
> and the things to be convolved may be quite long (let's say up to 10^6
> samples for the impulse response). Obviously that shouldn't be done
> directly but do you have ideas about how this should be implemented?
>
> TTFN
> Martyn
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Audacity-devel mailing list
> Audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Lars Luthman-3
Re: FFTW
Reply Threaded More
Print post
Permalink

On Wed, 2008-03-19 at 01:21 +0000, Martyn Shaw wrote:

> Hi there
>
> Now that FFTW http://www.fftw.org/faq/section1.html#isfftwfree is GPL,
> is anyone out there working on using it in Audacity?
>
> I am thinking about writing something to (generally) convolve one
> track with another and thought that FFTW might be useful.  Any input?
>
> I have been reading
> http://pcfarina.eng.unipr.it/Public/Papers/134-AES00.PDF
> and the things to be convolved may be quite long (let's say up to 10^6
> samples for the impulse response). Obviously that shouldn't be done
> directly but do you have ideas about how this should be implemented?
You could have a look at the code for Anders Torger's BruteFIR or Fons
Adriaensen's JACE.


--ll


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel

signature.asc (196 bytes) Download Attachment
Markus Meyer
Re: Questions about licensing and media support
Reply Threaded More
Print post
Permalink
Brian,

the topic of GPL compatibility seems to come up every now and then, so
there has been plenty of discussion around this already (just search the
mailing list), but I nevertheless want to answer the questions shortly
below.

Brian Cameron schrieb:
> I notice that audacity supports linking with libmad and libtwolame
> for MP3 and MPEG2 support.  Hoewver, since these are non-royalty free
> this obviously means that no distribution can build audacity with
> this code enabled and distribute it.
It seems that the generally accepted position among the Audacity team is
that MP3 _reading_ seems not to be covered by patents, but MP3 writing
is. This is why we link libmad directly in, but only provide support for
a separate LAME download for MP3 writing. MP2 support (which is NOT the
same as MPEG-2!) is not considered critical when it comes to reading and
writing, so we build it in.

This stance seems to be supported e.g. by the Debian project, which e.g.
ships MP3 decoders and MP2 encoders and decoders, but not MP3 encoders.
A quick Google search e.g. put up this email regarding the subject:

http://archives.mandrivalinux.com/cooker/2007-08/msg00056.php

I know there are different opinions on this issue and even experts seeem
to disagree as to which patents exactly apply to which encoding/decoding
technique, but the above is the position which has been accepted by the
Audacity team and is not likely to change.

> I think it would make sense if audacity had a similar exception clause
> so that distros which have license to ship MP3, MPEG2, or other codec
> support can consider shipping audacity with the support enabled.
>  
It would make sense to change the Audacity license for other reasons,
too (say e.g. for VST support), but to do that we would need permission
from everyone who _ever_ committed a patch to Audacity, which is unlikely.

> I am also wondering if the audacity team has considered integrating
> with GStreamer.  Since GStreamer uses a plugin interface, users
> can easily add additional plugins and they simply work with all
> programs which use GStreamer.  You don't have to rebuild the
> applications themselves.
>  
Support for GStreamer is a good idea, but Audacity is a cross-platform
app and the major user base is still on Windows, so GStreamer support
would not be of much use to most users, nor would it change our
licensing problems.


Markus


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Brian Cameron
Questions about licensing and media support
Reply Threaded More
Print post
Permalink

Audacity Team:

I notice that Audacity is released under the GPL.  The GPL does not
allow people to distribute GPL code that links in any code which
contains any non-royalty free patents.

I notice that audacity supports linking with libmad and libtwolame
for MP3 and MPEG2 support.  Hoewver, since these are non-royalty free
this obviously means that no distribution can build audacity with
this code enabled and distribute it.  This might be useful for
end-users who want to go through the trouble of building audacity
themselves to turn on this support, but not all users would be
likely able to figure out how to do this, and it might not be a
legally viable option for some users.

This also means that even if a distro has license to ship a particular
media codec (such as MP3 or MPEG2), they still would not be able to
distribute support with audacity because this violates the GPL license.
This is discussed in the GStreamer FAQ, for example:

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/faq/html/chapter-legal.html

Note there is no problem to distribute code that links in such IP
with LGPL.  Only with GPL.  So, a GPL program which uses GStreamer
has this issue unless it has an exception clause.  Note that some
GStreamer-based programs have a license exception clause to allow
linking in certain IP for interacting with media.  Examples of
GStreamer-based programs with such a clause include totem and the
Songbird media player from Mozilla.  Here is an example of the
clause from totem:

http://svn.gnome.org/viewvc/totem/trunk/license_change?revision=4301&view=markup

I think it would make sense if audacity had a similar exception clause
so that distros which have license to ship MP3, MPEG2, or other codec
support can consider shipping audacity with the support enabled.
As I said, otherwise, end users have to rebuild audacity by hand to
get this support.  It would be nice if Audacity had such a clause
regardless of whether it used GStreamer or libraries like libmad
directly.

----

I am also wondering if the audacity team has considered integrating
with GStreamer.  Since GStreamer uses a plugin interface, users
can easily add additional plugins and they simply work with all
programs which use GStreamer.  You don't have to rebuild the
applications themselves.

Fluendo is already selling several legal GStreamer plugins from their
webstore, so users have a legal mechanism to add MP3, MPEG2, MPEG4,
WindowsMedia support to their systems.  Currently Fluendo is only
selling decoders but I understand they soon plan to make available
encoders as well.  Also GStreamer supports plugins for libmad and
twolame if these are particularly useful.

I know Audacity uses Portaudio already, but perhaps it could use
GStreamer instead?  Or perhaps it could use both.  It could use
Portaudio for interacting with the soundcard and GStreamer for
converting files between different media types.

This seems a better approach than linking libraries like libmad and
twolame directly into audacity.

Thoughts?

Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Brian Cameron
Re: Questions about licensing and media support
Reply Threaded More
Print post
Permalink

Markus:

> Brian Cameron schrieb:
>> I notice that audacity supports linking with libmad and libtwolame
>> for MP3 and MPEG2 support.  Hoewver, since these are non-royalty free
>> this obviously means that no distribution can build audacity with
>> this code enabled and distribute it.
 >

> It seems that the generally accepted position among the Audacity team is
> that MP3 _reading_ seems not to be covered by patents, but MP3 writing
> is. This is why we link libmad directly in, but only provide support for
> a separate LAME download for MP3 writing. MP2 support (which is NOT the
> same as MPEG-2!) is not considered critical when it comes to reading and
> writing, so we build it in.
>
> This stance seems to be supported e.g. by the Debian project, which e.g.
> ships MP3 decoders and MP2 encoders and decoders, but not MP3 encoders.
> A quick Google search e.g. put up this email regarding the subject:
>
> http://archives.mandrivalinux.com/cooker/2007-08/msg00056.php
>
> I know there are different opinions on this issue and even experts seeem
> to disagree as to which patents exactly apply to which encoding/decoding
> technique, but the above is the position which has been accepted by the
> Audacity team and is not likely to change.

Thank you for explaining this.  I wasn't aware that some distros have
this interpretation.  I'm not a lawyer so I can't meaningfully discuss
this further.  I know that on Solaris we take a more conservative
position and we disable MPEG1 layers1-3 support in all GPL programs,
even though Sun does have license for MPEG1 layers 1-3 decoding in
Solaris.

>> I think it would make sense if audacity had a similar exception clause
>> so that distros which have license to ship MP3, MPEG2, or other codec
>> support can consider shipping audacity with the support enabled.
>>  
> It would make sense to change the Audacity license for other reasons,
> too (say e.g. for VST support), but to do that we would need permission
> from everyone who _ever_ committed a patch to Audacity, which is unlikely.

Typically when modules go through a relicensing process (such as when
it happened in the totem project), it is not necessary for every person
who ever contributed a patch to give permission.  Instead, it is only
necessary for the authors who contributed significant portions of the
code to give permission.  A person who contributed a trivial patch
can't meaningfully claim copyright issues.  And even if they did
raise a problem, rewriting their code should likewise be a trivial
solution to the problem.

If it is impossible to relicense the code, then this is unfortunate
since it basically means that audacity is fundamentally limited in
what it can do.  Most people who want to use professional audio
software want to be able to do things like save files in popular
non-free formats.

>> I am also wondering if the audacity team has considered integrating
>> with GStreamer.  Since GStreamer uses a plugin interface, users
>> can easily add additional plugins and they simply work with all
>> programs which use GStreamer.  You don't have to rebuild the
>> applications themselves.
>>  
> Support for GStreamer is a good idea, but Audacity is a cross-platform
> app and the major user base is still on Windows, so GStreamer support
> would not be of much use to most users, nor would it change our
> licensing problems.

GStreamer also supports Windows, so I'd think you could also use it on
Windows to provide the ability to save files in different formats.

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/manual/html/chapter-win32.html

If you were to integrate with GStreamer, then I would recommend that you
use the gst-launch command line program to convert files into different
formats, rather than linking with GStreamer.  This is slower, but if
you link in GStreamer directly then you would encounter the problem that
distros wouldn't be able to distribute audacity with any GStreamer
plugins that contain IP.

Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Richard Ash (audacity-help)
Re: Questions about licensing and media support
Reply Threaded More
Print post
Permalink
On Wed, 2008-03-19 at 12:56 -0500, Brian Cameron wrote:
> I notice that Audacity is released under the GPL.  The GPL does not
> allow people to distribute GPL code that links in any code which
> contains any non-royalty free patents.
That does depend on the version of the GPL to some extent. Note that
audacity has not yet upgraded to GPL v3 (although it may well do so).

> I notice that audacity supports linking with libmad and libtwolame
> for MP3 and MPEG2 support.  Hoewver, since these are non-royalty free
> this obviously means that no distribution can build audacity with
> this code enabled and distribute it.  This might be useful for
> end-users who want to go through the trouble of building audacity
> themselves to turn on this support, but not all users would be
> likely able to figure out how to do this, and it might not be a
> legally viable option for some users.

> This also means that even if a distro has license to ship a particular
> media codec (such as MP3 or MPEG2), they still would not be able to
> distribute support with audacity because this violates the GPL license.
That only applies if you are in a jurisdiction where the patents apply.
In Europe (for example) there is not held to be any patent on MP3
decoding (because of prior art in the standard), or on MPEG1 layer 2
audio encoding or decoding.

> This seems a better approach than linking libraries like libmad and
> twolame directly into audacity.
Depends on your definition of "better". It might be more flexible if you
are paranoid about potential software patents in a non-free country
(mainly the USA). On the other hand it's non-standard (every other
open-source media application I know of links directly to these
libraries), inefficient, inflexible (because the amount of information
you can get back from a gst-launch command is minimal, e.g. no progress
information) and a pain to configure on the user's system (because they
need loads of different binaries installed and they all need to be able
to find each other. This is a particular issue for Windows
installations).

It's notable that Xine, Mplayer, VLC and (optionally) FFMPEG are all
licensed under the GPL whilst including support for formats that in some
jurisdiction may be patented (this is a statement that can be made about
almost any non-trivial audio and video format, given the way patents
have been granted in some jurisdictions). They are however all based in
Europe (in so far as an open source project developed over the web is
based at all).

Your point that some users won't be able or know how to recompile media
applications with extra libraries is a valid one, however it is one of
the reasons that few users use the commercial Linux distributions for
serious multimedia work, given that none of the non-commercial
distributions have ever seen this as a problem. For the commercial
distributions with active user communities there are considerable
repositories of additional packages available which usually include full
builds of multimedia software.

Richard


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Schwartz-5
Re: Questions about licensing and media support
Reply Threaded More
Print post
Permalink
I seem to recall that the MP3 patent holders allow non-commercial use of
the mp3 technology.

http://mp3licensing.com/help/index.html#1

Also, many companies have licensed the mp3 technology and if your using
it for company business and your company is a license holder I suppose
you're covered.

http://mp3licensing.com/licensees/index.asp

I don't know if Audacity would be considered non-commercial by the MP3
patent holders, but I'm sure they know about it and if there was a
problem they would have said something. Being that Audacity is free. . .


Paul


Brian Cameron wrote:
> Markus:
>
>> Brian Cameron schrieb:
>>> I notice that audacity supports linking with libmad and libtwolame
>>> for MP3 and MPEG2 support.  Hoewver, since these are non-royalty free
>>> this obviously means that no distribution can build audacity with
>>> this code enabled and distribute it.
>  >
>

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Brian Cameron
Re: Questions about licensing and media support
Reply Threaded More
Print post
Permalink
Richard:

> On Wed, 2008-03-19 at 12:56 -0500, Brian Cameron wrote:
>> I notice that Audacity is released under the GPL.  The GPL does not
>> allow people to distribute GPL code that links in any code which
>> contains any non-royalty free patents.
>
 > That does depend on the version of the GPL to some extent. Note that
> audacity has not yet upgraded to GPL v3 (although it may well do so).

My understanding is this is an issue with GPLv2.  I haven't reviewed
GPLv3 well enough to understand the impact there.

>> I notice that audacity supports linking with libmad and libtwolame
>> for MP3 and MPEG2 support.  Hoewver, since these are non-royalty free
>> this obviously means that no distribution can build audacity with
>> this code enabled and distribute it.  This might be useful for
>> end-users who want to go through the trouble of building audacity
>> themselves to turn on this support, but not all users would be
>> likely able to figure out how to do this, and it might not be a
>> legally viable option for some users.
>
>> This also means that even if a distro has license to ship a particular
>> media codec (such as MP3 or MPEG2), they still would not be able to
>> distribute support with audacity because this violates the GPL license.
> That only applies if you are in a jurisdiction where the patents apply.
> In Europe (for example) there is not held to be any patent on MP3
> decoding (because of prior art in the standard), or on MPEG1 layer 2
> audio encoding or decoding.

While this may not apply to all distros, it does apply to distros
which are based in the U.S. or which distribute to the U.S.  This
is probably most major distros, I'd think.  It does include Solaris
at any rate.

>> This seems a better approach than linking libraries like libmad and
>> twolame directly into audacity.
> Depends on your definition of "better". It might be more flexible if you
> are paranoid about potential software patents in a non-free country
> (mainly the USA). On the other hand it's non-standard (every other
> open-source media application I know of links directly to these
> libraries), inefficient, inflexible (because the amount of information
> you can get back from a gst-launch command is minimal, e.g. no progress
> information) and a pain to configure on the user's system (because they
> need loads of different binaries installed and they all need to be able
> to find each other. This is a particular issue for Windows
> installations).

There are many media applications which use interfaces like GStreamer
to interact with different media types.  I think linking against
GStreamer directly is better than using gst-launch, for the reasons you
explain.

The only problem with linking in GStreamer directly is that if you do
not have a license exception which allows distribution with non-free
GStreamer plugins, then you force the distribution to decide whether
to ship audacity or to ship non-free media plugins, or to disable
any potentially controversial media support in audacity.

The only reason I suggested using gst-launch instead of linking with
the GStreamer libraries is because it sounded like you weren't in
a position to put together a reasonable license clause to allow the
usage of non-free GStreamer plugins.  Linking against GStreamer is
less useful if you force the distro between shipping your application
or shipping any non-free plugins they might have license to ship.

If you run gst-launch instead of linking then I believe this avoids
the need for a GPL exception  since your application wouldn't be linking
against GStreamer.

> It's notable that Xine, Mplayer, VLC and (optionally) FFMPEG are all
> licensed under the GPL whilst including support for formats that in some
> jurisdiction may be patented (this is a statement that can be made about
> almost any non-trivial audio and video format, given the way patents
> have been granted in some jurisdictions). They are however all based in
> Europe (in so far as an open source project developed over the web is
> based at all).

I don't believe any major distro ships any of these programs because
these programs all have IP issues.  The FFMPEG and MPlayer community is
very open about the fact that they disregard IP law.

   http://ffmpeg.mplayerhq.hu/legal.html

When you compare audacity to these products, are you suggesting that
the audacity community has a similar attitude?  That it perhaps should
not be used in non-free countries?

Most distros don't ship a DVD player, for example.

> Your point that some users won't be able or know how to recompile media
> applications with extra libraries is a valid one, however it is one of
> the reasons that few users use the commercial Linux distributions for
> serious multimedia work, given that none of the non-commercial
> distributions have ever seen this as a problem. For the commercial
> distributions with active user communities there are considerable
> repositories of additional packages available which usually include full
> builds of multimedia software.

I think GStreamer and Fluendo are working to provide a realistic and
legal approach to providing more rich media on Linux/UNIX/Solaris.  But
you are right that there is a long way to go.

Brian


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Brian Cameron
audacity build issue on Solaris
Reply Threaded More
Print post
Permalink

The new 1.3.5 version of audacity has one compile issue that is fixed
with the attached patch.

Note that TieRadioButton is defined in the header file with "const int
iValue" so the link of audacity complains that it can not find the
function if the C-file does not also define it as "const".

However, defining it as "const" then makes the WrappedRef constructor
function complain with the following error:

"ShuttleGui.cpp", line 1530: Error: Cannot use const int to initialize
WrappedType.

So to address this I copy the iValue into a temporary int variable
called iTemp before calling the WrappedRef constructor with iTemp
instead.  This fixes the compile issue.

Can this patch go upstream?

Brian

--- audacity-src-1.3.5-beta/src/ShuttleGui.cpp-orig 2008-05-12 17:50:26.920076000 -0500
+++ audacity-src-1.3.5-beta/src/ShuttleGui.cpp 2008-05-12 17:53:28.403221000 -0500
@@ -1525,9 +1525,10 @@ void ShuttleGuiBase::StartRadioButtonGro
 /// This function must be within a StartRadioButtonGroup - EndRadioButtonGroup pair.
 wxRadioButton * ShuttleGuiBase::TieRadioButton(
    const wxString &Prompt,
-   int iValue)
+   const int iValue)
 {
-   WrappedType WrappedRef( iValue );
+   int iTemp = iValue;
+   WrappedType WrappedRef( iTemp );
    return TieRadioButton( Prompt, WrappedRef );
 }
 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Martyn Shaw-2
Re: audacity build issue on Solaris
Reply Threaded More
Print post
Permalink
Hi Brian

We are not ignoring you, but a little distracted at the moment with
modular builds.  Please bring this up again in a week or so if nobody
has responded in the positive.

TTFN
Martyn

Brian Cameron wrote:

>
> The new 1.3.5 version of audacity has one compile issue that is fixed
> with the attached patch.
>
> Note that TieRadioButton is defined in the header file with "const int
> iValue" so the link of audacity complains that it can not find the
> function if the C-file does not also define it as "const".
>
> However, defining it as "const" then makes the WrappedRef constructor
> function complain with the following error:
>
> "ShuttleGui.cpp", line 1530: Error: Cannot use const int to initialize
> WrappedType.
>
> So to address this I copy the iValue into a temporary int variable
> called iTemp before calling the WrappedRef constructor with iTemp
> instead.  This fixes the compile issue.
>
> Can this patch go upstream?
>
> Brian
>
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Audacity-devel mailing list
> Audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Martyn Shaw-2
Re: audacity build issue on Solaris
Reply Threaded More
Print post
Permalink
This worked fine for me, so I committed it.

Martyn

Brian Cameron wrote:

>
> The new 1.3.5 version of audacity has one compile issue that is fixed
> with the attached patch.
>
> Note that TieRadioButton is defined in the header file with "const int
> iValue" so the link of audacity complains that it can not find the
> function if the C-file does not also define it as "const".
>
> However, defining it as "const" then makes the WrappedRef constructor
> function complain with the following error:
>
> "ShuttleGui.cpp", line 1530: Error: Cannot use const int to initialize
> WrappedType.
>
> So to address this I copy the iValue into a temporary int variable
> called iTemp before calling the WrappedRef constructor with iTemp
> instead.  This fixes the compile issue.
>
> Can this patch go upstream?
>
> Brian
>
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Audacity-devel mailing list
> Audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel