Nabble - Ext2 - Dev

File System Traces

2007-11-16T11:22:25Z

Hello All,

I'm trying to collect the following information about an application at the file system layer:

Type of request - Read/Write
Sector Number to which the request is directed - to which the request is directed
Time of request

Can anyone pls let me know what changes should I make in which modules to extract this information? Thanks a lot!!

Rgds
SunDevil

Linux 2007 File System & IO Workshop notes & talks

2007-04-10T07:23:47Z

We have some of the material reviewed and posted now from the IO & FS
workshop.

USENIX has posted the talks at:

http://www.usenix.org/events/lsf07/tech/tech.html

A write up of the workshop went out at LWN and invoked a healthy discussion:

http://lwn.net/Articles/226351/

At that LWN article, there is a link to the Linux FS wiki with good notes:

http://linuxfs.pbwiki.com/LSF07-Workshop-Notes

Another summary will go out in the next USENIX ;login edition.

ric

nfs mounting of root file system

2007-01-29T20:17:38Z

hi,

I am using montavista linux kernel 2.6.10 and after nfs mounting it is giving fallowing error.

=> setenv bootargs root=/dev/nfs nfsroot=192.168.178.110:/mnt ip=192.168.178.234
:192.168.178.110:192.168.178.6:255.255.255.0:cashel:eth1:off
=> savee
Saving Environment to Flash...
.
Un-Protected 1 sectors
Erasing Flash...
. done
Erased 1 sectors
Writing to Flash... done
.
Protected 1 sectors
=> printenv
bootdelay=5
baudrate=38400
ethact=FCC2 ETHERNET
serverip=192.168.178.110
ethaddr=00:99:23:44:ad:de
bootcmd=tftpboot 0x1000000 godcome;bootm 0x1000000;
ipaddr=192.168.178.234
stdin=serial
stdout=serial
stderr=serial
bootargs=root=/dev/nfs nfsroot=192.168.178.110:/mnt ip=192.168.178.234:192.168.1
78.110:192.168.178.6:255.255.255.0:cashel:eth1:off

Environment size: 346/262140 bytes
=> run bootcmd
Using FCC2 ETHERNET device
TFTP from server 192.168.178.110; our IP address is 192.168.178.234
Filename 'godcome'.
Load address: 0x1000000
Loading: #################################################################
#################################################################
########################################################
done
Bytes transferred = 948671 (e79bf hex)
## Booting image at 01000000 ...
Image Name: Linux-2.6.10_mvl401-8272ads
Image Type: PowerPC Linux Kernel Image (gzip compressed)
Data Size: 948607 Bytes = 926.4 kB
Load Address: 00000000
Entry Point: 00000000
Verifying Checksum ... OK
Uncompressing Kernel Image ... OK
Linux version 2.6.10_mvl401-8272ads (root@em178110) (gcc version 3.4.3 (MontaVis
ta 3.4.3-25.0.70.0501961 2005-12-18)) #2 Tue Jan 23 16:54:50 IST 2007
Motorola PQ2 ADS PowerPC port
Built 1 zonelists
Kernel command line: root=/dev/nfs nfsroot=192.168.178.110:/mnt ip=192.168.178.2
34:192.168.178.110:192.168.178.6:255.255.255.0:cashel:eth1:off
PID hash table entries: 256 (order: 8, 4096 bytes)
hr_time_init: arch_to_nsec = 83886080, nsec_to_arch = 107374182
Warning: real time clock seems stuck!
Dentry cache hash table entries: 8192 (order: 3, 32768 bytes)
Inode-cache hash table entries: 4096 (order: 2, 16384 bytes)
Memory: 30152k available (1684k kernel code, 468k data, 100k init, 0k highmem)
Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
spawn_desched_task(00000000)
desched cpu_callback 3/00000000
ksoftirqd started up.
desched cpu_callback 2/00000000
desched thread 0 started up.
NET: Registered protocol family 16
Installing knfsd (copyright (C) 1996 okir@monad.swb.de).
Initializing Cryptographic API
Serial: CPM driver $Revision: 0.01 $
ttyCPM0 at MMIO 0xf0011a00 (irq = 40) is a CPM UART
ttyCPM1 at MMIO 0xf0011a60 (irq = 43) is a CPM UART
io scheduler noop registered
io scheduler anticipatory registered
io scheduler deadline registered
io scheduler cfq registered
RAMDISK driver initialized: 16 RAM disks of 8192K size 1024 blocksize
loop: loaded (max 8 devices)
fs_enet.c:v1.0 (Aug 8, 2005)
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 50MHz system bus speed for PIO modes; override with idebus=xx
eth0: FCC ENET Version 0.3, 00:99:23:c4:ad:de
eth1: FCC ENET Version 0.3, 00:99:23:44:ad:de
eth2: FCC ENET Version 0.3, 00:99:23:64:ad:de
NET: Registered protocol family 2
IP: routing cache hash table of 512 buckets, 4Kbytes
TCP: Hash tables configured (established 2048 bind 4096)
NET: Registered protocol family 1
NET: Registered protocol family 17
IP-Config: Complete:
device=eth1, addr=192.168.178.234, mask=255.255.255.0, gw=192.168.178.6,
host=cashel, domain=, nis-domain=(none),
bootserver=192.168.178.110, rootserver=192.168.178.110, rootpath=
Looking up port of RPC 100003/2 on 192.168.178.110
Looking up port of RPC 100005/1 on 192.168.178.110
VFS: Mounted root (nfs filesystem) readonly.
Freeing unused kernel memory: 100k init
Warning: unable to open an initial console.
Kernel panic - not syncing: No init found. Try passing init= option to kernel.
<0>Rebooting in 180 seconds..

is root file system correct? If not, where is the problem?

waiting for early response...

with regards,

Nethra

Online Gambling-Online Black Jack-Black Jack Casino-Online Slots-Slots Online

2007-01-02T00:38:01Z

Donna Mccall wrote:

At Vegas Lounge Casino, we are so sure you are going to love our games that we are giving you up to $888.00 FREE just for trying our Casino. $ 888.00 FREE! Click Here Now! http://airmen.biz.tilleykate.com/v/v22 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Ext2-devel mailing list Ext2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ext2-devel

Online Black Jack

Where to buy viagra
Buy cheap acomplia
Buy cheap generic acomplia
Generic Pharmacy Online
Buy viagra where
Buy cheap viagra where
Buy cheap viagra where
Buy cheap acomplia
cheap generic acomplia
Order cheap acomplia
Order cheap Albenza

Linux 2007 File System & IO Workshop

2006-10-24T05:18:29Z

Just a quick update, the submission process is now open through the
usenix hosted url below. Please note that usenix is just helping us
coordinate the site, no need to belong to usenix to attend.

http://www.usenix.org/events/lsf07/

Full details on the workshops below,

ric

2007 Linux Storage & Filesystem Workshop Call for Papers

2007 Linux Storage & Filesystem Workshop
February 12-13, 2007
San Jose, CA

Sponsored by USENIX, The Advanced Computing Systems Association

Co-located with the 5th USENIX Conference on File and Storage
Technologies (FAST '07), which will take place February 13-16, 2007.

Important Dates
Submissions due: November 24, 2006
Notification of acceptance: December 15, 2006

Workshop Organizers

Program Chair
Ric Wheeler, EMC

Program Committee
Jens Axboe, Oracle
James Bottomley, SteelEye
Valerie Henson, Intel
Andrew Morton, Google
Trond Myklebust, Network Appliance
Brian Pawlowski, Network Appliance
Theodore Ts'o, IBM

Overview
The Linux Storage and Filesystem Workshop is a small, tightly focused,
by-invitation workshop. It is intended to bring together developers and
researchers interested in implementing improvements in the Linux
filesystem and storage subsystems that can find their way into the
mainline kernel and into Linux distributions in the 2-3-year timeframe.
The workshop will be two days, the second day overlapping with FAST '07
tutorials. The workshop will be separated into storage and filesystem
tracks, with a combined plenary session.

Topics and Submissions
Researchers and developers who are interested in attending should submit
a 2-3-paragraph position paper that describes the topic or topics they
would like to discuss during the workshop, and whether such a topic
would suit the filesystem track, the storage track, or the plenary
session. Examples of topics of interest include:

* New trends in storage technologies likely to impact Linux in the
next 3-5 years
* More realistic methods of measuring filesystem and storage
performance
* Proposed improvements to Linux filesystems, including, in particular:
o Handling of storage errors
o Filesystem repair techniques
o Scaling to very large (terabyte) filesystems
* Progress reports on implementation of features discussed at the
Portland Filesystem Summit
* Changes to the interface between the operating system and storage
devices
* Proposed improvements to existing Linux storage subsystems,
particularly with an emphasis on:
o Refactoring common code out of storage subsystems and into
the block layer
o Better robustness and error recovery
o Barrier implementations in the face of TCQ
o Making use of storage capabilities (such as block guard or
non-power-of-2 block sizes) for novel filesystem and application features
* Progress reports on implementation of features discussed at the
Vancouver Storage Summit
* Userspace tools for managing storage systems (including better
presentation to the user via sysfs)
* Storage futures, including:
o New transports
o Changes to existing standards for new storage features
o SAS/SATA convergence
o Do we yet have a use for Object-Based Storage Devices (OSD)?

Submissions must be in plain text and must be submitted via the Web
submission form, which will be available here soon. The submissions are
intended as discussion topic proposals, not refereed papers.

Re: CFP: Linux 2007 File System & IO Workshop

2006-10-17T18:00:08Z

On Tue, 2006-10-17 at 16:25 -0700, Luben Tuikov wrote:
> The only mentioning of "Vancouver Storage summit" in the web content
> therein was, quoting from http://www.usenix.org/events/lsf07/cfp/ :
> ...
> * Progress reports on implementation of features discussed at the
> Vancouver Storage Summit
> ...
> So by "follow on" you mean "progress report" only? Or will this
> event also accept and/or discuss new material?

That was only one of the topics ... there are several other suggestions
in the list you pulled that quote from.

> > Although USENIX is helping us to run it, you don't have to be
> > a USENIX member to submit a position paper. The idea of the position
> > papers is to give the limited number of places (for storage we've got
> > about 20-25 and about the same again for fs) to people who have
> > interesting topics they need to discuss---so if you submit, be prepared
> > to make a presentation of it.
>
> Can I make a presentation of this paper:

You can submit it as your position paper, certainly.

However, the object of this event is not to collect a list of papers to
be presented: it's not a conference with hundreds of attendees (if you
want to present to an audience, you should submit to FAST, which is such
a conference, with which we're co-located). It's a roundtable type
discussion with 20-25 people in the field; plus some plenary sessions to
get input and ideas from people working on the filesystem layer. The
object is to stimulate discussion of important issues (which may be
guided by papers or other materials). The position paper thing is only
to ensure people actually have things they want to discuss (and to allow
the programme committee to pick the attendees if there would be too
many).

James

Re: CFP: Linux 2007 File System & IO Workshop

2006-10-17T17:25:06Z

--- James Bottomley <James.Bottomley@...> wrote:

> On Mon, 2006-10-16 at 20:40 -0400, Ric Wheeler wrote:
> > On February 12-13, we have put together a combined Linux file system &
> > IO 2-day workshop in San Jose, CA. Note that the USENIX File System and
> > Storage Technologies conference follows us in the same venue, so we hope
> > to get some interaction between the two groups as well as leverage the
> > USENIX people to help us get this done.
> >
> > For more information, please see:
> >
> > http://www.usenix.org/events/lsf07/
>
> Just to clarify, this event is a follow on to the Vancouver Storage
> summit.

The only mentioning of "Vancouver Storage summit" in the web content
therein was, quoting from http://www.usenix.org/events/lsf07/cfp/ :
...
* Progress reports on implementation of features discussed at the
Vancouver Storage Summit
...
So by "follow on" you mean "progress report" only? Or will this
event also accept and/or discuss new material?

> Although USENIX is helping us to run it, you don't have to be
> a USENIX member to submit a position paper. The idea of the position
> papers is to give the limited number of places (for storage we've got
> about 20-25 and about the same again for fs) to people who have
> interesting topics they need to discuss---so if you submit, be prepared
> to make a presentation of it.

Can I make a presentation of this paper:

Serial Attached SCSI, An Architecture For Linux
---------------------------------
This paper would start with an overview of SCSI (SCSI-3, that is), its
object oriented nature and why such is the direction of SCSI.

Then an introduction to SAS from this SCSI point of view will be given,
i.e. where it fits in the object oriented model, why and how. There may be
very little SAS technical introduction--a couple of sentences, something
anyone would understand and something sufficient for the latter sections of
the paper.

Then an introduction to SAS as an architecture in a SCSI stack would
follow. A layered, object oriented model will be presented, similar to the
one found in my code.

This will be accompanied with a SCSI "architectural roadmap", the how and
why the architecture.

Then an overview of pure-SCSI drivers would be given (at this point the
paper talks about implementations at each layer of the storage software
stack). Those are implementations which hide the transport layer completely
in their firmware, and present a pure SCSI "picture", a la SAM, to the
OS. How and why they do it and why it is better.

Then the paper would talk about what unifies those implementations, how it
can be done, and why it should be done this way. An introduction to SDI,
SCSI Driver Interface, would be presented.

There would be a section on a SCSI/ATA Translation, SAT, and a SAT
Layer (SATL). Where it fits, how and why. What its interface is and why.

The paper would include pictures and figures as necessary to show layers,
object oriented concepts and the like.
----------------------------------------

The thread is here:
http://marc.theaimsgroup.com/?t=114197580200002&r=1&w=2

Luben

Re: CFP: Linux 2007 File System & IO Workshop

2006-10-17T16:40:34Z

On Mon, 2006-10-16 at 20:40 -0400, Ric Wheeler wrote:
> On February 12-13, we have put together a combined Linux file system &
> IO 2-day workshop in San Jose, CA. Note that the USENIX File System and
> Storage Technologies conference follows us in the same venue, so we hope
> to get some interaction between the two groups as well as leverage the
> USENIX people to help us get this done.
>
> For more information, please see:
>
> http://www.usenix.org/events/lsf07/

Just to clarify, this event is a follow on to the Vancouver Storage
summit. Although USENIX is helping us to run it, you don't have to be
a USENIX member to submit a position paper. The idea of the position
papers is to give the limited number of places (for storage we've got
about 20-25 and about the same again for fs) to people who have
interesting topics they need to discuss---so if you submit, be prepared
to make a presentation of it.

James

CFP: Linux 2007 File System & IO Workshop

2006-10-16T18:40:46Z

On February 12-13, we have put together a combined Linux file system &
IO 2-day workshop in San Jose, CA. Note that the USENIX File System and
Storage Technologies conference follows us in the same venue, so we hope
to get some interaction between the two groups as well as leverage the
USENIX people to help us get this done.

For more information, please see:

http://www.usenix.org/events/lsf07/

Please direct question to the program committee members. If you want to
hit all of us in one go, you can use:

lsf07pc@...

Regards,

ric

*
*

[Ext2-devel] This is the last message to be sent to the ext2-devel mailing list

2006-08-30T15:36:40Z

In the future, traffic should be sent to the linux-ext4@...
mailing list.

If you haven't yet subscribed to the linux-ext4 list, information on how
to subscribe can be found here:

http://vger.kernel.org/majordomo-info.html

Despite the listname of linux-ext4, all topics related to the
development and bug-fixes of the ext2, ext3, and soon-to-be ext4
filesystems will be discussed on the list. We are just calling it
linux-ext4 since the main focus of future development will be on the
ext4 codebase.

- Ted

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

Re: [Ext2-devel] [PATCH] 2/6 Detect overflows in loop counters

2006-08-30T12:18:21Z

Theodore Tso wrote:
> Thanks, applied.
>
> As a reminder, I'd appreciate it if you included ChangeLog entries and
> if you try to avoid lines in C code which overrun 80 columns. I fixed
> those up after I applied your patch.
>
> Regards,
>
> - Ted

I've respun & refactored the remaining patches against the mercurial
repo, and put changelog entries in...

new patchset & series is at

http://people.redhat.com/esandeen/ext3/e2fsprogs-1.39-16T/e2fsprogs-hg-20060830-16T-patches.tar.gz

Thanks,

-Eric

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

Re: [Ext2-devel] [PATCH] 1/6 Avoid overflows in calculations of groups_count

2006-08-30T11:01:16Z

Theodore Tso wrote:

> On Wed, Aug 16, 2006 at 03:50:02PM -0500, Eric Sandeen wrote:
>> When s_blocks_count is at its maximum value (2^32-1), the way
>> groups_count was calculated could overflow; change the arithmetic to
>> avoid this.
>>
>> This is the same calculation that was submitted for the ext3 kernel
>> mount code.
>>
>> Signed-off-by: Eric Sandeen <esandeen@...>
>
>
> I created a new inline function, ext2fs_div_ceil(), which is used to
> replace the problematic calculations. This makes it easier to audit
> the changes, and it turns out it is needed in a lot more places than
> just the groups_count calculation. I've taken hopefully all of the
> other related fixups from your other patch and bundled them into this
> patchset which introduces the use of the div_ceil() function.
>
> - Ted

Looks good, Ted - and I think there's one more:

Index: e2fsprogs-1.39/resize/online.c
===================================================================
--- e2fsprogs-1.39.orig/resize/online.c
+++ e2fsprogs-1.39/resize/online.c
@@ -59,8 +59,7 @@ errcode_t online_resize_fs(ext2_filsys f
exit(1);
}

- r_frac = ((100 * sb->s_r_blocks_count) + sb->s_blocks_count-1) /
- sb->s_blocks_count;
+ r_frac = ext2fs_div_ceil(100 * sb->s_r_blocks_count, sb->s_blocks_count);

retval = ext2fs_read_bitmaps(fs);
if (retval)

-Eric

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

Re: [Ext2-devel] [PATCH] 3/6 Avoid overflow in calculation of resvd blocks in resized fs

2006-08-30T01:10:22Z

On Wed, Aug 16, 2006 at 03:51:50PM -0500, Eric Sandeen wrote:
> The way the new reserved blocks count was calculated at resize time could
> overflow pretty easily.
>
> The new calculation changes the rounding slightly, so fix up the expected
> output for the resize tests as well.

I created a new function, e2p_percent, which won't overflow and which
calculates the percentages as accurately as possible, so it doesn't
need to adjust the expected output of the test suite.

- Ted

# HG changeset patch
# User tytso@...
# Date 1156921693 14400
# Node ID 4a2b0d6c55fc3bea9e5bed4faa82845676f3be2b
# Parent 14e45223b10be14cc318f10b804a3fd535a86ad5
Fix potential 2**32-1 overflow by using e2p_percent()

Add a new functiom, e2p_percent(), which correct calculates the percentage
of a number based on a given percentage, without worrying about overflow
issues. This is used where we calculate the number of reserved blocks using
a percentage of the total number of blocks in a filesystem.

Based on patches from Eric Sandeen, but generalized to use this new function.

Signed-off-by: "Theodore Ts'o" <tytso@...>
Signed-off-by: Eric Sandeen <esandeen@...>

diff -r 14e45223b10b -r 4a2b0d6c55fc lib/e2p/ChangeLog
--- a/lib/e2p/ChangeLog Wed Aug 30 02:16:55 2006 -0400
+++ b/lib/e2p/ChangeLog Wed Aug 30 03:08:13 2006 -0400
@@ -1,3 +1,9 @@ 2006-08-05 Theodore Tso <tytso@...
+2006-08-30 Theodore Tso <tytso@...>
+
+ * percent.c (e2p_percent): Add a new function which accurate and
+ without risk of overflow calculates a percentage of a base
+ number.
+
2006-08-05 Theodore Tso <tytso@...>

* pf.c: Add support for EXT4_EXTENTS_FL flag.
diff -r 14e45223b10b -r 4a2b0d6c55fc lib/e2p/Makefile.in
--- a/lib/e2p/Makefile.in Wed Aug 30 02:16:55 2006 -0400
+++ b/lib/e2p/Makefile.in Wed Aug 30 03:08:13 2006 -0400
@@ -19,7 +19,7 @@ OBJS= feature.o fgetflags.o fsetflags.o
OBJS= feature.o fgetflags.o fsetflags.o fgetversion.o fsetversion.o \
getflags.o getversion.o hashstr.o iod.o ls.o mntopts.o \
parse_num.o pe.o pf.o ps.o setflags.o setversion.o uuid.o \
- ostype.o
+ ostype.o percent.o

SRCS= $(srcdir)/feature.c $(srcdir)/fgetflags.c \
$(srcdir)/fsetflags.c $(srcdir)/fgetversion.c \
@@ -28,7 +28,7 @@ SRCS= $(srcdir)/feature.c $(srcdir)/fge
$(srcdir)/ls.c $(srcdir)/mntopts.c $(srcdir)/parse_num.c \
$(srcdir)/pe.c $(srcdir)/pf.c $(srcdir)/ps.c \
$(srcdir)/setflags.c $(srcdir)/setversion.c $(srcdir)/uuid.c \
- $(srcdir)/ostype.c
+ $(srcdir)/ostype.c $(srcdir)/percent.o
HFILES= e2p.h

LIBRARY= libe2p
diff -r 14e45223b10b -r 4a2b0d6c55fc lib/e2p/e2p.h
--- a/lib/e2p/e2p.h Wed Aug 30 02:16:55 2006 -0400
+++ b/lib/e2p/e2p.h Wed Aug 30 03:08:13 2006 -0400
@@ -50,3 +50,5 @@ unsigned long parse_num_blocks(const cha

char *e2p_os2string(int os_type);
int e2p_string2os(char *str);
+
+unsigned int e2p_percent(int percent, unsigned int base);
diff -r 14e45223b10b -r 4a2b0d6c55fc lib/e2p/percent.c
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/lib/e2p/percent.c Wed Aug 30 03:08:13 2006 -0400
@@ -0,0 +1,62 @@
+/*
+ * percent.c - Take percentage of a number
+ *
+ * Copyright (C) 2006 Theodore Ts'o <tytso@...>
+ *
+ * This file can be redistributed under the terms of the GNU Library General
+ * Public License
+ */
+
+#include "e2p.h"
+
+#include <stdlib.h>
+
+/*
+ * We work really hard to calculate this accurately, while avoiding
+ * an overflow. "Is there a hyphen in anal-retentive?" :-)
+ */
+unsigned int e2p_percent(int percent, unsigned int base)
+{
+ unsigned int mask = ~((1 << (sizeof(unsigned int) - 1) * 8) - 1);
+
+ if (100 % percent == 0)
+ return base / (100 / percent);
+ if (mask & base)
+ return (base / 100) * percent;
+ return base * percent / 100;
+}
+
+#ifdef DEBUG
+#include <unistd.h>
+#include <stdio.h>
+
+main(int argc, char **argv)
+{
+ unsigned int base;
+ int percent;
+ char *p;
+ int log_block_size = 0;
+
+ if (argc != 3) {
+ fprintf(stderr, "Usage: %s percent base\n", argv[0]);
+ exit(1);
+ }
+
+ percent = strtoul(argv[1], &p, 0);
+ if (p[0] && p[1]) {
+ fprintf(stderr, "Bad percent: %s\n", argv[1]);
+ exit(1);
+ }
+
+ base = strtoul(argv[2], &p, 0);
+ if (p[0] && p[1]) {
+ fprintf(stderr, "Bad base: %s\n", argv[2]);
+ exit(1);
+ }
+
+ printf("%d percent of %u is %u.\n", percent, base,
+ e2p_percent(percent, base));
+
+ exit(0);
+}
+#endif
diff -r 14e45223b10b -r 4a2b0d6c55fc misc/ChangeLog
--- a/misc/ChangeLog Wed Aug 30 02:16:55 2006 -0400
+++ b/misc/ChangeLog Wed Aug 30 03:08:13 2006 -0400
@@ -1,4 +1,8 @@ 2006-08-30 Theodore Tso <tytso@...
2006-08-30 Theodore Tso <tytso@...>
+
+ * tune2fs.c (main), mke2fs.c (PRS): Use e2p_percent to properly
+ calculate the number of reserved blocks without worrying
+ about overflow.

* Makefile.in (resize2fs): Remove unused (and bogus) resize2fs
rule, which shouldn't be in misc/Makefile.in
diff -r 14e45223b10b -r 4a2b0d6c55fc misc/mke2fs.c
--- a/misc/mke2fs.c Wed Aug 30 02:16:55 2006 -0400
+++ b/misc/mke2fs.c Wed Aug 30 03:08:13 2006 -0400
@@ -1447,8 +1447,8 @@ static void PRS(int argc, char *argv[])
/*
* Calculate number of blocks to reserve
*/
- fs_param.s_r_blocks_count = (fs_param.s_blocks_count * reserved_ratio)
- / 100;
+ fs_param.s_r_blocks_count = e2p_percent(reserved_ratio,
+ fs_param.s_blocks_count);
}

int main (int argc, char *argv[])
diff -r 14e45223b10b -r 4a2b0d6c55fc misc/tune2fs.c
--- a/misc/tune2fs.c Wed Aug 30 02:16:55 2006 -0400
+++ b/misc/tune2fs.c Wed Aug 30 03:08:13 2006 -0400
@@ -823,7 +823,8 @@ int main (int argc, char ** argv)
printf (_("Setting interval between checks to %lu seconds\n"), interval);
}
if (m_flag) {
- sb->s_r_blocks_count = sb->s_blocks_count * reserved_ratio /100;
+ sb->s_r_blocks_count = e2p_percent(reserved_ratio,
+ sb->s_blocks_count);
ext2fs_mark_super_dirty(fs);
printf (_("Setting reserved blocks percentage to %g%% (%u blocks)\n"),
reserved_ratio, sb->s_r_blocks_count);
diff -r 14e45223b10b -r 4a2b0d6c55fc resize/ChangeLog
--- a/resize/ChangeLog Wed Aug 30 02:16:55 2006 -0400
+++ b/resize/ChangeLog Wed Aug 30 03:08:13 2006 -0400
@@ -1,4 +1,8 @@ 2006-08-30 Theodore Tso <tytso@...
2006-08-30 Theodore Tso <tytso@...>
+
+ * resize2fs.c (adjust_fs_info), online.c (online_resize_fs): Use
+ e2p_percent to properly calculate the number of reserved
+ blocks without worrying about overflow.

* resize2fs.c (ext2fs_calculate_summary_stats): Fix potential
overflow problems when the number of blocks is close to
diff -r 14e45223b10b -r 4a2b0d6c55fc resize/online.c
--- a/resize/online.c Wed Aug 30 02:16:55 2006 -0400
+++ b/resize/online.c Wed Aug 30 03:08:13 2006 -0400
@@ -107,7 +107,8 @@ errcode_t online_resize_fs(ext2_filsys f
sb->s_first_data_block -
(i * sb->s_blocks_per_group);
}
- input.reserved_blocks = input.blocks_count * r_frac / 100;
+ input.reserved_blocks = e2p_percent(r_frac,
+ input.blocks_count);

#if 0
printf("new block bitmap is at 0x%04x\n", input.block_bitmap);
diff -r 14e45223b10b -r 4a2b0d6c55fc resize/resize2fs.c
--- a/resize/resize2fs.c Wed Aug 30 02:16:55 2006 -0400
+++ b/resize/resize2fs.c Wed Aug 30 03:08:13 2006 -0400
@@ -245,8 +245,8 @@ retry:
*/
blk = old_fs->super->s_r_blocks_count * 100 /
old_fs->super->s_blocks_count;
- fs->super->s_r_blocks_count = ((fs->super->s_blocks_count * blk)
- / 100);
+ fs->super->s_r_blocks_count = e2p_percent(blk,
+ fs->super->s_blocks_count);

/*
* Adjust the bitmaps for size

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

Re: [Ext2-devel] [PATCH] 2/6 Detect overflows in loop counters

2006-08-30T00:18:25Z

Thanks, applied.

As a reminder, I'd appreciate it if you included ChangeLog entries and
if you try to avoid lines in C code which overrun 80 columns. I fixed
those up after I applied your patch.

Regards,

- Ted

# HG changeset patch
# User tytso@...
# Date 1156918615 14400
# Node ID 14e45223b10be14cc318f10b804a3fd535a86ad5
# Parent d609388faa895de79ff143e53f8ed04557048c42
Detect overflows in loop counters

For loops such as:

for (i=1; i <= fs->super->s_blocks_count; i++) {
<do_stuff>
}

if i is an int and s_blocks_count is (2^32-1), the condition is never false.
Change these loops to:

for (i=1; i <= fs->super->s_blocks_count && i > 0; i++) {
<do_stuff>
}

to stop the loop when we overflow i

Signed-off-by: Eric Sandeen <esandeen@...>
Signed-off-by: "Theodore Ts'o" <tytso@...>

diff -r d609388faa89 -r 14e45223b10b e2fsck/ChangeLog
--- a/e2fsck/ChangeLog Wed Aug 30 02:06:41 2006 -0400
+++ b/e2fsck/ChangeLog Wed Aug 30 02:16:55 2006 -0400
@@ -1,3 +1,9 @@ 2006-08-29 Theodore Tso <tytso@...
+2006-08-30 Theodore Tso <tytso@...>
+
+ * pass5.c (check_inode_bitmaps, check_inode_end, check_block_end):
+ * pass4.c (e2fsck_pass4): Fix potential overflow problems when the
+ number of blocks is close to 2**31.
+
2006-08-29 Theodore Tso <tytso@...>

* super.c (release_inode_blocks): Fix silly spelling error.
diff -r d609388faa89 -r 14e45223b10b e2fsck/pass4.c
--- a/e2fsck/pass4.c Wed Aug 30 02:06:41 2006 -0400
+++ b/e2fsck/pass4.c Wed Aug 30 02:16:55 2006 -0400
@@ -110,8 +110,9 @@ void e2fsck_pass4(e2fsck_t ctx)
if (ctx->progress)
if ((ctx->progress)(ctx, 4, 0, maxgroup))
return;
-
- for (i=1; i <= fs->super->s_inodes_count; i++) {
+
+ /* Protect loop from wrap-around if s_inodes_count maxed */
+ for (i=1; i <= fs->super->s_inodes_count && i > 0; i++) {
if (ctx->flags & E2F_FLAG_SIGNAL_MASK)
return;
if ((i % fs->super->s_inodes_per_group) == 0) {
diff -r d609388faa89 -r 14e45223b10b e2fsck/pass5.c
--- a/e2fsck/pass5.c Wed Aug 30 02:06:41 2006 -0400
+++ b/e2fsck/pass5.c Wed Aug 30 02:16:55 2006 -0400
@@ -370,7 +370,8 @@ redo_counts:
EXT2_BG_INODE_UNINIT))
skip_group++;

- for (i = 1; i <= fs->super->s_inodes_count; i++) {
+ /* Protect loop from wrap-around if inodes_count is maxed */
+ for (i = 1; i <= fs->super->s_inodes_count && i > 0; i++) {
actual = ext2fs_fast_test_inode_bitmap(ctx->inode_used_map, i);
if (skip_group)
bitmap = 0;
@@ -528,8 +529,9 @@ static void check_inode_end(e2fsck_t ctx
}
if (save_inodes_count == end)
return;
-
- for (i = save_inodes_count + 1; i <= end; i++) {
+
+ /* protect loop from wrap-around if end is maxed */
+ for (i = save_inodes_count + 1; i <= end && i > save_inodes_count; i++) {
if (!ext2fs_test_inode_bitmap(fs->inode_map, i)) {
if (fix_problem(ctx, PR_5_INODE_BMAP_PADDING, &pctx)) {
for (i = save_inodes_count + 1; i <= end; i++)
@@ -572,8 +574,9 @@ static void check_block_end(e2fsck_t ctx
}
if (save_blocks_count == end)
return;
-
- for (i = save_blocks_count + 1; i <= end; i++) {
+
+ /* Protect loop from wrap-around if end is maxed */
+ for (i = save_blocks_count + 1; i <= end && i > save_blocks_count; i++) {
if (!ext2fs_test_block_bitmap(fs->block_map, i)) {
if (fix_problem(ctx, PR_5_BLOCK_BMAP_PADDING, &pctx)) {
for (i = save_blocks_count + 1; i <= end; i++)
diff -r d609388faa89 -r 14e45223b10b lib/ext2fs/ChangeLog
--- a/lib/ext2fs/ChangeLog Wed Aug 30 02:06:41 2006 -0400
+++ b/lib/ext2fs/ChangeLog Wed Aug 30 02:16:55 2006 -0400
@@ -1,4 +1,7 @@ 2006-08-30 Theodore Tso <tytso@...
2006-08-30 Theodore Tso <tytso@...>
+
+ * bitmaps.c (ext2fs_set_bitmap_padding): Fix potential overflow
+ problems when the number of blocks is close to 2**31.

* ext2fs.h (ext2fs_div_ceil): Add new function which safely
calculates an integer division where the result is always
diff -r d609388faa89 -r 14e45223b10b lib/ext2fs/bitmaps.c
--- a/lib/ext2fs/bitmaps.c Wed Aug 30 02:06:41 2006 -0400
+++ b/lib/ext2fs/bitmaps.c Wed Aug 30 02:16:55 2006 -0400
@@ -102,7 +102,10 @@ void ext2fs_set_bitmap_padding(ext2fs_ge
{
__u32 i, j;

- for (i=map->end+1, j = i - map->start; i <= map->real_end; i++, j++)
+ /* Protect loop from wrap-around if map->real_end is maxed */
+ for (i=map->end+1, j = i - map->start;
+ i <= map->real_end && i > map->end;
+ i++, j++)
ext2fs_set_bit(j, map->bitmap);

return;
diff -r d609388faa89 -r 14e45223b10b resize/ChangeLog
--- a/resize/ChangeLog Wed Aug 30 02:06:41 2006 -0400
+++ b/resize/ChangeLog Wed Aug 30 02:16:55 2006 -0400
@@ -1,4 +1,8 @@ 2006-08-30 Theodore Tso <tytso@...
2006-08-30 Theodore Tso <tytso@...>
+
+ * resize2fs.c (ext2fs_calculate_summary_stats): Fix potential
+ overflow problems when the number of blocks is close to
+ 2**31.

* resize2fs.c (adjust_fs_info): Use ext2fs_div_ceil() instead of a
using an open-coded expression which was subject to
diff -r d609388faa89 -r 14e45223b10b resize/resize2fs.c
--- a/resize/resize2fs.c Wed Aug 30 02:06:41 2006 -0400
+++ b/resize/resize2fs.c Wed Aug 30 02:16:55 2006 -0400
@@ -1582,7 +1582,9 @@ static errcode_t ext2fs_calculate_summar
total_free = 0;
count = 0;
group = 0;
- for (ino = 1; ino <= fs->super->s_inodes_count; ino++) {
+
+ /* Protect loop from wrap-around if s_inodes_count maxed */
+ for (ino = 1; ino <= fs->super->s_inodes_count && ino > 0; ino++) {
if (!ext2fs_fast_test_inode_bitmap(fs->inode_map, ino)) {
group_free++;
total_free++;

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

Re: [Ext2-devel] [PATCH] 1/6 Avoid overflows in calculations of groups_count

2006-08-30T00:01:29Z

On Wed, Aug 16, 2006 at 03:50:02PM -0500, Eric Sandeen wrote:
> When s_blocks_count is at its maximum value (2^32-1), the way
> groups_count was calculated could overflow; change the arithmetic to
> avoid this.
>
> This is the same calculation that was submitted for the ext3 kernel
> mount code.
>
> Signed-off-by: Eric Sandeen <esandeen@...>

I created a new inline function, ext2fs_div_ceil(), which is used to
replace the problematic calculations. This makes it easier to audit
the changes, and it turns out it is needed in a lot more places than
just the groups_count calculation. I've taken hopefully all of the
other related fixups from your other patch and bundled them into this
patchset which introduces the use of the div_ceil() function.

- Ted

# HG changeset patch
# User tytso@...
# Date 1156917420 14400
# Node ID 59f8a8974d914231642239f176284d92dce0678d
# Parent c76ddbe4519a571de3868c2888d8bb99a559046f
Fix potential 2**32-1 overflow problems by ext2fs_div_ceil()

Add a new function, ext2fs_div_ceil(), which correctly calculates a division
of two unsigned integer where the result is always rounded up the next
largest integer. This is used everywhere where we might have
previously caused an overflow when the number of blocks
or inodes is too close to 2**32-1.

Based on patches from Eric Sandeen, but generalized to use this new function

Signed-off-by: "Theodore Ts'o" <tytso@...>
Signed-off-by: Eric Sandeen <esandeen@...>

diff -r c76ddbe4519a -r 59f8a8974d91 ext2ed/ChangeLog
--- a/ext2ed/ChangeLog Tue Aug 29 17:12:18 2006 -0400
+++ b/ext2ed/ChangeLog Wed Aug 30 01:57:00 2006 -0400
@@ -1,3 +1,8 @@ 2006-06-30 Theodore Ts'o <tytso@...
+2006-08-30 Theodore Tso <tytso@...>
+
+ * init.c (div_ceil, set_file_system_info): Fix potential overflow
+ for really big filesystems.
+
2006-06-30 Theodore Ts'o <tytso@...>

* Release of E2fsprogs 1.38
diff -r c76ddbe4519a -r 59f8a8974d91 ext2ed/init.c
--- a/ext2ed/init.c Tue Aug 29 17:12:18 2006 -0400
+++ b/ext2ed/init.c Wed Aug 30 01:57:00 2006 -0400
@@ -370,6 +370,13 @@ void add_user_command (struct struct_com
ptr->callback [num]=callback;
}

+static unsigned int div_ceil(unsigned int a, unsigned int b)
+{
+ if (!a)
+ return 0;
+ return ((a - 1) / b) + 1;
+}
+
int set_file_system_info (void)

{
@@ -415,8 +422,8 @@ int set_file_system_info (void)
file_system_info.first_group_desc_offset=2*EXT2_MIN_BLOCK_SIZE;
else
file_system_info.first_group_desc_offset=file_system_info.block_size;
- file_system_info.groups_count=( sb->s_blocks_count-sb->s_first_data_block+sb->s_blocks_per_group-1) /
- sb->s_blocks_per_group;
+ file_system_info.groups_count = div_ceil(sb->s_blocks_count,
+ sb->s_blocks_per_group);

file_system_info.inodes_per_block=file_system_info.block_size/sizeof (struct ext2_inode);
file_system_info.blocks_per_group=sb->s_inodes_per_group/file_system_info.inodes_per_block;
diff -r c76ddbe4519a -r 59f8a8974d91 lib/ext2fs/ChangeLog
--- a/lib/ext2fs/ChangeLog Tue Aug 29 17:12:18 2006 -0400
+++ b/lib/ext2fs/ChangeLog Wed Aug 30 01:57:00 2006 -0400
@@ -1,3 +1,14 @@ 2006-08-06 Andreas Dilger <adilger@clus
+2006-08-30 Theodore Tso <tytso@...>
+
+ * ext2fs.h (ext2fs_div_ceil): Add new function which safely
+ calculates an integer division where the result is always
+ rounded up while avoiding overflow errors.
+
+ * initialize.c (calc_reserved_gdt_blocks, ext2fs_initialize):
+ * openfs.c (ext2fs_open2): Use ext2fs_div_ceil() instead of a
+ using an open-coded expression which was subject to
+ overflows.
+
2006-08-06 Andreas Dilger <adilger@...>

* bitops.h (ext2fs_cpu_to_le32, ext2fs_le64_to_cpu,
diff -r c76ddbe4519a -r 59f8a8974d91 lib/ext2fs/ext2fs.h
--- a/lib/ext2fs/ext2fs.h Tue Aug 29 17:12:18 2006 -0400
+++ b/lib/ext2fs/ext2fs.h Wed Aug 30 01:57:00 2006 -0400
@@ -965,6 +965,7 @@ extern int ext2fs_group_of_ino(ext2_fils
extern int ext2fs_group_of_ino(ext2_filsys fs, ext2_ino_t ino);
extern blk_t ext2fs_inode_data_blocks(ext2_filsys fs,
struct ext2_inode *inode);
+extern unsigned int ext2fs_div_ceil(unsigned int a, unsigned int b);

/*
* The actual inlined functions definitions themselves...
@@ -1132,6 +1133,16 @@ _INLINE_ blk_t ext2fs_inode_data_blocks(
return inode->i_blocks -
(inode->i_file_acl ? fs->blocksize >> 9 : 0);
}
+
+/*
+ * This is an efficient, overflow safe way of calculating ceil((1.0 * a) / b)
+ */
+_INLINE_ unsigned int ext2fs_div_ceil(unsigned int a, unsigned int b)
+{
+ if (!a)
+ return 0;
+ return ((a - 1) / b) + 1;
+}
#undef _INLINE_
#endif

diff -r c76ddbe4519a -r 59f8a8974d91 lib/ext2fs/initialize.c
--- a/lib/ext2fs/initialize.c Tue Aug 29 17:12:18 2006 -0400
+++ b/lib/ext2fs/initialize.c Wed Aug 30 01:57:00 2006 -0400
@@ -77,8 +77,8 @@ static unsigned int calc_reserved_gdt_bl
*/
if (sb->s_blocks_count < max_blocks / 1024)
max_blocks = sb->s_blocks_count * 1024;
- rsv_groups = (max_blocks - sb->s_first_data_block + bpg - 1) / bpg;
- rsv_gdb = (rsv_groups + gdpb - 1) / gdpb - fs->desc_blocks;
+ rsv_groups = ext2fs_div_ceil(max_blocks - sb->s_first_data_block, bpg);
+ rsv_gdb = ext2fs_div_ceil(rsv_groups, gdpb) - fs->desc_blocks;
if (rsv_gdb > EXT2_ADDR_PER_BLOCK(sb))
rsv_gdb = EXT2_ADDR_PER_BLOCK(sb);
#ifdef RES_GDT_DEBUG
@@ -205,17 +205,15 @@ errcode_t ext2fs_initialize(const char *
}

retry:
- fs->group_desc_count = (super->s_blocks_count -
- super->s_first_data_block +
- EXT2_BLOCKS_PER_GROUP(super) - 1)
- / EXT2_BLOCKS_PER_GROUP(super);
+ fs->group_desc_count = ext2fs_div_ceil(super->s_blocks_count -
+ super->s_first_data_block,
+ EXT2_BLOCKS_PER_GROUP(super));
if (fs->group_desc_count == 0) {
retval = EXT2_ET_TOOSMALL;
goto cleanup;
}
- fs->desc_blocks = (fs->group_desc_count +
- EXT2_DESC_PER_BLOCK(super) - 1)
- / EXT2_DESC_PER_BLOCK(super);
+ fs->desc_blocks = ext2fs_div_ceil(fs->group_desc_count,
+ EXT2_DESC_PER_BLOCK(super));

i = fs->blocksize >= 4096 ? 1 : 4096 / fs->blocksize;
set_field(s_inodes_count, super->s_blocks_count / i);
@@ -233,8 +231,7 @@ retry:
* should be. But make sure that we don't allocate more than
* one bitmap's worth of inodes each group.
*/
- ipg = (super->s_inodes_count + fs->group_desc_count - 1) /
- fs->group_desc_count;
+ ipg = ext2fs_div_ceil(super->s_inodes_count, fs->group_desc_count);
if (ipg > fs->blocksize * 8) {
if (super->s_blocks_per_group >= 256) {
/* Try again with slightly different parameters */
diff -r c76ddbe4519a -r 59f8a8974d91 lib/ext2fs/openfs.c
--- a/lib/ext2fs/openfs.c Tue Aug 29 17:12:18 2006 -0400
+++ b/lib/ext2fs/openfs.c Wed Aug 30 01:57:00 2006 -0400
@@ -258,12 +258,11 @@ errcode_t ext2fs_open2(const char *name,
retval = EXT2_ET_CORRUPT_SUPERBLOCK;
goto cleanup;
}
- fs->group_desc_count = (fs->super->s_blocks_count -
- fs->super->s_first_data_block +
- blocks_per_group - 1) / blocks_per_group;
- fs->desc_blocks = (fs->group_desc_count +
- EXT2_DESC_PER_BLOCK(fs->super) - 1)
- / EXT2_DESC_PER_BLOCK(fs->super);
+ fs->group_desc_count = ext2fs_div_ceil(fs->super->s_blocks_count -
+ fs->super->s_first_data_block,
+ blocks_per_group);
+ fs->desc_blocks = ext2fs_div_ceil(fs->group_desc_count,
+ EXT2_DESC_PER_BLOCK(fs->super));
retval = ext2fs_get_mem(fs->desc_blocks * fs->blocksize,
&fs->group_desc);
if (retval)
diff -r c76ddbe4519a -r 59f8a8974d91 misc/ChangeLog
--- a/misc/ChangeLog Tue Aug 29 17:12:18 2006 -0400
+++ b/misc/ChangeLog Wed Aug 30 01:57:00 2006 -0400
@@ -1,3 +1,12 @@ 2006-08-06 Theodore Tso <tytso@...
+2006-08-30 Theodore Tso <tytso@...>
+
+ * mke2fs.c (parse_extended_opts): Use ext2fs_div_ceil() instead of
+ a using an open-coded expression which was subject to
+ overflows.
+
+ * filefrag.c (div_ceil, frag_report): Fix potential overflow for
+ really big filesystems.
+
2006-08-06 Theodore Tso <tytso@...>

* findsuper.c (main): Improve findsuper program by printing the
diff -r c76ddbe4519a -r 59f8a8974d91 misc/filefrag.c
--- a/misc/filefrag.c Tue Aug 29 17:12:18 2006 -0400
+++ b/misc/filefrag.c Wed Aug 30 01:57:00 2006 -0400
@@ -47,6 +47,13 @@ int verbose = 0;
#define EXT4_EXTENTS_FL 0x00080000 /* Inode uses extents */
#define EXT3_IOC_GETFLAGS _IOR('f', 1, long)

+static unsigned int div_ceil(unsigned int a, unsigned int b)
+{
+ if (!a)
+ return 0;
+ return ((a - 1) / b) + 1;
+}
+
static unsigned long get_bmap(int fd, unsigned long block)
{
int ret;
@@ -105,7 +112,7 @@ static void frag_report(const char *file
if (verbose) {
printf("Filesystem type is: %x\n", fsinfo.f_type);
}
- cylgroups = (fsinfo.f_blocks + fsinfo.f_bsize*8-1) / fsinfo.f_bsize*8;
+ cylgroups = div_ceil(fsinfo.f_blocks, fsinfo.f_bsize*8);
if (verbose) {
printf("Filesystem cylinder groups is approximately %ld\n",
cylgroups);
diff -r c76ddbe4519a -r 59f8a8974d91 misc/mke2fs.c
--- a/misc/mke2fs.c Tue Aug 29 17:12:18 2006 -0400
+++ b/misc/mke2fs.c Wed Aug 30 01:57:00 2006 -0400
@@ -820,12 +820,12 @@ static void parse_extended_opts(struct e
if (!bpg)
bpg = blocksize * 8;
gdpb = blocksize / sizeof(struct ext2_group_desc);
- group_desc_count = (param->s_blocks_count +
- bpg - 1) / bpg;
+ group_desc_count =
+ ext2fs_div_ceil(param->s_blocks_count, bpg);
desc_blocks = (group_desc_count +
gdpb - 1) / gdpb;
- rsv_groups = (resize + bpg - 1) / bpg;
- rsv_gdb = (rsv_groups + gdpb - 1) / gdpb -
+ rsv_groups = ext2fs_div_ceil(resize, bpg);
+ rsv_gdb = ext2fs_div_ceil(rsv_groups, gdpb) -
desc_blocks;
if (rsv_gdb > (int) EXT2_ADDR_PER_BLOCK(param))
rsv_gdb = EXT2_ADDR_PER_BLOCK(param);
diff -r c76ddbe4519a -r 59f8a8974d91 resize/ChangeLog
--- a/resize/ChangeLog Tue Aug 29 17:12:18 2006 -0400
+++ b/resize/ChangeLog Wed Aug 30 01:57:00 2006 -0400
@@ -1,3 +1,9 @@ 2006-05-22 Theodore Tso <tytso@...
+2006-08-30 Theodore Tso <tytso@...>
+
+ * resize2fs.c (adjust_fs_info): Use ext2fs_div_ceil() instead of a
+ using an open-coded expression which was subject to
+ overflows.
+
2006-05-22 Theodore Tso <tytso@...>

* resize2fs.8.in: Fixed spelling mistake (Addresses Debian Bug:
diff -r c76ddbe4519a -r 59f8a8974d91 resize/resize2fs.c
--- a/resize/resize2fs.c Tue Aug 29 17:12:18 2006 -0400
+++ b/resize/resize2fs.c Wed Aug 30 01:57:00 2006 -0400
@@ -190,15 +190,13 @@ errcode_t adjust_fs_info(ext2_filsys fs,
fs->super->s_blocks_count = new_size;

retry:
- fs->group_desc_count = (fs->super->s_blocks_count -
- fs->super->s_first_data_block +
- EXT2_BLOCKS_PER_GROUP(fs->super) - 1)
- / EXT2_BLOCKS_PER_GROUP(fs->super);
+ fs->group_desc_count = ext2fs_div_ceil(fs->super->s_blocks_count -
+ fs->super->s_first_data_block,
+ EXT2_BLOCKS_PER_GROUP(fs->super));
if (fs->group_desc_count == 0)
return EXT2_ET_TOOSMALL;
- fs->desc_blocks = (fs->group_desc_count +
- EXT2_DESC_PER_BLOCK(fs->super) - 1)
- / EXT2_DESC_PER_BLOCK(fs->super);
+ fs->desc_blocks = ext2fs_div_ceil(fs->group_desc_count,
+ EXT2_DESC_PER_BLOCK(fs->super));

/*
* Overhead is the number of bookkeeping blocks per group. It

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

fernandameireles@dsnet.com.br te enviou um cartão do Postcar

2006-08-29T22:05:18Z

Olá !

Surpresa!
Você acaba de receber um Postcards de fernandameireles@....

Clique aqui para visualizar seu cartão

Se não funcionar, acesse:
http://www.postcards.com.br/index.php?step=pickup
copie e cole o código abaixo no campo Ver Cartão:

fc7552521

Seu cartão estará disponível por 15 dias.

Abraços,
fernandameireles@...

Para enviar um Postcards gratuitamente, visite o site: www.postcards.com.br

Este e-mail foi enviado utilizando a tecnologia dos servidores da WelterServer

Esta é uma mensagem automática. Por favor, não responda!

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

[Ext2-devel] holistic

2006-08-29T17:48:16Z

And theydont even leave the station from the same place.

I found myself on a CROSS-TOWN BUS, wailed Joan disgustedly. Well, shes got it for you now, said I, and explained.

While Across the Unknown was actually in press, I added one short chapterentitled I Bear Witness.

One, less normallyprofessional than the rest, let himself go.

With them, and Margaret, and another psychic, Mrs. I was visiting Darby and her over a long weekend, andso was present to hear her plaint. So much so that I have never in my life been sofilled with pure happiness. The point is this, we were told, Joan is selective. The loss was more than that of personal companionship, close andwarm as that had always been.

When we get to Rome, are there any more presents well haveto buy? That presence has continued, not all the time, but normally so.

And still more through talk and such mentalinterchanges.

Now, she demands, how are we going to do it? She has given me a thousand proofs of it.

She is so in hersocial and intellectual interests.

And was I disappointed when the truckgot away from me down an elevator! The bestway he can do it is to tell you something that only you and he know.

I go intoa room; she may or may not be there.

I found myself happy and twinkling, for no reason at all.

More and more we have been tending toward writing offeverything but the gain of the day.

Many of them, indeed, were gone from my own memory, untilBetty recalled them to me.

Given that,man or nation makes its own security. So at the earliest opportunity Iwent to see Millicent.

No, said the salesman,the merchandise on the truck was all sold goods. Neither the more nor the less, said Betty, may set the pace forall. The promise of the gliders we investigated atonce. Itll be such fun to see her when she gets it!

I think that might be possible, if the bartender is kind-hearted. We deny the claim of the future; weare increasingly indifferent to the coming generations.

The worth of the new pattern must depend on the basisof its establishment.

She does not mean, she carefully explained, a conscious attitude ofagnosticism or denial. What happened out on the hillside under thetrees that April night I have told elsewhere.

[Ext2-devel] [PATCH] ext3 should use uint for internal inode containers

2006-08-29T15:39:11Z

Talking to sct, he'd prefer to see ext3 continue to use only uints for
inode number containers which are internal to the filesystem, since the
filesystem itself can only do 32-bit inode numbers (on-disk format
restriction), and uint is always 32, while ulong is sometimes 64.
So, this patch bumps the unsigned longs from
ext3-inode-numbers-are-unsigned-long.patch back down to unsigned ints.

(this patch applies over that one)

Thanks,

-Eric

Signed-off-by: Eric Sandeen <esandeen@...>

diff -u a/fs/ext3/ialloc.c linux-2.6.17/fs/ext3/ialloc.c
--- a/fs/ext3/ialloc.c
+++ linux-2.6.17/fs/ext3/ialloc.c
@@ -202,7 +202,7 @@
static int find_group_dir(struct super_block *sb, struct inode *parent)
{
int ngroups = EXT3_SB(sb)->s_groups_count;
- unsigned long freei, avefreei;
+ unsigned int freei, avefreei;
struct ext3_group_desc *desc, *best_desc = NULL;
struct buffer_head *bh;
int group, best_group = -1;
@@ -261,10 +261,10 @@
struct ext3_super_block *es = sbi->s_es;
int ngroups = sbi->s_groups_count;
int inodes_per_group = EXT3_INODES_PER_GROUP(sb);
- unsigned long freei, avefreei;
+ unsigned int freei, avefreei;
ext3_fsblk_t freeb, avefreeb;
ext3_fsblk_t blocks_per_dir;
- unsigned long ndirs;
+ unsigned int ndirs;
int max_debt, max_dirs, min_inodes;
ext3_grpblk_t min_blocks;
int group = -1, i;
diff -u a/fs/ext3/super.c linux-2.6.17/fs/ext3/super.c
--- a/fs/ext3/super.c
+++ linux-2.6.17/fs/ext3/super.c
@@ -45,7 +45,7 @@
static int ext3_load_journal(struct super_block *, struct ext3_super_block *,
unsigned long journal_devnum);
static int ext3_create_journal(struct super_block *, struct ext3_super_block *,
- unsigned long);
+ unsigned int);
static void ext3_commit_super (struct super_block * sb,
struct ext3_super_block * es,
int sync);
@@ -711,7 +711,7 @@
}

static int parse_options (char *options, struct super_block *sb,
- unsigned long *inum, unsigned long *journal_devnum,
+ unsigned int *inum, unsigned long *journal_devnum,
ext3_fsblk_t *n_blocks_count, int is_remount)
{
struct ext3_sb_info *sbi = EXT3_SB(sb);
@@ -1353,7 +1353,7 @@
ext3_fsblk_t sb_block = get_sb_block(&data);
ext3_fsblk_t logic_sb_block;
unsigned long offset = 0;
- unsigned long journal_inum = 0;
+ unsigned int journal_inum = 0;
unsigned long journal_devnum = 0;
unsigned long def_mount_opts;
struct inode *root;
@@ -1803,7 +1803,7 @@
}

static journal_t *ext3_get_journal(struct super_block *sb,
- unsigned long journal_inum)
+ unsigned int journal_inum)
{
struct inode *journal_inode;
journal_t *journal;
@@ -1938,7 +1938,7 @@
unsigned long journal_devnum)
{
journal_t *journal;
- unsigned long journal_inum = le32_to_cpu(es->s_journal_inum);
+ unsigned int journal_inum = le32_to_cpu(es->s_journal_inum);
dev_t journal_dev;
int err = 0;
int really_read_only;
@@ -2024,7 +2024,7 @@

static int ext3_create_journal(struct super_block * sb,
struct ext3_super_block * es,
- unsigned long journal_inum)
+ unsigned int journal_inum)
{
journal_t *journal;

@@ -2037,7 +2037,7 @@
if (!(journal = ext3_get_journal(sb, journal_inum)))
return -EINVAL;

- printk(KERN_INFO "EXT3-fs: creating new journal on inode %lu\n",
+ printk(KERN_INFO "EXT3-fs: creating new journal on inode %u\n",
journal_inum);

if (journal_create(journal)) {

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

[Ext2-devel] [PATCH] endianness fixes for 16T ext patches

2006-08-29T10:50:06Z

Whoops... thanks for pointing this out, Stephen...

Fix some endian errors in the 16T ext[23] patches I sent in the past couple weeks.

Signed-off-by: Eric Sandeen <esandeen@...>

Index: linux-2.6.17/fs/ext2/super.c
===================================================================
--- linux-2.6.17.orig/fs/ext2/super.c
+++ linux-2.6.17/fs/ext2/super.c
@@ -514,7 +514,7 @@ static int ext2_check_descriptors (struc
for (i = 0; i < sbi->s_groups_count; i++)
{
if (i == sbi->s_groups_count - 1)
- last_block = sbi->s_es->s_blocks_count - 1;
+ last_block = le32_to_cpu(sbi->s_es->s_blocks_count) - 1;
else
last_block = first_block +
(EXT2_BLOCKS_PER_GROUP(sb) - 1);
Index: linux-2.6.17/fs/ext3/resize.c
===================================================================
--- linux-2.6.17.orig/fs/ext3/resize.c
+++ linux-2.6.17/fs/ext3/resize.c
@@ -730,12 +730,14 @@ int ext3_group_add(struct super_block *s
return -EPERM;
}

- if (es->s_blocks_count + input->blocks_count < es->s_blocks_count) {
+ if (le32_to_cpu(es->s_blocks_count) + input->blocks_count <
+ le32_to_cpu(es->s_blocks_count)) {
ext3_warning(sb, __FUNCTION__, "blocks_count overflow\n");
return -EINVAL;
}

- if (es->s_inodes_count+EXT3_INODES_PER_GROUP(sb) < es->s_inodes_count) {
+ if (le32_to_cpu(es->s_inodes_count) + EXT3_INODES_PER_GROUP(sb) <
+ le32_to_cpu(es->s_inodes_count)) {
ext3_warning(sb, __FUNCTION__, "inodes_count overflow\n");
return -EINVAL;
}
Index: linux-2.6.17/fs/ext3/super.c
===================================================================
--- linux-2.6.17.orig/fs/ext3/super.c
+++ linux-2.6.17/fs/ext3/super.c
@@ -1143,7 +1143,7 @@ static int ext3_check_descriptors (struc
for (i = 0; i < sbi->s_groups_count; i++)
{
if (i == sbi->s_groups_count - 1)
- last_block = sbi->s_es->s_blocks_count - 1;
+ last_block = le32_to_cpu(sbi->s_es->s_blocks_count) - 1;
else
last_block = first_block +
(EXT3_BLOCKS_PER_GROUP(sb) - 1);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

[Ext2-devel] Spanish. Copyright copy Helios

2006-08-29T02:08:46Z

editor for Windows // Search Contacts Home Whats New Products Support Download Buy

Support Download

files. Easy use with all

for Windows // Search Contacts Home Whats New Products Support Download Buy Forums home page English Japanese Polski .. powerful general purpose plain files. Easy use with all features user requires. More ... tool users make same changes set of folder Supported platforms products are ME XP and Server also supports NT. editions Dutch French German Italian Polish Brazilian Spanish. Copyright copy

general purpose plain files. Easy use with all features user requires. More ... tool users make same changes set of folder Supported platforms products are ME XP and Server also supports NT. editions Dutch French German Italian

// Search Contacts Home Whats New Products Support Download Buy Forums home page English Japanese Polski .. powerful general purpose plain files. Easy use with all features user requires. More ... tool users make same changes set of folder Supported platforms products are ME XP and Server also supports NT. editions Dutch French German Italian Polish Brazilian Spanish. Copyright copy Helios Software All

editor for Windows // Search Contacts Home Whats New Products Support Download Buy Forums home page English Japanese Polski .. powerful general purpose plain files. Easy use with all features user requires. More ... tool users make same changes set of folder Supported platforms

Contacts Home Whats New Products Support Download Buy Forums home page English Japanese Polski .. powerful general purpose plain files. Easy use with all features user requires. More ... tool users make same changes set of folder Supported platforms products are ME XP and Server also supports NT. editions Dutch French German Italian Polish Brazilian Spanish. Copyright copy Helios Software All rights reserved. CSE HTML

[Ext2-devel] 2.6.18-rc4 panic in do_get_write_access()

2006-08-28T16:33:35Z

2.6.18-rc4 doesn't survive fsx tests on 1k ext3 filesystem
with CONFIG_DEBUG_SLAB.

Known issue ?

Thanks,
Badari

elm3a241 login: kfree_debugcheck: bad ptr ffff8100d39ae000h.
----------- [cut here ] --------- [please bite here ] ---------
Kernel BUG at mm/slab.c:2698
invalid opcode: 0000 [1] SMP
CPU 0
Modules linked in: stap_2543 autofs4 hidp rfcomm l2cap bluetooth sunrpc
af_packet xt_state ip_conntrack nfnetlink xt_tcpudp ip6table_filter
ip6_tables x_tables ipv6 acpi_cpufreq freq_table processor binfmt_misc
parport_pc lp parport ide_cd cdrom generic floppy e752x_edac edac_mc
shpchp i2c_i801 uhci_hcd piix serio_raw ehci_hcd i2c_core pci_hotplug
usbcore dm_snapshot dm_zero dm_mirror dm_mod ide_disk ide_core
Pid: 2638, comm: fsx-linux Not tainted 2.6.18-rc4-smp #17
RIP: 0010:[<ffffffff8027de3d>] [<ffffffff8027de3d>] kfree_debugcheck
+0x9a/0xa8
RSP: 0018:ffff81010d9ad5b8 EFLAGS: 00010096
RAX: 0000000000000030 RBX: ffff8100d39ae000 RCX: ffffffff8062daa0
RDX: 0000000000000000 RSI: 0000000000000092 RDI: 0000000100000000
RBP: ffff81010d9ad5c8 R08: 00000000000042ee R09: 0000000000000000
R10: 0000000000000092 R11: 0000000000000000 R12: ffff81010ab2dd60
R13: ffff8100d39ae000 R14: ffff8101212ddea8 R15: 0000000000000286
FS: 00002b611ab05200(0000) GS:ffffffff8069b000(0000)
knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 00002af34fee4000 CR3: 000000010b1c5000 CR4: 00000000000006e0
Process fsx-linux (pid: 2638, threadinfo ffff81010d9ac000, task
ffff81010b6a30c0)
Stack: 0000000000000000 0000000000000000 ffff81010d9ad618
ffffffff8027fbbc
ffff81010d9ad618 ffffffff80309080 ffff81010d9ad608 0000000000000000
ffff81010ab2dd60 ffff81010da6d928 ffff8101212ddea8 0000000000000000
Call Trace:
[<ffffffff8027fbbc>] kfree+0x26/0x1f2
[<ffffffff80304110>] do_get_write_access+0x52e/0x54f
[<ffffffff803051a3>] journal_get_undo_access+0x2e/0x118
[<ffffffff802f0a0c>] ext3_try_to_allocate_with_rsv+0x4b/0x504
[<ffffffff802f117e>] ext3_new_blocks+0x2b9/0x74e
[<ffffffff802f46d3>] ext3_get_blocks_handle+0x467/0xac4
[<ffffffff802f5095>] ext3_get_block+0xc4/0xec
[<ffffffff8028795c>] __block_prepare_write+0x1bf/0x41e
[<ffffffff80287bdd>] block_prepare_write+0x22/0x30
[<ffffffff802f660f>] ext3_prepare_write+0xb5/0x185
[<ffffffff8025fbc3>] generic_file_buffered_write+0x2c7/0x6b7
[<ffffffff80260298>] __generic_file_aio_write_nolock+0x2e5/0x331
[<ffffffff8026034d>] generic_file_aio_write+0x69/0xc4
[<ffffffff802f21a6>] ext3_file_write+0x1e/0x9b
[<ffffffff80284804>] do_sync_write+0xf0/0x12e
[<ffffffff80285197>] vfs_write+0xcf/0x175
[<ffffffff8028577f>] sys_write+0x47/0x70
[<ffffffff8020988e>] system_call+0x7e/0x83
DWARF2 unwinder stuck at system_call+0x7e/0x83
Leftover inexact backtrace:

Code: 0f 0b 68 ae 3c 4a 80 c2 8a 0a 58 5b c9 c3 55 48 89 e5 41 57
RIP [<ffffffff8027de3d>] kfree_debugcheck+0x9a/0xa8
RSP <ffff81010d9ad5b8>
<3>BUG: sleeping function called from invalid context at
kernel/rwsem.c:20
in_atomic():0, irqs_disabled():1

Call Trace:
[<ffffffff8020ad7f>] show_trace+0xae/0x30e
[<ffffffff8020aff4>] dump_stack+0x15/0x17
[<ffffffff802288a5>] __might_sleep+0xb2/0xb4
[<ffffffff8024750e>] down_read+0x1d/0x2f
[<ffffffff8023e674>] blocking_notifier_call_chain+0x1b/0x41
[<ffffffff80232511>] profile_task_exit+0x15/0x17
[<ffffffff80233f95>] do_exit+0x25/0x91e
[<ffffffff8020b222>] kernel_math_error+0x0/0x96
[<ffff81010b6a30c0>]
DWARF2 unwinder stuck at 0xffff81010b6a30c0
Leftover inexact backtrace:
[<ffffffff80471079>] do_trap+0xe0/0xef
[<ffffffff8020b82d>] do_invalid_op+0xa7/0xb3
[<ffffffff8027de3d>] kfree_debugcheck+0x9a/0xa8
[<ffffffff804707db>] _spin_unlock_irq+0x9/0xc
[<ffffffff8046e95e>] thread_return+0x5e/0xef
[<ffffffff8020a55d>] error_exit+0x0/0x84
[<ffffffff8027de3d>] kfree_debugcheck+0x9a/0xa8
[<ffffffff8027de3d>] kfree_debugcheck+0x9a/0xa8
[<ffffffff8027fbbc>] kfree+0x26/0x1f2
[<ffffffff80309080>] journal_cancel_revoke+0x137/0x1ac
[<ffffffff80304110>] do_get_write_access+0x52e/0x54f
[<ffffffff80244b7f>] wake_bit_function+0x0/0x2a
[<ffffffff80286ca7>] __find_get_block+0x171/0x183
[<ffffffff803051a3>] journal_get_undo_access+0x2e/0x118
[<ffffffff802f0a0c>] ext3_try_to_allocate_with_rsv+0x4b/0x504
[<ffffffff80286cf2>] __getblk+0x39/0x25c
[<ffffffff80288592>] __bread+0xe/0xb5
[<ffffffff802f117e>] ext3_new_blocks+0x2b9/0x74e
[<ffffffff802f46d3>] ext3_get_blocks_handle+0x467/0xac4
[<ffffffff8028613f>] alloc_buffer_head+0x19/0x40
[<ffffffff8027dd28>] cache_alloc_debugcheck_after+0x1a5/0x1b4
[<ffffffff8028613f>] alloc_buffer_head+0x19/0x40
[<ffffffff8027ef82>] kmem_cache_alloc+0xbe/0xca
[<ffffffff802f5095>] ext3_get_block+0xc4/0xec
[<ffffffff8028795c>] __block_prepare_write+0x1bf/0x41e
[<ffffffff802f4fd1>] ext3_get_block+0x0/0xec
[<ffffffff80287bdd>] block_prepare_write+0x22/0x30
[<ffffffff802f660f>] ext3_prepare_write+0xb5/0x185
[<ffffffff80470693>] _write_unlock_irq+0x9/0xc
[<ffffffff8025fbc3>] generic_file_buffered_write+0x2c7/0x6b7
[<ffffffff8029e15d>] touch_atime+0x6b/0xaa
[<ffffffff80236172>] current_fs_time+0x3f/0x41
[<ffffffff8025f059>] do_generic_mapping_read+0x42e/0x47a
[<ffffffff80260298>] __generic_file_aio_write_nolock+0x2e5/0x331
[<ffffffff8026034d>] generic_file_aio_write+0x69/0xc4
[<ffffffff802f21a6>] ext3_file_write+0x1e/0x9b
[<ffffffff80284804>] do_sync_write+0xf0/0x12e
[<ffffffff80244b47>] autoremove_wake_function+0x0/0x38
[<ffffffff8046f59e>] mutex_lock+0x22/0x32
[<ffffffff80285197>] vfs_write+0xcf/0x175
[<ffffffff8028577f>] sys_write+0x47/0x70
[<ffffffff8020988e>] system_call+0x7e/0x83

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Ext2-devel mailing list
Ext2-devel@...
https://lists.sourceforge.net/lists/listinfo/ext2-devel

[Ext2-devel] fem. reader

2006-08-28T13:58:35Z

Galsworthy, shall we find what weseek in his pages. Look within and life, it seems, is very far from being like this.

And what effect would all this have had upon the six novels thatJane Austen did not write? CharlotteBrontë, at least, owed nothing to the reading of many books.

But, afterall, she died at the age of forty-two. She would not have written of crime, ofpassion, or of adventure. It makes them poets, or, if they choose to write inprose, intolerant of its restrictions. But, afterall, she died at the age of forty-two. Their masterpieces certainly have astrange air of simplicity.

The impulsewhich urged her to create was not her own suffering or her owninjuries.

Therefore the observation is less of facts and more offeelings than is usual. Her experience, though moreintense, is on a level with our own. Think of the moor, and again there is JaneEyre.

She shows herself far more openly andcompletely in Maggie in The Mill on the Floss. We ought to respect ourinfluence, she said.

Life escapes; and perhapswithout life nothing else is worth while. She was the pride and paragon of her sex.

There is not so much as a draught between the frames ofthe windows, or a crack in the boards. She talks of the influence sosweet and so sad of autumnal months in the country. Naturally, no single word reaches the centre of threeseparate targets. Life escapes; and perhapswithout life nothing else is worth while. Her experience, though moreintense, is on a level with our own.