Examples

[Jonathan Gallimore-2]

Hi All,

I added a couple of patches to Jira recently which provide examples for
stateless and message driven beans using a deployment descriptor instead
of annotations (OPENEJB-343 and OPENEJB-345). My implementation is
exactly the same as the other stateless and message driven samples, just
replacing the annotations with an ejb-jar.xml. It looks like my SVN
account has been set up, so if this is ok, I'll have a go at committing
these patches. As its my first commit, I just wanted to check it was ok ;-)

Cheers

Jon

[David Blevins]

On Jul 18, 2008, at 2:22 PM, Jonathan Gallimore wrote:

> Hi All,
>
> I added a couple of patches to Jira recently which provide examples  
> for stateless and message driven beans using a deployment descriptor  
> instead of annotations (OPENEJB-343 and OPENEJB-345). My  
> implementation is exactly the same as the other stateless and  
> message driven samples, just replacing the annotations with an ejb-
> jar.xml. It looks like my SVN account has been set up, so if this is  
> ok, I'll have a go at committing these patches. As its my first  
> commit, I just wanted to check it was ok ;-)

Big thumbs up!

I set you up as a committer in JIRA too, so you should be able to  
close the issue as well.

I try to include the JIRA id and title in my commit messages if there  
is a related JIRA.  Then I like to put the svn commit revision in the  
JIRA comments when I close it -- picked up that habit from Jacek.  No  
need to do exactly the same, feel free to blaze your own trail.

-David

[Jonathan Gallimore-2]

David Blevins wrote:

>
> On Jul 18, 2008, at 2:22 PM, Jonathan Gallimore wrote:
>
>> Hi All,
>>
>> I added a couple of patches to Jira recently which provide examples
>> for stateless and message driven beans using a deployment descriptor
>> instead of annotations (OPENEJB-343 and OPENEJB-345). My
>> implementation is exactly the same as the other stateless and message
>> driven samples, just replacing the annotations with an ejb-jar.xml.
>> It looks like my SVN account has been set up, so if this is ok, I'll
>> have a go at committing these patches. As its my first commit, I just
>> wanted to check it was ok ;-)
>
> Big thumbs up!
>
> I set you up as a committer in JIRA too, so you should be able to
> close the issue as well.

Brilliant, thanks for that! They're both committed and closed.
>
> I try to include the JIRA id and title in my commit messages if there
> is a related JIRA.  Then I like to put the svn commit revision in the
> JIRA comments when I close it -- picked up that habit from Jacek.  No
> need to do exactly the same, feel free to blaze your own trail.
I think this is a good idea, I've done it for my commits :)

[KMalhi]

Jonathan,

Nice work! . Here is a page in our wiki where everybody has contributed Tips
and Suggestions. This might be helpful too
http://openejb.apache.org/tips-and-suggestions.html

On Fri, Jul 18, 2008 at 5:22 PM, Jonathan Gallimore <
jonathan.gallimore@...> wrote:

> Hi All,
>
> I added a couple of patches to Jira recently which provide examples for
> stateless and message driven beans using a deployment descriptor instead of
> annotations (OPENEJB-343 and OPENEJB-345). My implementation is exactly the
> same as the other stateless and message driven samples, just replacing the
> annotations with an ejb-jar.xml. It looks like my SVN account has been set
> up, so if this is ok, I'll have a go at committing these patches. As its my
> first commit, I just wanted to check it was ok ;-)
>
> Cheers
>
> Jon
>

--
Karan Singh Malhi