EXPERIMENTAL_NOTE_TRACK - Translations?

2 Messages Forum Options Options
Permalink
Greg Williams-2
EXPERIMENTAL_NOTE_TRACK - Translations?
Reply Threaded More
Print post
Permalink
Hi, I'm working with Roger Dannenberg on the changes being made under the EXPERIMENTAL_NOTE_TRACK flag.  On Saturday, I committed a change I made to Menus.cpp (line 3845) that I've found a small issue with, and I'm wondering how to go about fixing it.

When EXPERIMENTAL_NOTE_TRACK is defined, the Import MIDI option is changed such that upon choosing a file, the file filter options are no longer:
 - All files (*.*) [default]
 - MIDI files (*.mid)
 - Allegro files (*.gro)

Instead, I have changed them to:
 - MIDI and Allegro files (*.mid;*.gro) [default]
 - MIDI files (*.mid)
 - Allegro files (*.gro)
 - All files (*.*)

(When EXPERIMENTAL_NOTE_TRACK is not defined, the original options are kept.)

I believe this is a positive (albeit small) change to the program because it has the potential to eliminate seeing unnecessary files in a cluttered directory.  However, I did not notice until today that because I did not update the language files accordingly, the new string will not be translated correctly.  I would imagine that this isn't a high-priority issue, but I thought it would be worth mentioning regardless.  Is the lack of translation enough of an issue that I should revert my changes, or should I leave things as they are?  Is there another action I should take?

Thanks,
-Greg Williams

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Leland (AudacityTeam)
Re: EXPERIMENTAL_NOTE_TRACK - Translations?
Reply Threaded More
Print post
Permalink
Greg Williams wrote:

>
> I believe this is a positive (albeit small) change to the program because it
> has the potential to eliminate seeing unnecessary files in a cluttered
> directory.  However, I did not notice until today that because I did not
> update the language files accordingly, the new string will not be translated
> correctly.  I would imagine that this isn't a high-priority issue, but I
> thought it would be worth mentioning regardless.  Is the lack of translation
> enough of an issue that I should revert my changes, or should I leave things
> as they are?  Is there another action I should take?
>
No worries.  The translators will pick it up next time they go through
their procedures.  Until they get round to it, the strings will show in
English.

Leland


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Audacity-devel mailing list
Audacity-devel@...
https://lists.sourceforge.net/lists/listinfo/audacity-devel