ECB patch

View: New views
2 Messages — Rating Filter:   Alert me  

ECB patch

by Eric M. Ludlam :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Howdy,

  Last fall I optimized the analyzer, and a slot ECB was using was
deleted.  The following patch (plus comment you can delete at your
leisure) uses a function that ought to work with older versions of
CEDET as well as the CVS version.

  ECB users wrappers for all this stuff so it probably needs some
additional assistance.

  I found a compile warning about a new required argument too, but I
made that optional in CEDET so that code can stay the same.

  I gave it a quick run, and it works against CVS/CEDET.

Enjoy
Eric

---------------------------------
*** ecb-analyse.el 12 May 2006 12:03:11 -0400 1.16
--- ecb-analyse.el 02 Feb 2008 17:56:01 -0500
***************
*** 270,276 ****
 
  (defmethod ecb-analyse-more-nodes ((context semantic-analyze-context))
    "Show a set of ecb-nodes specific to CONTEXT."
!   (let ((localvars (oref context localvariables)))
      (when localvars
        (ecb-analyse-add-nodes "Local Variables" "Local Variables" localvars
                               ecb-analyse-nodetype-localvars)))
--- 270,278 ----
 
  (defmethod ecb-analyse-more-nodes ((context semantic-analyze-context))
    "Show a set of ecb-nodes specific to CONTEXT."
!   (let ((localvars (semantic-get-local-variables))
! ;;      was ... (oref context localvariables)))
! )
      (when localvars
        (ecb-analyse-add-nodes "Local Variables" "Local Variables" localvars
                               ecb-analyse-nodetype-localvars)))

--
          Eric Ludlam:                       eric@...
   Siege: www.siege-engine.com          Emacs: http://cedet.sourceforge.net

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ecb-list mailing list
Ecb-list@...
https://lists.sourceforge.net/lists/listinfo/ecb-list

Re: ECB patch

by klaus.berndl :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Eric,

thanks for the patch and your effort! I will check this as soon as i find some time ;-)

Ciao,
Klaus

Eric M. Ludlam wrote:

> Howdy,
>
>   Last fall I optimized the analyzer, and a slot ECB was using was
> deleted.  The following patch (plus comment you can delete at your
> leisure) uses a function that ought to work with older versions of
> CEDET as well as the CVS version.
>
>   ECB users wrappers for all this stuff so it probably needs some
> additional assistance.
>
>   I found a compile warning about a new required argument too, but I
> made that optional in CEDET so that code can stay the same.
>
>   I gave it a quick run, and it works against CVS/CEDET.
>
> Enjoy
> Eric
>
> ---------------------------------
> *** ecb-analyse.el 12 May 2006 12:03:11 -0400 1.16
> --- ecb-analyse.el 02 Feb 2008 17:56:01 -0500
> ***************
> *** 270,276 ****
>
>   (defmethod ecb-analyse-more-nodes ((context
>     semantic-analyze-context)) "Show a set of ecb-nodes specific to
> CONTEXT." !   (let ((localvars (oref context localvariables)))
>       (when localvars
>         (ecb-analyse-add-nodes "Local Variables" "Local Variables"
>                                localvars
> ecb-analyse-nodetype-localvars))) --- 270,278 ----
>
>   (defmethod ecb-analyse-more-nodes ((context
>     semantic-analyze-context)) "Show a set of ecb-nodes specific to
> CONTEXT." !   (let ((localvars (semantic-get-local-variables))
> ! ;;      was ... (oref context localvariables)))
> ! )
>       (when localvars
>         (ecb-analyse-add-nodes "Local Variables" "Local Variables"
>                                localvars
> ecb-analyse-nodetype-localvars)))

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ecb-list mailing list
Ecb-list@...
https://lists.sourceforge.net/lists/listinfo/ecb-list
LightInTheBox - Buy quality products at wholesale price!