Nabble - Castle

Re: : /trunk/InversionOfControl/Castle.MicroKernel/

2008-10-12T13:33:18Z

Not to burst anyone's bubble but RWSlim doesn't work in medium trust
environments anyway. Are we still going to allow a medium trust build
option?
http://weblogs.asp.net/leftslipper/archive/2008/03/31/mvc-locking-the-routecollection.aspx

On Oct 12, 12:20 pm, "Ayende Rahien" <aye...@...> wrote:

> I think it was for C# 3.0 features, not .net 3.5 .net-2.0 compatibility is
> still important, I think.
> We can use #ifdef again, I suppose.
>
> On Sun, Oct 12, 2008 at 6:35 PM, hammett <hamm...@...> wrote:
>
> > I thought we have held a vote on that recently...
>
> > On Sun, Oct 12, 2008 at 5:25 AM, Ayende Rahien <aye...@...> wrote:
> > > This ties the castle code base to .NET 3.5, was this intentional?
>
> > > ---------- Forwarded message ----------
> > > From: <notificat...@...>
> > > Date: Sun, Oct 12, 2008 at 7:04 AM
> > > Subject: [hammett commit: 5376]:
> > > /trunk/InversionOfControl/Castle.MicroKernel/
> > > To: castle-project-commits@...
>
> > > User: hammett
> > > Date: 2008/10/11 10:04 PM
>
> > > Modified:
> > > /trunk/InversionOfControl/Castle.MicroKernel/
> > > Castle.MicroKernel-vs2008.csproj
> > > /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
> > > AllComponentsReleasePolicy.cs
>
> > > Log:
> > > Changed to use ReaderWriterLockSlim - see
>
> >http://www.bluebytesoftware.com/blog/PermaLink,guid,c4ea3d6d-190a-48f...
>
> > > File Changes:
>
> > > Directory: /trunk/InversionOfControl/Castle.MicroKernel/
> > > ========================================================
>
> > > File [modified]: Castle.MicroKernel-vs2008.csproj
> > > Delta lines: +83 -79
> > > ===================================================================
>
> > > ---
>
> > trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleaseP olicy.cs
> > > 2008-10-10 23:14:31 UTC (rev 5375)
> > > +++
>
> > trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleaseP olicy.cs
> > > 2008-10-12 05:04:37 UTC (rev 5376)
> > > @@ -12,103 +12,107 @@
> > > // See the License for the specific language governing permissions and
> > > // limitations under the License.
>
> > > -using System.Threading;
> > > -
> > > namespace Castle.MicroKernel.Releasers
> > > {
> > > - using System;
> > > - using System.Collections;
> > > + using System;
> > > + using System.Collections;
> > > + using System.Threading;
>
> > > - [Serializable]
> > > - public class AllComponentsReleasePolicy : IReleasePolicy
> > > - {
> > > - private readonly IDictionary instance2Burden =
> > > - new Hashtable(new Util.ReferenceEqualityComparer());
> > > + [Serializable]
> > > + public class AllComponentsReleasePolicy : IReleasePolicy
> > > + {
> > > + private readonly IDictionary instance2Burden =
> > > + new Hashtable(new
> > Util.ReferenceEqualityComparer());
>
> > > - readonly ReaderWriterLock rwLock = new ReaderWriterLock();
> > > + private readonly ReaderWriterLockSlim rwLock = new
> > > ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
>
> > > - public virtual void Track(object instance, Burden burden)
> > > - {
> > > - rwLock.AcquireWriterLock(Timeout.Infinite);
> > > - try
> > > - {
> > > - instance2Burden[instance] = burden;
> > > - }
> > > - finally
> > > - {
> > > - rwLock.ReleaseWriterLock();
> > > - }
> > > - }
> > > + public virtual void Track(object instance, Burden burden)
> > > + {
> > > + rwLock.EnterWriteLock();
>
> > > - public bool HasTrack(object instance)
> > > - {
> > > - if (instance == null) throw new
> > > ArgumentNullException("instance");
> > > - rwLock.AcquireReaderLock(Timeout.Infinite);
> > > - try
> > > - {
> > > - return instance2Burden.Contains(instance);
> > > - }
> > > - finally
> > > - {
> > > - rwLock.ReleaseReaderLock();
> > > - }
> > > - }
> > > + try
> > > + {
> > > + instance2Burden[instance] = burden;
> > > + }
> > > + finally
> > > + {
> > > + rwLock.ExitWriteLock();
> > > + }
> > > + }
>
> > > - public void Release(object instance)
> > > - {
> > > - if (instance == null) throw new
> > > ArgumentNullException("instance");
> > > - rwLock.AcquireReaderLock(Timeout.Infinite);
> > > - try
> > > - {
> > > - var burden = (Burden)instance2Burden[instance];
> > > + public bool HasTrack(object instance)
> > > + {
> > > + if (instance == null) throw new
> > > ArgumentNullException("instance");
>
> > > - if (burden == null)
> > > - return;
> > > + rwLock.EnterReadLock();
> > > + try
> > > + {
> > > + return
> > instance2Burden.Contains(instance);
> > > + }
> > > + finally
> > > + {
> > > + rwLock.ExitReadLock();
> > > + }
> > > + }
>
> > > - LockCookie cookie =
> > > rwLock.UpgradeToWriterLock(Timeout.Infinite);
> > > + public void Release(object instance)
> > > + {
> > > + if (instance == null) throw new
> > > ArgumentNullException("instance");
>
> > > - try
> > > - {
> > > - burden = (Burden)instance2Burden[instance];
> > > - if (burden == null)
> > > - return;
> > > + rwLock.EnterUpgradeableReadLock();
>
> > > - instance2Burden.Remove(instance);
> > > + try
> > > + {
> > > + var burden = (Burden)
> > > instance2Burden[instance];
>
> > > - burden.Release(this);
> > > - }
> > > - finally
> > > - {
> > > - rwLock.DowngradeFromWriterLock(ref cookie);
> > > - }
> > > - }
> > > - finally
> > > - {
> > > - rwLock.ReleaseReaderLock();
> > > - }
> > > - }
> > > + if (burden == null)
> > > + return;
>
> > > - public void Dispose()
> > > - {
> > > - rwLock.AcquireWriterLock(Timeout.Infinite);
> > > - try
> > > - {
> > > + rwLock.EnterWriteLock();
> > > +
> > > + try
> > > + {
> > > + burden = (Burden)
> > > instance2Burden[instance];
> > > + if (burden == null)
> > > + return;
> > > +
> > > + instance2Burden.Remove(instance);
> > > +
> > > + burden.Release(this);
> > > + }
> > > + finally
> > > + {
> > > + rwLock.ExitWriteLock();
> > > + }
> > > + }
> > > + finally
> > > + {
> > > + rwLock.ExitUpgradeableReadLock();
> > > + }
> > > + }
> > > +
> > > + public void Dispose()
> > > + {
> > > + rwLock.EnterWriteLock();
> > > +
> > > + try
> > > + {
> > > Burden[] burdens = new
> > > Burden[instance2Burden.Count];
> > > instance2Burden.Values.CopyTo(burdens, 0);
>
> > > - foreach (Burden burden in burdens)
> > > - {
> > > + foreach(Burden burden in burdens)
> > > + {
> > > if
> > (instance2Burden.Contains(burden))
> > > {
> > > burden.Release(this);
>
> > > instance2Burden.Remove(burden);
> > > }
> > > - }
> > > - }
> > > - finally
> > > - {
> > > - rwLock.ReleaseWriterLock();
> > > - }
> > > - }
> > > - }
> > > -}
> > > + }
> > > + }
> > > + finally
> > > + {
> > > + rwLock.ExitWriteLock();
> > > + }
> > > + }
> > > + }
> > > +}
>
> > > Directory: /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
> > > ==================================================================
>
> > > File [modified]: AllComponentsReleasePolicy.cs
> > > Delta lines: +0 -0
> > > ===================================================================
>
> > --
> > Cheers,
> > hammett
> >http://hammett.castleproject.org/

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To post to this group, send email to castle-project-devel@...
To unsubscribe from this group, send email to castle-project-devel+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en
-~----------~----~----~----~------~----~------~--~---

From forum: Castle Dev

Re: [hammett commit: 5376]: /trunk/InversionOfControl/Castle.MicroKernel/

2008-10-12T10:20:31Z

I think it was for C# 3.0 features, not .net 3.5

.net-2.0 compatibility is still important, I think.

We can use #ifdef again, I suppose.

On Sun, Oct 12, 2008 at 6:35 PM, hammett <hammett@...> wrote:

I thought we have held a vote on that recently...

On Sun, Oct 12, 2008 at 5:25 AM, Ayende Rahien <ayende@...> wrote:
> This ties the castle code base to .NET 3.5, was this intentional?
>
> ---------- Forwarded message ----------
> From: <notification@...>
> Date: Sun, Oct 12, 2008 at 7:04 AM
> Subject: [hammett commit: 5376]:
> /trunk/InversionOfControl/Castle.MicroKernel/
> To: castle-project-commits@...
>
>
>
> User: hammett
> Date: 2008/10/11 10:04 PM
>
> Modified:
> /trunk/InversionOfControl/Castle.MicroKernel/
> Castle.MicroKernel-vs2008.csproj
> /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
> AllComponentsReleasePolicy.cs
>
> Log:
> Changed to use ReaderWriterLockSlim - see
> http://www.bluebytesoftware.com/blog/PermaLink,guid,c4ea3d6d-190a-48f8-a677-44a438d8386b.aspx
>
> File Changes:
>
> Directory: /trunk/InversionOfControl/Castle.MicroKernel/
> ========================================================
>
> File [modified]: Castle.MicroKernel-vs2008.csproj
> Delta lines: +83 -79
> ===================================================================
>
> ---
> trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleasePolicy.cs
> 2008-10-10 23:14:31 UTC (rev 5375)
> +++
> trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleasePolicy.cs
> 2008-10-12 05:04:37 UTC (rev 5376)
> @@ -12,103 +12,107 @@
> // See the License for the specific language governing permissions and
> // limitations under the License.
>
> -using System.Threading;
> -
> namespace Castle.MicroKernel.Releasers
> {
> - using System;
> - using System.Collections;
> + using System;
> + using System.Collections;
> + using System.Threading;
>
> - [Serializable]
> - public class AllComponentsReleasePolicy : IReleasePolicy
> - {
> - private readonly IDictionary instance2Burden =
> - new Hashtable(new Util.ReferenceEqualityComparer());
> + [Serializable]
> + public class AllComponentsReleasePolicy : IReleasePolicy
> + {
> + private readonly IDictionary instance2Burden =
> + new Hashtable(new Util.ReferenceEqualityComparer());
>
> - readonly ReaderWriterLock rwLock = new ReaderWriterLock();
> + private readonly ReaderWriterLockSlim rwLock = new
> ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
>
> - public virtual void Track(object instance, Burden burden)
> - {
> - rwLock.AcquireWriterLock(Timeout.Infinite);
> - try
> - {
> - instance2Burden[instance] = burden;
> - }
> - finally
> - {
> - rwLock.ReleaseWriterLock();
> - }
> - }
> + public virtual void Track(object instance, Burden burden)
> + {
> + rwLock.EnterWriteLock();
>
> - public bool HasTrack(object instance)
> - {
> - if (instance == null) throw new
> ArgumentNullException("instance");
> - rwLock.AcquireReaderLock(Timeout.Infinite);
> - try
> - {
> - return instance2Burden.Contains(instance);
> - }
> - finally
> - {
> - rwLock.ReleaseReaderLock();
> - }
> - }
> + try
> + {
> + instance2Burden[instance] = burden;
> + }
> + finally
> + {
> + rwLock.ExitWriteLock();
> + }
> + }
>
> - public void Release(object instance)
> - {
> - if (instance == null) throw new
> ArgumentNullException("instance");
> - rwLock.AcquireReaderLock(Timeout.Infinite);
> - try
> - {
> - var burden = (Burden)instance2Burden[instance];
> + public bool HasTrack(object instance)
> + {
> + if (instance == null) throw new
> ArgumentNullException("instance");
>
> - if (burden == null)
> - return;
> + rwLock.EnterReadLock();
> + try
> + {
> + return instance2Burden.Contains(instance);
> + }
> + finally
> + {
> + rwLock.ExitReadLock();
> + }
> + }
>
> - LockCookie cookie =
> rwLock.UpgradeToWriterLock(Timeout.Infinite);
> + public void Release(object instance)
> + {
> + if (instance == null) throw new
> ArgumentNullException("instance");
>
> - try
> - {
> - burden = (Burden)instance2Burden[instance];
> - if (burden == null)
> - return;
> + rwLock.EnterUpgradeableReadLock();
>
> - instance2Burden.Remove(instance);
> + try
> + {
> + var burden = (Burden)
> instance2Burden[instance];
>
> - burden.Release(this);
> - }
> - finally
> - {
> - rwLock.DowngradeFromWriterLock(ref cookie);
> - }
> - }
> - finally
> - {
> - rwLock.ReleaseReaderLock();
> - }
> - }
> + if (burden == null)
> + return;
>
> - public void Dispose()
> - {
> - rwLock.AcquireWriterLock(Timeout.Infinite);
> - try
> - {
> + rwLock.EnterWriteLock();
> +
> + try
> + {
> + burden = (Burden)
> instance2Burden[instance];
> + if (burden == null)
> + return;
> +
> + instance2Burden.Remove(instance);
> +
> + burden.Release(this);
> + }
> + finally
> + {
> + rwLock.ExitWriteLock();
> + }
> + }
> + finally
> + {
> + rwLock.ExitUpgradeableReadLock();
> + }
> + }
> +
> + public void Dispose()
> + {
> + rwLock.EnterWriteLock();
> +
> + try
> + {
> Burden[] burdens = new
> Burden[instance2Burden.Count];
> instance2Burden.Values.CopyTo(burdens, 0);
>
> - foreach (Burden burden in burdens)
> - {
> + foreach(Burden burden in burdens)
> + {
> if (instance2Burden.Contains(burden))
> {
> burden.Release(this);
>
> instance2Burden.Remove(burden);
> }
> - }
> - }
> - finally
> - {
> - rwLock.ReleaseWriterLock();
> - }
> - }
> - }
> -}
> + }
> + }
> + finally
> + {
> + rwLock.ExitWriteLock();
> + }
> + }
> + }
> +}
>
> Directory: /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
> ==================================================================
>
> File [modified]: AllComponentsReleasePolicy.cs
> Delta lines: +0 -0
> ===================================================================
>
>
>
>
>
> >
>

--

Cheers,
hammett
http://hammett.castleproject.org/

From forum: Castle Dev

Re: [hammett commit: 5376]: /trunk/InversionOfControl/Castle.MicroKernel/

2008-10-12T09:54:14Z

well, as it is now, one of the major sell-point of MR over MVC (and NH/AR over EF and Linq2Sql) is 2.0 compatibility

maybe it's time to bring back conditionals?
or - call what we have now a 1.0RTM (which will be 2.0 compat) and name the trunk 1.1 unlocking 3.5?

On Sun, Oct 12, 2008 at 6:48 PM, hammett <hammett@...> wrote:

Was it? This kinda sucks as our "competitors" can take dependency on
3.5, and there's 4.0 under the way.
Having compatibility with older frameworks takes much of the fun of
OSS as a place for experimentations.

On Sun, Oct 12, 2008 at 9:38 AM, Ken Egozi <egozi13@...> wrote:
> wasn't the vote on
> 1. getting rid of 2005 projects
> and
> 2. allowing c#3 language features that can compile to 2.0 (like var and
> initialisers), but *not* System.Core/System.Linq etc
>
> On Sun, Oct 12, 2008 at 6:35 PM, hammett <hammett@...> wrote:
>>
>> I thought we have held a vote on that recently...
>>
>> On Sun, Oct 12, 2008 at 5:25 AM, Ayende Rahien <ayende@...> wrote:
>> > This ties the castle code base to .NET 3.5, was this intentional?
>> >
>> > ---------- Forwarded message ----------
>> > From: <notification@...>
>> > Date: Sun, Oct 12, 2008 at 7:04 AM
>> > Subject: [hammett commit: 5376]:
>> > /trunk/InversionOfControl/Castle.MicroKernel/
>> > To: castle-project-commits@...
>> >
>> >
>> >
>> > User: hammett
>> > Date: 2008/10/11 10:04 PM
>> >
>> > Modified:
>> > /trunk/InversionOfControl/Castle.MicroKernel/
>> > Castle.MicroKernel-vs2008.csproj
>> > /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
>> > AllComponentsReleasePolicy.cs
>> >
>> > Log:
>> > Changed to use ReaderWriterLockSlim - see
>> >
>> > http://www.bluebytesoftware.com/blog/PermaLink,guid,c4ea3d6d-190a-48f8-a677-44a438d8386b.aspx
>> >
>> > File Changes:
>> >
>> > Directory: /trunk/InversionOfControl/Castle.MicroKernel/
>> > ========================================================
>> >
>> > File [modified]: Castle.MicroKernel-vs2008.csproj
>> > Delta lines: +83 -79
>> > ===================================================================
>> >
>> > ---
>> >
>> > trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleasePolicy.cs
>> > 2008-10-10 23:14:31 UTC (rev 5375)
>> > +++
>> >
>> > trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleasePolicy.cs
>> > 2008-10-12 05:04:37 UTC (rev 5376)
>> > @@ -12,103 +12,107 @@
>> > // See the License for the specific language governing permissions and
>> > // limitations under the License.
>> >
>> > -using System.Threading;
>> > -
>> > namespace Castle.MicroKernel.Releasers
>> > {
>> > - using System;
>> > - using System.Collections;
>> > + using System;
>> > + using System.Collections;
>> > + using System.Threading;
>> >
>> > - [Serializable]
>> > - public class AllComponentsReleasePolicy : IReleasePolicy
>> > - {
>> > - private readonly IDictionary instance2Burden =
>> > - new Hashtable(new Util.ReferenceEqualityComparer());
>> > + [Serializable]
>> > + public class AllComponentsReleasePolicy : IReleasePolicy
>> > + {
>> > + private readonly IDictionary instance2Burden =
>> > + new Hashtable(new
>> > Util.ReferenceEqualityComparer());
>> >
>> > - readonly ReaderWriterLock rwLock = new ReaderWriterLock();
>> > + private readonly ReaderWriterLockSlim rwLock = new
>> > ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
>> >
>> > - public virtual void Track(object instance, Burden burden)
>> > - {
>> > - rwLock.AcquireWriterLock(Timeout.Infinite);
>> > - try
>> > - {
>> > - instance2Burden[instance] = burden;
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseWriterLock();
>> > - }
>> > - }
>> > + public virtual void Track(object instance, Burden
>> > burden)
>> > + {
>> > + rwLock.EnterWriteLock();
>> >
>> > - public bool HasTrack(object instance)
>> > - {
>> > - if (instance == null) throw new
>> > ArgumentNullException("instance");
>> > - rwLock.AcquireReaderLock(Timeout.Infinite);
>> > - try
>> > - {
>> > - return instance2Burden.Contains(instance);
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseReaderLock();
>> > - }
>> > - }
>> > + try
>> > + {
>> > + instance2Burden[instance] = burden;
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitWriteLock();
>> > + }
>> > + }
>> >
>> > - public void Release(object instance)
>> > - {
>> > - if (instance == null) throw new
>> > ArgumentNullException("instance");
>> > - rwLock.AcquireReaderLock(Timeout.Infinite);
>> > - try
>> > - {
>> > - var burden = (Burden)instance2Burden[instance];
>> > + public bool HasTrack(object instance)
>> > + {
>> > + if (instance == null) throw new
>> > ArgumentNullException("instance");
>> >
>> > - if (burden == null)
>> > - return;
>> > + rwLock.EnterReadLock();
>> > + try
>> > + {
>> > + return
>> > instance2Burden.Contains(instance);
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitReadLock();
>> > + }
>> > + }
>> >
>> > - LockCookie cookie =
>> > rwLock.UpgradeToWriterLock(Timeout.Infinite);
>> > + public void Release(object instance)
>> > + {
>> > + if (instance == null) throw new
>> > ArgumentNullException("instance");
>> >
>> > - try
>> > - {
>> > - burden = (Burden)instance2Burden[instance];
>> > - if (burden == null)
>> > - return;
>> > + rwLock.EnterUpgradeableReadLock();
>> >
>> > - instance2Burden.Remove(instance);
>> > + try
>> > + {
>> > + var burden = (Burden)
>> > instance2Burden[instance];
>> >
>> > - burden.Release(this);
>> > - }
>> > - finally
>> > - {
>> > - rwLock.DowngradeFromWriterLock(ref cookie);
>> > - }
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseReaderLock();
>> > - }
>> > - }
>> > + if (burden == null)
>> > + return;
>> >
>> > - public void Dispose()
>> > - {
>> > - rwLock.AcquireWriterLock(Timeout.Infinite);
>> > - try
>> > - {
>> > + rwLock.EnterWriteLock();
>> > +
>> > + try
>> > + {
>> > + burden = (Burden)
>> > instance2Burden[instance];
>> > + if (burden == null)
>> > + return;
>> > +
>> > +
>> > instance2Burden.Remove(instance);
>> > +
>> > + burden.Release(this);
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitWriteLock();
>> > + }
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitUpgradeableReadLock();
>> > + }
>> > + }
>> > +
>> > + public void Dispose()
>> > + {
>> > + rwLock.EnterWriteLock();
>> > +
>> > + try
>> > + {
>> > Burden[] burdens = new
>> > Burden[instance2Burden.Count];
>> > instance2Burden.Values.CopyTo(burdens,
>> > 0);
>> >
>> > - foreach (Burden burden in burdens)
>> > - {
>> > + foreach(Burden burden in burdens)
>> > + {
>> > if
>> > (instance2Burden.Contains(burden))
>> > {
>> > burden.Release(this);
>> >
>> > instance2Burden.Remove(burden);
>> > }
>> > - }
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseWriterLock();
>> > - }
>> > - }
>> > - }
>> > -}
>> > + }
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitWriteLock();
>> > + }
>> > + }
>> > + }
>> > +}
>> >
>> > Directory: /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
>> > ==================================================================
>> >
>> > File [modified]: AllComponentsReleasePolicy.cs
>> > Delta lines: +0 -0
>> > ===================================================================
>> >
>> >
>> >
>> >
>> >
>> > >
>> >
>>
>>
>>
>> --
>> Cheers,
>> hammett
>> http://hammett.castleproject.org/
>>
>>
>
>
>
> --

> Ken Egozi.
> http://www.kenegozi.com/blog
> http://www.musicglue.com
> http://www.castleproject.org
> http://www.gotfriends.co.il
>
> >
>

--

Cheers,
hammett
http://hammett.castleproject.org/

--
Ken Egozi.
http://www.kenegozi.com/blog
http://www.musicglue.com
http://www.castleproject.org
http://www.gotfriends.co.il

From forum: Castle Dev

Re: [hammett commit: 5376]: /trunk/InversionOfControl/Castle.MicroKernel/

2008-10-12T09:48:52Z

Was it? This kinda sucks as our "competitors" can take dependency on
3.5, and there's 4.0 under the way.
Having compatibility with older frameworks takes much of the fun of
OSS as a place for experimentations.

On Sun, Oct 12, 2008 at 9:38 AM, Ken Egozi <egozi13@...> wrote:

> wasn't the vote on
> 1. getting rid of 2005 projects
> and
> 2. allowing c#3 language features that can compile to 2.0 (like var and
> initialisers), but *not* System.Core/System.Linq etc
>
> On Sun, Oct 12, 2008 at 6:35 PM, hammett <hammett@...> wrote:
>>
>> I thought we have held a vote on that recently...
>>
>> On Sun, Oct 12, 2008 at 5:25 AM, Ayende Rahien <ayende@...> wrote:
>> > This ties the castle code base to .NET 3.5, was this intentional?
>> >
>> > ---------- Forwarded message ----------
>> > From: <notification@...>
>> > Date: Sun, Oct 12, 2008 at 7:04 AM
>> > Subject: [hammett commit: 5376]:
>> > /trunk/InversionOfControl/Castle.MicroKernel/
>> > To: castle-project-commits@...
>> >
>> >
>> >
>> > User: hammett
>> > Date: 2008/10/11 10:04 PM
>> >
>> > Modified:
>> > /trunk/InversionOfControl/Castle.MicroKernel/
>> > Castle.MicroKernel-vs2008.csproj
>> > /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
>> > AllComponentsReleasePolicy.cs
>> >
>> > Log:
>> > Changed to use ReaderWriterLockSlim - see
>> >
>> > http://www.bluebytesoftware.com/blog/PermaLink,guid,c4ea3d6d-190a-48f8-a677-44a438d8386b.aspx
>> >
>> > File Changes:
>> >
>> > Directory: /trunk/InversionOfControl/Castle.MicroKernel/
>> > ========================================================
>> >
>> > File [modified]: Castle.MicroKernel-vs2008.csproj
>> > Delta lines: +83 -79
>> > ===================================================================
>> >
>> > ---
>> >
>> > trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleasePolicy.cs
>> > 2008-10-10 23:14:31 UTC (rev 5375)
>> > +++
>> >
>> > trunk/InversionOfControl/Castle.MicroKernel/Releasers/AllComponentsReleasePolicy.cs
>> > 2008-10-12 05:04:37 UTC (rev 5376)
>> > @@ -12,103 +12,107 @@
>> > // See the License for the specific language governing permissions and
>> > // limitations under the License.
>> >
>> > -using System.Threading;
>> > -
>> > namespace Castle.MicroKernel.Releasers
>> > {
>> > - using System;
>> > - using System.Collections;
>> > + using System;
>> > + using System.Collections;
>> > + using System.Threading;
>> >
>> > - [Serializable]
>> > - public class AllComponentsReleasePolicy : IReleasePolicy
>> > - {
>> > - private readonly IDictionary instance2Burden =
>> > - new Hashtable(new Util.ReferenceEqualityComparer());
>> > + [Serializable]
>> > + public class AllComponentsReleasePolicy : IReleasePolicy
>> > + {
>> > + private readonly IDictionary instance2Burden =
>> > + new Hashtable(new
>> > Util.ReferenceEqualityComparer());
>> >
>> > - readonly ReaderWriterLock rwLock = new ReaderWriterLock();
>> > + private readonly ReaderWriterLockSlim rwLock = new
>> > ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
>> >
>> > - public virtual void Track(object instance, Burden burden)
>> > - {
>> > - rwLock.AcquireWriterLock(Timeout.Infinite);
>> > - try
>> > - {
>> > - instance2Burden[instance] = burden;
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseWriterLock();
>> > - }
>> > - }
>> > + public virtual void Track(object instance, Burden
>> > burden)
>> > + {
>> > + rwLock.EnterWriteLock();
>> >
>> > - public bool HasTrack(object instance)
>> > - {
>> > - if (instance == null) throw new
>> > ArgumentNullException("instance");
>> > - rwLock.AcquireReaderLock(Timeout.Infinite);
>> > - try
>> > - {
>> > - return instance2Burden.Contains(instance);
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseReaderLock();
>> > - }
>> > - }
>> > + try
>> > + {
>> > + instance2Burden[instance] = burden;
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitWriteLock();
>> > + }
>> > + }
>> >
>> > - public void Release(object instance)
>> > - {
>> > - if (instance == null) throw new
>> > ArgumentNullException("instance");
>> > - rwLock.AcquireReaderLock(Timeout.Infinite);
>> > - try
>> > - {
>> > - var burden = (Burden)instance2Burden[instance];
>> > + public bool HasTrack(object instance)
>> > + {
>> > + if (instance == null) throw new
>> > ArgumentNullException("instance");
>> >
>> > - if (burden == null)
>> > - return;
>> > + rwLock.EnterReadLock();
>> > + try
>> > + {
>> > + return
>> > instance2Burden.Contains(instance);
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitReadLock();
>> > + }
>> > + }
>> >
>> > - LockCookie cookie =
>> > rwLock.UpgradeToWriterLock(Timeout.Infinite);
>> > + public void Release(object instance)
>> > + {
>> > + if (instance == null) throw new
>> > ArgumentNullException("instance");
>> >
>> > - try
>> > - {
>> > - burden = (Burden)instance2Burden[instance];
>> > - if (burden == null)
>> > - return;
>> > + rwLock.EnterUpgradeableReadLock();
>> >
>> > - instance2Burden.Remove(instance);
>> > + try
>> > + {
>> > + var burden = (Burden)
>> > instance2Burden[instance];
>> >
>> > - burden.Release(this);
>> > - }
>> > - finally
>> > - {
>> > - rwLock.DowngradeFromWriterLock(ref cookie);
>> > - }
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseReaderLock();
>> > - }
>> > - }
>> > + if (burden == null)
>> > + return;
>> >
>> > - public void Dispose()
>> > - {
>> > - rwLock.AcquireWriterLock(Timeout.Infinite);
>> > - try
>> > - {
>> > + rwLock.EnterWriteLock();
>> > +
>> > + try
>> > + {
>> > + burden = (Burden)
>> > instance2Burden[instance];
>> > + if (burden == null)
>> > + return;
>> > +
>> > +
>> > instance2Burden.Remove(instance);
>> > +
>> > + burden.Release(this);
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitWriteLock();
>> > + }
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitUpgradeableReadLock();
>> > + }
>> > + }
>> > +
>> > + public void Dispose()
>> > + {
>> > + rwLock.EnterWriteLock();
>> > +
>> > + try
>> > + {
>> > Burden[] burdens = new
>> > Burden[instance2Burden.Count];
>> > instance2Burden.Values.CopyTo(burdens,
>> > 0);
>> >
>> > - foreach (Burden burden in burdens)
>> > - {
>> > + foreach(Burden burden in burdens)
>> > + {
>> > if
>> > (instance2Burden.Contains(burden))
>> > {
>> > burden.Release(this);
>> >
>> > instance2Burden.Remove(burden);
>> > }
>> > - }
>> > - }
>> > - finally
>> > - {
>> > - rwLock.ReleaseWriterLock();
>> > - }
>> > - }
>> > - }
>> > -}
>> > + }
>> > + }
>> > + finally
>> > + {
>> > + rwLock.ExitWriteLock();
>> > + }
>> > + }
>> > + }
>> > +}
>> >
>> > Directory: /trunk/InversionOfControl/Castle.MicroKernel/Releasers/
>> > ==================================================================
>> >
>> > File [modified]: AllComponentsReleasePolicy.cs
>> > Delta lines: +0 -0
>> > ===================================================================
>> >
>> >
>> >
>> >
>> >
>> > >
>> >
>>
>>
>>
>> --
>> Cheers,
>> hammett
>> http://hammett.castleproject.org/
>>
>>
>
>
>
> --
> Ken Egozi.
> http://www.kenegozi.com/blog
> http://www.musicglue.com
> http://www.castleproject.org
> http://www.gotfriends.co.il
>
> >
>

--
Cheers,
hammett
http://hammett.castleproject.org/

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To post to this group, send email to castle-project-devel@...
To unsubscribe from this group, send email to castle-project-devel+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en
-~----------~----~----~----~------~----~------~--~---

From forum: Castle Dev