Bugs in i18n Library

4 Messages Forum Options Options
Permalink
olivier.ligot
Bugs in i18n Library
Reply Threaded More
Print post
Permalink
Hello,

I'm extending the i18n library with a new file format and during the
process, I found the two following bugs :

1) The postcondition of {I18N_FILE_HANDLER}.get_file_dictionary should
be :

handled_if_can_handle: can_handle (a_path) implies handled
next_handeld: (not can_handle (a_path)) and then next /= Void
implies handled = next.handled
not_handeled: (not can_handle (a_path)) and then next = Void
implies not handled

instead of
can_handle(a_path) implies handled
not (can_handle(a_path) and then next /= Void) implies handled =
next.handled
not (can_handle(a_path) and then next = Void) implies not handled

2) {I18N_FILE_MANAGER}.dictionary should use
chain.get_file_dictionary (...)
instead of
chain.extract_dictionary (...)

Olivier Ligot


------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/eiffel_software/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/eiffel_software/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:eiffel_software-digest@...
    mailto:eiffel_software-fullfeatured@...

<*> To unsubscribe from this group, send an email to:
    eiffel_software-unsubscribe@...

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

Ted-47
Re: Bugs in i18n Library
Reply Threaded More
Print post
Permalink
Hi, Olivier,

Your changes has been integrated into the trunk.
Thank you.

Ted

--- In eiffel_software@..., "olivier.ligot"
<olivier.ligot@...> wrote:

>
> Hello,
>
> I'm extending the i18n library with a new file format and during the
> process, I found the two following bugs :
>
> 1) The postcondition of {I18N_FILE_HANDLER}.get_file_dictionary should
> be :
>
> handled_if_can_handle: can_handle (a_path) implies handled
> next_handeld: (not can_handle (a_path)) and then next /= Void
> implies handled = next.handled
> not_handeled: (not can_handle (a_path)) and then next = Void
> implies not handled
>
> instead of
> can_handle(a_path) implies handled
> not (can_handle(a_path) and then next /= Void) implies handled =
> next.handled
> not (can_handle(a_path) and then next = Void) implies not handled
>
> 2) {I18N_FILE_MANAGER}.dictionary should use
> chain.get_file_dictionary (...)
> instead of
> chain.extract_dictionary (...)
>
> Olivier Ligot
>



------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/eiffel_software/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/eiffel_software/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:eiffel_software-digest@...
    mailto:eiffel_software-fullfeatured@...

<*> To unsubscribe from this group, send an email to:
    eiffel_software-unsubscribe@...

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

olivier.ligot
Re: Bugs in i18n Library
Reply Threaded More
Print post
Permalink
One more:

The arguments in {I18N_DUMMY_DICTIONARY}.has_plural,
{I18N_DUMMY_DICTIONARY}.singular and {I18N_DUMMY_DICTIONARY}.plural
should contain STRING_GENERAL instead of STRING_32, as declared in the
parent I18N_DICTIONARY. Otherwise, EiffelStudio 6.2 will detect a
catcall at runtime.

Best regards,

Olivier Ligot


------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/eiffel_software/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/eiffel_software/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:eiffel_software-digest@...
    mailto:eiffel_software-fullfeatured@...

<*> To unsubscribe from this group, send an email to:
    eiffel_software-unsubscribe@...

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

Ted-47
Re: Bugs in i18n Library
Reply Threaded More
Print post
Permalink
Indeed. The fix has been committed. Thanks Olivier.

Ted

--- In eiffel_software@..., "olivier.ligot"
<olivier.ligot@...> wrote:

>
> One more:
>
> The arguments in {I18N_DUMMY_DICTIONARY}.has_plural,
> {I18N_DUMMY_DICTIONARY}.singular and {I18N_DUMMY_DICTIONARY}.plural
> should contain STRING_GENERAL instead of STRING_32, as declared in the
> parent I18N_DICTIONARY. Otherwise, EiffelStudio 6.2 will detect a
> catcall at runtime.
>
> Best regards,
>
> Olivier Ligot
>



------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/eiffel_software/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/eiffel_software/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:eiffel_software-digest@...
    mailto:eiffel_software-fullfeatured@...

<*> To unsubscribe from this group, send an email to:
    eiffel_software-unsubscribe@...

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/