Bug in dlmwrite.m (patch attached)

[Matt Foster-6]

Hi,

I found a small bug in octave-forge's dlmwrite.m, whereby it wouldn't accept 'delim', as an option.
I've made a patch against SVN head, and it's attached.

Please let me known If i should send this elsewhere.

Cheers,
Matt

--
Matt Foster | http://my-mili.eu/matt

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Jaroslav Hajek-2]

On Mon, Jun 23, 2008 at 12:35 PM, Matt Foster <matt.p.foster@...> wrote:
> Hi,
>
> I found a small bug in octave-forge's dlmwrite.m, whereby it wouldn't accept
> 'delim', as an option.
> I've made a patch against SVN head, and it's attached.
>
> Please let me known If i should send this elsewhere.
>

OctaveForge has a mailing list of its own: <octave-dev@...>.
I've applied your patch.

regards

> Cheers,
> Matt
>
> --
> Matt Foster | http://my-mili.eu/matt
> _______________________________________________
> Bug-octave mailing list
> Bug-octave@...
> https://www.cae.wisc.edu/mailman/listinfo/bug-octave
>
>

--
RNDr. Jaroslav Hajek
computing expert
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[David Bateman]

Jaroslav Hajek wrote:

> On Mon, Jun 23, 2008 at 12:35 PM, Matt Foster <matt.p.foster@...> wrote:
>  
>> Hi,
>>
>> I found a small bug in octave-forge's dlmwrite.m, whereby it wouldn't accept
>> 'delim', as an option.
>> I've made a patch against SVN head, and it's attached.
>>
>> Please let me known If i should send this elsewhere.
>>
>>    
>
> OctaveForge has a mailing list of its own: <octave-dev@...>.
> I've applied your patch.
>
> regards
>
>  
>  

But dlmwrite was imported into Octave 3.1.x so sending it to
bug@... is also reasonable.. However, looking at

http://www.mathworks.com/access/helpdesk/help/techdoc/index.html?/access/helpdesk/help/techdoc/ref/dlmwrite.html

"delim" is not documented as a valid option to dlmwrite for matlab and
so I don't see this as compatibility issue. Sure we might accept "delim"
as well, but is it necessary?

D.

--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Jaroslav Hajek-2]

On Mon, Jun 23, 2008 at 1:50 PM, David Bateman
<David.Bateman@...> wrote:

> Jaroslav Hajek wrote:
>> On Mon, Jun 23, 2008 at 12:35 PM, Matt Foster <matt.p.foster@...> wrote:
>>
>>> Hi,
>>>
>>> I found a small bug in octave-forge's dlmwrite.m, whereby it wouldn't accept
>>> 'delim', as an option.
>>> I've made a patch against SVN head, and it's attached.
>>>
>>> Please let me known If i should send this elsewhere.
>>>
>>>
>>
>> OctaveForge has a mailing list of its own: <octave-dev@...>.
>> I've applied your patch.
>>
>> regards
>>
>>
>>
>
> But dlmwrite was imported into Octave 3.1.x so sending it to
> bug@... is also reasonable.. However, looking at
>
> http://www.mathworks.com/access/helpdesk/help/techdoc/index.html?/access/helpdesk/help/techdoc/ref/dlmwrite.html
>
> "delim" is not documented as a valid option to dlmwrite for matlab and
> so I don't see this as compatibility issue. Sure we might accept "delim"
> as well, but is it necessary?
>

Hm, I see I was too rush. Based on the fact that OP identified this as
a "bug", I thought this was a missing documented Matlab feature. Sigh.
Nevertheless, given that dlmwrite was taken into Octave (which I
forgot), the OctaveForge version should probably be removed as soon as
it is first released in Octave.

> D.
>
> --
> David Bateman                                David.Bateman@...
> Motorola Labs - Paris                        [phone] (Ph)
> Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
> 91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)
>
> The information contained in this communication has been classified as:
>
> [x] General Business Information
> [ ] Motorola Internal Use Only
> [ ] Motorola Confidential Proprietary
>
>

--
RNDr. Jaroslav Hajek
computing expert
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[David Bateman]

Jaroslav Hajek wrote:

> On Mon, Jun 23, 2008 at 1:50 PM, David Bateman
> <David.Bateman@...> wrote:
>  
>> Jaroslav Hajek wrote:
>>    
>>> On Mon, Jun 23, 2008 at 12:35 PM, Matt Foster <matt.p.foster@...> wrote:
>>>
>>>      
>>>> Hi,
>>>>
>>>> I found a small bug in octave-forge's dlmwrite.m, whereby it wouldn't accept
>>>> 'delim', as an option.
>>>> I've made a patch against SVN head, and it's attached.
>>>>
>>>> Please let me known If i should send this elsewhere.
>>>>
>>>>
>>>>        
>>> OctaveForge has a mailing list of its own: <octave-dev@...>.
>>> I've applied your patch.
>>>
>>> regards
>>>
>>>
>>>
>>>      
>> But dlmwrite was imported into Octave 3.1.x so sending it to
>> bug@... is also reasonable.. However, looking at
>>
>> http://www.mathworks.com/access/helpdesk/help/techdoc/index.html?/access/helpdesk/help/techdoc/ref/dlmwrite.html
>>
>> "delim" is not documented as a valid option to dlmwrite for matlab and
>> so I don't see this as compatibility issue. Sure we might accept "delim"
>> as well, but is it necessary?
>>
>>    
>
> Hm, I see I was too rush. Based on the fact that OP identified this as
> a "bug", I thought this was a missing documented Matlab feature. Sigh.
> Nevertheless, given that dlmwrite was taken into Octave (which I
> forgot), the OctaveForge version should probably be removed as soon as
> it is first released in Octave.
>
>  
>

cf.

http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/TODO?revision=HEAD&view=markup

where it states

<quote>
When transitioning to Octave 3.1
================================
* Remove the functions gtext, ginput, waitforbuttonpress, hex2num, num2hex,
dlmread, dlmwrite, csvread, csvwrite
* Remove dependency of ga on miscellaneous
</quote>

D.

--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Matt Foster-6]

> OctaveForge has a mailing list of its own: <octave-dev@...>.
> I've applied your patch.

Thanks, I'll subscribe there.

Cheers,

Matt
--
Matt Foster | http://my-mili.eu/matt
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Matt Foster-6]

On Mon, Jun 23, 2008 at 12:50 PM, David Bateman
<David.Bateman@...> wrote:
> http://www.mathworks.com/access/helpdesk/help/techdoc/index.html?/access/helpdesk/help/techdoc/ref/dlmwrite.html
>
> "delim" is not documented as a valid option to dlmwrite for matlab and
> so I don't see this as compatibility issue. Sure we might accept "delim"
> as well, but is it necessary?
>

It's probably not necessary, but it is listed at the top of the function's help.

Cheers,
Matt
--
Matt Foster | http://my-mili.eu/matt
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[David Bateman]

Matt Foster wrote:

> On Mon, Jun 23, 2008 at 12:50 PM, David Bateman
> <David.Bateman@...> wrote:
>  
>> http://www.mathworks.com/access/helpdesk/help/techdoc/index.html?/access/helpdesk/help/techdoc/ref/dlmwrite.html
>>
>> "delim" is not documented as a valid option to dlmwrite for matlab and
>> so I don't see this as compatibility issue. Sure we might accept "delim"
>> as well, but is it necessary?
>>
>>    
>
> It's probably not necessary, but it is listed at the top of the function's help.
>  

No "delim" in the help text of the function is a variable as in texinfo
its flagged as "@var{delim}", and its the means of passing the delimiter
without defining what the option type is. That is

dlmwrite (file, a, "\t")

is the same as

dlmwrite (file, a, "delimiter", "\t")

The use of @var{} is a standard convention in Octave help strings to
define the difference between a variable and an option string.

D.


--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary

_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave

[Matt Foster-6]

On Mon, Jun 23, 2008 at 1:31 PM, David Bateman
<David.Bateman@...> wrote:

>
> No "delim" in the help text of the function is a variable as in texinfo
> its flagged as "@var{delim}", and its the means of passing the delimiter
> without defining what the option type is. That is
>
> dlmwrite (file, a, "\t")
>
> is the same as
>
> dlmwrite (file, a, "delimiter", "\t")
>
> The use of @var{} is a standard convention in Octave help strings to
> define the difference between a variable and an option string.
>
> D.

Ahhh, I see. I misunderstood the help. Thanks for the explanation.

Sorry for all the fuss!

Matt

--
Matt Foster | http://my-mili.eu/matt
_______________________________________________
Bug-octave mailing list
Bug-octave@...
https://www.cae.wisc.edu/mailman/listinfo/bug-octave