Bug in Spinner Widget

View: New views
4 Messages — Rating Filter:   Alert me  

Bug in Spinner Widget

by Fink, Andreas :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

the Spinner Widget still uses a deprecated method of the ChangeEvent
(getOldData()) in line 710.
It seems that the Method was removed from the framework, so the Spinner
won't work anymore.

I've added a patch.

Greetings,
Andreas


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@...
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Spinner.patch (444 bytes) Download Attachment

Re: Bug in Spinner Widget

by Alexander Back :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Andreas,

many thanks for the patch. However, this is already fixed in the
legacy_0_7_x branch and will be included in the upcoming release 0.7.4 :-)

cheers,
   Alex

Fink, Andreas wrote:

> Hi,
>
> the Spinner Widget still uses a deprecated method of the ChangeEvent
> (getOldData()) in line 710.
> It seems that the Method was removed from the framework, so the Spinner
> won't work anymore.
>
> I've added a patch.
>
> Greetings,
> Andreas

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@...
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Re: Bug in Spinner Widget

by Fink, Andreas :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Alex,

I've forgotten to mention that I'm working with the legacy_0_7_x branch and the bug is still there.
Please have a look at the diff of Revision 14405 the fix you mentioned was reverted there.

Greetings,
Andreas

-----Ursprüngliche Nachricht-----
Von: qooxdoo-devel-bounces@... [mailto:qooxdoo-devel-bounces@...] Im Auftrag von Alexander Back
Gesendet: Donnerstag, 10. Juli 2008 14:40
An: qooxdoo Development
Betreff: Re: [qooxdoo-devel] Bug in Spinner Widget

Hi Andreas,

many thanks for the patch. However, this is already fixed in the
legacy_0_7_x branch and will be included in the upcoming release 0.7.4 :-)

cheers,
   Alex

Fink, Andreas wrote:

> Hi,
>
> the Spinner Widget still uses a deprecated method of the ChangeEvent
> (getOldData()) in line 710.
> It seems that the Method was removed from the framework, so the Spinner
> won't work anymore.
>
> I've added a patch.
>
> Greetings,
> Andreas

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@...
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@...
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Re: Bug in Spinner Widget

by Alexander Back :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Andreas,

you're absolutely right with the bug. I've just committed your patch.
Please update your sources.

Thanks for the patch!

cheers,
   Alex

Fink, Andreas wrote:

> Hi Alex,
>
> I've forgotten to mention that I'm working with the legacy_0_7_x branch and the bug is still there.
> Please have a look at the diff of Revision 14405 the fix you mentioned was reverted there.
>
> Greetings,
> Andreas
>
> -----Ursprüngliche Nachricht-----
> Von: qooxdoo-devel-bounces@... [mailto:qooxdoo-devel-bounces@...] Im Auftrag von Alexander Back
> Gesendet: Donnerstag, 10. Juli 2008 14:40
> An: qooxdoo Development
> Betreff: Re: [qooxdoo-devel] Bug in Spinner Widget
>
> Hi Andreas,
>
> many thanks for the patch. However, this is already fixed in the
> legacy_0_7_x branch and will be included in the upcoming release 0.7.4 :-)
>
> cheers,
>    Alex
>
> Fink, Andreas wrote:
>> Hi,
>>
>> the Spinner Widget still uses a deprecated method of the ChangeEvent
>> (getOldData()) in line 710.
>> It seems that the Method was removed from the framework, so the Spinner
>> won't work anymore.
>>
>> I've added a patch.
>>
>> Greetings,
>> Andreas

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@...
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel