Bug 60030

Hi,

I just took a look at bug 60030
(http://bugs.kde.org/show_bug.cgi?id=60030) and then at the relevant
code.
The reason of the bug is as easy as slotStop() being called on line
3247 in konqmainwindow.cpp.

The attached patch simply removes this line.

// Linus Östberg

[unstoploading.diff]

---

Index: konqmainwindow.cpp
===================================================================
--- konqmainwindow.cpp (revision 826036)
+++ konqmainwindow.cpp (working copy)
@@ -3244,7 +3244,6 @@
 
 void KonqMainWindow::slotClearLocationBar()
 {
-    slotStop();
     m_combo->clearTemporary();
     focusLocationBar();
 }

---

On Sunday 29 June 2008, Linus Östberg wrote:
> Hi,
>
> I just took a look at bug 60030
> (http://bugs.kde.org/show_bug.cgi?id=60030) and then at the relevant
> code.
> The reason of the bug is as easy as slotStop() being called on line
> 3247 in konqmainwindow.cpp.
>
> The attached patch simply removes this line.

I had a look at the reason why this line was added using svn annotate,
and the answer is: it was added by Dirk Mueller as a fix for the case
where a website constantly redirects to itself, so the user cannot type anything
in the location bar, since it keeps being overwritten by the website.

However if a call to slotStop is enough to make the redirect-craziness stop,
then surely the user could hit the stop button before typing the URL, I suppose?
I think this needs to be retested... If hitting stop is enough to gain control over
the location bar again, then I agree with remove the automatic clear-calls-stop
which is indeed very unexpected when a download is going on.

--
David Faure, faure@..., sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).