Bug#489906: glibc: tst-regex fails on hppa

[Aurelien Jarno-2]

Package: libc6
Version: 2.7-12
Severity: critical

tst-regex fails on hppa, which IMHO is not something acceptable for a
release architecture.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libc6 depends on:
ii  libgcc1                       1:4.3.1-2  GCC support library

libc6 recommends no packages.

-- debconf information excluded



--
To UNSUBSCRIBE, email to debian-hppa-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Aurelien Jarno]

Hi,

For those that are not on IRC, I have made a lot of progress on this
bug. The problem comes from the patch any/cvs-strerror_r.diff. However,
this patch looks ok, actually comes from upstream and fix a bug. It
seems it only triggers a lock bug on hppa.

FYI you will find below the part of the patch that causes the problem in
case of tst-regex. It's only a change in the locks type.

Cheers,
Aurelien


--- glibc-2.7.orig/locale/setlocale.c
+++ glibc-2.7/locale/setlocale.c
@@ -123,7 +123,7 @@
 
 
 /* Lock for protecting global data.  */
-__libc_lock_define_initialized (, __libc_setlocale_lock attribute_hidden)
+__libc_rwlock_define_initialized (, __libc_setlocale_lock attribute_hidden)
 
 /* Defined in loadmsgcat.c.  */
 extern int _nl_msg_cat_cntr;
@@ -314,7 +314,7 @@
  }
 
       /* Protect global data.  */
-      __libc_lock_lock (__libc_setlocale_lock);
+      __libc_rwlock_wrlock (__libc_setlocale_lock);
 
       /* Load the new data for each category.  */
       while (category-- > 0)
@@ -381,7 +381,7 @@
     free ((char *) newnames[category]);
 
       /* Critical section left.  */
-      __libc_lock_unlock (__libc_setlocale_lock);
+      __libc_rwlock_unlock (__libc_setlocale_lock);
 
       /* Free the resources (the locale path variable).  */
       free (locale_path);
@@ -394,7 +394,7 @@
       const char *newname[1] = { locale };
 
       /* Protect global data.  */
-      __libc_lock_lock (__libc_setlocale_lock);
+      __libc_rwlock_wrlock (__libc_setlocale_lock);
 
       if (CATEGORY_USED (category))
  {
@@ -446,7 +446,7 @@
  }
 
       /* Critical section left.  */
-      __libc_lock_unlock (__libc_setlocale_lock);
+      __libc_rwlock_unlock (__libc_setlocale_lock);
 
       /* Free the resources (the locale path variable.  */
       free (locale_path);

--
  .''`.  Aurelien Jarno            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@...         | aurelien@...
   `-    people.debian.org/~aurel32 | www.aurel32.net


--
To UNSUBSCRIBE, email to debian-hppa-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Carlos O'Donell-2]

On Tue, Jul 22, 2008 at 4:00 AM, Aurelien Jarno <aurelien@...> wrote:
> For those that are not on IRC, I have made a lot of progress on this
> bug. The problem comes from the patch any/cvs-strerror_r.diff. However,
> this patch looks ok, actually comes from upstream and fix a bug. It
> seems it only triggers a lock bug on hppa.
>
> FYI you will find below the part of the patch that causes the problem in
> case of tst-regex. It's only a change in the locks type.

The only think I can think of is a miscompilation. If you turn down
the optimization to -O1 on that file, does it help?

Cheers,
Carlos.


--
To UNSUBSCRIBE, email to debian-hppa-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Aurelien Jarno]

On Thu, Aug 07, 2008 at 10:27:45AM -0400, Carlos O'Donell wrote:

> On Tue, Jul 22, 2008 at 4:00 AM, Aurelien Jarno <aurelien@...> wrote:
> > For those that are not on IRC, I have made a lot of progress on this
> > bug. The problem comes from the patch any/cvs-strerror_r.diff. However,
> > this patch looks ok, actually comes from upstream and fix a bug. It
> > seems it only triggers a lock bug on hppa.
> >
> > FYI you will find below the part of the patch that causes the problem in
> > case of tst-regex. It's only a change in the locks type.
>
> The only think I can think of is a miscompilation. If you turn down
> the optimization to -O1 on that file, does it help?
>

We have actually solved this bug using a patch from upstream CVS:
http://lists.debian.org/debian-glibc/2008/07/msg00240.html

--
  .''`.  Aurelien Jarno            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@...         | aurelien@...
   `-    people.debian.org/~aurel32 | www.aurel32.net


--
To UNSUBSCRIBE, email to debian-hppa-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...