Bug#487404: dont copy code from laptop-detect

[Petter Reinholdtsen]

This is the code in question from debian-edu-profile that is using the
laptop-detect result:

  # Activate our and Debians Laptop task if a laptop is detected
  if is_laptop; then
    log "Detected a laptop"
    tasksel="${tasksel:+$tasksel, }Laptop, DebianEdu laptop packages"
  else
    log "Did not detect a laptop"
  fi

I guess we could move it to run after base-installer, and avoid the
problem completely.  We would then need to extract the current tasksel
setting and replace it with one including the two laptop tasks.

Testing this code, I discovered that it did not work because
dmidecode-udeb was not installed.  I've added it as a dependency in
svn, fixing it for now, but it might be better to use the installed
laptop-detect instead of tracking these changes ourself.

Happy hacking,
--
Petter Reinholdtsen



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Petter Reinholdtsen]

[Petter Reinholdtsen]
> I guess we could move it to run after base-installer, and avoid the
> problem completely.  We would then need to extract the current
> tasksel setting and replace it with one including the two laptop
> tasks.

A problem with running laptop-detect after base-installer, is that
this make it impossible to adjust the partitioning on laptops.  I
would like us to create encrypted filesystems / LVM physical volumes
on laptops, and for that to work we need to detect laptops very early
in the installation, before base-installer is executed.

Happy hacking,
--
Petter Reinholdtsen



--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Holger Levsen-2]

Hi,

On Saturday 19 July 2008 09:11, Petter Reinholdtsen wrote:
> A problem with running laptop-detect after base-installer, is that
> this make it impossible to adjust the partitioning on laptops.  I
> would like us to create encrypted filesystems / LVM physical volumes
> on laptops, and for that to work we need to detect laptops very early
> in the installation, before base-installer is executed.

While I see this as a valid use-case I think this is a feature for lenny+1.
For lenny I'd suggest to document how to do manual partitioning of
workstation profiles. For standalone this is already the case and easily
possible.


regards,
        Holger