Bug#486030: fbb: bashism in /bin/sh script

[Raphael Geissert-2]

Package: fbb
Severity: important
Version: 7.04j-7
User: debian-release@...
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing one or more /bin/sh scripts making
use of bashisms.

checkbashisms' output:
> possible bashism in ./usr/sbin/fbb line 244 ('$[' should be '$(('):
>                 NB=$[ $NB + 1 ]
> possible bashism in ./usr/sbin/fbb line 272 ('$[' should be '$(('):
>                                 NUMPORT=$[ $NUMPORT + 1 ]
> possible bashism in ./usr/sbin/fbb line 280 ('$[' should be '$(('):
>                                 NB=$[ $NB + 1 ]
> possible bashism in ./usr/sbin/fbb line 310 ('$[' should be '$(('):
>                         NB=$[ $NB + 1 ]

Not using bash (or a Debian Policy conformant shell interpreter which does
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
--
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



--
To UNSUBSCRIBE, email to debian-hams-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Debian Bug Tracking System]

Your message dated Wed, 25 Jun 2008 17:17:03 +0000
with message-id <E1KBYcB-0006AM-Bg@...>
and subject line Bug#486030: fixed in fbb 7.04j-8
has caused the Debian Bug report #486030,
regarding fbb: bashism in /bin/sh script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@...
immediately.)


--
486030: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=486030
Debian Bug Tracking System
Contact owner@... with problems

Package: fbb
Severity: important
Version: 7.04j-7
User: debian-release@...
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing one or more /bin/sh scripts making
use of bashisms.

checkbashisms' output:
> possible bashism in ./usr/sbin/fbb line 244 ('$[' should be '$(('):
>                 NB=$[ $NB + 1 ]
> possible bashism in ./usr/sbin/fbb line 272 ('$[' should be '$(('):
>                                 NUMPORT=$[ $NUMPORT + 1 ]
> possible bashism in ./usr/sbin/fbb line 280 ('$[' should be '$(('):
>                                 NB=$[ $NB + 1 ]
> possible bashism in ./usr/sbin/fbb line 310 ('$[' should be '$(('):
>                         NB=$[ $NB + 1 ]

Not using bash (or a Debian Policy conformant shell interpreter which does
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
--
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



Source: fbb
Source-Version: 7.04j-8

We believe that the bug you reported is fixed in the latest version of
fbb, which is due to be installed in the Debian FTP archive:

fbb_7.04j-8.diff.gz
  to pool/main/f/fbb/fbb_7.04j-8.diff.gz
fbb_7.04j-8.dsc
  to pool/main/f/fbb/fbb_7.04j-8.dsc
fbb_7.04j-8_i386.deb
  to pool/main/f/fbb/fbb_7.04j-8_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 486030@...,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joop Stakenborg <pa3aba@...> (supplier of updated fbb package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@...)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 25 Jun 2008 18:51:19 +0200
Source: fbb
Binary: fbb
Architecture: source i386
Version: 7.04j-8
Distribution: unstable
Urgency: low
Maintainer: Debian Hamradio Maintainers <debian-hams@...>
Changed-By: Joop Stakenborg <pa3aba@...>
Description:
 fbb        - Packet radio mailbox and utilities
Closes: 486030
Changes:
 fbb (7.04j-8) unstable; urgency=low
 .
   * Fix bashism in /bin/sh script. Thanks Manuel Prinz.
     Closes: #486030.
Checksums-Sha1:
 1777ef0c73823f535c2d4b98d4a8dd6394d0b5f4 1120 fbb_7.04j-8.dsc
 fbdbafc7ed82c9e2f796a440af5c42d8aa264886 5534 fbb_7.04j-8.diff.gz
 213c20376fd6dd7026c71462284bc1090bea412f 394536 fbb_7.04j-8_i386.deb
Checksums-Sha256:
 a493703d636304e886e2bc1642af490e7453d86800026f107bc192a9f3da099b 1120 fbb_7.04j-8.dsc
 93cb1da5856b2c9869ecca2cbc3612bb0b8bf3c84a9eb56f5b6983298faf090e 5534 fbb_7.04j-8.diff.gz
 fdc2ef0ac72142791710398bbb657f18bf9246a7106d5634b73442cf58708969 394536 fbb_7.04j-8_i386.deb
Files:
 58f783cc52a38976986abd2e2d1910f4 1120 hamradio optional fbb_7.04j-8.dsc
 ebd5324fd3e2b5c078e81187166c3a8e 5534 hamradio optional fbb_7.04j-8.diff.gz
 c6fb8867178b89eb83b6a2b5d7f3f77f 394536 hamradio optional fbb_7.04j-8_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkhiefAACgkQ/CqtjGLxpX/Z3wCdFKake/jh8WESZR6CikXrkSl7
H+kAn1u1oztB4mslbFqSnrPyQ7upBhyH
=O9lT
-----END PGP SIGNATURE-----