Bug#483655: queue.length assertion failure

[Ian Jackson]

I have reproduced this bug in the course of a routine upgrade to my
main not really very unusual lenny box.  I have a reproduceable test
case for a /var/lib/dpkg.  I'm not attaching that to this bug because
I intend to fix it but if I haven't done so soon please ping me and I
will upload the relevant files.

As a workaround I would recommend
  --abort-after=10000
which managed to get me out of the hole.

Ian.




--
To UNSUBSCRIBE, email to debian-dpkg-bugs-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Raphael Hertzog-3]

On Wed, 02 Jul 2008, Ian Jackson wrote:
> I have reproduced this bug in the course of a routine upgrade to my
> main not really very unusual lenny box.  I have a reproduceable test
> case for a /var/lib/dpkg.  I'm not attaching that to this bug because
> I intend to fix it but if I haven't done so soon please ping me and I
> will upload the relevant files.

Ping. (Yes I believe one should always upload relevant information
immediately, it's a pain to have to remember to ping people later on)

Cheers,
--
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/




--
To UNSUBSCRIBE, email to debian-dpkg-bugs-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Ian Jackson]

tags 483655 + patch
severity 483655 minor

Raphael Hertzog writes ("Re: Bug#483655: queue.length assertion failure"):
> Ping. (Yes I believe one should always upload relevant information
> immediately, it's a pain to have to remember to ping people later on)

Yes, sorry, but I really didn't have time then (I was already late and
was bashing out my mails in a hurry while fixing lots of other stuff
here) and then of course I forgot about it :-(.

I've uploaded it now FWIW at
 http://www.chiark.greenend.org.uk/~ian/2008-07-24/varlibdpkg-483655.tar.gz
but the fix is trivial, and attached.

The assertion (and hence the bug) was introduced by me in my triggers
patch, and it causes this assertion failure whenever (and only when)
dpkg is stopping processing packages (for configure or remove) due to
too many errors.  The assertion is overzealous and should be bypassed
in that case.

Since the only effect is to turn a correct nonzero exit into a
coredump (and incidentally to suppress the intended display of the
list of unprocessed packages) I think this bug is minor.  But it
should be fixed for lenny; it is easy to see that the fix is correct.

Ian.

--- orig2/dpkg-1.14.20/src/packages.c 2008-06-28 15:54:24.000000000 +0100
+++ dpkg-1.14.20/src/packages.c 2008-07-24 00:55:17.000000000 +0100
@@ -233,7 +233,7 @@
       /* give up on it from the point of view of other packages, ie reset istobe */
       pkg->clientdata->istobe= itb_normal;
       error_unwind(ehflag_bombout);
-      if (onerr_abort > 0) break;
+      if (onerr_abort > 0) return;
       continue;
     }
     push_error_handler(&ejbuf,print_error_perpackage,pkg->name);




--
To UNSUBSCRIBE, email to debian-dpkg-bugs-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Debian Bug Tracking System]

Processing commands for control@...:

> tags 483655 + patch
Bug#483655: ../../packages.c:265: process_queue: Assertion 'queue.length' failed.
There were no tags set.
Tags added: patch

> severity 483655 minor
Bug#483655: ../../packages.c:265: process_queue: Assertion 'queue.length' failed.
Severity set to `minor' from `important'

> Raphael Hertzog writes ("Re: Bug#483655: queue.length assertion failure"):
Unknown command or malformed arguments to command.

> > Ping. (Yes I believe one should always upload relevant information
Unknown command or malformed arguments to command.

> > immediately, it's a pain to have to remember to ping people later on)
Unknown command or malformed arguments to command.

> Yes, sorry, but I really didn't have time then (I was already late and
Unknown command or malformed arguments to command.

> was bashing out my mails in a hurry while fixing lots of other stuff
Unknown command or malformed arguments to command.

Too many unknown commands, stopping here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)



--
To UNSUBSCRIBE, email to debian-dpkg-bugs-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...