Bug#369147: GetCache() segfaults if called before InitSystem()

[Josh Triplett-2]

Package: python-apt
Version: 0.6.17

apt_pkg.GetCache() segfaults if called before apt_pkg.InitSystem():

>>> import apt_pkg
>>> apt_pkg.GetCache()
Segmentation fault

It should raise an exception like other functions do:

>>> import apt_pkg
>>> apt_pkg.VersionCompare("1","2")
Traceback (most recent call last):
  File "<stdin>", line 1, in ?
ValueError: _system not initialized

Or alternatively, these functions should change to automatically call
InitSystem() if the caller hasn't already.

- Josh Triplett

[Emanuele Rocca]

tag 369147 patch
thanks

* Josh Triplett <josh@...>, [2006-05-27 13:02 -0700]:

>  apt_pkg.GetCache() segfaults if called before apt_pkg.InitSystem():
>  
>  >>> import apt_pkg
>  >>> apt_pkg.GetCache()
>  Segmentation fault
>  
>  It should raise an exception like other functions do:
>  
>  >>> import apt_pkg
>  >>> apt_pkg.VersionCompare("1","2")
>  Traceback (most recent call last):
>    File "<stdin>", line 1, in ?
>  ValueError: _system not initialized

The attached patch fixes this bug, please consider applying it.

Thanks.
ciao,
    ema

---

diff -Nru python-apt-0.7.6/python/cache.cc python-apt-0.7.6/python/cache.cc
--- python-apt-0.7.6/python/cache.cc    2008-06-17 17:26:33.000000000 +0200
+++ python-apt-0.7.6/python/cache.cc    2008-07-12 19:31:15.000000000 +0200
@@ -928,6 +928,11 @@
    if (PyArg_ParseTuple(Args, "|O", &pyCallbackInst) == 0)
       return 0;
 
+    if (_system == 0) {
+        PyErr_SetString(PyExc_ValueError,"_system not initialized");
+        return 0;
+    }
+
    pkgCacheFile *Cache = new pkgCacheFile();
 
    if(pyCallbackInst != 0) {

---

[Debian Bug Tracking System]

Processing commands for control@...:

> tag 369147 patch
Bug#369147: GetCache() segfaults if called before InitSystem()
There were no tags set.
Tags added: patch

> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


--
To UNSUBSCRIBE, email to deity-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Debian Bug Tracking System]

Your message dated Tue, 22 Jul 2008 14:02:02 +0000
with message-id <E1KLIRG-0000wb-B0@...>
and subject line Bug#369147: fixed in python-apt 0.7.7
has caused the Debian Bug report #369147,
regarding GetCache() segfaults if called before InitSystem()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@...
immediately.)


--
369147: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=369147
Debian Bug Tracking System
Contact owner@... with problems

Package: python-apt
Version: 0.6.17

apt_pkg.GetCache() segfaults if called before apt_pkg.InitSystem():

>>> import apt_pkg
>>> apt_pkg.GetCache()
Segmentation fault

It should raise an exception like other functions do:

>>> import apt_pkg
>>> apt_pkg.VersionCompare("1","2")
Traceback (most recent call last):
  File "<stdin>", line 1, in ?
ValueError: _system not initialized

Or alternatively, these functions should change to automatically call
InitSystem() if the caller hasn't already.

- Josh Triplett



Source: python-apt
Source-Version: 0.7.7

We believe that the bug you reported is fixed in the latest version of
python-apt, which is due to be installed in the Debian FTP archive:

python-apt-dbg_0.7.7_i386.deb
  to pool/main/p/python-apt/python-apt-dbg_0.7.7_i386.deb
python-apt_0.7.7.dsc
  to pool/main/p/python-apt/python-apt_0.7.7.dsc
python-apt_0.7.7.tar.gz
  to pool/main/p/python-apt/python-apt_0.7.7.tar.gz
python-apt_0.7.7_i386.deb
  to pool/main/p/python-apt/python-apt_0.7.7_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 369147@...,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@...> (supplier of updated python-apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@...)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 22 Jul 2008 10:16:03 +0200
Source: python-apt
Binary: python-apt python-apt-dbg
Architecture: source i386
Version: 0.7.7
Distribution: unstable
Urgency: low
Maintainer: APT Development Team <deity@...>
Changed-By: Michael Vogt <mvo@...>
Description:
 python-apt - Python interface to libapt-pkg
 python-apt-dbg - Python interface to libapt-pkg (debug extension)
Closes: 257007 369147 487673
Changes:
 python-apt (0.7.7) unstable; urgency=low
 .
   [ Emanuele Rocca ]
   * data/templates/Debian.info.in:
     - s/MatchUri/MatchURI/. Thanks, Gustavo Noronha Silva (closes: #487673)
   * python/cache.cc:
     - Throw an exception rather than segfaulting when GetCache() is called
       before InitSystem() (closes: #369147)
   * doc/examples/config.py:
     - Fix config.py --help (closes: #257007)
 .
   [ Michael Vogt ]
   * python/apt_pkgmodule.cc:
     - fix bug in hashsum calculation when the original string
       contains \0 charackters (thanks to Celso Providelo and
       Ryan Hass for the test-case) LP: #243630
   * tests/test_hashsums.py:
     - add tests for the hashsum code
   * apt/package.py:
     - add "isAutoRemovable()" method
   * python/pkgsrcrecords.cc:
     - add "Record" attribute to the PkgSrcRecord to access the
       full source record
   * debian/rules:
     - remove the arch-build target, we have bzr-builddeb now
Checksums-Sha1:
 31ad3056958abaa94e843c9afc18752f8b9d6dda 1035 python-apt_0.7.7.dsc
 c13a52ecd34a3f5898e50bcf26f6f9a23bde6339 638372 python-apt_0.7.7.tar.gz
 bd1df2a4625b7690a8800e2a585a7f7b9fa4c7fd 216430 python-apt_0.7.7_i386.deb
 a93fe1041472f9cd77f5dcdf79241a324d443776 1436524 python-apt-dbg_0.7.7_i386.deb
Checksums-Sha256:
 410c25c12c89827ce38c78a12f42d159cc83c83a11d2dcacd0f323c345342ce4 1035 python-apt_0.7.7.dsc
 365f44806a17e39ceb0562f4c10768dd764dc80eb1722c266354a23162dcca55 638372 python-apt_0.7.7.tar.gz
 089c6e2682a4b399b17a044f6dc1e214f8a46f61e87fdd77425bfeec3a28dcf1 216430 python-apt_0.7.7_i386.deb
 136c0aa1b0166512b648837535f521bf7cf74af30cfb097210076e88806ff0b7 1436524 python-apt-dbg_0.7.7_i386.deb
Files:
 dc7d717bb7478fed6e3ab409964573a9 1035 python optional python-apt_0.7.7.dsc
 114f31662b31b5f5d40601413508b98c 638372 python optional python-apt_0.7.7.tar.gz
 b1ad38e32124de1e44f3c98f240f4b46 216430 python optional python-apt_0.7.7_i386.deb
 72a5872e29a95922999f1188b7aa9b33 1436524 python extra python-apt-dbg_0.7.7_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiF5yYACgkQliSD4VZixzSgVACeI1EYO34q8xCnjJjzukZPJlEU
CLsAni98kykj9nl8taop+S6mpeoFmYC4
=aUEs
-----END PGP SIGNATURE-----