Beta DKIM Reputation Spamassassin Plugin

[Florian Sager]

Hi,

I wrote a Spamassassin DKIM Reputation Plugin that uses the output
of the DKIM Plugin to request reputation data from our DNS zones at http://www.dkim-reputation.org, you can download it here: http://www.agitos.de/dkim-reputation.org-dns-data.html

Is there anybody with plugin development experience who could review my
code? Just to be sure before a proposal to
http://wiki.apache.org/spamassassin/CustomPlugins (furthermore we will
setup a Secondary DNS in the US on sponsored hardware in the next days -
... so it's not made for production use until end of September I think).

Points to check:

- the plugin was developed with Spamassassin 3.1.7. Since 3.2.4 the DKIM plugin supports multiple signatures: I prepared the DKIM Reputation Plugin for that but there is no switch yet to differ between versions: how to get the spamassassin version number at runtime?

- the (2) DKIM Reputation Plugin has to be executed after the (1) DKIM Plugin: I experienced with some configs loadplugin (1), loadplugin (2) that execution was in the order (2), (1): why that?


FYI I: at time the main purpose of dkim-reputation.org is to send ARF
reports to DKIM signing ISPs. Blocking of senders with DNS reputation
data is an additional purpose now. If you like to get ARF reports, contact me directly.

FYI II: For the measurement of alleged ISP domains I scripted a small Spamassassin-Plugin some months before: http://www.agitos.de/pub/ReportDomainHit.pm with which a participant
reports alleged sender domains to our UDP logging server.
Some of you joined this measurement, thanks a lot!

Flo

[Dave Brondsema]

Hi Florian,

I'm not an plugin development expert, but have made 2 of my own.  I
appreciate you sharing yours here.  There isn't much documentation or
examples of how to write plugins, so it's very useful to look at someone
else's.  Here are the 2 that I wrote:

http://search.cpan.org/~brondsem/Mail-SpamAssassin-Plugin-OpenPGP-1.0.4/lib/Mail/SpamAssassin/Plugin/OpenPGP.pm

http://search.cpan.org/~brondsem/Mail-SpamAssassin-Plugin-Konfidi-1.0.1/lib/Mail/SpamAssassin/Plugin/Konfidi.pm

There are unit tests and acceptance tests for those plugins too, which
could be useful examples for you.

Florian Sager wrote:

> Hi,
>
> I wrote a Spamassassin DKIM Reputation Plugin that uses the output of
> the DKIM Plugin to request reputation data from our DNS zones at
> http://www.dkim-reputation.org, you can download it here:
> http://www.agitos.de/dkim-reputation.org-dns-data.html
>
> Is there anybody with plugin development experience who could review my
> code? Just to be sure before a proposal to
> http://wiki.apache.org/spamassassin/CustomPlugins (furthermore we will
> setup a Secondary DNS in the US on sponsored hardware in the next days -
> ... so it's not made for production use until end of September I think).
>
> Points to check:
>
> - the plugin was developed with Spamassassin 3.1.7. Since 3.2.4 the DKIM
> plugin supports multiple signatures: I prepared the DKIM Reputation
> Plugin for that but there is no switch yet to differ between versions:
> how to get the spamassassin version number at runtime?
>
> - the (2) DKIM Reputation Plugin has to be executed after the (1) DKIM
> Plugin: I experienced with some configs loadplugin (1), loadplugin (2)
> that execution was in the order (2), (1): why that?
>
>
> FYI I: at time the main purpose of dkim-reputation.org is to send ARF
> reports to DKIM signing ISPs. Blocking of senders with DNS reputation
> data is an additional purpose now. If you like to get ARF reports,
> contact me directly.
>
> FYI II: For the measurement of alleged ISP domains I scripted a small
> Spamassassin-Plugin some months before:
> http://www.agitos.de/pub/ReportDomainHit.pm with which a participant
> reports alleged sender domains to our UDP logging server.
> Some of you joined this measurement, thanks a lot!
>
> Flo
>
>

--
Dave Brondsema : dave@...
http://www.brondsema.net : personal
http://www.splike.com : programming
               <><

[Florian Sager]

Hi,

I published new SpamAssassin DKIM Reputation Plugins at
http://www.agitos.de/dkim-reputation.org-dns-data.html
This time the downloads accord to different preceding DKIM.pm versions.
The README includes more information about the project.
Your testing feedback is highly appreciated.

---

BTW: Since SpamAssassin 3.2.0
$plugin->register_method_priority($methodname, $priority) should allow
priorities of plugin methods. This didn't work for me, priority 1 was
not considered (I didn't debug this). To allow method priorities I
propose to use a simple sorting by method names by default (currently
the check methods are taken from a hash by an each statement in random
order).

Flo


Florian Sager schrieb:

> Hi,
>
> I wrote a Spamassassin DKIM Reputation Plugin that uses the output of
> the DKIM Plugin to request reputation data from our DNS zones at
> http://www.dkim-reputation.org, you can download it here:
> http://www.agitos.de/dkim-reputation.org-dns-data.html
>
> Is there anybody with plugin development experience who could review
> my code? Just to be sure before a proposal to
> http://wiki.apache.org/spamassassin/CustomPlugins (furthermore we will
> setup a Secondary DNS in the US on sponsored hardware in the next days
> - ... so it's not made for production use until end of September I
> think).
>
> Points to check:
>
> - the plugin was developed with Spamassassin 3.1.7. Since 3.2.4 the
> DKIM plugin supports multiple signatures: I prepared the DKIM
> Reputation Plugin for that but there is no switch yet to differ
> between versions: how to get the spamassassin version number at runtime?
>
> - the (2) DKIM Reputation Plugin has to be executed after the (1) DKIM
> Plugin: I experienced with some configs loadplugin (1), loadplugin (2)
> that execution was in the order (2), (1): why that?
>
>
> FYI I: at time the main purpose of dkim-reputation.org is to send ARF
> reports to DKIM signing ISPs. Blocking of senders with DNS reputation
> data is an additional purpose now. If you like to get ARF reports,
> contact me directly.
>
> FYI II: For the measurement of alleged ISP domains I scripted a small
> Spamassassin-Plugin some months before:
> http://www.agitos.de/pub/ReportDomainHit.pm with which a participant
> reports alleged sender domains to our UDP logging server.
> Some of you joined this measurement, thanks a lot!
>
> Flo

[Justin Mason]

Florian Sager writes:

> Hi,
>
> I published new SpamAssassin DKIM Reputation Plugins at
> http://www.agitos.de/dkim-reputation.org-dns-data.html
> This time the downloads accord to different preceding DKIM.pm versions.
> The README includes more information about the project.
> Your testing feedback is highly appreciated.
>
> ---
>
> BTW: Since SpamAssassin 3.2.0
> $plugin->register_method_priority($methodname, $priority) should allow
> priorities of plugin methods. This didn't work for me, priority 1 was
> not considered (I didn't debug this). To allow method priorities I
> propose to use a simple sorting by method names by default (currently
> the check methods are taken from a hash by an each statement in random
> order).

hi Florian -- if you send a patch to do this I'll apply it for 3.3.0.
thanks!

--j.

> Flo
>
>
> Florian Sager schrieb:
> > Hi,
> >
> > I wrote a Spamassassin DKIM Reputation Plugin that uses the output of
> > the DKIM Plugin to request reputation data from our DNS zones at
> > http://www.dkim-reputation.org, you can download it here:
> > http://www.agitos.de/dkim-reputation.org-dns-data.html
> >
> > Is there anybody with plugin development experience who could review
> > my code? Just to be sure before a proposal to
> > http://wiki.apache.org/spamassassin/CustomPlugins (furthermore we will
> > setup a Secondary DNS in the US on sponsored hardware in the next days
> > - ... so it's not made for production use until end of September I
> > think).
> >
> > Points to check:
> >
> > - the plugin was developed with Spamassassin 3.1.7. Since 3.2.4 the
> > DKIM plugin supports multiple signatures: I prepared the DKIM
> > Reputation Plugin for that but there is no switch yet to differ
> > between versions: how to get the spamassassin version number at runtime?
> >
> > - the (2) DKIM Reputation Plugin has to be executed after the (1) DKIM
> > Plugin: I experienced with some configs loadplugin (1), loadplugin (2)
> > that execution was in the order (2), (1): why that?
> >
> >
> > FYI I: at time the main purpose of dkim-reputation.org is to send ARF
> > reports to DKIM signing ISPs. Blocking of senders with DNS reputation
> > data is an additional purpose now. If you like to get ARF reports,
> > contact me directly.
> >
> > FYI II: For the measurement of alleged ISP domains I scripted a small
> > Spamassassin-Plugin some months before:
> > http://www.agitos.de/pub/ReportDomainHit.pm with which a participant
> > reports alleged sender domains to our UDP logging server.
> > Some of you joined this measurement, thanks a lot!
> >
> > Flo