Append Labels patch -- take two

[Julie S]

Dear RG Team:

I've attached a diff file containing the Append Label Patch.

This feature is just like my first patch (See Append Label Suffixes discussion).  As discussed, this patch contains no QT or KDE in the base directory or class.

Appending of labels uses std::string AppendLabel(std::string &, std::string &) found in src/misc/AppendLabel.cpp and .h.

Let me know if there is anything else needed.

Sincerely,
Julie S.


     

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[D. Michael McIntyre]

On Wednesday 23 July 2008, Julie S wrote:

> Let me know if there is anything else needed.

Committed revision 8935.

I didn't see anything to nitpick about.  Good, clean code, and it works.

Thanks!
--
D. Michael McIntyre

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[Julie S]

Dear RG Team:

Thank you for the help.  I've appreciated it all.  I'm glad to see the update go to svn.

Somewhere inside me though, I was bugged that AppendLabel ended up in src/misc.  Like Chis asked, "Is this a Corner case...?"

I've given it some thought.  No it is not a corner case.  This is a case of me being dense and RG unschooled.

If you look at commands such as:
src/segment/SegmentSplitTwiceCommand
src/segment/SegmentReconfigureCommand

These were implemented as sub-commands that other commands called.  I'm pretty certain they are not available elsewhere from the RG interface.

Moving the AppendLabel feature to src/segment/ would fit more in line with how RG is setup and also main-streams the code with the rest of RG.

If we went this route, I'd need to rewrite some of the AppendLabel code to convert it to a Command.  I'd have a few questions concerning that:
* How does execute() and unexecute() get called?  Is this a QT, or KDE thing?  Something else?
* Would I need to create a protected member m_oldLabel that needs to be reset if an unexecute occurs?

I see from the other two sub-commands they are written as if they could be called from anywhere inside RG, so I'd imagine I'd need to do something with the old label.

I should just shut up and be content, but I want to do this right.

Sincerely,
Julie S.



     

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[Julie S]

Hello All,

Sorry, Chris I misspelled your name in the last post--I should be more thoughtful.

I think I got Jostein's name incorrect a few post back, too.  Sorry.

Sincerely,
Julie S.


     

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[D. Michael McIntyre]

On Thursday 24 July 2008, Julie S wrote:
> I should just shut up and be content, but I want to do this right.

I'd just be content at this point.

If you really want to re-implement this within the Command framework, I'd at
least wait until you can see what we come up with in the QT4 port.  As I
recall, all of this has changed in a way that demands a total rewrite anyway,
so rather than move to the next generation QT or KDE whatever (I think it's
QUndo,) we're going to switch to something in-house, borrowed from work Chris
did on Sonic Visualiser.

I don't expect the change you propose would have a big impact on the
difficulty involved in moving all of this to some new framework, but it seems
decidedly pointless to bother with that at this time since you already have
it working, and the framework you'd be studying in order to produce this
third rewrite will be changing radically anyway.
--
D. Michael McIntyre

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[Julie S]

Dear Michael,

I think when the QT4 port is more in shape, I'd like to revisit this and mainstream the feature into the code as a sub-command or something.

With, that, I leave this subject--I hope.

Sincerely,
Julie S.



     

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

[Jostein Chr. Andersen-3]

Julie S wrote:

> I think I got Jostein's name incorrect a few post back, too.  Sorry.

No problem! :-)  People use to miss spell it all the time - I'm a Norwgian,
living in Sweden, and my name is not very common - so I'm used to it.

J.



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@... - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel