Nabble - Apache Commons

Re: To and Subject headers disappearing

2008-10-06T11:08:28Z

For anyone experiencing similar issues I thought I would post a reply
to myself and explain how I solved this.

The problem was due to a custom JavaMail implementation that found
it's way onto my classpath via Apache CXF.

The artifact causing the problem was:
org.apache.geronimo.specs:geronimo-javamail_1.4_spec. To me this seems
to be a custom Geronimo implementation of JavaMail, or at least some
of it's classes. I cannot imagine the need for an implementation which
strips all the headers from the message, but I guess they have their
reason.

Using Maven on my project, I simply added
<exclusions>
<exclusion>
<groupId>org.apache.geronimo.specs</groupId>
<artifactId>geronimo-javamail_1.4_spec</artifactId>
</exclusion>
</exclusions>

to the org.apache.cxf:cxf-rt-frontend-simple dependency.

Anyways, hopefully this will help anyone out there struggling with the
same problem :)

Jaran

On Tue, Sep 30, 2008 at 2:37 PM, Jaran Nilsen <jaran.nilsen@...> wrote:

> Hi.
>
> I am having a problem with commons-email 1.1. I am not sure where the
> problem is,but figured this would be a good place to start trying to
> figure out why this is happening to my application.
>
> I have two projects, A and B. In project A, the only dependency (Maven
> 2) is commons-email 1.1. This is again dependent on JavaMail 1.4
> (mail-1.4).
>
> In project B, I have the same dependency, commons-email 1.1, but I
> also have several other dependencies. One of these are xfire-core
> 1.2.6, which I have seen is also dependent on JavaMail 1.4. Xfire-core
> and commons-email are the ONLY artifacts depending on JavaMail in
> project B.
>
> When I run the following codesnippet in Project A, everything works
> fine. The email arrives and things are sweet like a warm summer day.
> However, when I run the same piece of code in Project B, the To and
> Subject headers disappear! I have been scratching my head and been
> testing up and down and can't figure out what is causing this.
>
> Are there anyone out there who have experienced anything similar and
> can point me in the right direction?
>
> Here is the code snippet:
> SimpleEmail email = new SimpleEmail();
> email.setHostName("localhost");
> email.setSmtpPort(25025);
> email.addTo("jaran.nilsen@...");
> email.setFrom("peons@...", "Integrasco Peons");
> email.setSubject("Test message");
> email.setMsg("This is a simple test of commons-email");
> email.setDebug(true);
> email.send();
>
> Debug output from Project A:
> DEBUG: JavaMail version 1.4ea
> DEBUG: java.io.FileNotFoundException:
> /usr/lib/jvm/java-6-sun-1.6.0.06/jre/lib/javamail.providers (No such
> file or directory)
> DEBUG: !anyLoaded
> DEBUG: not loading resource: /META-INF/javamail.providers
> DEBUG: successfully loaded resource: /META-INF/javamail.default.providers
> DEBUG: Tables of loaded providers
> DEBUG: Providers Listed By Class Name:
> {com.sun.mail.smtp.SMTPSSLTransport=javax.mail.Provider[TRANSPORT,smtps,com.sun.mail.smtp.SMTPSSLTransport,Sun
> Microsystems, Inc],
> com.sun.mail.smtp.SMTPTransport=javax.mail.Provider[TRANSPORT,smtp,com.sun.mail.smtp.SMTPTransport,Sun
> Microsystems, Inc],
> com.sun.mail.imap.IMAPSSLStore=javax.mail.Provider[STORE,imaps,com.sun.mail.imap.IMAPSSLStore,Sun
> Microsystems, Inc],
> com.sun.mail.pop3.POP3SSLStore=javax.mail.Provider[STORE,pop3s,com.sun.mail.pop3.POP3SSLStore,Sun
> Microsystems, Inc],
> com.sun.mail.imap.IMAPStore=javax.mail.Provider[STORE,imap,com.sun.mail.imap.IMAPStore,Sun
> Microsystems, Inc],
> com.sun.mail.pop3.POP3Store=javax.mail.Provider[STORE,pop3,com.sun.mail.pop3.POP3Store,Sun
> Microsystems, Inc]}
> DEBUG: Providers Listed By Protocol:
> {imaps=javax.mail.Provider[STORE,imaps,com.sun.mail.imap.IMAPSSLStore,Sun
> Microsystems, Inc],
> imap=javax.mail.Provider[STORE,imap,com.sun.mail.imap.IMAPStore,Sun
> Microsystems, Inc],
> smtps=javax.mail.Provider[TRANSPORT,smtps,com.sun.mail.smtp.SMTPSSLTransport,Sun
> Microsystems, Inc],
> pop3=javax.mail.Provider[STORE,pop3,com.sun.mail.pop3.POP3Store,Sun
> Microsystems, Inc],
> pop3s=javax.mail.Provider[STORE,pop3s,com.sun.mail.pop3.POP3SSLStore,Sun
> Microsystems, Inc],
> smtp=javax.mail.Provider[TRANSPORT,smtp,com.sun.mail.smtp.SMTPTransport,Sun
> Microsystems, Inc]}
> DEBUG: successfully loaded resource: /META-INF/javamail.default.address.map
> DEBUG: !anyLoaded
> DEBUG: not loading resource: /META-INF/javamail.address.map
> DEBUG: java.io.FileNotFoundException:
> /usr/lib/jvm/java-6-sun-1.6.0.06/jre/lib/javamail.address.map (No such
> file or directory)
> DEBUG: getProvider() returning
> javax.mail.Provider[TRANSPORT,smtp,com.sun.mail.smtp.SMTPTransport,Sun
> Microsystems, Inc]
> DEBUG SMTP: useEhlo true, useAuth false
> DEBUG SMTP: trying to connect to host "localhost", port 25025, isSSL false
> 220 ludvig.integrasco.no ESMTP Sendmail 8.13.1/8.13.1; Tue, 30 Sep
> 2008 14:35:48 +0200
> DEBUG SMTP: connected to host "localhost", port: 25025
>
> EHLO jaran-laptop
> 250-ludvig.integrasco.no Hello localhost.localdomain [127.0.0.1],
> pleased to meet you
> 250-ENHANCEDSTATUSCODES
> 250-PIPELINING
> 250-8BITMIME
> 250-SIZE
> 250-DSN
> 250-ETRN
> 250-AUTH DIGEST-MD5 CRAM-MD5
> 250-DELIVERBY
> 250 HELP
> DEBUG SMTP: Found extension "ENHANCEDSTATUSCODES", arg ""
> DEBUG SMTP: Found extension "PIPELINING", arg ""
> DEBUG SMTP: Found extension "8BITMIME", arg ""
> DEBUG SMTP: Found extension "SIZE", arg ""
> DEBUG SMTP: Found extension "DSN", arg ""
> DEBUG SMTP: Found extension "ETRN", arg ""
> DEBUG SMTP: Found extension "AUTH", arg "DIGEST-MD5 CRAM-MD5"
> DEBUG SMTP: Found extension "DELIVERBY", arg ""
> DEBUG SMTP: Found extension "HELP", arg ""
> DEBUG SMTP: use8bit false
> MAIL FROM:<peons@...>
> 250 2.1.0 <peons@...>... Sender ok
> RCPT TO:<jaran.nilsen@...>
> 250 2.1.5 <jaran.nilsen@...>... Recipient ok
> DEBUG SMTP: Verified Addresses
> DEBUG SMTP: "jaran.nilsen@..." <jaran.nilsen@...>
> DATA
> 354 Enter mail, end with "." on a line by itself
> Date: Tue, 30 Sep 2008 14:36:46 +0200 (CEST)
> From: Integrasco Peons <peons@...>
> To: "jaran.nilsen@..." <jaran.nilsen@...>
> Message-ID: <19058102.01222778206577.JavaMail.jaran@jaran-laptop>
> Subject: Test message
> MIME-Version: 1.0
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
>
> This is a simple test of commons-email
> .
> 250 2.0.0 m8UCZmKZ029942 Message accepted for delivery
> QUIT
> 221 2.0.0 ludvig.integrasco.no closing connection
>
> Debug output from Project B:
> Loading javamail.default.providers from
> jar:file:/home/jaran/.m2/repository/javax/mail/mail/1.4/mail-1.4.jar!/META-INF/javamail.default.providers
> DEBUG: loading new provider protocol=imap,
> className=com.sun.mail.imap.IMAPStore, vendor=Sun Microsystems, Inc,
> version=null
> DEBUG: loading new provider protocol=imaps,
> className=com.sun.mail.imap.IMAPSSLStore, vendor=Sun Microsystems,
> Inc, version=null
> DEBUG: loading new provider protocol=smtp,
> className=com.sun.mail.smtp.SMTPTransport, vendor=Sun Microsystems,
> Inc, version=null
> DEBUG: loading new provider protocol=smtps,
> className=com.sun.mail.smtp.SMTPSSLTransport, vendor=Sun Microsystems,
> Inc, version=null
> DEBUG: loading new provider protocol=pop3,
> className=com.sun.mail.pop3.POP3Store, vendor=Sun Microsystems, Inc,
> version=null
> DEBUG: loading new provider protocol=pop3s,
> className=com.sun.mail.pop3.POP3SSLStore, vendor=Sun Microsystems,
> Inc, version=null
> DEBUG: getProvider() returning provider protocol=smtp;
> type=javax.mail.Provider$Type@106082;
> class=com.sun.mail.smtp.SMTPTransport; vendor=Sun Microsystems, Inc
> DEBUG SMTP: useEhlo true, useAuth false
> DEBUG SMTP: trying to connect to host "localhost", port 25025, isSSL false
> 220 ludvig.integrasco.no ESMTP Sendmail 8.13.1/8.13.1; Tue, 30 Sep
> 2008 14:36:44 +0200
> DEBUG SMTP: connected to host "localhost", port: 25025
>
> EHLO jaran-laptop
> 250-ludvig.integrasco.no Hello localhost.localdomain [127.0.0.1],
> pleased to meet you
> 250-ENHANCEDSTATUSCODES
> 250-PIPELINING
> 250-8BITMIME
> 250-SIZE
> 250-DSN
> 250-ETRN
> 250-AUTH DIGEST-MD5 CRAM-MD5
> 250-DELIVERBY
> 250 HELP
> DEBUG SMTP: Found extension "ENHANCEDSTATUSCODES", arg ""
> DEBUG SMTP: Found extension "PIPELINING", arg ""
> DEBUG SMTP: Found extension "8BITMIME", arg ""
> DEBUG SMTP: Found extension "SIZE", arg ""
> DEBUG SMTP: Found extension "DSN", arg ""
> DEBUG SMTP: Found extension "ETRN", arg ""
> DEBUG SMTP: Found extension "AUTH", arg "DIGEST-MD5 CRAM-MD5"
> DEBUG SMTP: Found extension "DELIVERBY", arg ""
> DEBUG SMTP: Found extension "HELP", arg ""
> DEBUG SMTP: use8bit false
> MAIL FROM:<peons@...>
> 250 2.1.0 <peons@...>... Sender ok
> RCPT TO:<jaran.nilsen@...>
> 250 2.1.5 <jaran.nilsen@...>... Recipient ok
> DEBUG SMTP: Verified Addresses
> DEBUG SMTP: "jaran.nilsen@..." <jaran.nilsen@...>
> DATA
> 354 Enter mail, end with "." on a line by itself
>
> This is a simple test of commons-email
> .
> 250 2.0.0 m8UCaixb030029 Message accepted for delivery
> QUIT
> 221 2.0.0 ludvig.integrasco.no closing connection
>
> Appreciate any help on this. Starting to go out of hair to pull out :)
>
> Kind regards,
> Jaran Nilsen
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@...
For additional commands, e-mail: user-help@...

From forum: Commons - User

[jira] Created: (POOL-130) GenericObjectPool.Evictor creates new objects although exactly minIdle objects are idle

2008-10-06T07:51:44Z

GenericObjectPool.Evictor creates new objects although exactly minIdle objects are idle
---------------------------------------------------------------------------------------

Key: POOL-130
URL: https://issues.apache.org/jira/browse/POOL-130
Project: Commons Pool
Issue Type: Bug
Affects Versions: 1.4, 1.2
Reporter: Torsten Feig

When you
- create a GenericObjectPool with these parameters: maxActive=100, maxIdle=100, minIdle=10, timeBetweenEvictionRunsMillis=360000 (1h), minEvictableIdleTimeMillis=30000 (5min)
- preload the 10 minIdle objects (10x borrowObject() + returnObject)
you have a pool with 10 idle objects.

Then every 1h the evictor destroys the 10 idle objects and creates 10 new ones. Why? After all, creating and tearing down pool objects is likely to be expensive. So why destroy the old objects when they exactly represent the minIdle objects? I don't see any need for this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

[jira] Created: (VFS-221) Memory not released in SoftRefFilesCache

2008-10-06T05:17:44Z

Memory not released in SoftRefFilesCache
----------------------------------------

Key: VFS-221
URL: https://issues.apache.org/jira/browse/VFS-221
Project: Commons VFS
Issue Type: Bug
Environment: All
Reporter: Gilles Gaillard
Priority: Trivial

Implementation of method putFile(final FileObject file) does not remove references from refReverseMap when adding a new file.

#current implementation
{noformat}
synchronized (files)
{
files.put(file.getName(), ref);
synchronized(refReverseMap)
{
refReverseMap.put(ref, key);
}
}
{noformat}

#should become:
{noformat}
synchronized (files)
{
Reference old = files.put(file.getName(), ref);
synchronized(refReverseMap)
{
refReverseMap.remove(old);
refReverseMap.put(ref, key);
}
}
{noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

Request Inormation Regarding EOL for the following Jars

2008-10-06T04:06:26Z

Hi

We are mailing you from Inautix , India, a Bank of Newyork Mellon company.
We just want to know the End Of Life ( Dates) for the Following Open Source Jars. As we have used these jars to build applications.

Appreciate if you could mail us back as soon as possible.

Thanks & Regards
Ganesh Nagalingam
D: Development - BNY - ECSE
A: i|Nautix Technologies India Pvt Ltd,
8th Floor, Ascendas IT Park (Chennai) Ltd,
Taramani Road, Taramani,
Chennai - 600 113.
T: 91-44-22545000
X: 4347
E: gnagalingam@...
I: www.inautix.com

From forum: Commons - User

[jira] Commented: (IO-182) add new APPEND parameter for writing string into files

2008-10-06T02:57:44Z

[ https://issues.apache.org/jira/browse/IO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637056#action_12637056 ]

Stefan Simik commented on IO-182:
---------------------------------

Yes, exactly ;)
appendStringToFile(File file, String encoding, String textToAppend);
is the function I was looking for.

> add new APPEND parameter for writing string into files
> ------------------------------------------------------
>
> Key: IO-182
> URL: https://issues.apache.org/jira/browse/IO-182
> Project: Commons IO
> Issue Type: New Feature
> Components: Streams/Writers
> Affects Versions: 1.4
> Reporter: Stefan Simik
>
> It would be great to have one additional parameter for writing strins into file - boolean append.
> If true, string will be appended to the end of the file.
> It is very useful for many purposes, for example logging and so on..

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

[jira] Updated: (FILEUPLOAD-168) read form field parameters even if maxSize has been exceeded

2008-10-06T02:49:46Z

[ https://issues.apache.org/jira/browse/FILEUPLOAD-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Rivera updated FILEUPLOAD-168:
-----------------------------------

Attachment: fileupload2.patch

Uploaded a version of the patch named fileupload2.patch with some additional methods.

> read form field parameters even if maxSize has been exceeded
> ------------------------------------------------------------
>
> Key: FILEUPLOAD-168
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-168
> Project: Commons FileUpload
> Issue Type: Improvement
> Environment: commons fileupload 1.2.2-SNAPSHOT
> Reporter: Paul Rivera
> Attachments: fileupload1.patch, fileupload2.patch
>
>
> Hi!
> This issue is similar to FILEUPLOAD-140. I can't seem to reopen it so I created a new one instead. FILEUPLOAD-140 was marked as resolve by using the streaming API, if I'm not mistaken. No change was done. But I disagree on the resolution of simply using the streaming API (as detailed in http://commons.apache.org/fileupload/streaming.html).
> First of all, I tried to upload a big file exceeding maxSize with streaming API and got the SizeLimitExceededException even before ANY parameter has been read.
> ServletFileUpload.getItemIterator() calls FileUploadBase.getItemIterator() which creates a new FileItemIteratorImpl(). In the constructor code of FileItemIteratorImpl, it already checks for the requestSize and throws SizeLimitExceededException if sizeMax is exceeded.
> I'd like to open this discussion again and hope that in the end, we can have either:
> - form field parameters BEFORE the file parameter will still get read if requestSize is greater than sizeMax and then terminate once we reach the file
> - all form field parameters will still get read if requestSize is greater than sizeMax. But, we should skip reading the body of the files and proceed to the next 'boundary' so as not to keep the user waiting, if ever this is possible. (preferred)
> Then, we should also apply the same improvement into PortletFileUpload.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

[jira] Commented: (LANG-464) EqualsBuilder doesn't compile in 2.4 source code release

2008-10-05T23:21:44Z

[ https://issues.apache.org/jira/browse/LANG-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637012#action_12637012 ]

Henri Yandell commented on LANG-464:
------------------------------------

Bit odd in that javadoc for 1.5 shows that the compareTo(Object) was removed then; though maybe it's an Apple bug that it still has compareTo(Object) in it.

1.4: http://java.sun.com/j2se/1.4.2/docs/api/java/math/BigDecimal.html
1.5: http://java.sun.com/j2se/1.5.0/docs/api/java/math/BigDecimal.html
1.6: http://today.java.net/download/jdk6/doc/api/java/math/BigDecimal.html

So - JDK version issue. Presumably we should check that both lhs and rhs are BigDecimal and cast both.

> EqualsBuilder doesn't compile in 2.4 source code release
> --------------------------------------------------------
>
> Key: LANG-464
> URL: https://issues.apache.org/jira/browse/LANG-464
> Project: Commons Lang
> Issue Type: Bug
> Affects Versions: 2.4
> Environment: Windows Vista in Eclipse
> Reporter: Tim Halloran
>
> Line 381 of org.apache.commons.lang.EqualsBuilder fails to compile because the compareTo call requires a BigDecimal rather than an object.
> 376 public EqualsBuilder append(Object lhs, Object rhs) {
> ...
> 379 if (!lhsClass.isArray()) {
> 380 if (lhs instanceof java.math.BigDecimal) {
> 381 isEquals = (((java.math.BigDecimal)lhs).compareTo(rhs) == 0);
> 382 } else {
> I'm using Sun's JDK 1.6.0_07 in Eclipse, not sure if this is a JDK version issue or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

[jira] Closed: (LANG-463) Ant build file does not include ReflectTestSuite

2008-10-05T23:05:44Z

[ https://issues.apache.org/jira/browse/LANG-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell closed LANG-463.
------------------------------

Resolution: Fixed
Fix Version/s: 3.0

Applied in 701953.

> Ant build file does not include ReflectTestSuite
> ------------------------------------------------
>
> Key: LANG-463
> URL: https://issues.apache.org/jira/browse/LANG-463
> Project: Commons Lang
> Issue Type: Bug
> Affects Versions: 2.4
> Reporter: Sebb
> Fix For: 3.0
>
> Attachments: build_xml.patch
>
>
> Ant build file does not include ReflectTestSuite.
> Patch to follow.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

svn commit: r701953 - /commons/proper/lang/trunk/build.xml

2008-10-05T23:05:32Z

Author: bayard
Date: Sun Oct 5 23:05:32 2008
New Revision: 701953

URL: http://svn.apache.org/viewvc?rev=701953&view=rev
Log:
Adding reflect to the build.xml as per LANG-463

Modified:
commons/proper/lang/trunk/build.xml

Modified: commons/proper/lang/trunk/build.xml
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/build.xml?rev=701953&r1=701952&r2=701953&view=diff
==============================================================================
--- commons/proper/lang/trunk/build.xml (original)
+++ commons/proper/lang/trunk/build.xml Sun Oct 5 23:05:32 2008
@@ -147,6 +147,7 @@
test.exception,
test.math,
test.mutable,
+ test.reflect,
test.text,
test.time" description="Run all unit test cases">
<echo message="Running tests ..."/>
@@ -181,6 +182,9 @@
<target name="test.mutable" depends="compile.tests">
<runTestCase classname="org.apache.commons.lang.mutable.MutableTestSuite"/>
</target>
+ <target name="test.reflect" depends="compile.tests">
+ <runTestCase classname="org.apache.commons.lang.reflect.ReflectTestSuite"/>
+ </target>
<target name="test.text" depends="compile.tests">
<runTestCase classname="org.apache.commons.lang.text.TextTestSuite"/>
</target>

From forum: Commons - Dev

[jira] Commented: (IO-182) add new APPEND parameter for writing string into files

2008-10-05T23:03:44Z

[ https://issues.apache.org/jira/browse/IO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637005#action_12637005 ]

Henri Yandell commented on IO-182:
----------------------------------

Bad way of doing APIs though - what you're really asking for is an appendStringToFile imo.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

Re: [compress] What is the purpose of the reflection usage in ArchiveStreamFactory and CompressorStreamFactory?

2008-10-05T17:08:37Z

> I will fix it up and suggest a patch to bring it to a workable state.

I guess we could also just get rid of the reflection. What do you think?

cheers
--
Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Commons - Dev

[jira] Updated: (SANDBOX-262) COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)

2008-10-05T16:07:44Z

[ https://issues.apache.org/jira/browse/SANDBOX-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Pinet updated SANDBOX-262:
------------------------------

Attachment: ArchiveStreamFactory.patch

Attached patch throws exceptions properly. Also, cleaned up some strings in the class.

> COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)
> ------------------------------------------------------------------------------------------------------------
>
> Key: SANDBOX-262
> URL: https://issues.apache.org/jira/browse/SANDBOX-262
> Project: Commons Sandbox
> Issue Type: Bug
> Components: Compress
> Environment: N/A
> Reporter: Tim Pinet
> Attachments: ArchiveStreamFactory.patch
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> Reflection handles the checked exceptions for Constructor.newInstance() appropriately for:
> public ArchiveInputStream createArchiveInputStream( final String archiverName, final InputStream out ) throws ArchiveException {...}
> However, the other method:
> public ArchiveInputStream createArchiveInputStream( final InputStream input ) throws IOException {...}
> is not implemented to handle checked constructor exceptions since all Exception catches are not handled. It looks as though this method was not completed. This method should handle exceptions similar to its counterpart.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

[jira] Created: (SANDBOX-262) COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)

2008-10-05T16:05:44Z

COMPRESS-REDESIGN: ArchiveStreamFactory does not handle exceptions for createArchiveInputStream(InputStream)
------------------------------------------------------------------------------------------------------------

Key: SANDBOX-262
URL: https://issues.apache.org/jira/browse/SANDBOX-262
Project: Commons Sandbox
Issue Type: Bug
Components: Compress
Environment: N/A
Reporter: Tim Pinet

Reflection handles the checked exceptions for Constructor.newInstance() appropriately for:

public ArchiveInputStream createArchiveInputStream( final String archiverName, final InputStream out ) throws ArchiveException {...}

However, the other method:

public ArchiveInputStream createArchiveInputStream( final InputStream input ) throws IOException {...}

is not implemented to handle checked constructor exceptions since all Exception catches are not handled. It looks as though this method was not completed. This method should handle exceptions similar to its counterpart.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: Commons - Issues

svn commit: r701899 - in /commons/proper/net/tags/NET_2_0_RC_4: ./ pom.xml

2008-10-05T16:01:30Z

Author: rwinston
Date: Sun Oct 5 16:01:29 2008
New Revision: 701899

URL: http://svn.apache.org/viewvc?rev=701899&view=rev
Log:
made a copy

Added:
commons/proper/net/tags/NET_2_0_RC_4/
- copied from r699798, commons/proper/net/branches/NET_2_0/
commons/proper/net/tags/NET_2_0_RC_4/pom.xml
- copied unchanged from r700919, commons/proper/net/branches/NET_2_0/pom.xml

From forum: Commons - Dev

Re: [compress] What is the purpose of the reflection usage in ArchiveStreamFactory and CompressorStreamFactory?

2008-10-05T15:44:21Z

Reflection does handle checked exceptions for Constructor.newInstance() and
this is handled appropriately for:

public ArchiveInputStream createArchiveInputStream( final String
archiverName, final InputStream out ) throws ArchiveException {...}

However, the other method:

public ArchiveInputStream createArchiveInputStream( final InputStream
input ) throws IOException {...}

is not implemented to handle checked constructor exceptions since all
Exception catches are not handled. It looks as though this method was not
completed. I will fix it up and suggest a patch to bring it to a workable
state.

Thanks,
Tim

--------------------------------------------------
From: "Torsten Curdt" <tcurdt@...>
Sent: Sunday, October 05, 2008 10:27 AM
To: "Commons Developers List" <dev@...>
Subject: [compress] What is the purpose of the reflection usage in
ArchiveStreamFactory and CompressorStreamFactory?

> Hey there
>
>> Out of curiosity why must reflection be used for the create*Stream()
>> methods in the ArchiveStreamFactory and CompressorStreamFactory? There
>> is a cast at the end of each method to a corresponding interface anyway
>> (ex ArchiveInputStream, ArchiveOutputStream, etc) so why cant we use
>> this knowledge ahead of time and execute on the interface?
>
> I think the idea that it makes "dropping in" a new implementation easier.
> But I agree with you.
>
> As the registerArchive*Stream methods need to be called to register the
> implementation this becomes a moo point.
>
> I would change the factory to
>
> public ArchiveInputStream createArchiveInputStream( final String
> archiverName, final InputStream stream ) throws ArchiveException {
>
> if ("ar".equals(archiverName)) {
> return new ArAchiveInputStream(stream)
> }
>
> ..
>
> return null;
> }
>
> and then instead of registering a new implementation you just extend the
> factory and overload the create*Stream methods to add your custom impl
> ...and of course delegate to the super class.
>
>> The current implementation makes it next to impossible to capture errors
>> being thrown by the constructors of new implementations since the
>> reflective methods discard any Exceptions and simply return null.
>
> Hm ... I thought that would be indeed possible:
>
> http://java.sun.com/docs/books/tutorial/reflect/member/ctorTrouble.html
>
> cheers
> --
> Torsten
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Commons - Dev