Nabble - Apache C++ Standard Library

Created: (STDCXX-1015) [gcc 4.3.0] ICE compiling VA_LIST.cpp config test

2008-09-06T17:07:44Z

[gcc 4.3.0] ICE compiling VA_LIST.cpp config test
-------------------------------------------------

Key: STDCXX-1015
URL: https://issues.apache.org/jira/browse/STDCXX-1015
Project: C++ Standard Library
Issue Type: Bug
Components: Configuration
Affects Versions: 4.2.1
Environment: gcc 4.3.0, 4.3.1
Reporter: Martin Sebor
Assignee: Martin Sebor
Priority: Critical
Fix For: 4.2.2

Both gcc 4.3.0 and 4.3.1 choke on the [{{VA_LIST.cpp}}|http://svn.apache.org/repos/asf/stdcxx/branches/4.2.x/etc/config/src/VA_LIST.cpp] config test. A misconfigured {{va_list}} can't be good for the library... We should probably hardcode the expected value when {{\_RWSTD_NO_VA_LIST}} is #defined (although we might already be doing it since we do have some good gcc 4.3.0 builds...)

The ICE has been filed with gcc in [bug 37404|http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37404].

{noformat}
gcc -D_RWSTDDEBUG -pthread -I. -pedantic -nostdinc++ -g -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align -c /amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp -o VA_LIST.o
/amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp: In function 'int main()':
/amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp:198: warning: format '%u' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
/amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp:202: warning: format '%u' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
/amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp: In static member function 'static const char* Type<T [N]>::type_name() [with T = __va_list_tag, int N = 1]':
/amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp:96: instantiated from here
/amd/devco/sebor/stdcxx-4.2.x/etc/config/src/VA_LIST.cpp:85: internal compiler error: in build_special_member_call, at cp/call.c:5323
Please submit a full bug report,with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
{noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

svn commit: r692757 - /stdcxx/branches/4.2.x/examples/manual/search.cpp

2008-09-06T15:42:30Z

Author: sebor
Date: Sat Sep 6 15:42:30 2008
New Revision: 692757

URL: http://svn.apache.org/viewvc?rev=692757&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

STDCXX-1007
* examples/manual/search.cpp (main): Silenced HP aCC warning #4320:
performance advice: std::endl is expensive because it flushes the
stream.

Modified:
stdcxx/branches/4.2.x/examples/manual/search.cpp

Modified: stdcxx/branches/4.2.x/examples/manual/search.cpp
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/examples/manual/search.cpp?rev=692757&r1=692756&r2=692757&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/examples/manual/search.cpp (original)
+++ stdcxx/branches/4.2.x/examples/manual/search.cpp Sat Sep 6 15:42:30 2008
@@ -22,7 +22,7 @@
* implied. See the License for the specific language governing
* permissions and limitations under the License.
*
- * Copyright 1994-2006 Rogue Wave Software.
+ * Copyright 1994-2006 Rogue Wave Software, Inc.
*
**************************************************************************/

@@ -46,8 +46,8 @@
//
// Print out the original sequence.
//
- cout << endl << "The subsequence, " << subseq << ", was found at the ";
- cout << endl << "location identified by a '*'" << endl << " ";
+ cout << "\nThe subsequence, " << subseq << ", was found at the ";
+ cout << "\nlocation identified by a '*'" << "\n ";
//
// Create an iterator to identify the location of
// subsequence within sequence.
@@ -65,9 +65,10 @@
//
// Output sequence to display result.
//
- for (list<char,allocator<char> >::iterator i = sequence.begin(); i != sequence.end(); i++)
+ for (list<char,allocator<char> >::iterator i = sequence.begin();
+ i != sequence.end(); ++i)
cout << *i;
- cout << endl;
+ cout << '\n';

return 0;
}

From forum: stdcxx-commits

svn commit: r692756 - /stdcxx/branches/4.2.x/examples/manual/stack.cpp

2008-09-06T15:41:46Z

Author: sebor
Date: Sat Sep 6 15:41:46 2008
New Revision: 692756

URL: http://svn.apache.org/viewvc?rev=692756&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

STDCXX-1007
* examples/manual/stack.cpp (main): Silenced HP aCC warning #4320:
performance advice: std::endl is expensive because it flushes the
stream.
Also silenced remark #4271-D: type conversion may lose sign.

Modified:
stdcxx/branches/4.2.x/examples/manual/stack.cpp

Modified: stdcxx/branches/4.2.x/examples/manual/stack.cpp
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/examples/manual/stack.cpp?rev=692756&r1=692755&r2=692756&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/examples/manual/stack.cpp (original)
+++ stdcxx/branches/4.2.x/examples/manual/stack.cpp Sat Sep 6 15:41:46 2008
@@ -22,7 +22,7 @@
* implied. See the License for the specific language governing
* permissions and limitations under the License.
*
- * Copyright 1994-2006 Rogue Wave Software.
+ * Copyright 1994-2006 Rogue Wave Software, Inc.
*
**************************************************************************/

@@ -41,13 +41,14 @@
//
// Make a stack using a vector container.
//
- stack<int,vector<int,allocator<int> > > s;
+ typedef stack<int,vector<int,allocator<int> > > IntStack;
+ IntStack s;
//
// Push a couple of values on the stack.
//
s.push(1);
s.push(2);
- cout << s.top() << endl;
+ cout << s.top() << '\n';
//
// Now pop them off.
//
@@ -61,7 +62,7 @@
//
// Push a bunch of strings on then pop them off.
//
- int i;
+ IntStack::size_type i;
for (i = 0; i < 10; i++)
{
ss.push(string(i+1,'a'));

From forum: stdcxx-commits

Closed: (STDCXX-1014) [HP aCC 6] enable performance advice and security warnings

2008-09-06T13:35:44Z

[ https://issues.apache.org/jira/browse/STDCXX-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Sebor closed STDCXX-1014.
--------------------------------

Resolution: Fixed

Options enabled in [r692728|http://svn.apache.org/viewvc?rev=692728&view=rev].

> [HP aCC 6] enable performance advice and security warnings
> ----------------------------------------------------------
>
> Key: STDCXX-1014
> URL: https://issues.apache.org/jira/browse/STDCXX-1014
> Project: C++ Standard Library
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 4.2.1
> Environment: HP aCC 6
> Reporter: Martin Sebor
> Assignee: Martin Sebor
> Fix For: 4.2.2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> HP aCC provides two useful warning options that aren't enabled in stdcxx builds:
> * [+wperfadvice|http://docs.hp.com/en/10946/options.htm#opt+wperfadvice] (since aCC A.06.15)
> * [+wsecurity|http://docs.hp.com/en/7283/options.htm#opt+wsecurity] (since aCC A.06.05)
> It'd be good to enable these and silence any potential warnings.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

svn commit: r692728 - /stdcxx/branches/4.2.x/etc/config/acc.config

2008-09-06T13:30:16Z

Author: sebor
Date: Sat Sep 6 13:30:16 2008
New Revision: 692728

URL: http://svn.apache.org/viewvc?rev=692728&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

STDCXX-1014
* etc/config/acc.config (WARNFLAGS): Enabled the +wperfadvice
and +wsecurity warning options for HP aCC 6.15 and 6.05 (with
optimization), respectively.

Modified:
stdcxx/branches/4.2.x/etc/config/acc.config

Modified: stdcxx/branches/4.2.x/etc/config/acc.config
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/etc/config/acc.config?rev=692728&r1=692727&r2=692728&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/etc/config/acc.config (original)
+++ stdcxx/branches/4.2.x/etc/config/acc.config Sat Sep 6 13:30:16 2008
@@ -46,6 +46,21 @@

ifeq ($(aCC_MAJOR),06)

+ ifeq ($(findstring optimized,$(BUILDMODE)),optimized)
+ ifeq ($(shell [ $(aCC_MINOR) -ge 5 ] && echo 1),1)
+ # enable security warnings for aCC 6.05 and higher
+ # when optimization is enabled (the option implicitly
+ # enables a limited form of cross module analysis and
+ # increases compilation times)
+ WARNFLAGS += +wsecurity
+ endif # aCC >= 6.05
+ endif # optimization on
+
+ ifeq ($(shell [ $(aCC_MINOR) -ge 15 ] && echo 1),1)
+ # enable performance suggestions for aCC 6.15 and higher
+ WARNFLAGS += +wperfadvice
+ endif # aCC >= 6.15
+
# disabled warnings:
# 2193 zero used for undefined preprocessing identifier
# 2236 controlling expression is constant

From forum: stdcxx-commits

Created: (STDCXX-1014) [HP aCC 6] enable performance advice and security warnings

2008-09-06T13:27:44Z

[HP aCC 6] enable performance advice and security warnings
----------------------------------------------------------

Key: STDCXX-1014
URL: https://issues.apache.org/jira/browse/STDCXX-1014
Project: C++ Standard Library
Issue Type: Improvement
Components: Documentation
Affects Versions: 4.2.1
Environment: HP aCC 6
Reporter: Martin Sebor
Assignee: Martin Sebor
Fix For: 4.2.2

HP aCC provides two useful warning options that aren't enabled in stdcxx builds:

* [+wperfadvice|http://docs.hp.com/en/10946/options.htm#opt+wperfadvice] (since aCC A.06.15)
* [+wsecurity|http://docs.hp.com/en/7283/options.htm#opt+wsecurity] (since aCC A.06.05)

It'd be good to enable these and silence any potential warnings.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

Created: (STDCXX-1013) [HP aCC 6.16] +wsecurity warnings in setlocale.cpp

2008-09-06T12:55:44Z

[HP aCC 6.16] +wsecurity warnings in setlocale.cpp
--------------------------------------------------

Key: STDCXX-1013
URL: https://issues.apache.org/jira/browse/STDCXX-1013
Project: C++ Standard Library
Issue Type: Bug
Components: 22. Localization
Affects Versions: 4.2.1
Environment: HP aCC 6.16 with [+wsecurity|http://docs.hp.com/en/10946/options.htm#opt+wsecurity]
Reporter: Martin Sebor
Assignee: Martin Sebor
Priority: Minor
Fix For: 4.2.2

Compiling the library with HP aCC 6.16 with the [+wsecurity|http://docs.hp.com/en/10946/options.htm#opt+wsecurity] option emits the following warnings:

{noformat}
aCC -c -mt -I/amd/devco/sebor/stdcxx-4.2.x/include -I/build/sebor/stdcxx-4.2.x-aCC-6.16-12D-ipo/include \
-AA +O2 +DD64 -ipo +tls=static +w +wsecurity +wendian +W392,655,684,818,819,849 \
+W2193,2236,2261,2340,2401,2487 +W4227,4229,4231,4235,4237,4249 \
+W4255,4272,4284,4285,4286,4296,4297 +W3348 +Z \
/amd/devco/sebor/stdcxx-4.2.x/src/setlocale.cpp
"/amd/devco/sebor/stdcxx-4.2.x/src/setlocale.cpp", line 168, procedure __rw::__rw_locale_name: warning #20119-D:
(SECURITY) Unsafe API 'strcpy' is used. Buffer overflow is not
checked when copying to target buffer. Consider using 'strncpy'.

"/amd/devco/sebor/stdcxx-4.2.x/src/setlocale.cpp", line 182, procedure __rw::__rw_locale_name: warning #20119-D:
(SECURITY) Unsafe API 'strcpy' is used. Buffer overflow is not
checked when copying to target buffer. Consider using 'strncpy'.

"/amd/devco/sebor/stdcxx-4.2.x/src/setlocale.cpp", line 193, procedure __rw::__rw_locale_name: warning #20119-D:
(SECURITY) Unsafe API 'strcpy' is used. Buffer overflow is not
checked when copying to target buffer. Consider using 'strncpy'.
{noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

Closed: (STDCXX-1012) [HP aCC 6.15] warning #20200-D: potential null pointer dereference in locale_combine.cpp

2008-09-06T12:49:44Z

[ https://issues.apache.org/jira/browse/STDCXX-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Sebor closed STDCXX-1012.
--------------------------------

Resolution: Fixed

Silenced bogus warnings in [r692714|http://svn.apache.org/viewvc?rev=692714&view=rev].

> [HP aCC 6.15] warning #20200-D: potential null pointer dereference in locale_combine.cpp
> -----------------------------------------------------------------------------------------
>
> Key: STDCXX-1012
> URL: https://issues.apache.org/jira/browse/STDCXX-1012
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: 22. Localization
> Affects Versions: 4.2.1
> Environment: HP aCC 6.16 with [-ipo|http://docs.hp.com/en/14487/options.htm#opt-ipo]
> Reporter: Martin Sebor
> Assignee: Martin Sebor
> Fix For: 4.2.2
>
> Original Estimate: 1h
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Here's another HP [cadvise|http://www.hp.com/go/cadvise] warning that shows up with the [-ipo|http://docs.hp.com/en/14487/options.htm#opt-ipo] option. This one looks bogus -- see STDCXX-764.
> {noformat}
> aCC -AA +nostl -Wl,+s -mt +DD64 +O2 -ipo +tls=static +Z -b +DD64 assert.o ... locale_combine.o ... wctype.o -o libstd12D.sl.4.2.2
> ...
> "/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp", line 511, procedure __rw::__rw_init_classic: warning #20200-D: Potential null pointer dereference through sep is detected (null definition:/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp, line 505)
> "/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp", line 533, procedure __rw::__rw_init_classic: warning #20200-D: Potential null pointer dereference through next is detected (null definition:/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp, line 511)
> {noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

svn commit: r692714 - /stdcxx/branches/4.2.x/src/locale_combine.cpp

2008-09-06T12:46:09Z

Author: sebor
Date: Sat Sep 6 12:46:08 2008
New Revision: 692714

URL: http://svn.apache.org/viewvc?rev=692714&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

STDCXX-1012
* src/locale_combine.cpp (_C_get_body): Shut up bogus HP aCC
(cadvise) warnings #20200-D: Potential null pointer dereference.

Modified:
stdcxx/branches/4.2.x/src/locale_combine.cpp

Modified: stdcxx/branches/4.2.x/src/locale_combine.cpp
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/src/locale_combine.cpp?rev=692714&r1=692713&r2=692714&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/src/locale_combine.cpp (original)
+++ stdcxx/branches/4.2.x/src/locale_combine.cpp Sat Sep 6 12:46:08 2008
@@ -502,15 +502,12 @@
const char *pcatnames [__rw_n_cats] = { 0 };

// try the libc "native" separator first, semicolon next
- const char *sep = strchr (locname, *_RWSTD_CAT_SEP);
- if (!sep)
- sep = ";";
-
- for (const char *s = locname; *s; ) {
-
- const char *next = strchr (s, *sep);
- if (!next)
- next = s + strlen (s);
+ const char* const psep = strchr (locname, *_RWSTD_CAT_SEP);
+ const char sep = psep ? *psep : ';';
+
+ // redundant check for s being non-null shuts up a bogus
+ // HP cadvise null pointer derefence warning #20200
+ for (const char *s = locname; s && *s; ) {

const char* const endcat = strchr (s, '=');
if (!endcat)
@@ -530,7 +527,9 @@
}
}

- s = *next ? next + 1 : next;
+ // advance just past the next separator if one exists
+ const char* const next = strchr (s, sep);
+ s = next ? next + 1 : s + strlen (s);
}

// compose a normalized locale name out of category names
@@ -542,7 +541,7 @@
pcatnames [i] = "C";
}

- const char *endcat = strchr (pcatnames [i], *sep);
+ const char *endcat = strchr (pcatnames [i], sep);

if (!endcat)
endcat = pcatnames [i] + strlen (pcatnames [i]);

From forum: stdcxx-commits

svn commit: r692712 - /stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp

2008-09-06T12:38:04Z

Author: sebor
Date: Sat Sep 6 12:38:04 2008
New Revision: 692712

URL: http://svn.apache.org/viewvc?rev=692712&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

* tests/locale/22.locale.name.cpp: New test (so far superficially)
exercising the interaction of the std::locale(const char*) ctor and
the std::locale::name() function.

Added:
stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp (with props)

Added: stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp?rev=692712&view=auto
==============================================================================
--- stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp (added)
+++ stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp Sat Sep 6 12:38:04 2008
@@ -0,0 +1,149 @@
+/***************************************************************************
+ *
+ * 22.locale.name.cpp - test exercising std::locale::name()
+ *
+ * $Id$
+ *
+ ***************************************************************************
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ * implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ *
+ **************************************************************************/
+
+#include <cstdio> // for printf()
+#include <cstring> // for strcmp()
+#include <locale> // for locale
+
+#include <rw_driver.h>
+
+
+void test_combined_name ()
+{
+ const char name[] = {
+#ifdef _AIX
+ "LC_TIME=EN_US.UTF-8;"
+ "LC_NUMERIC=C;"
+ "LC_MONETARY=en_US;"
+ "LC_MESSAGES=EN_US.UTF-8;"
+ "LC_CTYPE=C;"
+ "LC_COLLATE=en_US.ISO8859-1;"
+#elif defined __hpux
+ "LC_TIME=en_US.utf8;"
+ "LC_NUMERIC=C;"
+ "LC_MONETARY=en_US.roman8;"
+ "LC_MESSAGES=en_US.utf8;"
+ "LC_CTYPE=C;"
+ "LC_COLLATE=en_US.iso88591;"
+#elif defined __linux
+ "LC_TIME=en_US.utf8;"
+ "LC_NUMERIC=C;"
+ "LC_MONETARY=en_US;"
+ "LC_MESSAGES=en_US.utf8;"
+ "LC_CTYPE=C;"
+ "LC_COLLATE=en_US.iso88591;"
+#elif defined __osf__
+ "C"
+#elif defined __sun
+ "LC_TIME=en_US.UTF-8;"
+ "LC_NUMERIC=C;"
+ "LC_MONETARY=en_US;"
+ "LC_MESSAGES=en_US.UTF-8;"
+ "LC_CTYPE=C;"
+ "LC_COLLATE=en_US.ISO8859-1;"
+#elif defined _WIN32
+ "C"
+#else
+ "C"
+#endif
+ };
+
+ const char expected_name[] = {
+#ifdef _AIX
+ "en_US.ISO8859-1 " // LC_COLLATE
+ "C " // LC_CTYPE
+ "en_US " // LC_MONETARY
+ "C " // LC_NUMERIC
+ "EN_US.UTF-8 " // LC_TIME
+ "EN_US.UTF-8" // LC_MESSAGES
+#elif defined __hpux
+ "en_US.iso88591 " // LC_COLLATE
+ "C " // LC_CTYPE
+ "en_US.roman8 " // LC_MONETARY
+ "C " // LC_NUMERIC
+ "en_US.utf8 " // LC_TIME
+ "en_US.utf8" // LC_MESSAGES
+#elif defined __linux
+ "LC_CTYPE=C;"
+ "LC_NUMERIC=C;"
+ "LC_TIME=en_US.utf8;"
+ "LC_COLLATE=en_US.iso88591;"
+ "LC_MONETARY=en_US;"
+ "LC_MESSAGES=en_US.utf8"
+#elif defined __osf__
+ ""
+#elif defined __sun
+ "/C" // LC_COLLATE
+ "/C" // LC_CTYPE
+ "/en_US.UTF-8" // LC_MONETARY
+ "/en_US.ISO8859-1" // LC_NUMERIC
+ "/en_US" // LC_TIME
+ "/en_US.UTF-8" // LC_MESSAGES
+#elif defined _WIN32
+ "C"
+#else
+ "C"
+#endif
+ };
+
+ std::locale loc;
+
+ try {
+ // try to create the combined locale
+ loc = std::locale (name);
+ }
+ catch (...) {
+ rw_error (0, 0, __LINE__,
+ "std::locale(%#s) threw an exception\n", name);
+ return;
+ }
+
+ // verify that the actual locale name matches the expected name
+ const int cmp = std::strcmp (loc.name ().c_str (), expected_name);
+
+ rw_assert (0 == cmp, 0, __LINE__,
+ "std::locale(%#s).name() == %#s, got %#s",
+ name, expected_name, loc.name ().c_str ());
+}
+
+
+static int
+run_test (int, char**)
+{
+ test_combined_name ();
+
+ return 0;
+}
+
+
+int main (int argc, char *argv[])
+{
+ return rw_test (argc, argv, __FILE__,
+ "[lib.locale]",
+ "name()", // comment
+ run_test, "", 0);
+}
+

Propchange: stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp
------------------------------------------------------------------------------
svn:eol-style = native

Propchange: stdcxx/branches/4.2.x/tests/localization/22.locale.name.cpp
------------------------------------------------------------------------------
svn:keywords = Id

From forum: stdcxx-commits

Created: (STDCXX-1012) [HP aCC 6.15] warning #20200-D: potential null pointer dereference in locale_combine.cpp

2008-09-06T11:15:44Z

[HP aCC 6.15] warning #20200-D: potential null pointer dereference in locale_combine.cpp
-----------------------------------------------------------------------------------------

Key: STDCXX-1012
URL: https://issues.apache.org/jira/browse/STDCXX-1012
Project: C++ Standard Library
Issue Type: Sub-task
Components: 22. Localization
Affects Versions: 4.2.1
Environment: HP aCC 6.16 with [-ipo|http://docs.hp.com/en/14487/options.htm#opt-ipo]
Reporter: Martin Sebor
Assignee: Martin Sebor
Fix For: 4.2.2

Here's another HP [cadvise|http://www.hp.com/go/cadvise] warning that shows up with the [-ipo|http://docs.hp.com/en/14487/options.htm#opt-ipo] option. This one looks bogus -- see STDCXX-764.

{noformat}
aCC -AA +nostl -Wl,+s -mt +DD64 +O2 -ipo +tls=static +Z -b +DD64 assert.o ... locale_combine.o ... wctype.o -o libstd12D.sl.4.2.2
...
"/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp", line 511, procedure __rw::__rw_init_classic: warning #20200-D: Potential null pointer dereference through sep is detected (null definition:/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp, line 505)

"/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp", line 533, procedure __rw::__rw_init_classic: warning #20200-D: Potential null pointer dereference through next is detected (null definition:/amd/devco/sebor/stdcxx-4.2.x/src/locale_combine.cpp, line 511)
{noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

Closed: (STDCXX-1011) [HP aCC 6.16] warning #20200-D: potential null pointer dereference in collate.cpp

2008-09-06T11:03:44Z

[ https://issues.apache.org/jira/browse/STDCXX-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Sebor closed STDCXX-1011.
--------------------------------

Resolution: Fixed

This was a real problem. Fixed in [r692697|http://svn.apache.org/viewvc?rev=692697&view=rev].

> [HP aCC 6.16] warning #20200-D: potential null pointer dereference in collate.cpp
> ---------------------------------------------------------------------------------
>
> Key: STDCXX-1011
> URL: https://issues.apache.org/jira/browse/STDCXX-1011
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: 22. Localization
> Affects Versions: 4.2.1
> Environment: HP aCC 6.16
> Reporter: Martin Sebor
> Assignee: Martin Sebor
> Fix For: 4.2.2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The warning below shows up when linking with the [-ipo|http://docs.hp.com/en/10946/options.htm#opt-ipo] option:
> {noformat}
> aCC -AA +nostl -Wl,+s -mt +DD64 +O2 -ipo +tls=static +Z -b +DD64 assert.o ... collate.o ... wctype.o -o libstd12D.sl.4.2.2
> "/amd/devco/sebor/stdcxx-4.2.x/src/collate.cpp", line 471, procedure do_compare:
> warning #20200-D: Potential null pointer dereference through return of call to __rw::__rw_get_facet_data is detected (null definition:/amd/devco/sebor/stdcxx-4.2.x/src/collate.cpp, line 987)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

svn commit: r692697 - /stdcxx/branches/4.2.x/src/collate.cpp

2008-09-06T10:59:18Z

Author: sebor
Date: Sat Sep 6 10:59:18 2008
New Revision: 692697

URL: http://svn.apache.org/viewvc?rev=692697&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

STDCXX-1011
* src/collate.cpp (collate_byname::do_transform): Silenced HP aCC
warning #20200: Potential null pointer dereference through return
of call to __rw::__rw_get_facet_data().
Optimized the initialization of the facet data so as to take place
only in the first iteration of the loop in which it's needed, and
not each time.

Modified:
stdcxx/branches/4.2.x/src/collate.cpp

Modified: stdcxx/branches/4.2.x/src/collate.cpp
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/src/collate.cpp?rev=692697&r1=692696&r2=692697&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/src/collate.cpp (original)
+++ stdcxx/branches/4.2.x/src/collate.cpp Sat Sep 6 10:59:18 2008
@@ -966,6 +966,10 @@
// each character, in the process check for collating elements.
const char* tmp_lo = low;

+ // lazily initialized in the first iteration of the loop
+ // in which the facet data is needed (possibly never)
+ const _RW::__rw_codecvt_t* cvt = 0;
+
for (; tmp_lo < high; tmp_lo++) {
const char* tmp_lo2 = tmp_lo;
int ret = _RW::__rw_get_n_ce_offset (impl, &tmp_lo2, high);
@@ -983,18 +987,22 @@
if (impl->undefined_optimization) {

size_t size;
+ if (0 == cvt) {
+ cvt = _RWSTD_STATIC_CAST (const _RW::__rw_codecvt_t*,
+ _RW::__rw_get_facet_data (
+ ccvt_cat, size, _C_name,
+ impl->codeset_name ()));

- const _RW::__rw_codecvt_t *cvt =
- _RWSTD_STATIC_CAST (const _RW::__rw_codecvt_t*,
- _RW::__rw_get_facet_data (
- ccvt_cat, size, _C_name,
- impl->codeset_name ()));
+ if (0 == cvt)
+ return string_type (); // error
+ }

if (_RW::__rw_is_invalid (cvt->n_to_w_tab(), tmp_lo2))
- return 0;
+ return string_type (); // error

- const unsigned int *pwt =
+ const unsigned int* const pwt =
impl->get_weight (impl->undefined_weight_idx);
+
indexes.append (&pwt, 1);

tmp_lo = tmp_lo2;
@@ -1194,6 +1202,10 @@
// is high - low
_RW::__rw_pod_array<const unsigned int*, 1024> indexes;

+ // lazily initialized in the first iteration of the loop
+ // in which the facet data is needed (possibly never)
+ const _RW::__rw_codecvt_t* cvt = 0;
+
// first go through the string getting a weight offset for
// each character, in the process check for collating elements.
for (const wchar_t* tmp_lo =low; tmp_lo < high; tmp_lo++) {
@@ -1211,11 +1223,17 @@
// database to discover this information
if (impl->undefined_optimization) {
size_t size;
- const _RW::__rw_codecvt_t *cvt =
- _RWSTD_STATIC_CAST (const _RW::__rw_codecvt_t*,
- _RW::__rw_get_facet_data (
- ccvt_cat, size, _C_name,
- impl->codeset_name ()));
+
+
+ if (0 == cvt) {
+ cvt = _RWSTD_STATIC_CAST(const _RW::__rw_codecvt_t*,
+ _RW::__rw_get_facet_data (
+ ccvt_cat, size, _C_name,
+ impl->codeset_name ()));
+
+ if (0 == cvt)
+ return string_type (); // error
+ }

char tmp [_RWSTD_MB_MAX];

From forum: stdcxx-commits

Created: (STDCXX-1011) [HP aCC 6.16] warning #20200-D: potential null pointer dereference in collate.cpp

2008-09-06T10:51:44Z

[HP aCC 6.16] warning #20200-D: potential null pointer dereference in collate.cpp
---------------------------------------------------------------------------------

Key: STDCXX-1011
URL: https://issues.apache.org/jira/browse/STDCXX-1011
Project: C++ Standard Library
Issue Type: Sub-task
Components: 22. Localization
Affects Versions: 4.2.1
Environment: HP aCC 6.16
Reporter: Martin Sebor
Assignee: Martin Sebor
Fix For: 4.2.2

The warning below shows up when linking with the [-ipo|http://docs.hp.com/en/10946/options.htm#opt-ipo] option:
{noformat}
aCC -AA +nostl -Wl,+s -mt +DD64 +O2 -ipo +tls=static +Z -b +DD64 assert.o ... collate.o ... wctype.o -o libstd12D.sl.4.2.2
"/amd/devco/sebor/stdcxx-4.2.x/src/collate.cpp", line 471, procedure do_compare:
warning #20200-D: Potential null pointer dereference through return of call to __rw::__rw_get_facet_data is detected (null definition:/amd/devco/sebor/stdcxx-4.2.x/src/collate.cpp, line 987)
...
{noformat}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

From forum: stdcxx-issues

svn commit: r692684 - /stdcxx/branches/4.2.x/src/collate.cpp

2008-09-06T10:09:52Z

Author: sebor
Date: Sat Sep 6 10:09:52 2008
New Revision: 692684

URL: http://svn.apache.org/viewvc?rev=692684&view=rev
Log:
2008-09-06 Martin Sebor <sebor@...>

* src/collate.cpp: Globally replaced all occurrences of
the _RWSTD_SIZE_T macro with the equivalent C typedef.

Modified:
stdcxx/branches/4.2.x/src/collate.cpp

Modified: stdcxx/branches/4.2.x/src/collate.cpp
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/src/collate.cpp?rev=692684&r1=692683&r2=692684&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/src/collate.cpp (original)
+++ stdcxx/branches/4.2.x/src/collate.cpp Sat Sep 6 10:09:52 2008
@@ -43,7 +43,7 @@
#include <limits> // for numeric_limits

#include <limits.h>
-#include <stdlib.h> // for wcstombs()
+#include <stdlib.h> // for size_t, wcstombs()
#include <string.h> // for memchr(), memcpy()

#ifndef _RWSTD_NO_WCHAR_H
@@ -88,7 +88,7 @@
extern "C" {

// declare if not declared in the system header(s)
-_RWSTD_SIZE_T wcsxfrm (wchar_t*, const wchar_t*, _RWSTD_SIZE_T) _LIBC_THROWS ();
+size_t wcsxfrm (wchar_t*, const wchar_t*, size_t) _LIBC_THROWS ();

# define _RWSTD_WCSXFRM wcsxfrm
# undef _RWSTD_NO_WCSXFRM
@@ -108,8 +108,8 @@
extern "C" {

// declare if not declared in the system header(s)
-_RWSTD_DLLIMPORT _RWSTD_SIZE_T
-wcstombs (char*, const wchar_t*, _RWSTD_SIZE_T) _LIBC_THROWS ();
+_RWSTD_DLLIMPORT size_t
+wcstombs (char*, const wchar_t*, size_t) _LIBC_THROWS ();

# undef _RWSTD_NO_WCSTOMBS

@@ -321,10 +321,10 @@
while (*cur_char < end) {

// convert the next wchar_t character to a utf8 encoded character
- const _RWSTD_SIZE_T nbytes =
+ const size_t nbytes =
_RW::__rw_itoutf8 (**cur_char, utf8_enc);

- for (_RWSTD_SIZE_T i = 0; i < nbytes; i++) {
+ for (size_t i = 0; i < nbytes; i++) {

const unsigned c1 = impl->get_first_char_in_w_ce_tab (cur_tab);
const unsigned c2 = impl->get_last_char_in_w_ce_tab (cur_tab);
@@ -365,10 +365,10 @@

while (*cur_char < end) {
// convert the next wchar_t character to a utf8 encoded character
- const _RWSTD_SIZE_T nbytes =
+ const size_t nbytes =
_RW::__rw_itoutf8 (**cur_char, utf8_enc);

- for (_RWSTD_SIZE_T i = 0; i < nbytes; i++) {
+ for (size_t i = 0; i < nbytes; i++) {
const unsigned c1 = impl->get_first_char_in_w_tab (cur_tab);
if (UChar (utf8_enc [i]) < c1)
return -1;
@@ -476,14 +476,14 @@
// in an array that may contain embedded NULs; these are inserted
// into the transformed string
static _STD::string
-__rw_strnxfrm (const char *src, _RWSTD_SIZE_T nchars)
+__rw_strnxfrm (const char *src, size_t nchars)
{
_STD::string res;

char buf [256];
char *pbuf = buf;

- _RWSTD_SIZE_T bufsize = sizeof buf;
+ size_t bufsize = sizeof buf;
char *psrc = buf;

while (nchars) {
@@ -533,13 +533,13 @@
char just_in_case_buf [8];
#endif

- const _RWSTD_SIZE_T dst_size = strxfrm (just_in_case_buf, psrc, 0);
+ const size_t dst_size = strxfrm (just_in_case_buf, psrc, 0);

// check for strxfrm() errors
if (0 == (dst_size << 1))
return _STD::string ();

- _RWSTD_SIZE_T res_size = res.size ();
+ size_t res_size = res.size ();

_TRY {
// resize the result string to fit itself plus the result
@@ -554,7 +554,7 @@
}

// transfor the source string up to the terminating NUL
- _RWSTD_SIZE_T xfrm_size =
+ size_t xfrm_size =
strxfrm (&res [0] + res_size, psrc, dst_size + 1);

#if defined _MSC_VER && _MSC_VER < 1400
@@ -594,8 +594,8 @@
// implements wcsxfrm() using wcstombs() and strxfrm() on platforms
// such as some versions of BSD where the function isn't defined in
// the C Standard Library
-static _RWSTD_SIZE_T
-__rw_wcsxfrm (wchar_t *dst, const wchar_t *src, _RWSTD_SIZE_T dstsize)
+static size_t
+__rw_wcsxfrm (wchar_t *dst, const wchar_t *src, size_t dstsize)
{
// src must be non-null
_RWSTD_ASSERT (0 != src);
@@ -608,20 +608,20 @@
// convert wide string to a multibyte string before tranforming it
// using strxfrm() and widening the result into the destination buffer

- const _RWSTD_SIZE_T srclen = _RWSTD_WCSLEN (src);
+ const size_t srclen = _RWSTD_WCSLEN (src);

// compute the size of the temporary nearrow buffer where to narrow
// the source wide string to
- const _RWSTD_SIZE_T needbytes =
+ const size_t needbytes =
(dstsize ? dstsize : srclen) * MB_LEN_MAX;

char narrow_buf [256];
char* const nbuf =
sizeof narrow_buf < needbytes ? new char [needbytes + 1] : narrow_buf;

- _RWSTD_SIZE_T result;
+ size_t result;

- const _RWSTD_SIZE_T nmbchars = wcstombs (nbuf, src, needbytes);
+ const size_t nmbchars = wcstombs (nbuf, src, needbytes);

if (_RWSTD_SIZE_MAX == nmbchars)
result = _RWSTD_SIZE_MAX;
@@ -630,8 +630,8 @@
// buffer (where 8 is a guess at the maximum number of bytes
// needed to transform the longest multibyte character)
char xfrm_buf [sizeof narrow_buf * 8];
- const _RWSTD_SIZE_T xbufsize = sizeof xfrm_buf;
- const _RWSTD_SIZE_T xbufneed = needbytes * 8;
+ const size_t xbufsize = sizeof xfrm_buf;
+ const size_t xbufneed = needbytes * 8;

// allocate a larger buffer if the small statically buffer
// isn't big enough
@@ -650,7 +650,7 @@
if (result < dstsize)
dstsize = result;

- for (_RWSTD_SIZE_T i = 0; i != dstsize; ++i)
+ for (size_t i = 0; i != dstsize; ++i)
dst [i] = wchar_t (UChar (xbuf [i]));
}

@@ -686,14 +686,14 @@
// in an array that may contain embedded NULs; these are inserted
// into the transformed string
static _STD::wstring
-__rw_wcsnxfrm (const wchar_t *src, _RWSTD_SIZE_T nchars)
+__rw_wcsnxfrm (const wchar_t *src, size_t nchars)
{
_STD::wstring res;

wchar_t buf [256];
wchar_t *pbuf = buf;

- _RWSTD_SIZE_T bufsize = sizeof buf / sizeof *buf;
+ size_t bufsize = sizeof buf / sizeof *buf;
wchar_t *psrc = buf;

while (nchars) {
@@ -742,14 +742,14 @@
wchar_t just_in_case_buf [8];
#endif

- const _RWSTD_SIZE_T dst_size =
+ const size_t dst_size =
_RWSTD_WCSXFRM (just_in_case_buf, psrc, 0);

// check for wcsxfrm() errors
if (_RWSTD_SIZE_MAX == dst_size)
return _STD::wstring ();

- _RWSTD_SIZE_T res_size = res.size ();
+ size_t res_size = res.size ();

_TRY {
// resize the result string to fit itself plus the result
@@ -764,7 +764,7 @@
}

// transfor the source string up to the terminating NUL
- _RWSTD_SIZE_T xfrm_size =
+ size_t xfrm_size =
_RWSTD_WCSXFRM (&res [0] + res_size, psrc, dst_size + 1);

# if defined _MSC_VER && _MSC_VER < 1400
@@ -871,8 +871,8 @@
{
_RWSTD_ASSERT (__lo1 <= __hi1 && __lo2 <= __hi2);

- const _RWSTD_SIZE_T __len1 = __hi1 - __lo1;
- const _RWSTD_SIZE_T __len2 = __hi2 - __lo2;
+ const size_t __len1 = __hi1 - __lo1;
+ const size_t __len2 = __hi2 - __lo2;

const int cmp = memcmp (__lo1, __lo2, __len1 < __len2 ? __len1 : __len2);

@@ -982,7 +982,7 @@
// database to discover this information
if (impl->undefined_optimization) {

- _RWSTD_SIZE_T size;
+ size_t size;

const _RW::__rw_codecvt_t *cvt =
_RWSTD_STATIC_CAST (const _RW::__rw_codecvt_t*,
@@ -1042,8 +1042,8 @@
{
_RWSTD_ASSERT (__lo1 <= __hi1 && __lo2 <= __hi2);

- const _RWSTD_SIZE_T __len1 = __hi1 - __lo1;
- const _RWSTD_SIZE_T __len2 = __hi2 - __lo2;
+ const size_t __len1 = __hi1 - __lo1;
+ const size_t __len2 = __hi2 - __lo2;

#ifndef _RWSTD_NO_WMEMCMP

@@ -1054,7 +1054,7 @@

#else // if defined (_RWSTD_NO_WMEMCMP)

- for (_RWSTD_SIZE_T __len = __len1 < __len2 ? __len1 : __len2;
+ for (size_t __len = __len1 < __len2 ? __len1 : __len2;
__len--; ++__lo1, ++__lo2) {

typedef string_type::traits_type _Traits;
@@ -1129,13 +1129,13 @@

_RW::__rw_setlocale clocale (this->_C_name, _RWSTD_LC_COLLATE);

- const _RWSTD_SIZE_T len1 = high1 - low1;
- const _RWSTD_SIZE_T len2 = high2 - low2;
- const _RWSTD_SIZE_T len = len1 + len2;
+ const size_t len1 = high1 - low1;
+ const size_t len2 = high2 - low2;
+ const size_t len = len1 + len2;

// small local buffer
wchar_t local_buffer [256];
- const _RWSTD_SIZE_T bufsize = sizeof local_buffer / sizeof *local_buffer;
+ const size_t bufsize = sizeof local_buffer / sizeof *local_buffer;

// allocate only if local buffer is too small
wchar_t* const wbuf =
@@ -1210,7 +1210,7 @@
// in the collate database we must use the codecvt
// database to discover this information
if (impl->undefined_optimization) {
- _RWSTD_SIZE_T size;
+ size_t size;
const _RW::__rw_codecvt_t *cvt =
_RWSTD_STATIC_CAST (const _RW::__rw_codecvt_t*,
_RW::__rw_get_facet_data (
@@ -1219,7 +1219,7 @@

char tmp [_RWSTD_MB_MAX];

- const _RWSTD_SIZE_T nbytes =
+ const size_t nbytes =
_RW::__rw_itoutf8 (*tmp_lo2, tmp);

tmp [nbytes] = '\0';

From forum: stdcxx-commits

[Stdcxx Wiki] Update of "OperatingSystems" by MartinSebor

2008-09-05T13:07:09Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Stdcxx Wiki" for change notification.

The following page has been changed by MartinSebor:
http://wiki.apache.org/stdcxx/OperatingSystems

The comment on the change is:
Added HP-UX/Integrity support document.

------------------------------------------------------------------------------
* [http://docs.hp.com/en/8681/aas_white_paper.pdf Adaptive Address Space] white paper
* [http://h71028.www7.hp.com/ERC/downloads/c00563208.pdf POSIX Threads on HP-UX 11i] white paper
* [http://h21007.www2.hp.com/portal/site/dspp/menuitem.863c3e4cbcdc3f3515b49c108973a801/?ciid=0008a22194f02110a22194f02110275d6e10RCRD HP-UX floating-point guide for HP Integrity servers]
+ * [http://h20338.www2.hp.com/hpux11i/downloads/public_hp-ux_systems_support.pdf HP-UX/Integrity Support Matrix] including dates

=== Predefined Macros ===

From forum: stdcxx-commits

Re: std::string::{assign|append|insert|replace} ([iterator, iterator,] size_type, value_type) ambiguous

2008-09-05T12:57:09Z

Farid Zaripov wrote:
> While testing boost the Performance.cpp test from statechart library fails to compile:
>
> http://beta.boost.org/development/tests/trunk/developer/output/msvc-9-0-x64-stdcxx-4-2-2-boost-bin-v2-libs-statechart-test-PerformanceExample-test-msvc-9-0_s-dbg-adrs-mdl-64-archt-x86-stdlb-stdcx-4-2-2-thrd-mlt.html
>
> On the other STL's that test compiled without errors.
>
> I've created an Improvement JIRA issue: STDCXX-1009 (https://issues.apache.org/jira/browse/STDCXX-1009).

I assume you set it to Improvement because you don't think the test
case is well-formed? I would have expected the general container
requirements to apply here, i.e.,

For every sequence container defined in this clause and in clause
21:

-- If the constructor
template <class InputIterator>
X (InputIterator first, InputIterator last,
const allocator_type& alloc = allocator_type())

is called with a type InputIterator that does not qualify as
an input iterator, then the constructor will behave as if the
overloaded constructor:

X (size_type, const value_type& = value_type(),
const allocator_type& = allocator_type())

were called instead, with the arguments
static_cast<size_type>(first), last and alloc, respectively.

Martin

From forum: stdcxx-dev