Address book search bug and the corresponding patch

[Thierry Godefroy-3]

Greetings,

I found another bug: when composing an email and searching for an address in
the address book, the search form presents all the address books in the pull
down list, even when some have been configured so as not to be shown (which is
the case for the global address book when $addrbook_global_listing = false in
config.php, for example).

The attached patch fixes this bug.

Regards,

Thierry.


      ____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ 

diff -urN squirrelmail/templates/util_addressbook.php squirrelmail-patched/templates/util_addressbook.php
--- squirrelmail/templates/util_addressbook.php 2007-01-13 21:15:44.000000000 +0100
+++ squirrelmail-patched/templates/util_addressbook.php 2008-02-05 16:16:32.000000000 +0100
@@ -185,6 +185,9 @@
     $backends['-1'] = _("All address books");
     $ret = $abook->get_backend_list();
     while (list($undef,$v) = each($ret)) {
+        if ($v->btype == 'local' && !$v->listing) {
+            continue;
+        }
         $backends[$v->bnum] = $v->sname;
     }
     

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Thijs Kinkhorst]

On Tuesday 5 February 2008 16:23, Thierry Godefroy wrote:
> I found another bug: when composing an email and searching for an address
> in the address book, the search form presents all the address books in the
> pull down list, even when some have been configured so as not to be shown
> (which is the case for the global address book when
> $addrbook_global_listing = false in config.php, for example).

Great, merged, thanks!


Thijs

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel