ANN: Orage version 4.5.14.0 released

[Juha Kautto]

Hi !

This 4.5.14.0 release probably is the last stable Orage 4.5 release
before the bundled Xfce 4.6. It is mainly a bug fix release, but contains
few small enhancements also.

/Juha

You can find it from
http://www.kolumbus.fi/~w408237/orage/download.html

............................................
Changelog compared to the previous stable Orage release 4.5.12.2:
BUG FIXES after 4.5.12.2:
=======================
Bug 3829
   - GLib-Critical on g_source_remove in orageclock

Bug 3835
   - No visual confirmation of setting
     Event list updated similarly than Orage 4.4 if appointment is changed.

Bug 3841
   - Appointment end time not updated when start time is changed
     By default Orage now uses duration, which eliminates this problem.
     End date is still not update automatically.

Bug 3851
   - strptime implicitly converted to pointer
     Fix provided by Debian development team

Bug 3885
   - Add support for evolution ics files

Bug 3894
   - typo in orage de translation
     There were more similar errors; fixed them all.

Bug 3904
   - Button layout in confirmation dialog swapped

Bug 3913
   - "Phantom" marks in calendar when switching month
     Thanks to Colin Leroy for the fix.

Bug 3917
   - Todo without due date

Bug 4074
   - Remove mcs-dependency
     Thanks to Stephan Arts, who created this patch

Bug 4096
   - Orage freezes on double click of orage-clock panel plugin

Bug 4209
   - Alarm procedure with redirection (meaning < or >)
     is parsed Incorrectly

Fixed timing problem in orageclock panel plugin.
   - If only hourly (or slower) changing clock was shown,
     the refresh was delayed instead of happening when the time changed.

Several memory leaks fixed.

Corrected some timezones.

Several internal code clean outs and efficiency improvements.

Changed default timezone selection directory to be /usr/share/zoneinfo.

Fixed possible problem in searching the icon.
   - Now using full path as last effort.
     Patch provided by MaLiK

Fixed problem in preferences when setting stick or on top properties.

Fixed error in day view when showing reserved time for appointments
crossing day change.

Fixed
Gtk-CRITICAL **: calendar_invalidate_day_num: assertion `row != -1' failed
which could happen when changing month in Orage main window.



ENHANCEMENTS after 4.5.12.2:
==========================
Bug 3842
   - Event Alarm Settings - Add ability to set/save defaults
     Added possibility to modify default alarms

Bug 3848
   - globaltime doesn't have manpage
     Added man pages for both Orage and globaltime.

Bug 3900
   - Add list of today's events in the mainbox
   Thanks to Colin Leroy for this code.

Several translations updates

Documentation and NEWS updated

Added small arrows into day view to help scrolling

Removed libical week start day setting and replaced that by reading
first week day from locale. There is still undocumented parameter
in case locale setting is wrong. (Bug 3898)

Added categories and made it possible to associate a colour to them.
     Event list and Day list views show categories with the colour.

Added sound to be part of the default alarm.

Made todo box under the main window invisible when it is empty

Refreshing day list similarly to event list if appointment changed.
.............................................
_______________________________________________
Xfce mailing list
Xfce@...
http://foo-projects.org/mailman/listinfo/xfce
http://www.xfce.org

[Landry Breuil-4]

On Tue, Jul 22, 2008 at 2:59 PM, juha <kautto.juha@...> wrote:
> Hi !
>
> This 4.5.14.0 release probably is the last stable Orage 4.5 release
> before the bundled Xfce 4.6. It is mainly a bug fix release, but contains
> few small enhancements also.

> Removed libical week start day setting and replaced that by reading
> first week day from locale. There is still undocumented parameter
> in case locale setting is wrong. (Bug 3898)

Fails to build on OpenBSD :

parameters.c: In function `get_first_weekday_from_locale':
parameters.c:138: error: `_NL_TIME_FIRST_WEEKDAY' undeclared (first
use in this function)
parameters.c:138: error: (Each undeclared identifier is reported only once
parameters.c:138: error: for each function it appears in.)
parameters.c:140: error: `_NL_TIME_WEEK_1STDAY' undeclared (first use
in this function)
parameters.c: In function `create_parameter_dialog_extra_setup_tab':
parameters.c:685: warning: unused variable `event'

I guess it's related to the fix for bug #3898... grep NL_TIME
/usr/include returns nothing here.
Time to add some #ifdef i think... or find a 'real portable way' to
have this functionality. I'm open
to all suggestions for a fix.

We don't have a real locale support, see
http://opengrok.creo.hu/openbsd/xref/src/include/ for the
values defined in nl_types.h/locale.h/langinfo.h.

Landry
_______________________________________________
Xfce mailing list
Xfce@...
http://foo-projects.org/mailman/listinfo/xfce
http://www.xfce.org

[Landry Breuil-4]

On Tue, Jul 22, 2008 at 7:04 PM, Landry Breuil <landry.breuil@...> wrote:

> On Tue, Jul 22, 2008 at 2:59 PM, juha <kautto.juha@...> wrote:
>> Hi !
>>
>> This 4.5.14.0 release probably is the last stable Orage 4.5 release
>> before the bundled Xfce 4.6. It is mainly a bug fix release, but contains
>> few small enhancements also.
>
>> Removed libical week start day setting and replaced that by reading
>> first week day from locale. There is still undocumented parameter
>> in case locale setting is wrong. (Bug 3898)
>
> Fails to build on OpenBSD :
>
> parameters.c: In function `get_first_weekday_from_locale':
> parameters.c:138: error: `_NL_TIME_FIRST_WEEKDAY' undeclared (first
> use in this function)
> parameters.c:138: error: (Each undeclared identifier is reported only once
> parameters.c:138: error: for each function it appears in.)
> parameters.c:140: error: `_NL_TIME_WEEK_1STDAY' undeclared (first use
> in this function)
> parameters.c: In function `create_parameter_dialog_extra_setup_tab':
> parameters.c:685: warning: unused variable `event'
>
> I guess it's related to the fix for bug #3898... grep NL_TIME
> /usr/include returns nothing here.
> Time to add some #ifdef i think... or find a 'real portable way' to
> have this functionality. I'm open
> to all suggestions for a fix.
>
> We don't have a real locale support, see
> http://opengrok.creo.hu/openbsd/xref/src/include/ for the
> values defined in nl_types.h/locale.h/langinfo.h.

Replying to myself... i've just checked, and those _NL_ defines are linux-only.
All *BSD share the same langinfo.h, without those.

Landry
_______________________________________________
Xfce mailing list
Xfce@...
http://foo-projects.org/mailman/listinfo/xfce
http://www.xfce.org

[Juha Kautto]

Landry Breuil kirjoitti:

> On Tue, Jul 22, 2008 at 7:04 PM, Landry Breuil <landry.breuil@...> wrote:
>  
>> On Tue, Jul 22, 2008 at 2:59 PM, juha <kautto.juha@...> wrote:
>>    
>>> Hi !
>>>
>>> This 4.5.14.0 release probably is the last stable Orage 4.5 release
>>> before the bundled Xfce 4.6. It is mainly a bug fix release, but contains
>>> few small enhancements also.
>>>      
>>> Removed libical week start day setting and replaced that by reading
>>> first week day from locale. There is still undocumented parameter
>>> in case locale setting is wrong. (Bug 3898)
>>>      
>> Fails to build on OpenBSD :
>>
>> parameters.c: In function `get_first_weekday_from_locale':
>> parameters.c:138: error: `_NL_TIME_FIRST_WEEKDAY' undeclared (first
>> use in this function)
>> parameters.c:138: error: (Each undeclared identifier is reported only once
>> parameters.c:138: error: for each function it appears in.)
>> parameters.c:140: error: `_NL_TIME_WEEK_1STDAY' undeclared (first use
>> in this function)
>> parameters.c: In function `create_parameter_dialog_extra_setup_tab':
>> parameters.c:685: warning: unused variable `event'
>>
>> I guess it's related to the fix for bug #3898... grep NL_TIME
>> /usr/include returns nothing here.
>> Time to add some #ifdef i think... or find a 'real portable way' to
>> have this functionality. I'm open
>> to all suggestions for a fix.
>>
>> We don't have a real locale support, see
>> http://opengrok.creo.hu/openbsd/xref/src/include/ for the
>> values defined in nl_types.h/locale.h/langinfo.h.
>>    
>
> Replying to myself... i've just checked, and those _NL_ defines are linux-only.
> All *BSD share the same langinfo.h, without those.
>
> Landry
>  

Thanks Laundry,

You are right. Those _NL_ things are defined only in linux.
Fixed now in svn  revision 27367.

Patch attached to this email. It would be nice to get
a confirmation that you can compile Orage with this
patch.

/Juha

Index: src/parameters.c
===================================================================
--- src/parameters.c (revision 27366)
+++ src/parameters.c (working copy)
@@ -30,7 +30,10 @@
 
 #include <stdio.h>
 #include <locale.h>
+
+#ifdef HAVE__NL_TIME_FIRST_WEEKDAY
 #include <langinfo.h>
+#endif
 
 #include <glib.h>
 #include <glib/gprintf.h>
@@ -129,6 +132,7 @@
  *     to return 0..6 mon..sun, which is what libical uses */
 int get_first_weekday_from_locale()
 {
+#ifdef HAVE__NL_TIME_FIRST_WEEKDAY
     union { unsigned int word; char *string; } langinfo;
     int week_1stday = 0;
     int first_weekday = 1;
@@ -147,6 +151,10 @@
         orage_message(150, "get_first_weekday: unknown value of _NL_TIME_WEEK_1STDAY.");
 
     return((week_1stday + first_weekday - 2 + 7) % 7);
+#else
+    orage_message(150, "get_first_weekday: Can not find first weekday. Using default: Monday=0. If this is wrong guess. please set undocumented parameter: Ical week start day (Sunday=6)");
+    return(0);
+#endif
 }
 
 static void dialog_response(GtkWidget *dialog, gint response_id
@@ -682,8 +690,9 @@
 
 static void create_parameter_dialog_extra_setup_tab(Itf *dialog)
 {
-    GtkWidget *hbox, *vbox, *label, *event;
+    GtkWidget *hbox, *vbox, *label;
     /* code removed. relying in get_first_weekday_from_locale now
+    GtkWidget *event;
     gchar *weekday_array[7] = {
             _("Monday"), _("Tuesday"), _("Wednesday"), _("Thursday")
           , _("Friday"), _("Saturday"), _("Sunday")};
Index: configure.in.in
===================================================================
--- configure.in.in (revision 27366)
+++ configure.in.in (working copy)
@@ -9,7 +9,7 @@
 dnl
 
 dnl Version information
-m4_define([orage_version], [4.5.14.0])
+m4_define([orage_version], [4.5.14.1-svn])
 
 m4_define([gtk_minimum_version], [2.6.0])
 m4_define([xfce_minimum_version], [4.4.0])
@@ -172,6 +172,21 @@
 esac
 AC_SUBST([PTHREAD_LIBS])
 
+dnl **********************************
+dnl *** check if we have _NL_TIME_FIRST_WEEKDAY
+dnl *** note that it is an enum and not a define
+dnl **********************************
+AC_MSG_CHECKING([for _NL_TIME_FIRST_WEEKDAY])
+AC_TRY_LINK([#include <langinfo.h>], [
+char c;
+c = *((unsigned char *)  nl_langinfo(_NL_TIME_FIRST_WEEKDAY));
+], nl_ok=yes, nl_ok=no)
+AC_MSG_RESULT($nl_ok)
+if test "$nl_ok" = "yes"; then
+  AC_DEFINE([HAVE__NL_TIME_FIRST_WEEKDAY], [1],
+      [Define if _NL_TIME_FIRST_WEEKDAY is available])
+fi
+
 AM_CONDITIONAL([INCLUDED_LIBICAL], [test x"$ac_INCLUDED_LIBICAL" = x"yes"])
 AM_CONDITIONAL([HAVE_PTHREAD], [test x"$have_pthread" = x"yes"])
 AM_CONDITIONAL([WITH_BDB4], [test x"$WITH_BDB4" = x"yes"])

_______________________________________________
Xfce mailing list
Xfce@...
http://foo-projects.org/mailman/listinfo/xfce
http://www.xfce.org

[Landry Breuil-4]

On Tue, Jul 22, 2008 at 10:02 PM, juha <kautto.juha@...> wrote:

> Landry Breuil kirjoitti:
>>
>> On Tue, Jul 22, 2008 at 7:04 PM, Landry Breuil <landry.breuil@...>
>> wrote:
>>
>>>
>>> On Tue, Jul 22, 2008 at 2:59 PM, juha <kautto.juha@...> wrote:
>>>
>>>>
>>>> Hi !
>>>>
>>>> This 4.5.14.0 release probably is the last stable Orage 4.5 release
>>>> before the bundled Xfce 4.6. It is mainly a bug fix release, but
>>>> contains
>>>> few small enhancements also.
>>>>      Removed libical week start day setting and replaced that by reading
>>>> first week day from locale. There is still undocumented parameter
>>>> in case locale setting is wrong. (Bug 3898)
>>>>
>>>
>>> Fails to build on OpenBSD :
>>>
>>> parameters.c: In function `get_first_weekday_from_locale':
>>> parameters.c:138: error: `_NL_TIME_FIRST_WEEKDAY' undeclared (first
>>> use in this function)
>>> parameters.c:138: error: (Each undeclared identifier is reported only
>>> once
>>> parameters.c:138: error: for each function it appears in.)
>>> parameters.c:140: error: `_NL_TIME_WEEK_1STDAY' undeclared (first use
>>> in this function)
>>> parameters.c: In function `create_parameter_dialog_extra_setup_tab':
>>> parameters.c:685: warning: unused variable `event'
>>>
>>> I guess it's related to the fix for bug #3898... grep NL_TIME
>>> /usr/include returns nothing here.
>>> Time to add some #ifdef i think... or find a 'real portable way' to
>>> have this functionality. I'm open
>>> to all suggestions for a fix.
>>>
>>> We don't have a real locale support, see
>>> http://opengrok.creo.hu/openbsd/xref/src/include/ for the
>>> values defined in nl_types.h/locale.h/langinfo.h.
>>>
>>
>> Replying to myself... i've just checked, and those _NL_ defines are
>> linux-only.
>> All *BSD share the same langinfo.h, without those.
>>
>> Landry
>>
>
> Thanks Laundry,

LaNdry, please :)

>
> You are right. Those _NL_ things are defined only in linux.
> Fixed now in svn  revision 27367.

svn compiles fine now, i correctly get the warning message on the
terminal upon startup.

Thanks !!
Landry
_______________________________________________
Xfce mailing list
Xfce@...
http://foo-projects.org/mailman/listinfo/xfce
http://www.xfce.org