[lto][patch] save visibility_specified in var_decl

View: New views
2 Messages — Rating Filter:   Alert me  

[lto][patch] save visibility_specified in var_decl

by Rafael Espindola-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

The attached patch fixes

-----------------------
extern int v14 __attribute__ ((visibility ("internal")));

int f1(void) {
  return v14;
}
-----------------------

Right now we are not recording the visibility.

OK for lto if bootstraps and tests are OK?

2008-07-23  Rafael Espindola  <espindola@...>

        * lto-tree-flags.def (VAR_DECL): add visibility_specified.

Cheers,
--
Rafael Avila de Espindola

Google Ireland Ltd.
Gordon House
Barrow Street
Dublin 4
Ireland

Registered in Dublin, Ireland
Registration Number: 368047

[vis.patch]

diff --git a/gcc/lto-tree-flags.def b/gcc/lto-tree-flags.def
index 779b888..21057ec 100644
--- a/gcc/lto-tree-flags.def
+++ b/gcc/lto-tree-flags.def
@@ -841,8 +841,8 @@
       ADD_VIS_FLAG (weak_flag)
       ADD_VIS_FLAG (seen_in_bind_expr)
       ADD_VIS_FLAG (comdat_flag)
-      /* ### Do we need visibility_specified ??? */
       ADD_VIS_FLAG_SIZE (visibility, 2)
+      ADD_VIS_FLAG (visibility_specified)
       /* ### We need to serialize the init priority itself.  */
       ADD_VIS_FLAG (init_priority_p)
       ADD_VIS_FLAG_SIZE (tls_model, 3)


Re: [lto][patch] save visibility_specified in var_decl

by Diego Novillo-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 7/23/08 12:29 PM, Rafael Espindola wrote:

> 2008-07-23  Rafael Espindola  <espindola@...>
>
> * lto-tree-flags.def (VAR_DECL): add visibility_specified.

OK.

Diego.