[jxpath] comments

Eclipse finds a few potential NPEs:

The variable p1 may be null at this location
commons-jxpath/src/java/org/apache/commons/jxpath/ri/model NodePointer.java line
797
The variable parameters may be null at this
location commons-jxpath/src/java/org/apache/commons/jxpath/util MethodLookupUtils.java line
53
The variable parameters may be null at this
location commons-jxpath/src/java/org/apache/commons/jxpath/util MethodLookupUtils.java line
121
The variable parameters may be null at this
location commons-jxpath/src/java/org/apache/commons/jxpath/util MethodLookupUtils.java line
282

[XPathParser has lots of unnecessary semi-colons]

[One or two unused imports]


Findbugs says (amongst other things):

Code may fail to close
stream commons-jxpath/src/java/org/apache/commons/jxpath JXPathContextFactory.java line
192

equals() methods in the CollectionPointer and NullElementPointer
classes both use instanceof - this is likely to cause assymetric
behaviour.

Dead store to active1 in
org.apache.commons.jxpath.ri.parser.XPathParserTokenManager.jjMoveStringLiteralDfa15_0(long,
long, long, long) line 1107:

if (((active0 &= old0) | (active1 &= old1)) == 0L)

should that be as follows:?

if (((active0 & old0) | (active1 & old1)) == 0L)

Incorrect lazy initialization and update of static field
org.apache.commons.jxpath.ri.JXPathContextReferenceImpl.nodeFactoryArray
in
createNodeFactoryArray() at line 119
The static field is written and then the contents are updated; it
would be safer to finish updating the contents before writing the
field.
Might also need synchronisation ...

The variable parent cannot be null at this
location commons-jxpath/src/java/org/apache/commons/jxpath/ri/axes ChildContext.java line
113

There are quite a few non-transient non-serializable fields, but
perhaps the classes are really intended for serialising.

Also various methods in SimpleCharStream and XPathParser,
XPathParserTokenManager don't start with a lower-case letter.
Probably too late to do anything about that now...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...