[jira] Created: (WW-2618) struts.codebehind.defaultPackage

struts.codebehind.defaultPackage
--------------------------------

                 Key: WW-2618
                 URL: https://issues.apache.org/struts/browse/WW-2618
             Project: Struts 2
          Issue Type: Bug
          Components: Plugin - CodeBehind
         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
            Reporter: pawan


an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.

my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43748#action_43748 ]

Wes Wannemacher commented on WW-2618:
-------------------------------------

pawan, I've been poking around in the codebehind plugin because I recently found another bug :(. Can you give a little bit more information? Are you seeing this behavior within all aspects of codebehind? Codebehind does two things, it creates default result mappings for action classes, and it maps requests to your default action (most likely ActionSupport). In which scenario are you noticing this behavior? How can you tell that you are not getting "my-default-package." And lastly, which version of struts2/codebehind are you using?

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43749#action_43749 ]

pawan commented on WW-2618:
---------------------------

We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" just before this package element.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/packagename/<actionName>), the defaultStack is invoked (i.e. the stack for codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration.

I am using Struts 2.1 and code behind was the latest version available around 50 days back. i will update the versions once i am in office (i.e. on monday).

Thanks for the amazingly quick response.

~Pawan

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43749#action_43749 ]

qwerts edited comment on WW-2618 at 4/25/08 11:33 PM:
-----------------------------------------------------

We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" just before this package element.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<configured-action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/class-package-name/<actionClassName>), the defaultStack is invoked (i.e. the stack for codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration.

I am using Struts 2.1 and code behind was the latest version available around 50 days back. i will update the versions once i am in office (i.e. on monday).

Thanks for the amazingly quick response.

~Pawan


      was (Author: qwerts):
    We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" just before this package element.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/packagename/<actionName>), the defaultStack is invoked (i.e. the stack for codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration.

I am using Struts 2.1 and code behind was the latest version available around 50 days back. i will update the versions once i am in office (i.e. on monday).

Thanks for the amazingly quick response.

~Pawan

 

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43749#action_43749 ]

qwerts edited comment on WW-2618 at 4/25/08 11:35 PM:
-----------------------------------------------------

We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" just before this package element.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<configured-action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/class-package-name/<actionClassName>), the defaultStack is invoked (i.e. the stack for codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration that uses interceptors.

I am using Struts 2.1 and code behind was the latest version available around 50 days back. i will update the versions once i am in office (i.e. on monday).

Thanks for the amazingly quick response.

~Pawan


      was (Author: qwerts):
    We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" just before this package element.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<configured-action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/class-package-name/<actionClassName>), the defaultStack is invoked (i.e. the stack for codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration.

I am using Struts 2.1 and code behind was the latest version available around 50 days back. i will update the versions once i am in office (i.e. on monday).

Thanks for the amazingly quick response.

~Pawan

 

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43749#action_43749 ]

qwerts edited comment on WW-2618 at 4/27/08 10:06 PM:
-----------------------------------------------------

We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" to "my-default-package" just before this package element for my-default-package.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<configured-action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/<action-class-package>/<actionClassName>), the defaultStack is invoked (i.e. the stack from codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration that uses interceptors.

Versions being used:
-------------------------------------
Spring: 2.5.1
struts: 2.1.0 (dev version)
struts2-core-2.1.0.jar
ognl-2.7.1.jar
xwork2-2.1.0.jar
freemarker-2.3.9.jar
struts2-codebehind-plugin-2.1.0.jar
struts2-spring-plugin-2.0.11.jar
struts2-sitemesh-plugin-2.1.0.jar

If of any value:
------------------------------------
Commons-logging-1.1.jar

Thanks for the amazingly quick response.

~Pawan


      was (Author: qwerts):
    We have a struts.xml and it contains the packge my-default-package, to be used as default package. i have  assigned the constant "struts.codebehind.defaultPackage" just before this package element.

We have a requirement for our own interceptor stack. So, I added my stack declaration and def-interceptor-ref element within the package.

If create an entry for an action and invoke it using "myRootContext/<configured-action-name>.action" URI, my custom interceptor stack is invoked. However, if I use codebehind based URI (i.e. myRootContext/class-package-name/<actionClassName>), the defaultStack is invoked (i.e. the stack for codebehind). All that my interceptor does is to log the URIs invoked. But it is never called when using the URI that uses code behind.

I am not trying any fancy statements/configurations. Just vanilla configuration that uses interceptors.

I am using Struts 2.1 and code behind was the latest version available around 50 days back. i will update the versions once i am in office (i.e. on monday).

Thanks for the amazingly quick response.

~Pawan

 

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43761#action_43761 ]

Jeromy Evans commented on WW-2618:
----------------------------------

This was definitely affected by WW-2607 as it could use the wrong interceptor stack when creating the ActionConfig.

Can you please try using the latest 2.1.2-SNAPSHOT.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43764#action_43764 ]

Wes Wannemacher commented on WW-2618:
-------------------------------------

Jeromy, I thought the same thing and started testing. I noticed a few things in my sample app... 1. If I am not using a namespace, the settings are honored. I have a customer interceptor that I want called all the time. So, I configured the following in my struts.xml -

    <constant name="struts.codebehind.defaultPackage" value="wrestlingBase"/>
    <package name="wrestlingBase" extends="struts-default">
        <interceptors>
            <interceptor name="wrestlingSessionPopulator" class="wrestlingSessionPopulator"></interceptor>
            <interceptor-stack name="wrestlingStack">
                <interceptor-ref name="defaultStack"></interceptor-ref>
                <interceptor-ref name="wrestlingSessionPopulator"></interceptor-ref>
            </interceptor-stack>
        </interceptors>
       
        <default-interceptor-ref name="wrestlingStack"></default-interceptor-ref>
    </package>

Now, when I call /${contextRoot}/login.action, the appropriate stack is used. However, when I am in a namespace, like if I call -
/${contextRoot}/user/manageProfile.action, then the defaultStack is used. Both login.action and manageProfile.action are configured by codebehind. login.action is mapped to ActionSupport, and manageProfile has an action class. I'll test a bit more and let you know what I find.

-Wes

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43765#action_43765 ]

Wes Wannemacher commented on WW-2618:
-------------------------------------

In my previous post, login.action used a default action mapping, but manageProfile used default result mappings. I removed the ManageProfileAction class (to allow manageProfile to have a default action mapping) and I had the same problem.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43766#action_43766 ]

pawan commented on WW-2618:
---------------------------

Looks like this is an existing defect.

What I felt is either of following:
1. Code Behind is either not honoring the default package entry (most likely one) or
2. Struts is not honoring the default interceptor entry. (very less likely)

It will be great if we can put a debug statement in ClasspathXMLProvider codebase after the argument injection so that we are sure about which entry are we getting so that if someone runs struts code in DEBUG mode, they will be able to give you the exact scenario.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43769#action_43769 ]

Wes Wannemacher commented on WW-2618:
-------------------------------------

After thinking I was able to reproduce this bug, I am changing my mind... It turns out I had an error in the interceptor I was using. Jetty swallowed the exception, but Tomcat does not. So, the error was my own. I am leaving it open in case pawan can provide a test app demonstrating the error. For me, as of 2.1.2-SNAPSHOT, I can't reproduce.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43770#action_43770 ]

pawan commented on WW-2618:
---------------------------

I am trying to take up 2.1.2 and I will update you if I can reproduce the issue.

Can you tell me what was the error? I am using Tomcat 6.0 + Spring 2.5.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43774#action_43774 ]

Wes Wannemacher commented on WW-2618:
-------------------------------------

pawan -

I was receiving a classcastexception in my interceptor. I had been running my app using `mvn jetty:run` and the error didn't show up on the target view or on the console, so I didn't realize that I wasn't making it all the way through the interceptor stack. I reconfigured my dev environment so that I could run everything through eclipse's debugger and in the process switched to Tomcat (by creating a server runtime in eclipse). Before I even got to the debugging, the exception was thrown into the view by tomcat so I fixed it and everything is working fine.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

pawan updated WW-2618:
----------------------

    Attachment: StrutsInterceptorTest.zip

An eclipse project is attached.

This reproduces the problem that I was mentioning about.

I have configured 2 interceptors here and even after setting the default package, my interceptors are not called at all (even thought they are instantiated).

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>         Attachments: StrutsInterceptorTest.zip
>
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43833#action_43833 ]

pawan commented on WW-2618:
---------------------------

another observation.

If i set the default parent package, instead of default package, the interceptors are picked up correctly.

It seems that code behind retrieves the def interceptor from parent rather than child packages.

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>         Attachments: StrutsInterceptorTest.zip
>
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/struts/browse/WW-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-2618:
--------------------------

    Fix Version/s: 2.1.3

> struts.codebehind.defaultPackage
> --------------------------------
>
>                 Key: WW-2618
>                 URL: https://issues.apache.org/struts/browse/WW-2618
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - CodeBehind
>         Environment: Spring 2.5, Tomcat, Struts 2 + Code behind, Windows XP SP2
>            Reporter: pawan
>             Fix For: 2.1.3
>
>         Attachments: StrutsInterceptorTest.zip
>
>
> an entry in struts.xml of <constant name="struts.codebehind.defaultPackage" value="my-default-package" /> does not override the default package name.
> my struts.xml is being loaded after the struts-plugin.xml which would have already set the value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.