[jira] Created: (WW-2525) default-action-ref not working!

default-action-ref not working!
-------------------------------

                 Key: WW-2525
                 URL: https://issues.apache.org/struts/browse/WW-2525
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.0.11
         Environment: RAD 7, Windows XP
            Reporter: Vijay


It looks like default-action-ref feature is not working (even using struts blank war) ---

web.xml

    <filter-mapping>
        <filter-name>struts2</filter-name>
        <url-pattern>/*</url-pattern>
    </filter-mapping>

struts.xml
    <package name="example" namespace="/example" extends="struts-default">

       <default-action-ref name="HelloWorld" />

        <action name="HelloWorld" class="example.HelloWorld">
            <result>/example/HelloWorld.jsp</result>
        </action>

The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
throws 404. My understanding is the default path should bring up action referenced in default-action-ref.

Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43448#action_43448 ]

Philip Luppens commented on WW-2525:
------------------------------------

I think you're misunderstanding; the default-action-ref is not the default action that will be invoked, but rather the default action if you didn't specify a class in your action tag, so it has nothing to do with being the default action from an url perspective. You'd have to look in the actionmapper(s) for that functionality. Note: I could be wrong, it's been a while.

Btw, please do not use the jira for user questions - post them on the Struts user mailing list prior to submitting them here. Thanks.

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Newton closed WW-2525.
---------------------------

    Resolution: Not A Problem

That is correct; the default-action-ref element configures the default action *class* if none is specified in an action mapping.

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Newton reopened WW-2525:
-----------------------------


(Post isn't on Nabble yet, so I'm cutting and pasting from struts-user.)

--- Décio Heinzelmann Luckow <decioluckow@...> wrote:

> I was testing the tag <default-action-ref> to configure the default action
> mapping for a package, without success, then I search Struts Jira for
> something about this and find the WW2525.
>
> The WW2525 is closed with the argument that this tag is used to configure
> the default class to be used when an action mapping don't specify the
> class.
>
> I disagree with this because we have this tags:
> <default-class-ref>
> and
> <default-action-ref>
>
> I think that <default-class-ref> is to set de default class of mapping
> without class, and not <default-action-ref>
>
> The file xwork-default.xml use <default-class-ref> to set ActionSupport
> <default-class-ref class="com.opensymphony.xwork2.ActionSupport" />
>
> And really, in my tests the default-action-ref don´t runs correctly.

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43657#action_43657 ]

Thomas Meire commented on WW-2525:
----------------------------------

I've been searching on this problem for a while, and got it working.

default-action-ref does set the default action, and not the default action class. So the example in the bug report is a valid example of the bug in action.
To work around this problem, it's enough to explicitly add a closing tag as in the example below. However, I checked the dtd (struts-2.0-1.dtd) and it permits an empty default-action-ref. So I'm not quite sure where the real bug is located.

As said, you can explicitly add a closing tag as a workaround:

<package name="example" namespace="/example" extends="struts-default">
    <default-action-ref name="HelloWorld" ></default-action-ref>
    <action name="HelloWorld" class="example.HelloWorld">
        <result>/example/HelloWorld.jsp</result>
    </action>
</package>

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43827#action_43827 ]

Javier D. Fernández commented on WW-2525:
-----------------------------------------

You got it working because no more actions were defined. Try to add new actions... The problem persists!

i.e:
<package name="example" namespace="/example" extends="struts-default">
    <default-action-ref name="HelloWorld" ></default-action-ref>
    <action name="HelloWorld" class="example.HelloWorld">
        <result>/example/HelloWorld.jsp</result>
    </action>
<action name="test" class="test.HelloWorld">
        <result>/test/HelloWorld.jsp</result>
    </action>
</package>

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43827#action_43827 ]

javifer edited comment on WW-2525 at 5/7/08 6:10 AM:
-----------------------------------------------------------------

Be careful when adding something like:

 <action name="*" class="example.Support">
            <result>/{1}.jsp</result>
     </action>

because of *,  this action triggers instead of the one by default. That was my first mistake using default-action-ref

      was (Author: javifer):
    Be careful not to add something like:

 <action name="*" class="example.Support">
            <result>/{1}.jsp</result>
     </action>

because of *,  this action triggers instead of the one by default. That was my first mistake using default-action-ref
 

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43827#action_43827 ]

javifer edited comment on WW-2525 at 5/7/08 6:09 AM:
-----------------------------------------------------------------

Be careful not to add something like:

 <action name="*" class="example.Support">
            <result>/{1}.jsp</result>
     </action>

because of *,  this action triggers instead of the one by default. That was my first mistake using default-action-ref

      was (Author: javifer):
    You got it working because no more actions were defined. Try to add new actions... The problem persists!

i.e:
<package name="example" namespace="/example" extends="struts-default">
    <default-action-ref name="HelloWorld" ></default-action-ref>
    <action name="HelloWorld" class="example.HelloWorld">
        <result>/example/HelloWorld.jsp</result>
    </action>
<action name="test" class="test.HelloWorld">
        <result>/test/HelloWorld.jsp</result>
    </action>
</package>
 

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-2525:
--------------------------

    Fix Version/s: 2.1.3

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>             Fix For: 2.1.3
>
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/struts/browse/WW-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown resolved WW-2525.
---------------------------

       Resolution: Cannot Reproduce
    Fix Version/s:     (was: 2.1.3)
         Assignee: Don Brown

You are correct in that default-action-ref should point to an action that should executed when no action name is specified in the URI, however, I'm unable to reproduce the problem you are talking about.  I even loaded up struts2-blank, which uses this element, and everything worked correctly.  I can only assume it has been fixed since 2.0.11

> default-action-ref not working!
> -------------------------------
>
>                 Key: WW-2525
>                 URL: https://issues.apache.org/struts/browse/WW-2525
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.11
>         Environment: RAD 7, Windows XP
>            Reporter: Vijay
>            Assignee: Don Brown
>
> It looks like default-action-ref feature is not working (even using struts blank war) ---
> web.xml
>     <filter-mapping>
>         <filter-name>struts2</filter-name>
>         <url-pattern>/*</url-pattern>
>     </filter-mapping>
> struts.xml
>     <package name="example" namespace="/example" extends="struts-default">
>        <default-action-ref name="HelloWorld" />
>         <action name="HelloWorld" class="example.HelloWorld">
>             <result>/example/HelloWorld.jsp</result>
>         </action>
> The URL such as: http://localhost:9080/struts2-blank-2.0.11/example/ 
> throws 404. My understanding is the default path should bring up action referenced in default-action-ref.
> Thanks.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.