[jira] Created: (VELOCITY-580) Multi line comments simply don't work inside a macro

[Velocity - Dev mailing list-2]

Multi line comments simply don't work inside a macro
----------------------------------------------------

                 Key: VELOCITY-580
                 URL: https://issues.apache.org/jira/browse/VELOCITY-580
             Project: Velocity
          Issue Type: Bug
          Components: Engine
    Affects Versions: 1.5
            Reporter: BoD


This very simple macro:

#macro(tabSection_begin $sectionTitle)
a
#*

test

*#
b
#end


produces :

a *# b

(notice the presence of the end of comment "*#" in the result !)

This worked as intended in 1.3.1.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Velocity - Dev mailing list-2]

    [ https://issues.apache.org/jira/browse/VELOCITY-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552771 ]

Will Glass-Husain commented on VELOCITY-580:
--------------------------------------------

Thanks for reporting this.  Will take a look at it.

> Multi line comments simply don't work inside a macro
> ----------------------------------------------------
>
>                 Key: VELOCITY-580
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-580
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.5
>            Reporter: BoD
>
> This very simple macro:
> #macro(tabSection_begin $sectionTitle)
> a
> #*
> test
> *#
> b
> #end
> produces :
> a *# b
> (notice the presence of the end of comment "*#" in the result !)
> This worked as intended in 1.3.1.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Velocity - Dev mailing list-2]

    [ https://issues.apache.org/jira/browse/VELOCITY-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571231#action_12571231 ]

Nathan Bubna commented on VELOCITY-580:
---------------------------------------

Marnix van Bochove posted a nice workaround patch that fixes this particular symptom in case VELOCITY-537.  If no one comes up with a patch to fix the root problem, then i'll commit that patch to fix this before the next release.

> Multi line comments simply don't work inside a macro
> ----------------------------------------------------
>
>                 Key: VELOCITY-580
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-580
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.5
>            Reporter: BoD
>
> This very simple macro:
> #macro(tabSection_begin $sectionTitle)
> a
> #*
> test
> *#
> b
> #end
> produces :
> a *# b
> (notice the presence of the end of comment "*#" in the result !)
> This worked as intended in 1.3.1.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Velocity - Dev mailing list-2]

     [ https://issues.apache.org/jira/browse/VELOCITY-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Will Glass-Husain resolved VELOCITY-580.
----------------------------------------

    Resolution: Fixed

applied Marnix's patch to trunk.

> Multi line comments simply don't work inside a macro
> ----------------------------------------------------
>
>                 Key: VELOCITY-580
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-580
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.5
>            Reporter: BoD
>
> This very simple macro:
> #macro(tabSection_begin $sectionTitle)
> a
> #*
> test
> *#
> b
> #end
> produces :
> a *# b
> (notice the presence of the end of comment "*#" in the result !)
> This worked as intended in 1.3.1.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...