[jira] Created: (TRINIDAD-978) Trininiad Jar file handles not being closed

[My Faces - Dev mailing list]

Trininiad Jar file handles not being closed
-------------------------------------------

                 Key: TRINIDAD-978
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 1.2.7-core
         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
Tomahawk-Sandbox 1.1.7-SNAPSHOT
Tomahawk 1.1.6
Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
JSF Sun RI 1.2 04 or MyFaces 1.2.2
Facelets 1.1.14
            Reporter: Tomas Cerny
            Priority: Blocker


We have a large application built on Trinidad, we are very close to release,
but our testing has found that Trinidad is not closing file handles after the request.
Garbage collection correctly closes the handles but they build up too quickly to be
efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
narrowed it down to the Trinidad servlet filter as we have performed tests that
monitor open file handles on a single simple page in complete isolation with and
without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
handles being created but when it is removed from web.xml, the file handles are
no longer being created.  After we reach the file handle limit then our entire
application becomes unstable as we can no longer use anything that depends
on opening file handles or named pipes.

We came across this post but nothing that specifically addressed a fix for the issue
in Trinidad:
https://issues.apache.org/jira/browse/TRINIDAD-806

Here is a similar issue and fix when using MyFaces JSF:
https://issues.apache.org/jira/browse/TOMAHAWK-1040

The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.

Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.

This is a bad hack but I'll include it here because it does seem to actually work
around the problem.  Load the application in your Web Server, ensuring that
Trinidad has loaded it's libraries at least once and then remove the file system
access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
access at all.




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575495#action_12575495 ]

Ray Holder commented on TRINIDAD-978:
-------------------------------------

These are all related to file handles not being closed properly when using JarURLConnection and getLastModified(), as is the case here.

http://www.mail-archive.com/users@.../msg39165.html
http://www.mail-archive.com/users@.../msg42822.html
https://issues.apache.org/jira/browse/TRINIDAD-806

This post addresses the known issue that seems to be troubling a lot of developers and provides a fix that could be applied to the *ResourceLoader classes, etc. in Trinidad-api and Trinidad-impl.
http://www.mail-archive.com/wicket-user@.../msg20937.html

Adam Winer may have patched/fixed this issue in the 1.0.x version, but I have not personally tested it.  It is unclear if he applied the same fix to the 1.2.x versions and if he did then it does not seem to have helped in this case.  More feedback would be appreciated as Tomas and I don't really feel comfortable registering MBeans for garbage collection or other hacks.  How is this being handled by other users out there?

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
>            Reporter: Tomas Cerny
>            Priority: Blocker
>             Fix For: 1.2.7-core
>
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579249#action_12579249 ]

Matthias Weßendorf commented on TRINIDAD-978:
---------------------------------------------

Ray,

can you confirm that this is only true for IE and that it works in FF ?

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579296#action_12579296 ]

Ray Holder commented on TRINIDAD-978:
-------------------------------------

I can confirm that it is definitely a problem for clients using FF on Linux.  I can test it in IE 7 and FF on Windows tomorrow when I get in to the office.  I tend to lean more toward it being a server side problem, too.

I can also confirm that the MBean garbage collection trick suggested elsewhere works but it is by no means elegant and definitely affects the normally passive JVM garbage collection routine.

-Ray

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Holder updated TRINIDAD-978:
--------------------------------

    Status: Patch Available  (was: Open)

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579310#action_12579310 ]

Ray Holder commented on TRINIDAD-978:
-------------------------------------

In all the excitement, I seem to have ticked the patch available flag on this one.  Could somebody reset that?  Or better yet, leave it alone and upload a patch, ;).

-Ray

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated TRINIDAD-978:
----------------------------------------

    Status: Open  (was: Patch Available)

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579395#action_12579395 ]

Matthias Weßendorf commented on TRINIDAD-978:
---------------------------------------------

reseted it. I will look deeper into the JarURLConnection bug. I already ping Sebaastian for his "JDK bug"

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579665#action_12579665 ]

Ray Holder commented on TRINIDAD-978:
-------------------------------------

It is a problem with every browser that I have tested today:

FF on Linux
Opera on Linux

IE 7 on WIndows
FF on Windows
Safari on Windows

Each one causes the unusual open file handle growth on our Linux host server.

-Ray

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582218#action_12582218 ]

Matthias Weßendorf commented on TRINIDAD-978:
---------------------------------------------

original issue was tracked at TRINIDAD-73

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595228#action_12595228 ]

Thomas Jacob commented on TRINIDAD-978:
---------------------------------------

Sorry, but the fix in TRINIDAD-73 does not work, so this issue is still open. I have commented why it does not work, and how to make it working, in that issue.

> Trininiad Jar file handles not being closed
> -------------------------------------------
>
>                 Key: TRINIDAD-978
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-978
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.7-core
>         Environment: Tomcat 6.0.16 (also Jetty 6.1.7)
> Tomahawk-Sandbox 1.1.7-SNAPSHOT
> Tomahawk 1.1.6
> Trinidad 1.2.7-SNAPSHOT (also 1.2.1 has this same issue)
> JSF Sun RI 1.2 04 or MyFaces 1.2.2
> Facelets 1.1.14
> Java 6
> Linux Gentoo, Red Hat Enterprise
>            Reporter: Tomas Cerny
>            Priority: Blocker
>
> We have a large application built on Trinidad, we are very close to release,
> but our testing has found that Trinidad is not closing file handles after the request.
> Garbage collection correctly closes the handles but they build up too quickly to be
> efficiently garbage collected ( ~54 handles per page hit!). We believe that we have
> narrowed it down to the Trinidad servlet filter (org.apache.myfaces.trinidad.webapp.ResourceServlet)
> as we have performed tests that monitor open file handles on a single simple page in complete isolation with and
> without Trinidad tags.  When the Trinidad servlet filter is enabled, we see the file
> handles being created but when it is removed from web.xml, the file handles are
> no longer being created.  After we reach the file handle limit then our entire
> application becomes unstable as we can no longer use anything that depends
> on opening file handles or named pipes.
> We came across this post but nothing that specifically addressed a fix for the issue
> in Trinidad:
> https://issues.apache.org/jira/browse/TRINIDAD-806
> Here is a similar issue and fix when using MyFaces JSF:
> https://issues.apache.org/jira/browse/TOMAHAWK-1040
> The file handle leak occurs with both Sun JSF RI 1.2 and MyFaces JSF 1.2.2.
> Specifically, the file handles are being created for trinidad-impl-1.2.7-SNAPSHOT.jar.
> This is a bad hack but I'll include it here because it does seem to actually work
> around the problem.  Load the application in your Web Server, ensuring that
> Trinidad has loaded it's libraries at least once and then remove the file system
> access to the offending trinidad-impl-1.2.7-SNAPSHOT.jar, preventing any file
> access at all.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.