[jira] Created: (TRINIDAD-1067) BlackBerry output label displays spurious message symbol

[My Faces - Dev mailing list]

BlackBerry output label displays spurious message symbol
---------------------------------------------------------

                 Key: TRINIDAD-1067
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1067
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 1.2.7-core
         Environment: BlackBerry Browser
            Reporter: Tadashi Enomori


The test for removing message symbol in output label renderer for BlackBerry specific case does not match the designed logic that is described in the comment in the code. It should simply test for the condition (null == messageType || "none".equals(messageType))).
With the current code, the label in a panel label and message component may show the message symbol on a BlackBerry device.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595078#action_12595078 ]

tenomori edited comment on TRINIDAD-1067 at 5/7/08 3:57 PM:
-------------------------------------------------------------------

This patch applies to both 1.2.x and 1.0.x.
This is a regression I introduced in fix for Trinidad-921.

      was (Author: tenomori):
    This patch applies to both 1.2.x and 1.0.x.

 

> BlackBerry output label displays spurious message symbol
> ---------------------------------------------------------
>
>                 Key: TRINIDAD-1067
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1067
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.7-core
>         Environment: BlackBerry Browser
>            Reporter: Tadashi Enomori
>            Priority: Minor
>         Attachments: TRINIDAD-1067.patch
>
>
> The test for removing message symbol in output label renderer for BlackBerry specific case does not match the designed logic that is described in the comment in the code. It should simply test for the condition (null == messageType || "none".equals(messageType))).
> With the current code, the label in a panel label and message component may show the message symbol on a BlackBerry device.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[My Faces - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TRINIDAD-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabrielle Crawford resolved TRINIDAD-1067.
------------------------------------------

       Resolution: Fixed
    Fix Version/s:  1.2.8-core
                    1.0.8-core

> BlackBerry output label displays spurious message symbol
> ---------------------------------------------------------
>
>                 Key: TRINIDAD-1067
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1067
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.7-core
>         Environment: BlackBerry Browser
>            Reporter: Tadashi Enomori
>            Priority: Minor
>             Fix For:  1.0.8-core,  1.2.8-core
>
>         Attachments: TRINIDAD-1067.patch
>
>
> The test for removing message symbol in output label renderer for BlackBerry specific case does not match the designed logic that is described in the comment in the code. It should simply test for the condition (null == messageType || "none".equals(messageType))).
> With the current code, the label in a panel label and message component may show the message symbol on a BlackBerry device.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.