[jira] Created: (TAPESTRY-2501) Form input not correctly decoded in case of non-english charsets

[Tapestry - Dev mailing list]

Form input not correctly decoded in case of non-english charsets
----------------------------------------------------------------

                 Key: TAPESTRY-2501
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2501
             Project: Tapestry
          Issue Type: Bug
    Affects Versions: 5.0.13
            Reporter: Vjeran Marcinko


This problem occurs because major browsers don't conform to standards which says that client charset should be sent via "content-type" HTTP header to server.
Everything is well described in this article:
http://www.crazysquirrel.com/computing/general/form-encoding.jspx

I guess this is closely related to submitted issue:
https://issues.apache.org/jira/browse/TAPESTRY-915

So, fix should be that
HttpServletRequest.setEncodingCharset("UTF-8"); (I guess charset should be configurable somehow)
is set in tapestry filter prior to anyone fetching any parameter value.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617621#action_12617621 ]

Howard M. Lewis Ship commented on TAPESTRY-2501:
------------------------------------------------

The code and comments seem to indicate that TAPESTRY-1605 resolved this.

> Form input not correctly decoded in case of non-english charsets
> ----------------------------------------------------------------
>
>                 Key: TAPESTRY-2501
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2501
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0.13
>            Reporter: Vjeran Marcinko
>
> This problem occurs because major browsers don't conform to standards which says that client charset should be sent via "content-type" HTTP header to server.
> Everything is well described in this article:
> http://www.crazysquirrel.com/computing/general/form-encoding.jspx
> I guess this is closely related to submitted issue:
> https://issues.apache.org/jira/browse/TAPESTRY-915
> So, fix should be that
> HttpServletRequest.setEncodingCharset("UTF-8"); (I guess charset should be configurable somehow)
> is set in tapestry filter prior to anyone fetching any parameter value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617622#action_12617622 ]

Howard M. Lewis Ship commented on TAPESTRY-2501:
------------------------------------------------

Looking at the code, I think I see how TAPESTRY-1605 is not quite fixed.  The check for query parameters occur before there's a chance to set the request encoding.

> Form input not correctly decoded in case of non-english charsets
> ----------------------------------------------------------------
>
>                 Key: TAPESTRY-2501
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2501
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0.13
>            Reporter: Vjeran Marcinko
>
> This problem occurs because major browsers don't conform to standards which says that client charset should be sent via "content-type" HTTP header to server.
> Everything is well described in this article:
> http://www.crazysquirrel.com/computing/general/form-encoding.jspx
> I guess this is closely related to submitted issue:
> https://issues.apache.org/jira/browse/TAPESTRY-915
> So, fix should be that
> HttpServletRequest.setEncodingCharset("UTF-8"); (I guess charset should be configurable somehow)
> is set in tapestry filter prior to anyone fetching any parameter value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617623#action_12617623 ]

Howard M. Lewis Ship commented on TAPESTRY-2501:
------------------------------------------------

That check occur when trying to restore persistent fields, potentially from stored request state (the t:state:client query parameter).

> Form input not correctly decoded in case of non-english charsets
> ----------------------------------------------------------------
>
>                 Key: TAPESTRY-2501
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2501
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0.13
>            Reporter: Vjeran Marcinko
>
> This problem occurs because major browsers don't conform to standards which says that client charset should be sent via "content-type" HTTP header to server.
> Everything is well described in this article:
> http://www.crazysquirrel.com/computing/general/form-encoding.jspx
> I guess this is closely related to submitted issue:
> https://issues.apache.org/jira/browse/TAPESTRY-915
> So, fix should be that
> HttpServletRequest.setEncodingCharset("UTF-8"); (I guess charset should be configurable somehow)
> is set in tapestry filter prior to anyone fetching any parameter value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617703#action_12617703 ]

Vjeran Marcinko commented on TAPESTRY-2501:
-------------------------------------------

I don't know if this comment is needed, because I never loooked at T5 code to see where fix should be aplied, but it should affect both normal and multipart requests.

> Form input not correctly decoded in case of non-english charsets
> ----------------------------------------------------------------
>
>                 Key: TAPESTRY-2501
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2501
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0.13
>            Reporter: Vjeran Marcinko
>
> This problem occurs because major browsers don't conform to standards which says that client charset should be sent via "content-type" HTTP header to server.
> Everything is well described in this article:
> http://www.crazysquirrel.com/computing/general/form-encoding.jspx
> I guess this is closely related to submitted issue:
> https://issues.apache.org/jira/browse/TAPESTRY-915
> So, fix should be that
> HttpServletRequest.setEncodingCharset("UTF-8"); (I guess charset should be configurable somehow)
> is set in tapestry filter prior to anyone fetching any parameter value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TAPESTRY-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-2501.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0.14
         Assignee: Howard M. Lewis Ship

TAPESTR-2543 now ensures that all incoming requests have their request encoding properly set as query parameters are extracted.

> Form input not correctly decoded in case of non-english charsets
> ----------------------------------------------------------------
>
>                 Key: TAPESTRY-2501
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2501
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0.13
>            Reporter: Vjeran Marcinko
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.0.14
>
>
> This problem occurs because major browsers don't conform to standards which says that client charset should be sent via "content-type" HTTP header to server.
> Everything is well described in this article:
> http://www.crazysquirrel.com/computing/general/form-encoding.jspx
> I guess this is closely related to submitted issue:
> https://issues.apache.org/jira/browse/TAPESTRY-915
> So, fix should be that
> HttpServletRequest.setEncodingCharset("UTF-8"); (I guess charset should be configurable somehow)
> is set in tapestry filter prior to anyone fetching any parameter value.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...