[jira] Created: (TAPESTRY-2464) Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service

[Tapestry - Dev mailing list]

Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service
------------------------------------------------------------------------------------------------------------------

                 Key: TAPESTRY-2464
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2464
             Project: Tapestry
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.0
         Environment: Any
            Reporter: Massimo Lusetti


It would be great if the logic (Pattern) inside the ComponentEventDispatcher which match the activePageName, events, contexts and components would be extended a little bit and refactored out to a service or more probably a utils method.

This way it could be used by various other dispatcher as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TAPESTRY-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-2464:
-------------------------------------------

    Priority: Minor  (was: Major)

> Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2464
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2464
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0
>         Environment: Any
>            Reporter: Massimo Lusetti
>            Priority: Minor
>
> It would be great if the logic (Pattern) inside the ComponentEventDispatcher which match the activePageName, events, contexts and components would be extended a little bit and refactored out to a service or more probably a utils method.
> This way it could be used by various other dispatcher as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606896#action_12606896 ]

Howard M. Lewis Ship commented on TAPESTRY-2464:
------------------------------------------------

Couldn't you use the existing class, but provide your own implementation of ComponentEventRequestHandler?

> Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2464
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2464
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0
>         Environment: Any
>            Reporter: Massimo Lusetti
>
> It would be great if the logic (Pattern) inside the ComponentEventDispatcher which match the activePageName, events, contexts and components would be extended a little bit and refactored out to a service or more probably a utils method.
> This way it could be used by various other dispatcher as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607162#action_12607162 ]

Massimo Lusetti commented on TAPESTRY-2464:
-------------------------------------------

It seems it could fit it very well, i'm looking at it right now and will try an implementation soon.

> Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2464
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2464
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0
>         Environment: Any
>            Reporter: Massimo Lusetti
>            Priority: Minor
>
> It would be great if the logic (Pattern) inside the ComponentEventDispatcher which match the activePageName, events, contexts and components would be extended a little bit and refactored out to a service or more probably a utils method.
> This way it could be used by various other dispatcher as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

     [ https://issues.apache.org/jira/browse/TAPESTRY-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Massimo Lusetti closed TAPESTRY-2464.
-------------------------------------

    Resolution: Later

I've implemented the logic as described/suggested by Howard and it's working nicely. The code probably needs to be polished but it's available to test as the chenillekit-access module from the ChenilleKit project.

> Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2464
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2464
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0
>         Environment: Any
>            Reporter: Massimo Lusetti
>            Priority: Minor
>
> It would be great if the logic (Pattern) inside the ComponentEventDispatcher which match the activePageName, events, contexts and components would be extended a little bit and refactored out to a service or more probably a utils method.
> This way it could be used by various other dispatcher as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tapestry - Dev mailing list]

    [ https://issues.apache.org/jira/browse/TAPESTRY-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610579#action_12610579 ]

Massimo Lusetti commented on TAPESTRY-2464:
-------------------------------------------

BTW I've chosen to close this as "Later" cause i still think it would be nice to have this logic as a utils/service but don't feel the need right now

> Migrate Pattern logic to catch pageName, context, events and components from ComponentEventDispatcher to a service
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2464
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2464
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0
>         Environment: Any
>            Reporter: Massimo Lusetti
>            Priority: Minor
>
> It would be great if the logic (Pattern) inside the ComponentEventDispatcher which match the activePageName, events, contexts and components would be extended a little bit and refactored out to a service or more probably a utils method.
> This way it could be used by various other dispatcher as well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...