[jira] Created: (PLUTO-489) Refactor request attribute handling into optional service interface

Refactor request attribute handling into optional service interface
-------------------------------------------------------------------

                 Key: PLUTO-489
                 URL: https://issues.apache.org/jira/browse/PLUTO-489
             Project: Pluto
          Issue Type: Improvement
            Reporter: Eric Dalquist
            Assignee: Eric Dalquist
             Fix For: 2.0.0, 1.1.6


To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/PLUTO-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist updated PLUTO-489:
--------------------------------

    Attachment: pluto_reqAttr.patch

This patch refactors the existing request attribute handling, including generation of the USER_INFO Map into an optional service. This patch is functionally identical and the only catch that upgrades may run into is if they implement OptionalContainerServices directly there is a new method RequestAttributeService getRequestAttributeService(); on the interface. Implementing the method is very easy and non-intrusive for portals using Pluto.

> Refactor request attribute handling into optional service interface
> -------------------------------------------------------------------
>
>                 Key: PLUTO-489
>                 URL: https://issues.apache.org/jira/browse/PLUTO-489
>             Project: Pluto
>          Issue Type: Improvement
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.0, 1.1.6
>
>         Attachments: pluto_reqAttr.patch
>
>
> To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/PLUTO-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist updated PLUTO-489:
--------------------------------

    Attachment: pluto_2.0-spi-refactoring_requestAttributeService.patch

Patch against r678336 of the 2.0-spi-refactoring branch. I want to wait on feedback from Ate before committing these changes.

> Refactor request attribute handling into optional service interface
> -------------------------------------------------------------------
>
>                 Key: PLUTO-489
>                 URL: https://issues.apache.org/jira/browse/PLUTO-489
>             Project: Pluto
>          Issue Type: Improvement
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
>         Attachments: pluto_2.0-spi-refactoring_requestAttributeService.patch, pluto_reqAttr.patch
>
>
> To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/PLUTO-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist updated PLUTO-489:
--------------------------------

    Fix Version/s: 2.0-refactoring

> Refactor request attribute handling into optional service interface
> -------------------------------------------------------------------
>
>                 Key: PLUTO-489
>                 URL: https://issues.apache.org/jira/browse/PLUTO-489
>             Project: Pluto
>          Issue Type: Improvement
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
>         Attachments: pluto_2.0-spi-refactoring_requestAttributeService.patch, pluto_reqAttr.patch
>
>
> To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/PLUTO-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616190#action_12616190 ]

Eric Dalquist commented on PLUTO-489:
-------------------------------------

This has been comitted to the trunk and the 1.1.patches branch. I am waiting on feedback from Ate before deciding on committing to the 2.0-spi-refactoring branch.

> Refactor request attribute handling into optional service interface
> -------------------------------------------------------------------
>
>                 Key: PLUTO-489
>                 URL: https://issues.apache.org/jira/browse/PLUTO-489
>             Project: Pluto
>          Issue Type: Improvement
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
>         Attachments: pluto_2.0-spi-refactoring_requestAttributeService.patch, pluto_reqAttr.patch
>
>
> To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/PLUTO-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist resolved PLUTO-489.
---------------------------------

    Resolution: Fixed

Applied to trunk, 1.1-patches and 2.0-refactoring

> Refactor request attribute handling into optional service interface
> -------------------------------------------------------------------
>
>                 Key: PLUTO-489
>                 URL: https://issues.apache.org/jira/browse/PLUTO-489
>             Project: Pluto
>          Issue Type: Improvement
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.0, 2.0-refactoring, 1.1.6
>
>         Attachments: pluto_2.0-spi-refactoring_requestAttributeService.patch, pluto_reqAttr.patch
>
>
> To allow portal more control over request attribute processing and generation without having to re-implement the entire PortletRequest object model the request attribute handling methods in PortletRequest should delegate to an optional service interface.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.