[jira] Created: (OFBIZ-1862) Modified receipts print for a "PREP" template

Modified receipts print for a "PREP" template
---------------------------------------------

                 Key: OFBIZ-1862
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1862
             Project: OFBiz
          Issue Type: Improvement
          Components: specialpurpose/pos
    Affects Versions: SVN trunk
         Environment: SVN Trunk
Independent
            Reporter: Branden Strickland
            Priority: Minor
             Fix For: SVN trunk


For many restaurant applications, the need to send a special receipt to either the main, or a different printer is needed.  This receipt contains no pricing, but only the type of products ordered, and the amount.

This receipt gets sent to a cook, or someone who receives the order and prepares the products.

In this enhancement I'm also looking at using the specialShipping instructions to include a special field for things like enhanced special orders that can't be predicted and placed in the configure item screen, and addresses for deliveries, or phone numbers.  Any misc information.

I have the new template working, through the saveSale screen, although it can be placed anywhere.

I'm currently having issues with the template placing the quantity number off of the paper, although I'm using a modified custReceipt template so it shouldn't be an issue.  

We're still working on the custom field, or as we refer to it "addtlInfo".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/OFBIZ-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Branden Strickland updated OFBIZ-1862:
--------------------------------------

    Attachment: prepReceipt.patch

Here is the current progress patch.

I think I've followed the coding standards much closer this time.... Although I'm sure I may have missed something.  Let me know Jacques!

> Modified receipts print for a "PREP" template
> ---------------------------------------------
>
>                 Key: OFBIZ-1862
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1862
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>         Environment: SVN Trunk
> Independent
>            Reporter: Branden Strickland
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: prepReceipt.patch
>
>
> For many restaurant applications, the need to send a special receipt to either the main, or a different printer is needed.  This receipt contains no pricing, but only the type of products ordered, and the amount.
> This receipt gets sent to a cook, or someone who receives the order and prepares the products.
> In this enhancement I'm also looking at using the specialShipping instructions to include a special field for things like enhanced special orders that can't be predicted and placed in the configure item screen, and addresses for deliveries, or phone numbers.  Any misc information.
> I have the new template working, through the saveSale screen, although it can be placed anywhere.
> I'm currently having issues with the template placing the quantity number off of the paper, although I'm using a modified custReceipt template so it shouldn't be an issue.  
> We're still working on the custom field, or as we refer to it "addtlInfo".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/OFBIZ-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611295#action_12611295 ]

Jacques Le Roux commented on OFBIZ-1862:
----------------------------------------

Branden,

After a cursorily review, it looks good, nothing really important :

* You don't need to put //PATCH in your comments
* Please dont use tabs in your patches but 4 spaces
* Try to always use
+             } catch(Exception e){
+                Debug.logError(e, module);
inplace of
+             }
+                catch(Exception e){
+                Debug.logError(e, module);
(same rule than for " } else")

> Modified receipts print for a "PREP" template
> ---------------------------------------------
>
>                 Key: OFBIZ-1862
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1862
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>         Environment: SVN Trunk
> Independent
>            Reporter: Branden Strickland
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: prepReceipt.patch
>
>
> For many restaurant applications, the need to send a special receipt to either the main, or a different printer is needed.  This receipt contains no pricing, but only the type of products ordered, and the amount.
> This receipt gets sent to a cook, or someone who receives the order and prepares the products.
> In this enhancement I'm also looking at using the specialShipping instructions to include a special field for things like enhanced special orders that can't be predicted and placed in the configure item screen, and addresses for deliveries, or phone numbers.  Any misc information.
> I have the new template working, through the saveSale screen, although it can be placed anywhere.
> I'm currently having issues with the template placing the quantity number off of the paper, although I'm using a modified custReceipt template so it shouldn't be an issue.  
> We're still working on the custom field, or as we refer to it "addtlInfo".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/OFBIZ-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611644#action_12611644 ]

Branden Strickland commented on OFBIZ-1862:
-------------------------------------------

I must admit, the four spaces thing gets me every time!

When I upload the newer patch, I'll make sure to do that.  

even though I don't need to put PATCH in my comments, am I confusing anyone by doing so?  Or if I do it, should I explain what I'm doing in the method etc?  

> Modified receipts print for a "PREP" template
> ---------------------------------------------
>
>                 Key: OFBIZ-1862
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1862
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>         Environment: SVN Trunk
> Independent
>            Reporter: Branden Strickland
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: prepReceipt.patch
>
>
> For many restaurant applications, the need to send a special receipt to either the main, or a different printer is needed.  This receipt contains no pricing, but only the type of products ordered, and the amount.
> This receipt gets sent to a cook, or someone who receives the order and prepares the products.
> In this enhancement I'm also looking at using the specialShipping instructions to include a special field for things like enhanced special orders that can't be predicted and placed in the configure item screen, and addresses for deliveries, or phone numbers.  Any misc information.
> I have the new template working, through the saveSale screen, although it can be placed anywhere.
> I'm currently having issues with the template placing the quantity number off of the paper, although I'm using a modified custReceipt template so it shouldn't be an issue.  
> We're still working on the custom field, or as we refer to it "addtlInfo".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/OFBIZ-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611670#action_12611670 ]

Jacques Le Roux commented on OFBIZ-1862:
----------------------------------------

Branden just think about that : iIf everybody were putting //PATCH or what else in patches we will end up with a code crowded with insignificant comments.
But of course putting significant. comments (explanation of what your code do) is a plus.
Note : not sure insignificant and significant are the best translations for French insignifiant and signifiant

> Modified receipts print for a "PREP" template
> ---------------------------------------------
>
>                 Key: OFBIZ-1862
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1862
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>         Environment: SVN Trunk
> Independent
>            Reporter: Branden Strickland
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: prepReceipt.patch
>
>
> For many restaurant applications, the need to send a special receipt to either the main, or a different printer is needed.  This receipt contains no pricing, but only the type of products ordered, and the amount.
> This receipt gets sent to a cook, or someone who receives the order and prepares the products.
> In this enhancement I'm also looking at using the specialShipping instructions to include a special field for things like enhanced special orders that can't be predicted and placed in the configure item screen, and addresses for deliveries, or phone numbers.  Any misc information.
> I have the new template working, through the saveSale screen, although it can be placed anywhere.
> I'm currently having issues with the template placing the quantity number off of the paper, although I'm using a modified custReceipt template so it shouldn't be an issue.  
> We're still working on the custom field, or as we refer to it "addtlInfo".

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.